122 Commits (4317b94de53a7f5016794e275190e1e22add09f0)

Author	SHA1	Message	Date
Min RK	c9a12798d1	copy uniq_stable out of IPython.utils.data	11 years ago
Min RK	7931ee52f1	move utils.io.atomic_writing to contents.fileio	11 years ago
Min RK	569857bede	import jsonutil from jupyter_client	11 years ago
Min RK	5786346bde	Merge pull request #8168 from quantopian/stop-delete-root ... BUG: Don't allow ContentsManager to delete root.	11 years ago
Scott Sanderson	f2825fdcad	BUG: Don't allow ContentsManager to delete root. ... Doing so leaves the notebook app in a bad state.	11 years ago
Min RK	02739afa42	use >= instead of > when comparing dates ... fast test runners can result in equal values.	11 years ago
Scott Sanderson	e8fd4ba9c2	TEST: Allow greater or equal modified_date on rename.	11 years ago
Scott Sanderson	72aeb78aaf	TEST: Add test for handling of last_modified. ... Saving should increment last_modified. Renaming should not. Noticed because incrementing last_modified on rename results in a scary error message from the frontend.	11 years ago
Scott Sanderson	7971a5ffc7	TEST: Also test deletion.	11 years ago
Scott Sanderson	fdcbd02ffb	TEST: Add test for renaming files with checkpoint. ... The checkpoint name should follow the file rename.	11 years ago
Min RK	9ded491c97	Merge pull request #7708 from SylvainCorlay/allow_none ... allow_none=False for all trait types but Instance and Type	11 years ago
Scott Sanderson	e21b99900d	MAINT: Remove unused import.	11 years ago
Scott Sanderson	257c7296c9	TEST: Move test_escape_root to TestFileContentsManager ... `root_dir` is specific to the FileContentsManager implementation.	11 years ago
Min RK	62e4a5d072	contents: double check that os_path is always within root ... check based on tornado `StaticFileHandler.validate_absolute_path` I haven't been able to actually escape root, but we should have this check anyway.	11 years ago
Min RK	0bc4549d25	skip permission -> 403 test on Windows ... The test actually passes on my VM (Win 7), but not on Jenkins (Server 2012). I haven't figured out how to identify the subset of Windows systems where it won't work, but since the problem appears to be in the test, not the tested code, skipping on Windows seems the right way to go.	11 years ago
Fernando Perez	50c8c5feed	Merge pull request #7852 from minrk/open-perm ... Catch IOError in addition to OSError. Closes #7848	11 years ago
Thomas Kluyver	80b931897c	Fix some formatting for config options help	11 years ago
Min RK	b83a9383a6	test that FileContentsManager.open turns permission error into 403	11 years ago
Min RK	4e6805c408	catch IOError in addition to OSError ... IOError is a subclass of OSError on py3, but not py2	11 years ago
Jason Grout	512187ac10	Fix contentsmanager api error message to give the path name	11 years ago
Sylvain Corlay	5c16ffe559	removing redundant allow_none=False	11 years ago
Min RK	ad83e79ea5	allow requesting contents without body ... adds `?content=0` to only fetch the metadata in the model. The REST API now exposes all arguments to ContentsManager.get.	11 years ago
Scott Sanderson	64e5c49608	DEV: Break get_checkpoint into separate methods. ... One for notebooks and one for checkpoints.	11 years ago
Scott Sanderson	2569c3069d	STY: s/CheckpointManager/Checkpoints ... It's easy to confuse CheckpointManager and ContentsManager.	11 years ago
Scott Sanderson	021e2da495	DEV: Separate FileCheckpointManager and GenericFileCheckpointManager. ... - Adds a `GenericCheckpointMixin` as a helper for implementing the two boundary-traversing Checkpoint API methods, `create_checkpoint` and `restore_checkpoint`. - `GenericFileCheckpointManager` is implemented as a subclass of `FileCheckpointManager` using `GenericCheckpointMixin`. Note that this is the safe subtyping relationship because of method signature *contra*variance: `FileCheckpointManager` accepts `FileContentsManager` in its method signatures type, whereas `GenericFileCheckpointManager` accepts any `ContentsManager`. - Moved Checkpoint-related classes to their own files.	11 years ago
Scott Sanderson	12fe97e2af	DEV: Allow CheckpointManagers to optimize for shared backends. ... On `create_checkpoint` and `restore_checkpoint`, pass a path and a `ContentsManager` to `CheckpointManager` instead of an already-loaded model. The `CheckpointManager` base class provides a correct implementation of these methods that's generic across any ContentsManager, but subclasses are free to specialize when the storage backend of `ContentsManager` is shared.	11 years ago
Scott Sanderson	55d4e20aaf	DEV: Remove ContentsManager.walk.	11 years ago
Scott Sanderson	2b73f1e620	DEV: Implement os.walk analog for ContentsManagers.	11 years ago
Scott Sanderson	1e2e86dcca	MAINT: Return dicts from CheckpointManager.get_checkpoint. ... The output is going to get converted to a dict anyway, and this makes it easier to pipe output from a CheckpointManager directly to a ContentsManager.	11 years ago
Scott Sanderson	7030a8717a	DEV: Add full support for non-notebook checkpoints.	11 years ago
Scott Sanderson	23837e9ad4	DEV: Remove unnecessary notary calls.	11 years ago
Scott Sanderson	631a68d83e	TEST: Test separate roots for Contents and Checkpoints.	11 years ago
Scott Sanderson	f71f216880	DEV: More checkpoint API refactoring. ... Changed the public checkpoint API to: - `create_checkpoint(self, nb, path)` - `get_checkpoint_content(self, checkpoint_id, path)` - `rename_checkpoint(self, checkpoint_id, old_path, new_path)` - `delete_checkpoint(self, checkpoint_id, path)` - `list_checkpoints(self, path)` All paths in the above are API-style paths, and the `nb` argument to `create_checkpoint` is a dictionary suitable for passing to `nbformat.write`. The new `get_checkpoint_content` method returns an unvalidated notebook content dictionary. It is used by `ContentManager.restore_checkpoint` to load content to be written via `save`.	11 years ago
Scott Sanderson	dc295f67bd	MAINT: Add missing `config=True`s.	11 years ago
Scott Sanderson	4da8a30f20	DEV: Refactor checkpoint logic from FileContentsManager. ... - Add a `CheckpointManager` base class and infrastructure for creating a `checkpoint_manager` instance attribute on `ContentsManager`. - Provide default implementations of `delete` and `rename` in the base `ContentsManager` class. `ContentsManager` subclasses are now required to implement `delete_file` and `rename_file`. These methods no longer need to manage checkpoints. - Move checkpoint-related functionality from `FileContentsManager` to a dedicated `FileCheckpointManager` subclass. - Move shared filesystem interaction logic into `FileManagerMixin` used by both `FileContentsManager` and `FileCheckpointManager`. - Minor tweaks to ContentsManager tests to get methods from the right object. The purpose of this change is to provide an API for users to replace just the checkpoint logic associated with a particular `ContentsManager`. In particular, this change makes it possible to easily support remote storage of checkpoints while otherwise retaining normal filesystem interactions.	11 years ago
Scott Sanderson	9aad3c631f	MAINT: Move `update` from FileContentsManager to ContentsManager. ... The implementation in FileContentsManager is written entirely in terms of the required API, and is sensible for other ContentsManager implementations.	11 years ago
Min RK	ad995dfdb8	Merge pull request #7244 from minrk/rm-signature ... don't store signatures in notebooks	11 years ago
Min RK	db5147998d	docstring on test_dir	11 years ago
Min RK	00e4ad59c0	add counter to new notebooks in test_manager ... ensures brand new notebooks are untrusted previously, all new notebooks were identical, so once one was trusted, they would all start trusted.	11 years ago
Scott Sanderson	a1ad9abe51	MAINT: Unicode literal in assertDictContainsSubset	11 years ago
Scott Sanderson	4a2149d1c3	TEST: Add a non-notebook file to directory test.	11 years ago
Scott Sanderson	af7d1cdb50	STY: Define dirs as a single expression.	11 years ago
Scott Sanderson	f7cf204b25	BUG: Convert to bytes before comparing binary blobs.	11 years ago
Scott Sanderson	e9b81b6c7a	TEST: Verify base64 return values after decoding.	11 years ago
Scott Sanderson	fcc1bbecb3	MAINT: Remove unused blob and b64_blob attributes.	11 years ago
Scott Sanderson	f20a7b41cb	TEST: Abstract out directory/file deletion methods.	11 years ago
Scott Sanderson	46f299ccf2	TEST: Refactor symlink tests.	11 years ago
Min RK	a4b47e7e8a	move symlink tests to TestFileManager	11 years ago
Scott Sanderson	61c2e0442f	TEST: Add checks for subdirectory name splitting. ... Previously the tests failed to catch a bug where a ContentsManager didn't split name from path in a nested subdirectory.	11 years ago
Scott Sanderson	c7ca3066ec	TEST: More fine-grained test for directory contents. ... Verify that each entry in a directory listing matches the result of a content-less direct get.	11 years ago