52 Commits (55c6aba9727b0243045cf056b0137e55beeefaed)

Author	SHA1	Message	Date
Stefano Rivera	6a46458f1f	Check for TrashPermissionError rather than guess ... _check_trash() was added (in #3304) because TrashPermissionError didn't exist, yet. Now that it does, we can use it, and stop guessing what will cause a permission problem. Closes: #3374	5 years ago
Ram Rachum	7d375282a9	Fix exception causes all over the codebase	6 years ago
Shane Canon	b5b44eb520	Fix for recursive symlink issue #4669 (#4670) ... * This is a potential fix to issue #4669. The fix simply catches the recusrive symlink error and moves on. It is possibble that the try/except belongs in the utils but I wanted to limit the scope. * It looks like too many levels is error number 40 on linux. * Switch to using errno instead of hardcoding the number. * Fix spelling, smarter assert methods * Log unrecognised errors and continue listing directory * Skip recursive symlink test entirely on Windows * Fix which test is skipped on Windows Co-authored-by: Thomas Kluyver <thomas@kluyver.me.uk>	6 years ago
Kevin Bates	df887b2edf	Check for invalid characters prior to rename (#5193) ... * Check for invalid characters prior to rename On Windows platforms, rename operations containing ':' are problematic since the operation succeeds, but creates an unintended "alternate data stream" that gives the user the impression their file contents have been deleted. This change performs cursory validation of the destination name on platforms in which issues can occur. Currently, non-Windows systems don't require this level of validation. Fixes #5190 * Apply changes per review comments	6 years ago
Kerwin.Sun	b5f5c9500e	remove py2 dependence	7 years ago
Maxime Mouchet	48915c0ad7	Split logic	7 years ago
Maxime Mouchet	1566dd1712	List hidden files if allowed (#3812)	7 years ago
Thomas Kluyver	f63af7376b	Don't trash non-empty directories on Windows ... It appears that the Windows backend of send2trash can't guarantee that files won't actually be deleted. There are some hints that this happens in particular when you delete a lot of data at once. So this returns to refusing to delete folders unless they're empty (or contain only ipynb checkpoints). Closes gh-3631	8 years ago
Celina Kilcrease	174e724174	get file size in base model	8 years ago
Celina Kilcrease	8cc9734c77	merged changes	8 years ago
Celina Kilcrease	acc2056e05	fixed filesize ... fixed typo	8 years ago
Celina Kilcrease	ff8e1cc983	only get filesize for files and notebooks ... adding sort function add file size text	8 years ago
Celina Kilcrease	d19f97017f	fixed filesize	8 years ago
Celina Kilcrease	3315dbd55f	only get filesize for files and notebooks	8 years ago
Ashley Teoh	3650cc7cb4	adding file size to model	8 years ago
Min RK	6ac6f97b80	Merge pull request #3304 from takluyver/trash-linux-home-only ... Don't trash files on different device to home dir on Linux	8 years ago
Simon Biggs	fa803ba238	import _	8 years ago
Thomas Kluyver	4200ea7c09	Don't trash files on different device to home dir on Linux ... Closes gh-3249	8 years ago
Daniel Farrell	605eaa72be	Added a flag to allow access of hidden files (#2819) ... * Added a flag to allow access of hidden files The flag '--allow-hidden' will allow Tornado to access hidden files such as '.images/my_img.jpg' * Fixed jupyterlab not following allow-hidden Jupyterlab stores its options in a different location than the standard notebook. Added the ability to check there as well. * Updated implementation for any app Previously I was accessing the settings dict based on the name of the app that was being used. ex 'NotebookApp', or 'LabApp'. Now the setting is passed directly into the Tornado settings, and can be accessed via a more general method. * Added/fixed unit tests for test_hidden_files Fixed broken unit tests by setting the default to allow_hidden=False then added unit test in FilesTest:test_hidden_files that checks for the accessibility of files with allow_hidden=True * allow-hidden now works everywhere Previously allow-hidden flag only allowed hidden files to be accessed via tornado. Now you can use the allow-hidden flag to access hidden directories and files via the filebrowser. * Remove --allow-hidden alias * Move allow_hidden option onto ContentsManager * Use try/finally to ensure allow_hidden option is set back to False after test * Allow access to hidden files, but don't list them for now * Simplify hidden check for listing again * Fix indentation	8 years ago
Kirit Thadaka	051cee61a5	Squashed all commits. Tests pass.	9 years ago
Min RK	1eb970074b	fix save-script deprecation ... when updating to traitlets API, required argument was omitted	9 years ago
Min RK	aa461d9e06	Merge pull request #1968 from takluyver/delete-to-trash ... Send files to OS trash mechanism on delete	9 years ago
Min RK	a69ddb6655	register contents_manager.files_handler_class directly ... rather than trying to call one handler from another, which is unreliable and can cause misbehavior.	9 years ago
Thomas Kluyver	3115f0602f	deprecated name warn() -> warning()	9 years ago
Thomas Kluyver	1e511c5ebf	Catch OSError when getting file mtime & ctime ... Closes gh-2757	9 years ago
Thomas Kluyver	1849b80287	Merge branch 'master' into delete-to-trash	9 years ago
Grant Nestor	5192d72c63	Merge pull request #2656 from agermanidis/master ... Use StaticFileHandler when files are local	9 years ago
Anastasis Germanidis	a82a510199	Use static file handler when files are local	9 years ago
John Emmons	f81fb46ff6	Preliminary i18n implementation as outlined in JEP 16 (#2140) ... setting up internationalization for log and UI messages See i18n README for details Squashed to resolve CRLF, tab-indent issues.	9 years ago
Thomas Kluyver	c17eb4ce8e	Handle invalid file timestamps ... Closes gh-2539	9 years ago
dhirschf	1975bf830f	Addressed review comments	9 years ago
dhirschf	6bb89b717a	Workaround for Windows Containers ... On Windows `os.stat` treats host mapped volumes as broken symlinks	9 years ago
Min RK	122cbf6785	typo in log command ... don't wrap format-arguments in a tuple	9 years ago
Min RK	2e52d15522	add missing `@default` decorator on checkpoints_class ... this is not strictly required, as default generators are no longer deprecated, but it'st still a good idea	9 years ago
Min RK	8b76de80be	move tz utils to top-level private module ._tz	9 years ago
Thomas Kluyver	ad3ab9b8c7	Send files to OS trash mechanism on delete ... This adds a config option, defaulting to use trash, and adds a dependency on the pure-Python 'send2trash' package. Linux, Mac and Windows should all be supported. Alternatively, we could make it default to hard delete (the current behaviour), and let users opt in to trash behaviour. Then Send2Trash could be a soft dependency. This doesn't touch the UI yet, so you still get a confirmation dialog which inaccurately says it will 'permanently delete' the file. If we want to do this, we'll need some way for the contents manager to pass the UI a hint about whether deleting is permanent or not. Closes gh-165	10 years ago
Thomas Kluyver	ee4b9ce598	Allow None for post_save_hook ... See gh-1868	10 years ago
Thomas Kluyver	1de0423448	Improve performance of directory listing ... - stat() the file once and reuse the result to save on syscalls. Not as good as using scandir(), but should still help. - Don't re-check if parent directories are hidden for each file in the directory. Could do with testing on Windows.	10 years ago
Min RK	92d3f4235d	Merge pull request #1359 from blink1073/generic-session ... Update the session api in preparation for file and console sessions	10 years ago
Min RK	f96feb5e8b	fix os.path.samefile backport on py2 + Windows ... os.path.samefile is available everywhere but Windows + py2. Backporting the py3 implementation doesn't work because `os.stat` on Windows py2 returns 0 for st_ino and st_dev, which will always be equal. In this case, use case-insensitive path comparison, plus full-stat comparison (times included).	10 years ago
Pierre	2ae49c84f9	[Post save hook] Raise web.HTTPError on fail	10 years ago
Sylvain Corlay	a91af4d642	Update traitlets API	10 years ago
Steven Silvester	cbdb8f1ceb	Fix method name	10 years ago
Steven Silvester	fb8943b676	Check for a directory in get_kernel_path	10 years ago
Safia Abdalla	7a8aa92b73	Add same_file check in rename_file	10 years ago
Diego Mesa	482ed8a5a3	updating log.warn to log.warning	10 years ago
Matthias Bussonnier	e4ec5ba3f3	Be more explicit about deprecation. ... Cf #916. Despite the fact that the function is private and meant to replace an old behavior that will be removed, people explicitly import it and register it as a post-save-hook. Hope that explicit versing removal will convey the "Don't use" in a more obvious manner.	10 years ago
Edd Barrett	1deb96999f	Don't crash if a filename contains invalid unicode.	11 years ago
Min RK	cc32f165e8	Merge edit-redirect fix	11 years ago
Min RK	f64aa490e3	set model mimetype, even when content=False	11 years ago