416 Commits (55c6aba9727b0243045cf056b0137e55beeefaed)

Author	SHA1	Message	Date
Thomas Kluyver	7b5248d1ce	Merge pull request #5055 from shuichiro-makigaki/fix-gateway-handled-exceptions ... Fix packages of exceptions catched by gateway manager	7 years ago
Shuichiro MAKIGAKI	aa73eb43cd	Fix packages of exceptions catched by gateway manager ... `gateway_request` in `gateway.manager` raises `tornado.web.HTTPError` exceptions, but the callers, such as `GatewayKernelManager.get_kernel`, catch `tornado.httpclient.HTTPError`, instead of `tornado.web.HTTPError`. Therefore, the callers can not handle exceptions during gateway interactions. This causes that, for example, when Jupyter Enterprise Gateway culled a kernel by idle timeout, the gateway manager can not handle the kernel's absent appropriately. As a result, notebook users see ambiguous "Kernel Error" and can not restart the kernel or start a new kernel.	7 years ago
Min RK	7e2ae22aee	apply asyncio patch before launching new loop for tests	7 years ago
Thomas Kluyver	7fb461ddf7	Selenium test fixture to open a notebook with prefilled content ... This makes several tests shorter and (hopefully) more efficient	7 years ago
Thomas Kluyver	9640e1f943	Merge pull request #4101 from dubielt1/test-kernel-menu ... Translated kernel menu javascript test to selenium	7 years ago
Thomas Kluyver	6d76481ccd	Merge pull request #4622 from TeresaPartidaS/convert_execute_code_js_to_selenium ... Migrate execute code test to selenium	7 years ago
Thomas Kluyver	257e71202c	Rework execution test, add wait_for_cell_output helper	7 years ago
TPartida	c23de34161	Modified to avoid race condition	7 years ago
TPartida	6811727a25	Remove execute_code js	7 years ago
TPartida	6c7ad0417e	Convert execute_code to Selenium	7 years ago
Thomas Kluyver	08d0b56390	Fix waiting for dialog to close before clicking menu again	7 years ago
Thomas Kluyver	934c7dda80	Return to tree window after test using notebook	7 years ago
Thomas Kluyver	46614c3772	Simplify test for interrupting running code	7 years ago
Thomas Kluyver	17176de1f2	Rename test file so test is discovered	7 years ago
lmcdon14	f4ba6daece	Remove interrupt.js	7 years ago
lmcdon14	f2bfd3bebd	create selenium interrupt test and add utility function	7 years ago
Thomas Kluyver	92db6a727c	Simplify test for shutting down & restarting kernel through the menus	7 years ago
Tres DuBiel	36e14efa93	Translated kernel menu javascript test to selenium	7 years ago
Thomas Kluyver	eb3e1a4d6c	Merge pull request #4991 from 00Kai0/fix-py2dep ... remove py2 dependence	7 years ago
Kerwin.Sun	b5f5c9500e	remove py2 dependence	7 years ago
Thomas Kluyver	fb2286585c	Fix checking if kernel is running through Selenium ... Avoid error "Jupyter.notebook.kernel is null"	7 years ago
David Leen	101f726690	Prevent tests from hanging ... When the NotebookApp raises an exception on initialization, a test can hang forever. This can happen when passing configuration when customizing NotebookTestBase: ``` class TestMissingExtension(NotebookTestBase): @classmethod def get_argv(cls): argv = super(TestMissingExtension, cls).get_argv() argv.extend( [ "--NotebookApp.session_manager_class=doesnt_exist", ] ) return argv def test_this_will_hang_forever(self): pass ``` Since the exception happens before the try/finally the `Event` will never be triggered. By including the construction and initialization of the notebook in the try/finally we can handle situations like this.	7 years ago
Min ho Kim	bd66c18b4f	Fix typos (#4760) ... * Fix typos * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces	7 years ago
Thomas Kluyver	9237c3732e	Merge pull request #4615 from LuisARodr/dualmode_execute ... Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium	7 years ago
Luis Rodriguez	cd2ea150a0	Refactor for ... Changed 'for mode in cells_mode' for 'for i, mode in enumerate(cells_mode)' Removed the manual 'i' increment and declaration.	7 years ago
Luis Rodriguez	799b8be841	Move repeated assert mode ... Moved 'assert mode == keyboard_mode' ouside the branches. This means that if a unknown mode comes its gonna get catched by the assert and never gona get to the else statement. For this, the else stament moved to before the assert, caching the mode error before the assert.	7 years ago
Luis Rodriguez	6679891464	Give space to inline comments	7 years ago
Luis Rodriguez	6b7d179697	Change assert for Exception	7 years ago
Luis Rodriguez	83b3c19de3	Solve insonsistensy on is_focused_on ... Changed asserts for returns Changed how the function is called on edit mode check	7 years ago
Luis Rodriguez	b294bf57f8	Refactor of ifs ... Removed parentheses Changed '==' for 'is' on None	7 years ago
Luis Rodriguez	c276d81914	Update docstring ... Added more information about what the checks are	7 years ago
Thomas Kluyver	8ae0c047a9	Merge pull request #4617 from TeresaPartidaS/convert_multiselect_toggle_js_to_selenium ... Migrate multiselect toggle test to selenium	7 years ago
TPartida	8749a5db99	Modified 'scrolling enabled' test assert	7 years ago
Luis Rodriguez	3a0cb7b113	Refactor validate_dualmode_mode ... Previously know as validate_notebook_mode changed name to validate_dualmode_mode to represent better the method. Added a docstring. Removed the handling of index being None.	7 years ago
Luis Rodriguez	fccc7d7420	Resolve notebook len duplicate method	7 years ago
Thomas Kluyver	93099010ff	Merge pull request #4608 from LuisARodr/dualmode_tests ... Convert dualmode_cellmode to selenium	7 years ago
TPartida	3f2fff21b0	Remove multiselect_toggle js	7 years ago
TPartida	c674a57955	Convert multiselect_toggle to selenium	7 years ago
Luis Rodriguez	849b7def18	Convert dualmode_markdown to selenium	7 years ago
Luis Rodriguez	ecc27953e3	Remove unused import & refactor	7 years ago
Luis Rodriguez	9158a79ec4	Convert dualmode_execute to selenium	7 years ago
Luis Rodriguez	5b162cfdf9	Convert dualmode_clipboard to selenium	7 years ago
Luis Rodriguez	3cdc418799	Add alt command, gets, and validate_notebook_state	7 years ago
Luis Rodriguez	89e678c74c	Convert dualmode_cellmode to selenium	7 years ago
Emilio Talamante Lugo	b2653ddb97	Add some code style improvements by not using list comprehension when not required	7 years ago
Emilio Talamante Lugo	31fce8270a	Converted clipboard js to selenium and rename undeleted to conventional name	7 years ago
Thomas Kluyver	f21650ed0c	Merge pull request #4512 from emiliotl/convert_dmode_arrows_and_fix_dmode_insert_tests ... Fixed dualmode insert test and convert dualmode arrows test to selenium	7 years ago
Emilio Talamante Lugo	d8120e5845	Rename ctrl method to cmdtrl which covers the mains OS	7 years ago
Min RK	5ad7a41c4c	wait for kernel to be ready in selenium tests ... might fix recent flaky tests	7 years ago
Emilio Talamante Lugo	35a19e9308	Fixed dualmode insert test and convert dualmode arrows test to selenium	7 years ago
Thomas Kluyver	b26221ad44	Merge pull request #4445 from emiliotl/convert_shutdown_js_to_py_selenium ... Converted shutdown.js test to selenium python test	7 years ago
Emilio Talamante Lugo	e3c9a67294	Changed to .utils module for CI tests acceptance	7 years ago
Emilio Talamante Lugo	0c003e9de1	Handled possible race conditions and modified returned object on get_cell_output	7 years ago
Emilio Talamante Lugo	23adb8e919	Replacing time.sleep for a conditional waiting method	7 years ago
Min RK	729183b148	use our own maybe_future ... instead of the monkeypatch we did to keep the backport patch small requiring tornado 5 simplifies things a ton because tornado.concurrent.Future is asyncio.Future	7 years ago
Emilio Talamante Lugo	b892d7c8c6	Converted shutdown.js test to selenium python test	7 years ago
Min RK	46ee18b23f	Merge pull request #4376 from mpacer/update_json_configd ... surface config.d nbserver_extensions to the NotebookApp config object	7 years ago
Min RK	906406aeb0	Merge pull request #4161 from kevin-bates/embed-nb2kg ... Embed NB2KG into Notebook server	7 years ago
Kevin Bates	acba19033b	Minimize handlers and manager methods ... Eliminated the Kernel and Kernelspec handlers. The Websocket (ZMQ) channels handler still remains. This required turning a few methods into coroutines in the Notebook server. Renamed the Gateway config object to GatewayClient in case we want to extend NB server (probably jupyter_server at that point) with Gateway server functionality - so an NB server could be a Gateway client or a server depending on launch settings. Add code to _replace_ the channels handler rather than rely on position within the handlers lists. Updated mock-gateway to return the appropriate form of results. Updated the session manager tests to use a sync ioloop to call the now async manager methods.	7 years ago
Kevin Bates	f74ef2f691	Move environment variables to SingletonConfigurable ... Created a singleton class `Gateway` to store all configuration options for a Gateway. This class also holds some help methods to make it easier to use the options and determine if the gateway option is enabled. Updated the NotebookTestBase class to allow for subclasses to infuence the patched environment as well as command line options via argv. Added a test to ensure various gateway configuration items can be set via the environment or command-line.	7 years ago
Kevin Bates	060a2b9aea	Embed NB2KG into Notebook server ... This change alleviates a significant pain-point for consumers of Jupyter Kernel and Enterprise Gateway projects by embedding the few classes defined in the NB2KG server extension directly into the Notebook server. All code resides in a separate gateway directory and the 'extension' is enabled via a new configuration option `--gateway-url`. Renamed classes from those used in standard NB2KG code so that Notebook servers using the existing NB2KG extension will still work. Added test_gateway.py to exercise overridden methods. It does this by mocking the call that issues requests to the gateway server. Updated the _Running a notebook server_ topic to include a description of this feature.	7 years ago
Thomas Kluyver	bc3a8cbe79	Convert test for saving with complex name to Selenium	7 years ago
Thomas Kluyver	e00a86c4cb	Throw clearer error if no new window handles found	7 years ago
M Pacer	134c8b6c03	surface config.d nbserver_extensions to the NotebookApp config object ... - separates nbserver_extension config loading into new init_server_extension_config method - adds init_server_extension_config to the initialize funciton before the init_webapp call - adds nbserver_extension configuration found in config.d files (by the BaseJSONConfigLoader) to both the underlying NotebookApp config object and the self.nbserver_extensions value - makes self.nbserver_extensions the canonical location for identifying all nbserver_extensions rather than temporary extensions variable	7 years ago
Thomas Kluyver	a5ad463427	Remove multiselect Javascript test converted to Selenium	7 years ago
Thomas Kluyver	605dfb8b15	Convert multiselect test to Selenium	7 years ago
Thomas Kluyver	6896aacdf6	Add failing test for list_running_servers	7 years ago
Thomas Kluyver	4b2e7dc3e3	Merge pull request #4193 from askerry/selenium_buffering ... Migrate buffering test to selenium	8 years ago
Amy Skerry	8b704d6628	Address review feedback ... - consolidate into single .append call - change function name to be clear we are waiting	8 years ago
Thomas Kluyver	6d7b6af514	Merge pull request #4182 from AndresSan6/merge_selected_cells ... Add test for JS function "merge_selected_cells" in test_merge_cells.py	8 years ago
Amy Skerry	f995db42ee	Address review feedback ... - fix indentation - remove unneccesary try/except - fix visibility logic	8 years ago
Amy Skerry	3faafc4122	Migrate buffering test to selenium ... As per issue #3335, we want all js tests migrated to selenium. This change migrates the test of buffered execution requests. Test Plan: py.test -v notebook/tests/selenium/test_buffering.py	8 years ago
Amy Skerry	6f73d79376	Add custom expectation to wait for n elements	8 years ago
Amy Skerry	dea186d177	Add wait_for_tag to avoid race condition in display isolation test ... Attempts to fix flakiness in `test_display_isolation`. We now ensure the iframe has been added to the dom before calling the selector. To make this work, we clean up the iframe cells (and all other cells) at the end of each test. I'm not 100% positive this fixes, since I haven't been able to reproduce the failure. But the hope is that this fixes the intermittent failing seen in https://github.com/jupyter/notebook/pull/4182.	8 years ago
Andres Sanchez	f27e87541d	Changed function name in utils.py and in test_merge_cells.py	8 years ago
Thomas Kluyver	c9378c71fe	Merge pull request #4146 from askerry/selenium_display_isolation ... Migrate display isolation test to selenium	8 years ago
Thomas Kluyver	099383e012	Merge pull request #4141 from askerry/selenium_display_image ... Migrate image display test to selenium	8 years ago
Amy Skerry	a5a6e4ad08	Address review feedback ... - remove sleep hack cruft - consolidate/remove unncessary intermediate variables	8 years ago
Amy Skerry	3ccc4ed207	Address review feedback ... - use %r instead of %s to handle quoting more succintly - add a finally block to ensure browser state is transitioned from iframe back to default content	8 years ago
Andres Sanchez	fd6ea8e556	Removed unnecessary property attibute created in utils.py and added comments to test_merge_cells.py	8 years ago
Andres Sanchez	1c87821dc1	Modifications to test JS funcion in test_merge_cells.py	8 years ago
Amy Skerry	aa658d3d79	Migrate display isolation test to selenium ... As per issue #3335, we want all js tests migrated to selenium. This change migrates and extends the svg isolation test (extended to include slightly more thorough validation of expected isolation behavior). Test Plan: py.test -v notebook/tests/selenium/test_display_isolation.py	8 years ago
Amy Skerry	34cd3528d5	Migrate test for merge cells api to selenium ... Migrates the test for merging cells to use selenium as suggested in issue #3335. Test Plan: py.test -v notebook/tests/selenium/test_merge_cells.py	8 years ago
Amy Skerry	03478bee87	Migrate image display test to selenium ... Migrates a single js test (testing image display functionality) to selenium as per issue #3335. Test Plan: py.test -v notebook/tests/selenium/test_display_image.py	8 years ago
Arjun Radhakrishna	7eb6e29509	Fix spurious newline in expected result	8 years ago
Arjun Radhakrishna	6fd0a80778	Reformat long string	8 years ago
Arjun Radhakrishna	c5bee3a29d	test and fix: disable math inside code blocks	8 years ago
Thomas Kluyver	c4c49b71ea	Wait for 'New' dropdown button to be clickable for Selenium tests	8 years ago
Thomas Kluyver	5766341360	Merge pull request #3289 from Madhu94/add-save-as-menu-option ... Add save as menu option	8 years ago
Grant Nestor	2ca3684003	Update selenium tests	8 years ago
Grant Nestor	6670d57e2f	Update tests	8 years ago
Thomas Kluyver	2941158ec7	Merge branch 'master' into test_empty_arrows	8 years ago
arovitn	dcb45b2b34	modified the deletion logic as per the comments and setting the readonly cell to false	8 years ago
arovitn	b22994eb47	renamed the ids, removed the replace_all parameter and changed the name of the testcase as mentioned in the comments	8 years ago
arovitn	33c1dea080	add 'ids' to the form_and_replace form and address other review comments	8 years ago
arovitn	66b257bf3b	removing test_empty_arrows_keys.py and moving the delete_cell test into test_deletecell.py	8 years ago
arovitn	0afa1e5855	Modified to use list comprehension, added '()' for to_command_mode, added assert to check presence of cell and remove 'return True' from remove_cells	8 years ago
arovitn	6fc09088ed	[WIP 838: Writing test for 'Find and replace' in selected cell apply on all cells]	8 years ago
madhu94	eab1e709eb	Add basic selenium test case	8 years ago
arovitn	70ce8fac33	forgot adding .perform() for ActionChain	8 years ago