11 Commits (7a9e58438c13e49c9dcc7043c2839bfd8ab90dfd)

Author	SHA1	Message	Date
Matt Riedemann	8b06db3eae	Address review comments	6 years ago
Matt Riedemann	47e06b013b	Log request properties separately when log_json=True ... This updates the log_request method to get the request properties logged separately if `log_json=True`. This ends up looking like: ``` {"written_at": "2020-10-09T20:59:52.044Z", "written_ts": 1602277192044732000, "msg": "", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "WARNING", "module": "log", "line_no": 50, "status": 404, "method": "GET", "ip": "127.0.0.1", "uri": "/api/kernels/a6dd447b-282a-4e1c-ab65-eb340ad12965/channels?session_id=472907c27ed94e2cbfbae86501f7d159", "request_time": 8.63, "referer": "None"} ```	6 years ago
Matt Riedemann	3e32ce576c	Cleanup for log_json review	6 years ago
Matt Riedemann	6a74393f95	Pass NotebookApp logger to log_request ... In order to use the same logger from the notebook app we need to pass it through to the log_request function. To do that we need to use a partial function so the `log` kwarg is available. If not provided the default logger is the same as before, the tornado web access logger. This is necessary for the `log_json` settings to be used for both the notebook app logs and the web app request logging. There is still a todo needed here so that the individual request fields get formatted separately rather than dumped into the `msg` field.	6 years ago
Matt Riedemann	b617d91052	Check for json log formatting in log_request ... This gets us closer to logging parts of the request as separate json fields but not all the way there. For example: ```json {"written_at": "2020-10-07T21:52:16.975Z", "written_ts": 1602107536975497000, "msg": "{'status': 404, 'method': 'GET', 'ip': '127.0.0.1', 'uri': '/nbextensions/widgets/notebook/js/extension.js', 'request_time': 1.9807815551757812, 'referer': 'http://localhost:8888/notebooks/test.ipynb'}", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "WARNING", "module": "log", "line_no": 54} ```	6 years ago
Luciano Resende	13039db1a6	Move license information from COPYING.md ... Closes #4765 Fixes 2768	7 years ago
Maxim Vov	03e5dc00e1	Moved the 'metrics' file to a new package named 'promethues'. ... Then split the file into two files, one containing the metrics themselves, the other containing any function that have something to do with prometheus. Finally, Added new metrics into the prometheus.metrics file that represent the number of running terminals and added the functionality for that metric to be recorded in the terminal.api_handlers file.	8 years ago
yuvipanda	8aa22d62f8	Log HTTP request codes & timings to Prometheus ... Code adapted from JupyterHub	8 years ago
Michael Marchetti	536a6d64dc	Use `dict()` to convert the mapping to a dictionary	11 years ago
Michael Marchetti	5639ac7134	Fix secondary error that occurs during handling of HTTP 500 status ... In log.py, we're attempting to log the request headers when a 500-series error occurs, but tornado.httputil.HTTPHeaders isn't a dict - it inherits from collections.MutableMapping. So it fails during JSON serialization. The fix is to convert it to a dict first. Unfortunately, the HTTPHeaders class doesn't expose any methods to access the underlying dictionary (`request.headers._dict`) directly, so we recreate it using the public API.	11 years ago
Min RK	d71a59cc9f	s/jupyter_notebook/notebook	11 years ago