monkeyking

Commit Graph

Author	SHA1	Message	Date
Saiwing	5042c80c62	Add missing spaces to help messages in config file	5 years ago
Min RK	80eb286f31	Bind the HTTPServer in start (#6061 ) Binding sockets hooks them up to the running eventloop, which we should try to avoid in initialize in case any other stages may configure the event loop policy	5 years ago
Min RK	008a6c0450	Revert "do not apply asyncio patch for tornado >=6.1" (#6052 ) This reverts commit `73c9ac1b2c`.	5 years ago
Matthias Geier	346c635595	Add missing "import inspect"	5 years ago
blair drummond	2712dc4226	change authenticate_prometheus default	5 years ago
Kevin Bates	8cd9a5f78a	Merge pull request #5957 from afshin/contents-manager Allow jupyter_server-based contents managers in notebook	5 years ago
Zachary Sailer	5c081a3d8c	Merge pull request #5965 from kevin-bates/drop-pyzmq-ioloop Drop use of deprecated pyzmq.ioloop	5 years ago
Kevin Bates	198178f4bf	Drop use of deprecated pyzmq.ioloop	5 years ago
Steven Silvester	ff5399a5c8	Update notebook/notebookapp.py Co-authored-by: Kevin Bates <kbates4@gmail.com>	5 years ago
Kevin Bates	2a90e23434	Drop Python 3.5	5 years ago
Afshin T. Darian	3865b7f2e5	Allow jupyter_server-based contents managers in notebook	5 years ago
Afshin T. Darian	b6297d011e	Re-enable support for answer_yes flag	5 years ago
Nicholas Bollweg	73c9ac1b2c	do not apply asyncio patch for tornado >=6.1	5 years ago
YuviPanda	c0ab18a534	Allow toggling auth for prometheus metrics Equivalent to https://github.com/jupyterhub/jupyterhub/pull/2224 Prometheus metrics can potentially leak information about the user, so they should be kept behind auth by default. However, for many JupyterHub deployments, they would need to be scraped by a centralized Prometheus instance that can not really authenticate separately to each user notebook without a lot of work. Admins can use this setting to allow unauthenticated access to the /metrics endpoint.	6 years ago
Nicholas Bollweg	c508af3cff	add wasm mimetype	6 years ago
Kevin Bates	1550410229	Merge pull request #5799 from mriedem/5798-json-logging Add support for JSON formatted logs	6 years ago
Kevin Bates	18e4834b12	Merge pull request #5806 from rahulporuri/cln/update-super-usage Update super usage	6 years ago
Matt Riedemann	67ad5a1c06	Merge remote-tracking branch 'origin/master' into 5798-json-logging	6 years ago
Kevin Bates	158cc007e8	Merge pull request #5805 from rahulporuri/cln/remove-unnecessary-future-imports Remove unnecessary future imports	6 years ago
Matt Riedemann	fac228567e	Fix logging in _validate_log_json Just use the app logger since that has the default LogFormatter logging until we change it to JSON.	6 years ago
Matt Riedemann	8b06db3eae	Address review comments	6 years ago
Sai Rahul Poruri	667e0d7519	CLN : Remove unnecessary future imports specifically print_function and absolute_import future imports	6 years ago
Sai Rahul Poruri	84df5297d5	CLN : Update super usage This commit updates the super usage. Because Python 2 is not supported anymore, super usage can be updated such that super is called without any arguments in the default case where super is called with the class name and self. Note that all usage of super has not been updated - a few cases which smelled funny have been ignored.	6 years ago
Sai Rahul Poruri	9dd2af27de	CLN : Remove utf8 coding cookies On Python 3, the default source file encoding for Python files is utf-8 and because Python 2 is no longer supported, the utf8 coding cookies can be removed	6 years ago
Matt Riedemann	47e06b013b	Log request properties separately when log_json=True This updates the log_request method to get the request properties logged separately if `log_json=True`. This ends up looking like: ``` {"written_at": "2020-10-09T20:59:52.044Z", "written_ts": 1602277192044732000, "msg": "", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "WARNING", "module": "log", "line_no": 50, "status": 404, "method": "GET", "ip": "127.0.0.1", "uri": "/api/kernels/a6dd447b-282a-4e1c-ab65-eb340ad12965/channels?session_id=472907c27ed94e2cbfbae86501f7d159", "request_time": 8.63, "referer": "None"} ```	6 years ago
Matt Riedemann	3e32ce576c	Cleanup for log_json review	6 years ago
Matt Riedemann	6a74393f95	Pass NotebookApp logger to log_request In order to use the same logger from the notebook app we need to pass it through to the log_request function. To do that we need to use a partial function so the `log` kwarg is available. If not provided the default logger is the same as before, the tornado web access logger. This is necessary for the `log_json` settings to be used for both the notebook app logs and the web app request logging. There is still a todo needed here so that the individual request fields get formatted separately rather than dumped into the `msg` field.	6 years ago
Matt Riedemann	ca95490d7c	Add log_json config option with default and validation handling This adds the `NotebookApp.log_json` CLI option which defaults to False. The default value comes from the `JUPYTER_ENABLE_JSON_LOGGING` environment variable. A validation hook is added such that if json logging is enabled but the `json-logging` package is not installed, an error is logged and the effective `log_json` value is False. If enabled and the `json-logging` package is installed, the `init_logging` method will initialize the non-web [1] json logging formatter. [1] https://github.com/bobbui/json-logging-python#21-non-web-application-log	6 years ago
Matt Riedemann	b617d91052	Check for json log formatting in log_request This gets us closer to logging parts of the request as separate json fields but not all the way there. For example: ```json {"written_at": "2020-10-07T21:52:16.975Z", "written_ts": 1602107536975497000, "msg": "{'status': 404, 'method': 'GET', 'ip': '127.0.0.1', 'uri': '/nbextensions/widgets/notebook/js/extension.js', 'request_time': 1.9807815551757812, 'referer': 'http://localhost:8888/notebooks/test.ipynb'}", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "WARNING", "module": "log", "line_no": 54} ```	6 years ago
Matt Riedemann	1929fb53b8	Add support for JSON formatted logs This adds a new extra package dependency on `json-logging` and an environment variable, which when set to "true" regardless of case, will try to use the json-logging non-web app log formatter. If the `json-logging` package is not installed but the environment variable is True, something like this will be logged but it will not crash the application: ``` $ ENABLE_JSON_LOGGING=true jupyter notebook Unable to use json logging due to missing packages. Run "pip install notebook[json-logging]" to fix. Traceback (most recent call last): File "/home/osboxes/jupyter/notebook/notebook/notebookapp.py", line 144, in <module> import json_logging ModuleNotFoundError: No module named 'json_logging' ``` Initially I tried to add a new Bool config option to toggle this but the problem is (from my limited understanding of traitlets and tornado) is that `_log_formatter_cls` needs to be set early and trying to se the log formatter later in `init_logging` is too late - or at least I couldn't figure out a way to reset the log formatter dynamically (I tried calling `_log_format_changed` [1] but that didn't work). With this working you get logs like this: ``` {"written_at": "2020-10-07T21:10:51.606Z", "written_ts": 1602105051606265000, "msg": "404 GET /nbextensions/widgets/notebook/js/extension.js (127.0.0.1) 9.26ms referer=http://localhost:8888/notebooks/Untitled.ipynb", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "WARNING", "module": "log", "line_no": 49} {"written_at": "2020-10-07T21:10:54.443Z", "written_ts": 1602105054443309000, "msg": "Starting buffering for f260ddd7-938c-42d0-ac3b-455bea76694f:49f30b53fc4b4ec6a8f2fb748a171613", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "INFO", "module": "kernelmanager", "line_no": 222} {"written_at": "2020-10-07T21:10:54.446Z", "written_ts": 1602105054446264000, "msg": "Kernel shutdown: f260ddd7-938c-42d0-ac3b-455bea76694f", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "INFO", "module": "multikernelmanager", "line_no": 201} ``` An obvious improvement here would to be able to split the `msg` fields apart so that we can log things like response status code, request method, request URL, response_time_ms etc. That should be possible with the `JSONLogWebFormatter` from `json-logging` but when I tried using that I was getting errors from the library about a correlation id (which is based on a request header we don't use). The `json-logging` library supports several web frameworks like Flask but unfortunately does not have built in support for Tornado, but it does support custom formatters so that might be a follow up option to improve on this. [1] https://github.com/ipython/traitlets/blob/4.3.3/traitlets/config/application.py#L195 Closes #5798	6 years ago
Kevin Bates	e32031f78c	Remove unnecessary import of bind_unix_socket Also found that windows pid detection is not reliable, so added extra check to detect server has been stopped.	6 years ago
Kevin Bates	f5d6995089	Merge pull request #5587 from NemesisFLX/jupyter_token_file Added support for JUPYTER_TOKEN_FILE	6 years ago
Felix Mönckemeyer	4d1bdf8027	Added help description	6 years ago
David Lukes	d157fa8fed	Document login vs. non-login shell behavior	6 years ago
Felix Mönckemeyer	e08b300251	Fixed typo	6 years ago
Felix Mönckemeyer	c8d41130e6	Added support for JUPYTER_TOKEN_FILE	6 years ago
Ram Rachum	7d375282a9	Fix exception causes all over the codebase	6 years ago
Laura Merlo	95348dd1de	FIX: removed double link when custom_display_url (#5400 )	6 years ago
E. M. Bray	8e7c99ad8d	Workaround for socket permission errors on Cygwin (#4584 ) * Workaround for wrong errno on socket bind permission errors on Cygwin. * [ci skip] Add period to comment Co-authored-by: Steven Silvester <stslve@amazon.com>	6 years ago
Kevin Bates	4da22cef44	Restore detection of missing terminado package (#5465 ) * Restore detection of missing terminado package * Properly handle terminals_enabled config * Disambiguate terminado availability from web settings * Further clarity on terminal availability * Rename terminals_in_use back to terminals_available	6 years ago
Max Klein	01e298f83d	added `--autoreload` flag to `NotebookApp` (#4795 ) * added `--autoreload` flag When passed, the webapp will watch for any changes to its Python source. On change, all changed packages will be reimported and the webapp will restart. Also works on Python source files in Jupyter server extensions. Implemented using the built in `autoreload` parameter in the constructor of `tornado.web.Application`. * updated .gitignore	6 years ago
Zachary Sailer	3ec00ad2ad	Merge pull request #5372 from kevin-bates/cull-terminals Add ability to cull terminals and track last activity	6 years ago
Kevin Bates	9d80001f83	Rename parent to nb_app	6 years ago
Kevin Bates	84b7b854b6	Apply review comments, revert interval validation, bump terminado to 0.8.3	6 years ago
Kevin Bates	d2d50f127a	Add env variable support for port options (#5221 ) * Add env variable support for port options In order to better support use cases relating to containerized environments, this change adds environment variable support for the `--port` option. Since anyone setting a specific port probably doesn't want port retry logic enabled, the `--port-retries` option has also been backed by an env. Option `--port` will be backed by env `JUPYTER_PORT` and still defaults to `8888`. Option `--port-retries` will be backed by env `JUPYTER_PORT_RETRIES` and still defaults to `50`. The CLI options will override those set via the envrionment, but environment values override those set via configuration files. Closes #5212 * Fixup after merge	6 years ago
Kevin Bates	e06a55ea51	Merge branch 'master' into cull-terminals	6 years ago
Steven Silvester	b69f22a1b1	Merge pull request #4835 from kwlzn/kwlzn/notebook_unix_socket Add UNIX socket support to notebook server.	6 years ago
Kris Wilson	dcc8874daa	Feedback: remove socket on stop.	6 years ago
Kris Wilson	5aa6e0dfd5	Feedback: add socket usage check on bind and test.	6 years ago
Kris Wilson	02cd1fa8a0	Traitlets type handling fixup.	6 years ago

1 2 3 4 5 ...

328 Commits (7a9e58438c13e49c9dcc7043c2839bfd8ab90dfd)