268 Commits (83b3c19de33e38fd508cb95b554c4714b8a14964)

Author	SHA1	Message	Date
Min RK	e908edf171	Fix return value for async restart_kernel ... gen.Return shouldn't be passed the Future, the future should be awaited	7 years ago
Min RK	d7becafd59	add xsrf checks on files endpoints	7 years ago
Min RK	729183b148	use our own maybe_future ... instead of the monkeypatch we did to keep the backport patch small requiring tornado 5 simplifies things a ton because tornado.concurrent.Future is asyncio.Future	7 years ago
Min RK	88aae11172	Merge pull request #4431 from kevin-bates/apply-nb2kg-updates ... Update gateway support with recent changes	7 years ago
Kevin Bates	46bcf78d63	Update gateway support with recent changes ... Convey notebook working directory to the gateway (nb2kg pr-21) Support retrieval of kernelspec resources from the gateway (nb2kg pr-23)	7 years ago
Frédéric Chapoton	9f59b7feb3	remove unused import of os ... found by lgtm	7 years ago
Min RK	6d15e9cdab	Merge pull request #4328 from maxmouchet/list_hidden_files ... List hidden files if allowed	7 years ago
Min RK	bba82ca3bd	Merge pull request #4412 from kevin-bates/async-startup ... Enable restart_kernel for async usage	7 years ago
Kevin Bates	2c526fb60b	Enable restart_kernel for async usage ... Converted `MappingKernelManager.restart_kernel` to a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts.	7 years ago
Kevin Bates	acba19033b	Minimize handlers and manager methods ... Eliminated the Kernel and Kernelspec handlers. The Websocket (ZMQ) channels handler still remains. This required turning a few methods into coroutines in the Notebook server. Renamed the Gateway config object to GatewayClient in case we want to extend NB server (probably jupyter_server at that point) with Gateway server functionality - so an NB server could be a Gateway client or a server depending on launch settings. Add code to _replace_ the channels handler rather than rely on position within the handlers lists. Updated mock-gateway to return the appropriate form of results. Updated the session manager tests to use a sync ioloop to call the now async manager methods.	7 years ago
Maxime Mouchet	48915c0ad7	Split logic	7 years ago
Maxime Mouchet	1566dd1712	List hidden files if allowed (#3812)	7 years ago
Matthias Bussonnier	64fa7cf674	Merge pull request #4210 from SylvainCorlay/message-filtering ... Enable kernel message filtering	7 years ago
Sylvain Corlay	4a7151448c	Enable kernel message filtering	7 years ago
Kevin Bates	0e63ebb1db	Update session_exists() to account for invalid sessions due to culling ... When kernels are culled, the kernel is terminated in the background, unbeknownst to the session management. As a result, invalid sessions can be produced that appear to exist, yet cannot produce a model from the persisted row due to the associated kernel no longer being active. Prior to this change, these sessions, when encountered via a subsequent call to `get_session()`, would be deleted and a KeyError would be raised. This change updates the existence check to tolerate those kinds of sessions. It removes such sessions (as would happen previously), but rather than raise a KeyError when attempting to convert the row to a dictionary, it logs a warning and returns None, which then allows `session_exists()` to return False since the session was removed (as was ultimately the case previously). Calls to `get_session()` remain just as before and have the potential to raise `KeyError` in such cases. The difference now being that the `KeyError` is accompanied by a message indicating the cause. Fixes #4209	7 years ago
Michal Charemza	815ed3ce56	Allow more contents manager functions to return futures ... This allows slower contents managers to not block the event loop by allowing more of their API to return futures. Other usages of contents manager functions are already wrapped in maybe_future, including a use of `file_exists` in contents/handlers.py	7 years ago
Min RK	b663bf1b14	Merge pull request #4034 from Carreau/adaptation-log ... When adapting also log the version jupyter_client is expecting.	7 years ago
Kevin Bates	23e74dcdfa	Include status types when logging activity ... Recently I needed to troubleshoot kernel responses and found it helpful to distinguish status types (busy vs. idle) - thought others might find it useful as well. Entries that previously appeared as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status ``` will now appear as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) ```	7 years ago
Maxim Vov	f2fdbf929e	Added metrics for number of kernels running labeled by type	8 years ago
Matthias Bussonnier	96cb061e7b	More descriptive message.	8 years ago
Matthias Bussonnier	7e140c5baf	When adapting also log the version jupyter_client is expecting. ... It's still (IMHO) unclear how the adaptation goes. Like does "adapting to protocol X.Y.Z." mean the end-result is X.Y.Z or what you got is X.Y.Z and it's X.Y.W after adaptation.	8 years ago
Kevin Bates	2d688f2071	Prevent access through 'NoneType' when closing activity_stream ... Although I'm unable to reproduce the issue, its a safe change to prevent an AttributeError from occuring ('NoneType' object has no attribute 'close'). The user that reported this is attempting to launch a kernel and I believe the launch only partially completed such that `kernel._activity_stream` did not get established. (This occurred from Jupyter Enterprise Gateway where we deal with remote kernel launches across resource-managed clusters, so things are a bit more involved relative to kernel establishment.)	8 years ago
Sally Wilsak	c258d3fa79	Get the list of exporters from entrypoints ... `exporter_map` is deprecated, so let's use the list of exporters fetched from the installed entrypoints. There's a supposed attribute `export_from_notebook` that should be set to a friendly string name if the exporter should be exposed in the front-end. However, the exporters defined in `nbconvert` don't have it set, so I haven't used it to determine inclusion in the list. Instead, I've used the entrypoint name as the friendly name, which looks like it was the intention from the way they are named. I ran the unit tests and tried starting up the notebook server and accessing the API endpoint to verify the JSON looked correct.	8 years ago
Min RK	a53d2c8489	flush iopub before sending restarting/dead status messages ... to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message	8 years ago
Thomas Kluyver	7ea7a8b97d	Skip directory deletion test on Windows	8 years ago
Thomas Kluyver	f63af7376b	Don't trash non-empty directories on Windows ... It appears that the Windows backend of send2trash can't guarantee that files won't actually be deleted. There are some hints that this happens in particular when you delete a lot of data at once. So this returns to refusing to delete folders unless they're empty (or contain only ipynb checkpoints). Closes gh-3631	8 years ago
M Pacer	c6dd032bf8	add kernel_info_timeout traitlet to wait for slow kernel startups ... This affects both the MappingKernelManager and the ZMQChannelsHandler(by extension). This allows one setting to apply to both startup andrestarting.	8 years ago
Thomas Kluyver	160754d27e	None -> null for JSON API	8 years ago
Celina Kilcrease	174e724174	get file size in base model	8 years ago
Ashley Teoh	577cbe52b7	update api description	8 years ago
Celina Kilcrease	8cc9734c77	merged changes	8 years ago
Celina Kilcrease	acc2056e05	fixed filesize ... fixed typo	8 years ago
Celina Kilcrease	ff8e1cc983	only get filesize for files and notebooks ... adding sort function add file size text	8 years ago
Celina Kilcrease	d19f97017f	fixed filesize	8 years ago
Celina Kilcrease	3315dbd55f	only get filesize for files and notebooks	8 years ago
Celina Kilcrease	b864f5aacc	make file size optional pproperty	8 years ago
Ashley Teoh	3650cc7cb4	adding file size to model	8 years ago
Kevin Bates	550120906c	Fix leak of iopub object in activity monitoring ... After analyzing various leaked items when running either Notebook or Jupyter Kernel Gateway, one item that recurred across each kernel startup and shutdown sequence was the a zmq socket instance associated with the iopub port. The leaked instance occurs because the activity monitor and normal port creation logic both call `create_iopub`. Although this ens up creating a _wrapper_ around the same port, the object (i.e., wrapper) created by the activity monitor is leaked. By setting the kernel manager's `_activity_stream` member to `None` when the kernel is shutdown, cleanup of the iopub wrapper object will take place.	8 years ago
Min RK	f77e3435cf	tornado 5 fixes in tests ... - start asyncio loop explicitly in notebook thread (tornado 4 starts per-thread loops automatically, asyncio doesn’t) - remove unsupported ‘io_loop=‘ arg in websocket test application runs fine with tornado 5, just a few test bits needed updating	8 years ago
M Pacer	5fd7d52ec2	API spec improvements, API handler improvements ... This changes the base-path to be / instead of /api so that in the future other APIs that return files and do not redirect you to a new address (e.g., see #2413). This also improves the way that the api spec handler responds to a request, by actually displaying the spec with the appropriate content-type header (text/x-yaml) instead of triggering a download with the StaticFileHandler's default application/octet-stream mimetype.	8 years ago
Min RK	6ac6f97b80	Merge pull request #3304 from takluyver/trash-linux-home-only ... Don't trash files on different device to home dir on Linux	8 years ago
Simon Biggs	fa803ba238	import _	8 years ago
ehengao	dd451c1861	Add _ from module to fix the not imported error	8 years ago
ehengao	cd49eee41f	_ is not defined anywhere in the module	8 years ago
Thomas Kluyver	4200ea7c09	Don't trash files on different device to home dir on Linux ... Closes gh-3249	8 years ago
Daniel Farrell	605eaa72be	Added a flag to allow access of hidden files (#2819) ... * Added a flag to allow access of hidden files The flag '--allow-hidden' will allow Tornado to access hidden files such as '.images/my_img.jpg' * Fixed jupyterlab not following allow-hidden Jupyterlab stores its options in a different location than the standard notebook. Added the ability to check there as well. * Updated implementation for any app Previously I was accessing the settings dict based on the name of the app that was being used. ex 'NotebookApp', or 'LabApp'. Now the setting is passed directly into the Tornado settings, and can be accessed via a more general method. * Added/fixed unit tests for test_hidden_files Fixed broken unit tests by setting the default to allow_hidden=False then added unit test in FilesTest:test_hidden_files that checks for the accessibility of files with allow_hidden=True * allow-hidden now works everywhere Previously allow-hidden flag only allowed hidden files to be accessed via tornado. Now you can use the allow-hidden flag to access hidden directories and files via the filebrowser. * Remove --allow-hidden alias * Move allow_hidden option onto ContentsManager * Use try/finally to ensure allow_hidden option is set back to False after test * Allow access to hidden files, but don't list them for now * Simplify hidden check for listing again * Fix indentation	8 years ago
Min RK	9c7c213a47	Merge pull request #3116 from maartenbreddels/directory_json ... allow default json files in a .d directory	8 years ago
Thomas Kluyver	3eb6d72bb5	Find available kernelspecs more efficiently ... Closes gh-3135	8 years ago
maartenbreddels	772544e60f	renamed manager.py to config_manager.py and added more docstrings	8 years ago
maartenbreddels	89b32e4412	allow default json files in a .d directory, original PR: ipython/traitlets#452	8 years ago