monkeyking

Commit Graph

Author	SHA1	Message	Date
Michael Marchetti	536a6d64dc	Use `dict()` to convert the mapping to a dictionary	11 years ago
Michael Marchetti	5639ac7134	Fix secondary error that occurs during handling of HTTP 500 status In log.py, we're attempting to log the request headers when a 500-series error occurs, but tornado.httputil.HTTPHeaders isn't a dict - it inherits from collections.MutableMapping. So it fails during JSON serialization. The fix is to convert it to a dict first. Unfortunately, the HTTPHeaders class doesn't expose any methods to access the underlying dictionary (`request.headers._dict`) directly, so we recreate it using the public API.	11 years ago
Min RK	d71a59cc9f	s/jupyter_notebook/notebook	11 years ago

Author

SHA1

Message

Date

Michael Marchetti

536a6d64dc

Use `dict()` to convert the mapping to a dictionary

Michael Marchetti

5639ac7134

Fix secondary error that occurs during handling of HTTP 500 status

In log.py, we're attempting to log the request headers when a
500-series error occurs, but tornado.httputil.HTTPHeaders isn't a dict -
it inherits from collections.MutableMapping. So it fails during
JSON serialization. The fix is to convert it to a dict first.

Unfortunately, the HTTPHeaders class doesn't expose any methods
to access the underlying dictionary (`request.headers._dict`) directly,
so we recreate it using the public API.

Min RK

d71a59cc9f

s/jupyter_notebook/notebook

3 Commits (d1358dd9bad2e77f9030ab46ea1b9bc91ce7b809)