132 Commits (ebfe75b6dfd72151b40e697e592d2fb630718bdd)

Author	SHA1	Message	Date
Min ho Kim	bd66c18b4f	Fix typos (#4760) ... * Fix typos * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces	7 years ago
Thomas Kluyver	9237c3732e	Merge pull request #4615 from LuisARodr/dualmode_execute ... Convert dualmode_execute, dualmode_clipboard & dualmode_markdown to selenium	7 years ago
Luis Rodriguez	cd2ea150a0	Refactor for ... Changed 'for mode in cells_mode' for 'for i, mode in enumerate(cells_mode)' Removed the manual 'i' increment and declaration.	7 years ago
Luis Rodriguez	799b8be841	Move repeated assert mode ... Moved 'assert mode == keyboard_mode' ouside the branches. This means that if a unknown mode comes its gonna get catched by the assert and never gona get to the else statement. For this, the else stament moved to before the assert, caching the mode error before the assert.	7 years ago
Luis Rodriguez	6679891464	Give space to inline comments	7 years ago
Luis Rodriguez	6b7d179697	Change assert for Exception	7 years ago
Luis Rodriguez	83b3c19de3	Solve insonsistensy on is_focused_on ... Changed asserts for returns Changed how the function is called on edit mode check	7 years ago
Luis Rodriguez	b294bf57f8	Refactor of ifs ... Removed parentheses Changed '==' for 'is' on None	7 years ago
Luis Rodriguez	c276d81914	Update docstring ... Added more information about what the checks are	7 years ago
Thomas Kluyver	8ae0c047a9	Merge pull request #4617 from TeresaPartidaS/convert_multiselect_toggle_js_to_selenium ... Migrate multiselect toggle test to selenium	7 years ago
TPartida	8749a5db99	Modified 'scrolling enabled' test assert	7 years ago
Luis Rodriguez	3a0cb7b113	Refactor validate_dualmode_mode ... Previously know as validate_notebook_mode changed name to validate_dualmode_mode to represent better the method. Added a docstring. Removed the handling of index being None.	7 years ago
Luis Rodriguez	fccc7d7420	Resolve notebook len duplicate method	7 years ago
Thomas Kluyver	93099010ff	Merge pull request #4608 from LuisARodr/dualmode_tests ... Convert dualmode_cellmode to selenium	7 years ago
TPartida	c674a57955	Convert multiselect_toggle to selenium	7 years ago
Luis Rodriguez	849b7def18	Convert dualmode_markdown to selenium	7 years ago
Luis Rodriguez	ecc27953e3	Remove unused import & refactor	7 years ago
Luis Rodriguez	9158a79ec4	Convert dualmode_execute to selenium	7 years ago
Luis Rodriguez	5b162cfdf9	Convert dualmode_clipboard to selenium	7 years ago
Luis Rodriguez	3cdc418799	Add alt command, gets, and validate_notebook_state	7 years ago
Luis Rodriguez	89e678c74c	Convert dualmode_cellmode to selenium	7 years ago
Emilio Talamante Lugo	b2653ddb97	Add some code style improvements by not using list comprehension when not required	7 years ago
Emilio Talamante Lugo	31fce8270a	Converted clipboard js to selenium and rename undeleted to conventional name	7 years ago
Thomas Kluyver	f21650ed0c	Merge pull request #4512 from emiliotl/convert_dmode_arrows_and_fix_dmode_insert_tests ... Fixed dualmode insert test and convert dualmode arrows test to selenium	7 years ago
Emilio Talamante Lugo	d8120e5845	Rename ctrl method to cmdtrl which covers the mains OS	7 years ago
Min RK	5ad7a41c4c	wait for kernel to be ready in selenium tests ... might fix recent flaky tests	7 years ago
Emilio Talamante Lugo	35a19e9308	Fixed dualmode insert test and convert dualmode arrows test to selenium	7 years ago
Emilio Talamante Lugo	e3c9a67294	Changed to .utils module for CI tests acceptance	7 years ago
Emilio Talamante Lugo	0c003e9de1	Handled possible race conditions and modified returned object on get_cell_output	7 years ago
Emilio Talamante Lugo	23adb8e919	Replacing time.sleep for a conditional waiting method	7 years ago
Emilio Talamante Lugo	b892d7c8c6	Converted shutdown.js test to selenium python test	7 years ago
Thomas Kluyver	bc3a8cbe79	Convert test for saving with complex name to Selenium	7 years ago
Thomas Kluyver	e00a86c4cb	Throw clearer error if no new window handles found	7 years ago
Thomas Kluyver	605dfb8b15	Convert multiselect test to Selenium	7 years ago
Thomas Kluyver	4b2e7dc3e3	Merge pull request #4193 from askerry/selenium_buffering ... Migrate buffering test to selenium	7 years ago
Amy Skerry	8b704d6628	Address review feedback ... - consolidate into single .append call - change function name to be clear we are waiting	7 years ago
Thomas Kluyver	6d7b6af514	Merge pull request #4182 from AndresSan6/merge_selected_cells ... Add test for JS function "merge_selected_cells" in test_merge_cells.py	7 years ago
Amy Skerry	f995db42ee	Address review feedback ... - fix indentation - remove unneccesary try/except - fix visibility logic	7 years ago
Amy Skerry	3faafc4122	Migrate buffering test to selenium ... As per issue #3335, we want all js tests migrated to selenium. This change migrates the test of buffered execution requests. Test Plan: py.test -v notebook/tests/selenium/test_buffering.py	7 years ago
Amy Skerry	6f73d79376	Add custom expectation to wait for n elements	7 years ago
Amy Skerry	dea186d177	Add wait_for_tag to avoid race condition in display isolation test ... Attempts to fix flakiness in `test_display_isolation`. We now ensure the iframe has been added to the dom before calling the selector. To make this work, we clean up the iframe cells (and all other cells) at the end of each test. I'm not 100% positive this fixes, since I haven't been able to reproduce the failure. But the hope is that this fixes the intermittent failing seen in https://github.com/jupyter/notebook/pull/4182.	7 years ago
Andres Sanchez	f27e87541d	Changed function name in utils.py and in test_merge_cells.py	7 years ago
Thomas Kluyver	c9378c71fe	Merge pull request #4146 from askerry/selenium_display_isolation ... Migrate display isolation test to selenium	7 years ago
Thomas Kluyver	099383e012	Merge pull request #4141 from askerry/selenium_display_image ... Migrate image display test to selenium	7 years ago
Amy Skerry	a5a6e4ad08	Address review feedback ... - remove sleep hack cruft - consolidate/remove unncessary intermediate variables	7 years ago
Amy Skerry	3ccc4ed207	Address review feedback ... - use %r instead of %s to handle quoting more succintly - add a finally block to ensure browser state is transitioned from iframe back to default content	7 years ago
Andres Sanchez	fd6ea8e556	Removed unnecessary property attibute created in utils.py and added comments to test_merge_cells.py	7 years ago
Andres Sanchez	1c87821dc1	Modifications to test JS funcion in test_merge_cells.py	7 years ago
Amy Skerry	aa658d3d79	Migrate display isolation test to selenium ... As per issue #3335, we want all js tests migrated to selenium. This change migrates and extends the svg isolation test (extended to include slightly more thorough validation of expected isolation behavior). Test Plan: py.test -v notebook/tests/selenium/test_display_isolation.py	7 years ago
Amy Skerry	34cd3528d5	Migrate test for merge cells api to selenium ... Migrates the test for merging cells to use selenium as suggested in issue #3335. Test Plan: py.test -v notebook/tests/selenium/test_merge_cells.py	7 years ago