28 Commits (f99beefdf45dd2891bb7ebdd93f7a67e44623aee)

Author	SHA1	Message	Date
Kevin Bates	a5ace13e0a	Merge pull request #5980 from kevin-bates/track-server-kernels ... [Gateway] Track only this server's kernels	5 years ago
faucct	5ab8717fec	Merging headers in load_connection_args	5 years ago
faucct	935d6df839	Correct 'Content-Type' headers	5 years ago
Kevin Bates	bbe2744f87	[Gateway] Track only this server's kernels	5 years ago
Kevin Bates	3e69164479	Update GatewayKernelManager to derive from AsyncMappingKernelManager	5 years ago
Dvoiak Stepan	d95f251ac6	Update notebook/gateway/managers.py ... Co-authored-by: Kevin Bates <kbates4@gmail.com>	5 years ago
sd	cd102428ca	traitlets Int for gateway_retry_max parameter	5 years ago
sd	ba0f490c94	mirrored logic from https://github.com/jupyter/nb2kg/pull/45 to notebook/gateway	5 years ago
Sai Rahul Poruri	84df5297d5	CLN : Update super usage ... This commit updates the super usage. Because Python 2 is not supported anymore, super usage can be updated such that super is called without any arguments in the default case where super is called with the class name and self. Note that all usage of super has not been updated - a few cases which smelled funny have been ignored.	6 years ago
Ram Rachum	7d375282a9	Fix exception causes all over the codebase	6 years ago
lucabem	266e2978e9	Changed _get_endpoint_for_user_filter to static and used in constructor class instead of each class method	6 years ago
lucabem	f5322fc387	Added functionality to allow filter kernels by Jupyter Enterprise Gateway using KERNEL_USERNAME env var	6 years ago
Kevin Bates	66ad3f469c	Enable check_origin on gateway websocket communication (#5471) ... This is a port of the same change in NB2KG (PR 22). Fixes #5460 Co-authored-by: Dylan <dylan.yi@icloud.com> Co-authored-by: Dylan <dylan.yi@icloud.com>	6 years ago
Kevin Bates	7de8df4dd8	Gateway only: Ensure launch and request timeouts are in sync (#5317) ... Prior to this change, the request timeout for a Gateway request was synchronized with KERNEL_LAUNCH_TIMEOUT only if KLT was greater. However, the two are closely associated and KLT should be adjusted if the configurable request_timeout is greater. This change ensures that the two values are synchronized to the greater value. It changes the two configurable timeouts to default to 40 (to match that of KLT) and removes the 2-second pad, since that wasn't helpful and only confused the situation. These changes were prompted by this issue: jupyter/enterprise_gateway#792	6 years ago
Shuichiro MAKIGAKI	aa73eb43cd	Fix packages of exceptions catched by gateway manager ... `gateway_request` in `gateway.manager` raises `tornado.web.HTTPError` exceptions, but the callers, such as `GatewayKernelManager.get_kernel`, catch `tornado.httpclient.HTTPError`, instead of `tornado.web.HTTPError`. Therefore, the callers can not handle exceptions during gateway interactions. This causes that, for example, when Jupyter Enterprise Gateway culled a kernel by idle timeout, the gateway manager can not handle the kernel's absent appropriately. As a result, notebook users see ambiguous "Kernel Error" and can not restart the kernel or start a new kernel.	7 years ago
Eunsoo Park	20c2c66857	Attempt to re-establish websocket connection to Gateway ... When notebook (with `--gateway-url` option) lost the connection to Gateway, notebook didn't connect to Gateway again although the websocket connection from the client was still alive. This change recovers the connection to Gateway to prevent this anomaly. Signed-off-by: Eunsoo Park <esevan.park@gmail.com>	7 years ago
Kevin Bates	7e50cdc856	Remove verbose debug statement in gateway mode ... I removed the mirroring 'Receiving' debug statement previously and didn't realize there's a 'Sending' statement. This change removes that statement. This should be part of the 6.0 release, just not signficant enough to warrant include in rc1.	7 years ago
Kevin Bates	f6e3c23089	Missing yield statement on WebSocketChannelsHandler (#4724) ... We were missing a yield statement in the deferral of `get()` to the superclass. This issue was occurring only when Tornado 6+ was deployed. Also removed a debug message producing way too much information.	7 years ago
Kevin Bates	f68e34f198	Add keepalive ping on gateway websocket	7 years ago
Kevin Bates	6939fae22b	Add authorization token to header only if no authorization already	7 years ago
Kevin Bates	191dc333f6	Modify/add various timeout values ... The connect and request timeout defaults have been updated from 20 to 60 seconds and a default value of 40 has been added for KERNEL_LAUNCH_TIMEOUT. The code ensures that KERNEL_LAUNCH_TIMEOUT is in the env and that the value of the request timeout is at least 2 greather than KERNEL_LAUNCH_TIMEOUT. This PR is port of the NB2KG PRs 35 and 38.	7 years ago
Solaris	83f591b81f	Fix binary message issue when configured to forward to gateway (#4576) ... If the message is bytes, we should set binary=True This is a port from NB2KG PR jupyter/nb2kg#33	7 years ago
Min RK	88aae11172	Merge pull request #4431 from kevin-bates/apply-nb2kg-updates ... Update gateway support with recent changes	7 years ago
Min RK	be35a370ce	gateway: compatibility with tornado 4 ... HTTPTimeoutError is new in tornado 5.1	7 years ago
Kevin Bates	46bcf78d63	Update gateway support with recent changes ... Convey notebook working directory to the gateway (nb2kg pr-21) Support retrieval of kernelspec resources from the gateway (nb2kg pr-23)	7 years ago
Kevin Bates	acba19033b	Minimize handlers and manager methods ... Eliminated the Kernel and Kernelspec handlers. The Websocket (ZMQ) channels handler still remains. This required turning a few methods into coroutines in the Notebook server. Renamed the Gateway config object to GatewayClient in case we want to extend NB server (probably jupyter_server at that point) with Gateway server functionality - so an NB server could be a Gateway client or a server depending on launch settings. Add code to _replace_ the channels handler rather than rely on position within the handlers lists. Updated mock-gateway to return the appropriate form of results. Updated the session manager tests to use a sync ioloop to call the now async manager methods.	7 years ago
Kevin Bates	f74ef2f691	Move environment variables to SingletonConfigurable ... Created a singleton class `Gateway` to store all configuration options for a Gateway. This class also holds some help methods to make it easier to use the options and determine if the gateway option is enabled. Updated the NotebookTestBase class to allow for subclasses to infuence the patched environment as well as command line options via argv. Added a test to ensure various gateway configuration items can be set via the environment or command-line.	7 years ago
Kevin Bates	060a2b9aea	Embed NB2KG into Notebook server ... This change alleviates a significant pain-point for consumers of Jupyter Kernel and Enterprise Gateway projects by embedding the few classes defined in the NB2KG server extension directly into the Notebook server. All code resides in a separate gateway directory and the 'extension' is enabled via a new configuration option `--gateway-url`. Renamed classes from those used in standard NB2KG code so that Notebook servers using the existing NB2KG extension will still work. Added test_gateway.py to exercise overridden methods. It does this by mocking the call that issues requests to the gateway server. Updated the _Running a notebook server_ topic to include a description of this feature.	7 years ago