293 Commits (fac228567eeaf6b15b196b82c7f294ff682d464e)

Author	SHA1	Message	Date
Ram Rachum	7d375282a9	Fix exception causes all over the codebase	6 years ago
Shane Canon	b5b44eb520	Fix for recursive symlink issue #4669 (#4670) ... * This is a potential fix to issue #4669. The fix simply catches the recusrive symlink error and moves on. It is possibble that the try/except belongs in the utils but I wanted to limit the scope. * It looks like too many levels is error number 40 on linux. * Switch to using errno instead of hardcoding the number. * Fix spelling, smarter assert methods * Log unrecognised errors and continue listing directory * Skip recursive symlink test entirely on Windows * Fix which test is skipped on Windows Co-authored-by: Thomas Kluyver <thomas@kluyver.me.uk>	6 years ago
Kevin Bates	6e9256b064	Culling: ensure last_activity attr exists before use (#5355) ... KernelManager's last_activity attribute is added following the instance's creation. Culling (independently) uses this attribute and should ensure it exists prior to its use, else skip the culling check for that instance. Fixes #5345	6 years ago
Kevin Bates	e06a55ea51	Merge branch 'master' into cull-terminals	6 years ago
Kevin Bates	a291f31cfe	Merge pull request #5425 from pinarkavak/log-notebook-type ... Logged notebook type	6 years ago
Pinar Kavak	8c063c2a61	Added notebook name to the logs	6 years ago
Kevin Bates	df887b2edf	Check for invalid characters prior to rename (#5193) ... * Check for invalid characters prior to rename On Windows platforms, rename operations containing ':' are problematic since the operation succeeds, but creates an unintended "alternate data stream" that gives the user the impression their file contents have been deleted. This change performs cursory validation of the destination name on platforms in which issues can occur. Currently, non-Windows systems don't require this level of validation. Fixes #5190 * Apply changes per review comments	6 years ago
Kevin Bates	deeb1e1214	Add ability to cull terminals and track last activity ... This adds functionality to track a terminal's last activity and optionally cull terminals that have been inactive for some specified duration. Resolves: #3868	6 years ago
Kevin Bates	1fc9bc0b72	Add comments indicating when dependency check can be removed	6 years ago
Kevin Bates	53d4d08813	Fix detection of unsupported config, prevent async on 3.5	6 years ago
Kevin Bates	99b0afd16e	Apply changes per review ... Add comments and rename self.super to self.pinned_superclass to clarify intent. Add run_sync() util method to clean up shutdown_all() invocation.	6 years ago
Kevin Bates	72d44c58cf	Switch class hierarchy to not use mixin base ... This commit uses the approach used in jupyter_server #191 first proposed by David Brochart. This reduces code duplication and alleviates redundancy relative to configurable options. Also, the startup message now includes the version information. Co-authored-by: David Brochart <david.brochart@gmail.com>	6 years ago
Kevin Bates	788bb0ebe0	Update all coroutine/yield methods to async/await, share another method	6 years ago
Kevin Bates	570986282e	Move duplicated methods to mixin, fix mixin order	6 years ago
Kevin Bates	8a4beb0d15	Convert to async/await and apply touch ups	6 years ago
Kevin Bates	7abd4bee27	Indicate that async kernel management is configured	6 years ago
Kevin Bates	3226b07345	Add support for AsyncMappingKernelManager ... Supports running against incompatible jupyter_client so long as the desired kernel_manager_class is not `AsyncMappingKernelManager`.	6 years ago
Kevin Bates	677ccc3d7a	Refactor buffering, culling and activity monitoring into classes ... Use composition in preparation for AsyncMappingKernelManager.	6 years ago
Kerwin.Sun	b5f5c9500e	remove py2 dependence	7 years ago
sasaki takeru	dcef16a5be	typo (#4946)	7 years ago
Vibhanshu	70d74d21ac	changed default filename for a copied notebook (#4618)	7 years ago
Min ho Kim	bd66c18b4f	Fix typos (#4760) ... * Fix typos * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces * Revert trimming whitespaces	7 years ago
Sylvain Corlay	10318a9827	Merge pull request #4672 from JohanMabille/control ... Added control channel to ZMQChannelsHandler	7 years ago
Min RK	efc0f0089e	Allow ?no_track_activity=1 to opt-out of activity tracking (#4235) ... * Don't track API requests with `?no_track_activity=1` in the activity counter allows external idle-culling scripts to avoid updating the activity counter * Don't track kernel shutdown as kernel activity this causes idle-kernel shutdowns to restart the idle-shutdown timer user-requested shutdowns will still be tracked as api activity * test ?no_track_activity=1 tracking * Changelog for activity	7 years ago
Johan Mabille	61ae2d6778	Added control channel to ZMQChannelsHandler	7 years ago
Min RK	e908edf171	Fix return value for async restart_kernel ... gen.Return shouldn't be passed the Future, the future should be awaited	7 years ago
Min RK	d7becafd59	add xsrf checks on files endpoints	7 years ago
Min RK	729183b148	use our own maybe_future ... instead of the monkeypatch we did to keep the backport patch small requiring tornado 5 simplifies things a ton because tornado.concurrent.Future is asyncio.Future	7 years ago
Min RK	88aae11172	Merge pull request #4431 from kevin-bates/apply-nb2kg-updates ... Update gateway support with recent changes	7 years ago
Kevin Bates	46bcf78d63	Update gateway support with recent changes ... Convey notebook working directory to the gateway (nb2kg pr-21) Support retrieval of kernelspec resources from the gateway (nb2kg pr-23)	7 years ago
Frédéric Chapoton	9f59b7feb3	remove unused import of os ... found by lgtm	7 years ago
Min RK	6d15e9cdab	Merge pull request #4328 from maxmouchet/list_hidden_files ... List hidden files if allowed	7 years ago
Min RK	bba82ca3bd	Merge pull request #4412 from kevin-bates/async-startup ... Enable restart_kernel for async usage	7 years ago
Kevin Bates	2c526fb60b	Enable restart_kernel for async usage ... Converted `MappingKernelManager.restart_kernel` to a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts.	7 years ago
Kevin Bates	acba19033b	Minimize handlers and manager methods ... Eliminated the Kernel and Kernelspec handlers. The Websocket (ZMQ) channels handler still remains. This required turning a few methods into coroutines in the Notebook server. Renamed the Gateway config object to GatewayClient in case we want to extend NB server (probably jupyter_server at that point) with Gateway server functionality - so an NB server could be a Gateway client or a server depending on launch settings. Add code to _replace_ the channels handler rather than rely on position within the handlers lists. Updated mock-gateway to return the appropriate form of results. Updated the session manager tests to use a sync ioloop to call the now async manager methods.	7 years ago
Maxime Mouchet	48915c0ad7	Split logic	7 years ago
Maxime Mouchet	1566dd1712	List hidden files if allowed (#3812)	7 years ago
Matthias Bussonnier	64fa7cf674	Merge pull request #4210 from SylvainCorlay/message-filtering ... Enable kernel message filtering	8 years ago
Sylvain Corlay	4a7151448c	Enable kernel message filtering	8 years ago
Kevin Bates	0e63ebb1db	Update session_exists() to account for invalid sessions due to culling ... When kernels are culled, the kernel is terminated in the background, unbeknownst to the session management. As a result, invalid sessions can be produced that appear to exist, yet cannot produce a model from the persisted row due to the associated kernel no longer being active. Prior to this change, these sessions, when encountered via a subsequent call to `get_session()`, would be deleted and a KeyError would be raised. This change updates the existence check to tolerate those kinds of sessions. It removes such sessions (as would happen previously), but rather than raise a KeyError when attempting to convert the row to a dictionary, it logs a warning and returns None, which then allows `session_exists()` to return False since the session was removed (as was ultimately the case previously). Calls to `get_session()` remain just as before and have the potential to raise `KeyError` in such cases. The difference now being that the `KeyError` is accompanied by a message indicating the cause. Fixes #4209	8 years ago
Michal Charemza	815ed3ce56	Allow more contents manager functions to return futures ... This allows slower contents managers to not block the event loop by allowing more of their API to return futures. Other usages of contents manager functions are already wrapped in maybe_future, including a use of `file_exists` in contents/handlers.py	8 years ago
Min RK	b663bf1b14	Merge pull request #4034 from Carreau/adaptation-log ... When adapting also log the version jupyter_client is expecting.	8 years ago
Kevin Bates	23e74dcdfa	Include status types when logging activity ... Recently I needed to troubleshoot kernel responses and found it helpful to distinguish status types (busy vs. idle) - thought others might find it useful as well. Entries that previously appeared as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status ``` will now appear as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) ```	8 years ago
Maxim Vov	f2fdbf929e	Added metrics for number of kernels running labeled by type	8 years ago
Matthias Bussonnier	96cb061e7b	More descriptive message.	8 years ago
Matthias Bussonnier	7e140c5baf	When adapting also log the version jupyter_client is expecting. ... It's still (IMHO) unclear how the adaptation goes. Like does "adapting to protocol X.Y.Z." mean the end-result is X.Y.Z or what you got is X.Y.Z and it's X.Y.W after adaptation.	8 years ago
Kevin Bates	2d688f2071	Prevent access through 'NoneType' when closing activity_stream ... Although I'm unable to reproduce the issue, its a safe change to prevent an AttributeError from occuring ('NoneType' object has no attribute 'close'). The user that reported this is attempting to launch a kernel and I believe the launch only partially completed such that `kernel._activity_stream` did not get established. (This occurred from Jupyter Enterprise Gateway where we deal with remote kernel launches across resource-managed clusters, so things are a bit more involved relative to kernel establishment.)	8 years ago
Sally Wilsak	c258d3fa79	Get the list of exporters from entrypoints ... `exporter_map` is deprecated, so let's use the list of exporters fetched from the installed entrypoints. There's a supposed attribute `export_from_notebook` that should be set to a friendly string name if the exporter should be exposed in the front-end. However, the exporters defined in `nbconvert` don't have it set, so I haven't used it to determine inclusion in the list. Instead, I've used the entrypoint name as the friendly name, which looks like it was the intention from the way they are named. I ran the unit tests and tried starting up the notebook server and accessing the API endpoint to verify the JSON looked correct.	8 years ago
Min RK	a53d2c8489	flush iopub before sending restarting/dead status messages ... to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message	8 years ago
Thomas Kluyver	7ea7a8b97d	Skip directory deletion test on Windows	8 years ago