49 Commits (fb6bb02b261bfec08073e3fbec1bec66a2e6ff39)

Author	SHA1	Message	Date
Paul Ivanov	997a9735f0	Merge pull request #5320 from jdfreder/focusbug_tt ... Fix for Tooltip & completer click focus bug.	12 years ago
Paul Ivanov	0c366861c5	brief key event desription	12 years ago
Paul Ivanov	09866e0ee1	go to the beginning of the line when entering cell	12 years ago
Paul Ivanov	96848748de	restore master behavior ... up arrow at the top line first goes to char 0, and only goes to the cell above if already on char 0. Same with down arrow on the bottom line: transition cursor to the end of the line, and only go down a cell if already at the end of the last line. this makes for an unhappy experience in code-mirror's vim mode for j and k keys, but we'll fix that in the next commit	12 years ago
Paul Ivanov	61b47695e4	renamed 'use_shortcut' method to 'handles'	12 years ago
Paul Ivanov	d8287466d0	another doc fix	12 years ago
Paul Ivanov	67fd905421	minor fixes to docs to address PR feedback	12 years ago
Paul Ivanov	469c70fd10	more semicolons	12 years ago
Jonathan Frederic	65732920eb	Remove all should cancel blur logic.	12 years ago
Paul Ivanov	19c7189b15	no need to special-case Escape anymore	12 years ago
Paul Ivanov	6a2c4121f9	up and down keys no longer need special casing	12 years ago
Paul Ivanov	2c9ff376a2	added new use_shortcut method to shortcuts ... this way, you can ask if a particular event will be handled by the shortcuts system. This takes away the need to special-case many different possible keys which should be ignored by codemirror by ignoring them en masse.	12 years ago
Paul Ivanov	b9e448b160	DRY: refactor common keyboard handling to Cell ... Our edit mode keyboard shortcuts don't distinguish between being in a code cell or in a text cell, so it makes sense to handle both in one place. This is a first step in that direction.	12 years ago
Paul Ivanov	15f4345ba3	typo, use keycodes object instead of magic numbers	12 years ago
Paul Ivanov	bf3ecdb35f	DRY: factor out common handle_keyevent method ... This method was identical in both CodeCell and TextCell	12 years ago
Paul Ivanov	71d4c427c9	refactor to improve cell switching in edit mode ... This code was repeated in both CodeCell and TextCell, both of which are extensions of Cell, so this just unifies the logic in Cell. TextCell had logic here to check if the cell was rendered or not, but I don't believe it is possible to end up triggering such a code path. (Should that be required, I can always just add back these methods to TextCell, performing the .rendered==True check, and calling the Cell prior to this, code mirror at_top would only return true on if the cursor was at the first character of the top line. Now, pressing up arrow on any character on the top line will take you to the cell above. The same applies for the bottom line. Pressing down arrow would only go to the next cell if the cursor was at a location *after* the last character (something that is only possible to achieve in vim mode if the last line is empty, for example). Now, down arrow on any character of the last line will go to the next cell.	12 years ago
Jonathan Frederic	c41fe67da2	Re-added removed refresh	12 years ago
Jonathan Frederic	69e760841a	Move should cancel blur into codecell	12 years ago
Jonathan Frederic	bfc51c2a29	Final touches?	12 years ago
Jonathan Frederic	b976804051	Moved edit_mode canceling logic back into cell.	12 years ago
Jonathan Frederic	ff37fb7a36	Standardized comments and removed last logs	12 years ago
Jonathan Frederic	70086d352f	s/unfocus/blur	12 years ago
Jonathan Frederic	c7860d8bc8	Post in person review ... Removed logic for reverse ordered events Removed almost all of the log statements Removed list for should unfocus callbacks Removed all the logic in focus_editor Only call focus_editor if the keyboard was used to enter edit mode	12 years ago
Jonathan Frederic	10d79a9102	Added cell unfocus event canceller API	12 years ago
Jonathan Frederic	6f7c502157	Fixed lots of bugs ... Half overhaul of notebook focus events...	12 years ago
Jonathan Frederic	206d35a89e	DEBUG ... Added lots of log calls and a couple small 'fixes' (attempts)	12 years ago
Brian E. Granger	63ae9e2fd7	Fixing this->that.	12 years ago
Brian E. Granger	5f4d4017c1	Only call CM.focus() if CM is not already focused.	12 years ago
Min RK	f7388dd2ea	Merge pull request #4785 from SylvainCorlay/master ... Replacing a for-in loop by an index loop on an array	12 years ago
Sylvain Corlay	a053ba2419	Replacing a for-in loop by an index loop on an array, to avoid enumerating inherited properties	12 years ago
Brian E. Granger	5e706935e1	Semicolon cleanup.	12 years ago
Brian E. Granger	177fb9bb5d	Fixing css class on cell related to selected, rendered, mode.	12 years ago
Brian E. Granger	06aa0d540d	Using a more specific approach for managing CM focus. ... I used to try and enter command mode when a cell looses focus. The problem with that is that focusing an output area would remain in edit mode. Now, I bind this logic to the code mirror blur event, so that focusing the output area enters command mode.	12 years ago
Brian E. Granger	0000e688d6	Code comments and minor fixes.	12 years ago
Brian E. Granger	c1166ea98a	Lots of updates and changes. ... * Cleaning up the code mirror event handlers. * Adding logic to prevent calling Notebook.command_mode on cell focusout. * Fixing bugs.	12 years ago
Brian E. Granger	40977e545b	Semi working version of basic dual mode UX. ... As of this point there are lots of things that don't work, but most of the basic dual mode interactions do work fine.	12 years ago
Brian E. Granger	2a530ff30d	More work on the dual mode UX.	12 years ago
Brian E. Granger	54088a0105	Adding new logic to cells.	12 years ago
Brian E. Granger	2181a29be7	Starting work on select/focus logic.	12 years ago
MinRK	9fc9580256	set cell_type properly first-class in the Cell object ... - in toJSON - don't clobber existing value in Cell constructor	12 years ago
MinRK	dd3a1866ff	give Raw Cells a placeholder ... and make sure cell_type is defined *before* calling TextCell.apply	12 years ago
Matthias BUSSONNIER	33dd73eea4	some optimisation and code cleaning ... optimisation are not obvious, but order and time of attribute creation in javascript have impact for VMs apparently (Google IO talk on V8)	12 years ago
Matthias BUSSONNIER	048ccde41b	get rid of most slowdown at notebook loading. ... 1) Do not setOption('mode',new_mode) on CM if new and old mode are the same. It triggert **a lot** of calculation of bounding box in the end. 2) Do **not** select cell when loading the notebook it triggers **a lot** of CM even that check visible things and so on and so forth. So add a option to add_cell_at_index not to select it 3) jQuery $.attr has some magics, but has a slight overhead on real native ELEM.setAttribute DOM method. Seem slight improvement when loads of PNGs on one page	12 years ago
MinRK	37a345bd93	add Cell.is_mergeable method ... and check it in the Notebook merge methods	13 years ago
Min RK	76f8de32ea	Merge pull request #4064 from Carreau/default_mode ... Store default codemirror mode in only 1 place	13 years ago
Matthias Bussonnier	b6e5dc0f65	catch if cm_config of other key undefined	13 years ago
Matthias BUSSONNIER	fc8f118610	store default codemirror mode in only 1 place	13 years ago
Matthias BUSSONNIER	13ff842be5	"use strict" in most (if not all) our javascript ... + fix one variable leaking in global nameespace	13 years ago
MinRK	cf726d6a40	mv IPython.html.notebook -> IPython.html	13 years ago