You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Matthias Bussonnier e751e1ca1e Implement discussed behavior: ... - replace regexes they were not matching at the end of files. - hide edit/view for multiple, they where not working From the Pr comments that should closely match the following Observations: - "View" is handled by the browser so in most case it's something "safe". I think that (A) all items we don't know what to do with should have the _possibility_ to be viewed. (example `config.yaml`, `cat.gifv`). - "Edit" make sens only on text files only. In general (B) "edit" should not be the default action for most files. - Though (C) "Edit" should be triggerable by advanced users (unless we know we should not). Example `foo.zorblax`, `conf.toml` - (D) "Edit" does not make sens for some filetypes, thus should not be available (`'png`, `.jpeg`) Question (E): - If the default action is X {in edit/view} should the X button be shown ? Proposition: - if ipynb: - default link edit - no button in toolbar. - If known type, editable (txt, json, yaml, py, rb): - default link open edit, - button in toolbar show view - if known type not editable: (, png, gif, zip) - default link open view - no button in toolbar - if unknown type ('.zorblax, toml, cson, ') - default link open "view" - button in the toolbar show "Edit".		9 years ago
..
js	Implement discussed behavior:	9 years ago
less	Adjust styling of dropdown header in new menu	10 years ago