You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
|
|
|
/*
|
|
|
|
* Copyright (c) 2015 - present Facebook, Inc.
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* This source code is licensed under the BSD style license found in the
|
|
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package codetoanalyze.java.quandary;
|
|
|
|
|
|
|
|
import android.content.SharedPreferences;
|
|
|
|
import android.util.Log;
|
|
|
|
|
|
|
|
public class LoggingPrivateData {
|
|
|
|
|
|
|
|
public void logSharedPreferencesDataBad(SharedPreferences prefs) {
|
|
|
|
Log.d("tag", prefs.getString("some", "data"));
|
|
|
|
}
|
|
|
|
|
|
|
|
public void logSharedPreferencesDataInTagBad(SharedPreferences prefs) {
|
|
|
|
Log.d(prefs.getString("some", "data"), "value");
|
|
|
|
}
|
|
|
|
|
|
|
|
static class StringWrapper extends Throwable {
|
|
|
|
private String mStr;
|
|
|
|
|
|
|
|
@Override
|
|
|
|
public String toString() {
|
|
|
|
return mStr;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public void logSharedPreferencesDataIndirectBad(SharedPreferences prefs) {
|
|
|
|
StringWrapper wrapper = new StringWrapper();
|
|
|
|
wrapper.mStr = prefs.getString("some", "data");
|
|
|
|
Log.w("tag", wrapper);
|
|
|
|
}
|
|
|
|
|
|
|
|
public void logDataOk(SharedPreferences prefs) {
|
|
|
|
Log.d("tag", "value");
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|