pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '12be484431'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/shared/block/dispatch.m.dot

228 lines
21 KiB
Raw Normal View History Unescape

Add @generated comment to icfg.dot files Reviewed By: jvillard Differential Revision: D3358243 fbshipit-source-id: a47cc01
9 years ago
/* @generated */
[cfg] rename iCFG to cfg in dotty files Summary: Not sure what an "iCFG" is but the dotty is only about CFGs anyway. Diff obtained by mass-`sed`. Reviewed By: sblackshear Differential Revision: D6324280 fbshipit-source-id: b7603bb
7 years ago
digraph cfg {
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_1" [label="1: Start DispatchA_sharedInstance\nFormals: \nLocals: \n DECLARE_LOCALS(&return); [line 27, column 1]\n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_1" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" ;
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_2" [label="2: Exit DispatchA_sharedInstance \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" [label="3: Return Stmt \n n$1=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_sharedInstance_sharedInstance:objc_object* [line 33, column 10]\n *&return:objc_object*=n$1 [line 33, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_2" ;
[objc] Model dispatch functions Reviewed By: ddino, jvillard Differential Revision: D6359807 fbshipit-source-id: b1a04de
7 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" [label="4: Call _fun__dispatch_once \n _fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_sharedInstance_once:long*,(_fun_objc_blockDispatchA_sharedInstance_1):_fn_(*)) block_params [line 30, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_1" [label="1: Start DispatchA_block_attribute\nFormals: \nLocals: a:DispatchA*(__block) \n DECLARE_LOCALS(&return,&a); [line 36, column 1]\n " color=yellow style=filled]
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_1" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" ;
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_2" [label="2: Exit DispatchA_block_attribute \n " color=yellow style=filled]
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" [label="3: Return Stmt \n n$4=*&a:DispatchA* [line 42, column 10]\n n$5=*n$4._x:int [line 42, column 10]\n *&return:int=n$5 [line 42, column 3]\n " shape="box"]
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_2" ;
[retain cycles] Do not report when the captured variable is weak Reviewed By: mbouaziz Differential Revision: D6912514 fbshipit-source-id: a30635c
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" [label="4: Call _fun__dispatch_once \n n$6=*&a:DispatchA* [line 39, column 24]\n _fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_block_attribute_once:long*,(_fun_objc_blockDispatchA_block_attribute_2,(n$6 &a:DispatchA*)):_fn_(*)) block_params [line 39, column 3]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" ;
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" [label="5: DeclStmt \n n$8=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 38, column 26]\n n$9=_fun_NSObject_init(n$8:DispatchA*) virtual [line 38, column 26]\n *&a:DispatchA*=n$9 [line 38, column 3]\n " shape="box"]
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" ;
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_1" [label="1: Start DispatchA_trans\nFormals: \nLocals: dummy_block:_fn_(*) \n DECLARE_LOCALS(&return,&dummy_block); [line 45, column 1]\n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_1" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" ;
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_2" [label="2: Exit DispatchA_trans \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" [label="3: Return Stmt \n n$10=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_trans_sharedInstance:objc_object* [line 51, column 10]\n *&return:objc_object*=n$10 [line 51, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" [label="4: Call n$11 \n n$11=*&dummy_block:_fn_(*) [line 50, column 3]\n n$11() [line 50, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" [label="5: DeclStmt \n *&dummy_block:_fn_(*)=(_fun_objc_blockDispatchA_trans_3) [line 47, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_1" [label="1: Start DispatchA_dispatch_a_block_variable\nFormals: \nLocals: initialization_block__:_fn_(*) \n DECLARE_LOCALS(&return,&initialization_block__); [line 54, column 1]\n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_1" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" ;
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_2" [label="2: Exit DispatchA_dispatch_a_block_variable \n " color=yellow style=filled]
initial synchronization
10 years ago
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" [label="3: Return Stmt \n n$14=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_static_storage__:objc_object* [line 61, column 10]\n *&return:objc_object*=n$14 [line 61, column 3]\n " shape="box"]
Adding endtoend test that shows that dispatch once works well Reviewed By: ddino Differential Revision: D2570191 fb-gh-sync-id: 01be61c
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" [label="4: Call _fun__dispatch_once \n n$15=*&initialization_block__:_fn_(*) [line 60, column 32]\n _fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_once_token__:long*,n$15:_fn_(*)) [line 60, column 3]\n " shape="box"]
Adding endtoend test that shows that dispatch once works well Reviewed By: ddino Differential Revision: D2570191 fb-gh-sync-id: 01be61c
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" [label="5: DeclStmt \n *&initialization_block__:_fn_(*)=(_fun_objc_blockDispatchA_dispatch_a_block_variable_4) [line 56, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_1" [label="1: Start DispatchA_dispatch_a_block_variable_from_macro\nFormals: \nLocals: initialization_block__:_fn_(*) \n DECLARE_LOCALS(&return,&initialization_block__); [line 64, column 1]\n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_1" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" ;
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_2" [label="2: Exit DispatchA_dispatch_a_block_variable_from_macro \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" [label="3: Fallback node \n n$18=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_from_macro_static_storage__:objc_object* [line 72, column 5]\n " shape="box"]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" [label="4: Call _fun__dispatch_once \n n$19=*&initialization_block__:_fn_(*) [line 71, column 34]\n _fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_from_macro_once_token__:long*,n$19:_fn_(*)) [line 71, column 5]\n " shape="box"]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" [label="5: DeclStmt \n *&initialization_block__:_fn_(*)=(_fun_objc_blockDispatchA_dispatch_a_block_variable_from_macro_5) [line 67, column 5]\n " shape="box"]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" [label="6: Return Stmt \n *&return:objc_object*=n$18 [line 65, column 3]\n " shape="box"]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_1" [label="1: Start DispatchA_dispatch_a_block_variable_from_macro_delivers_initialised_object\nFormals: \nLocals: a:DispatchA* \n DECLARE_LOCALS(&return,&a); [line 76, column 1]\n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_1" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" ;
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_2" [label="2: Exit DispatchA_dispatch_a_block_variable_from_macro_delivers_initialised_object \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" [label="3: Return Stmt \n n$22=*&a:DispatchA* [line 79, column 15]\n n$23=*n$22._x:int [line 79, column 15]\n *&return:int=(1 / (n$23 - 5)) [line 79, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" [label="4: BinaryOperatorStmt: Assign \n n$24=*&a:DispatchA* [line 78, column 3]\n *n$24._x:int=5 [line 78, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" [label="5: DeclStmt \n n$25=_fun_DispatchA_dispatch_a_block_variable_from_macro() [line 77, column 18]\n *&a:DispatchA*=n$25 [line 77, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" ;
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_1" [label="1: Start objc_blockDispatchA_sharedInstance_1\nFormals: \nLocals: \n DECLARE_LOCALS(&return); [line 30, column 24]\n " color=yellow style=filled]
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_1" -> "objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_3" ;
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_2" [label="2: Exit objc_blockDispatchA_sharedInstance_1 \n " color=yellow style=filled]
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_3" [label="3: BinaryOperatorStmt: Assign \n n$2=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 31, column 23]\n n$3=_fun_NSBundleResourceRequest_init(n$2:DispatchA*) virtual [line 31, column 22]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_sharedInstance_sharedInstance:objc_object*=n$3 [line 31, column 5]\n " shape="box"]
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_3" -> "objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_2" ;
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_1" [label="1: Start objc_blockDispatchA_trans_3\nFormals: \nLocals: \n DECLARE_LOCALS(&return); [line 47, column 27]\n " color=yellow style=filled]
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_1" -> "objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_3" ;
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_2" [label="2: Exit objc_blockDispatchA_trans_3 \n " color=yellow style=filled]
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_3" [label="3: BinaryOperatorStmt: Assign \n n$12=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 48, column 23]\n n$13=_fun_NSBundleResourceRequest_init(n$12:DispatchA*) virtual [line 48, column 22]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_trans_sharedInstance:objc_object*=n$13 [line 48, column 5]\n " shape="box"]
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_3" -> "objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_2" ;
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_1" [label="1: Start objc_blockDispatchA_dispatch_a_block_variable_4\nFormals: \nLocals: \n DECLARE_LOCALS(&return); [line 56, column 38]\n " color=yellow style=filled]
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_1" -> "objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_3" ;
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_2" [label="2: Exit objc_blockDispatchA_dispatch_a_block_variable_4 \n " color=yellow style=filled]
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_3" [label="3: BinaryOperatorStmt: Assign \n n$16=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 57, column 25]\n n$17=_fun_NSObject_init(n$16:DispatchA*) virtual [line 57, column 25]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_static_storage__:objc_object*=n$17 [line 57, column 5]\n " shape="box"]
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_3" -> "objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_2" ;
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_1" [label="1: Start objc_blockDispatchA_dispatch_a_block_variable_from_macro_5\nFormals: \nLocals: \n DECLARE_LOCALS(&return); [line 67, column 40]\n " color=yellow style=filled]
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_1" -> "objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_3" ;
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_2" [label="2: Exit objc_blockDispatchA_dispatch_a_block_variable_from_macro_5 \n " color=yellow style=filled]
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_3" [label="3: BinaryOperatorStmt: Assign \n n$20=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 68, column 27]\n n$21=_fun_NSObject_init(n$20:DispatchA*) virtual [line 68, column 27]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_from_macro_static_storage__:objc_object*=n$21 [line 68, column 7]\n " shape="box"]
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_3" -> "objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_1" [label="1: Start DispatchMain\nFormals: \nLocals: p:int* b:DispatchA* \n DECLARE_LOCALS(&return,&p,&b); [line 84, column 1]\n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_1" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" [label="2: Exit DispatchMain \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_3" [label="3: + \n " ]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_3" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" [label="4: between_join_and_exit \n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" [label="5: BinaryOperatorStmt: EQ \n n$0=*&b:DispatchA* [line 87, column 7]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" [label="6: Prune (true branch) \n PRUNE((n$0 == null), true); [line 87, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" [label="7: Prune (false branch) \n PRUNE(!(n$0 == null), false); [line 87, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" [label="8: Return Stmt \n n$1=*&p:int* [line 88, column 13]\n n$2=*n$1:int [line 88, column 12]\n *&return:int=n$2 [line 88, column 5]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" [label="9: Return Stmt \n *&return:int=0 [line 90, column 5]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" [label="10: DeclStmt \n *&p:int*=null [line 86, column 3]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" [label="11: DeclStmt \n n$3=_fun_DispatchA_sharedInstance() [line 85, column 18]\n *&b:DispatchA*=n$3 [line 85, column 3]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_1" [label="1: Start DispatchA_init\nFormals: self:DispatchA*\nLocals: \n DECLARE_LOCALS(&return); [line 23, column 1]\n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_1" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" ;
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_2" [label="2: Exit DispatchA_init \n " color=yellow style=filled]
initial synchronization
10 years ago
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" [label="3: Return Stmt \n n$0=*&self:DispatchA* [line 24, column 10]\n *&return:objc_object*=n$0 [line 24, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_2" ;
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
"objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_1" [label="1: Start objc_blockDispatchA_block_attribute_2\nFormals: a:DispatchA*\nLocals: \nCaptured: a:DispatchA* \n DECLARE_LOCALS(&return); [line 39, column 24]\n " color=yellow style=filled]
"objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_1" -> "objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_3" ;
"objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_2" [label="2: Exit objc_blockDispatchA_block_attribute_2 \n " color=yellow style=filled]
"objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_3" [label="3: BinaryOperatorStmt: Assign \n n$7=*&a:DispatchA* [line 40, column 5]\n *n$7._x:int=10 [line 40, column 5]\n " shape="box"]
"objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_3" -> "objc_blockDispatchA_block_attribute_2.871f06a0b12b5767153a5d30f3798261_2" ;
initial synchronization
10 years ago
}