pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '1f6b9edacc'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/biabduction/issues.exp

109 lines
26 KiB
Raw Normal View History Unescape

record objc tests Summary: Some recent severity changes broke them. Reviewed By: ngorogiannis Differential Revision: D21931247 fbshipit-source-id: 6b681b32d
5 years ago
codetoanalyze/objc/biabduction/field_superclass/field.c, field_superclass_main, 3, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure field_superclass_main()]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/biabduction/field_superclass/field.c, field_superclass_main, 3, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure field_superclass_main()]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/global_const/global_const.m, SimpleRoot.doSomethingBadWithDict:andString:, 3, NULL_DEREFERENCE, B2, ERROR, [start of procedure doSomethingBadWithDict:andString:,Message stringByAppendingString: with receiver nil returns nil.]
codetoanalyze/objc/biabduction/global_const/global_const.m, SimpleRoot.doSomethingOkWithDict:andString:, 3, NULL_DEREFERENCE, B2, ERROR, [start of procedure doSomethingOkWithDict:andString:,Message stringByAppendingString: with receiver nil returns nil.]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/biabduction/initialization/compound_literal.c, init_with_compound_literal, 2, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure init_with_compound_literal()]
[closures preanalysis] [3/n] Adding models to dispatch functions and remove code for previous specialization and dispatch models Summary: This diff finishes the migration from the specialization of methods that take blocks as arguments. Here we delete all the old code and change the way we model dispatch functions so that the tests pass. - Remove the code for specializing the methods in biabduction. - Remove the call flags `cf_with_block_parameters` that was only used in this algorithm. - Removes models for dispatch functions. - Adds models for dispatch functions as program transformation only in biabduction. To be added in other checkers in the future. Reviewed By: ngorogiannis Differential Revision: D23345342 fbshipit-source-id: b5e8542ce
4 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleStaticVar.m, RetainCSV.foo, 13, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure foo,start of procedure block,start of procedure init,return from a call to RetainCSV.init,return from a call to objc_blockRetainCSV.foo_3,start of procedure block,start of procedure init,return from a call to RetainCSV.init,return from a call to objc_blockRetainCSV.foo_2,start of procedure setHandler:,return from a call to RetainCSV.setHandler:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleStaticVar.m, RetainCSV.foo, 13, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure foo,start of procedure block,start of procedure init,return from a call to RetainCSV.init,return from a call to objc_blockRetainCSV.foo_3,start of procedure block,start of procedure init,return from a call to RetainCSV.init,return from a call to objc_blockRetainCSV.foo_2,start of procedure setHandler:,return from a call to RetainCSV.setHandler:]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/npe/null_returned_by_method.m, NullReturnedByMethodA.test1, 1, NULL_DEREFERENCE, B5, ERROR, [start of procedure test1,start of procedure test,return from a call to NullReturnedByMethodA.test]
[pulse] Enable pulse memory leaks and disable biabduction one Summary: The new memory leaks analysis is now ready to be enabled by default and turned on in production. This also replaces the biabduction one which is now disabled. Reviewed By: jvillard Differential Revision: D21998666 fbshipit-source-id: 9cd95e894
5 years ago
codetoanalyze/objc/biabduction/procdescs/main.c, ProcdescMain, 3, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure ProcdescMain(),Skipping plusX:andY:: method has no implementation]
codetoanalyze/objc/biabduction/procdescs/main.c, call_nslog, 3, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure call_nslog(),Skipping NSLog(): method has no implementation]
codetoanalyze/objc/biabduction/property/main.c, property_main, 3, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure property_main(),Skipping aProperty: method has no implementation]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.FBAudioInputCallbackChain:, 2, NULL_DEREFERENCE, B2, ERROR, [start of procedure FBAudioInputCallbackChain:,start of procedure recorder,return from a call to FBAudioRecorder.recorder]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.FBAudioInputCallbackChain:, 2, PARAMETER_NOT_NULL_CHECKED, B2, WARNING, [start of procedure FBAudioInputCallbackChain:,Message recorder with receiver nil returns nil. Message recordState with receiver nil returns nil.]
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.FBAudioInputCallbackField, 2, NULL_DEREFERENCE, B1, ERROR, [start of procedure FBAudioInputCallbackField,Message recordState with receiver nil returns nil.]
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.FBAudioInputCallbackSimple:, 2, PARAMETER_NOT_NULL_CHECKED, B2, WARNING, [start of procedure FBAudioInputCallbackSimple:,Message recordState with receiver nil returns nil.]
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.FBAudioInputCallbackSimpleAliasing:, 3, PARAMETER_NOT_NULL_CHECKED, B1, WARNING, [start of procedure FBAudioInputCallbackSimpleAliasing:,Message recordState with receiver nil returns nil.]
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.init, 2, NULL_DEREFERENCE, B2, ERROR, [start of procedure init]
codetoanalyze/objc/biabduction/warnings/ParameterNotNullableExample.m, FBAudioRecorder.test, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure test,Message recordState with receiver nil returns nil.]
codetoanalyze/objc/shared/block/BlockVar.m, BlockVar.blockPostBad, 5, NULL_DEREFERENCE, B5, ERROR, [start of procedure blockPostBad,start of procedure block,return from a call to objc_blockBlockVar.blockPostBad_2]
[preanalysis] Adding a preanalysis to resolve local closures Summary: This will allow all the analyses to be able to call closures without any special treatment: we transform the call to variables that point to closures into normal function calls. We treat only ObjC blocks at the moment, with C++ lambdas to be done as a next step. We aimed to achieve certain results in Pulse (see tests: avoid memory leaks and NPEs FPs) while also keeping the biabduction analysis working as before. We also checked that for the examples analyzed Pulse behaves like the correct semantics of ObjC programs with blocks. Reviewed By: jvillard Differential Revision: D22547333 fbshipit-source-id: efe56ed51
4 years ago
codetoanalyze/objc/shared/block/BlockVar.m, BlockVar.capturedNullDeref, 5, NULL_DEREFERENCE, B5, ERROR, [start of procedure capturedNullDeref,start of procedure block]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/shared/block/BlockVar.m, BlockVar.navigateToURLInBackground, 8, NULL_DEREFERENCE, B1, ERROR, [start of procedure navigateToURLInBackground,start of procedure block,start of procedure test,return from a call to BlockVar.test,return from a call to objc_blockBlockVar.navigateToURLInBackground_1,Taking true branch]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/shared/block/block.m, main1, 30, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure main1(),start of procedure block,start of procedure block,return from a call to objc_blockobjc_blockmain1_2_3,return from a call to objc_blockmain1_2,start of procedure block,return from a call to objc_blockmain1_1]
[clang] Adding implicit implementation of dealloc methods to ObjC classes Summary: This models ARC implementation of dealloc, see https://clang.llvm.org/docs/AutomaticReferenceCounting.html#dealloc. Dealloc methods can be added to ObjC classes to free C memory for example, but the deallocation of the ObjC instance variables of the object is done automatically. So here we add this explicitly to Infer: 1. First, we add an empty dealloc method when it is not written explicitly. 2. For each dealloc method (including the implicitly added ones) we add calls to dealloc of the ObjC instance variables. Reviewed By: jvillard Differential Revision: D21883546 fbshipit-source-id: f5d4930f2
5 years ago
codetoanalyze/objc/shared/block/block_no_args.m, Block_no_args.m, 10, NULL_DEREFERENCE, B1, ERROR, [start of procedure m,start of procedure block,return from a call to objc_blockBlock_no_args.m_1,Taking true branch]
[pulse] Enable pulse memory leaks and disable biabduction one Summary: The new memory leaks analysis is now ready to be enabled by default and turned on in production. This also replaces the biabduction one which is now disabled. Reviewed By: jvillard Differential Revision: D21998666 fbshipit-source-id: 9cd95e894
5 years ago
codetoanalyze/objc/shared/category_procdesc/main.c, CategoryProcdescMain, 3, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure CategoryProcdescMain(),Skipping performDaysWork: method has no implementation]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/shared/field_superclass/SuperExample.m, ASuper.init, 2, NULL_DEREFERENCE, B2, ERROR, [start of procedure init]
[closures preanalysis] [3/n] Adding models to dispatch functions and remove code for previous specialization and dispatch models Summary: This diff finishes the migration from the specialization of methods that take blocks as arguments. Here we delete all the old code and change the way we model dispatch functions so that the tests pass. - Remove the code for specializing the methods in biabduction. - Remove the call flags `cf_with_block_parameters` that was only used in this algorithm. - Removes models for dispatch functions. - Adds models for dispatch functions as program transformation only in biabduction. To be added in other checkers in the future. Reviewed By: ngorogiannis Differential Revision: D23345342 fbshipit-source-id: b5e8542ce
4 years ago
codetoanalyze/objc/biabduction/blocks_in_heap/BlockInHeap.m, block_in_heap_executed_after_bi_abduction_ok_test, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure block_in_heap_executed_after_bi_abduction_ok_test(),start of procedure block_in_heap_executed_after_bi_abduction_ok_no_retain_cycle(),start of procedure assign_block_to_ivar,start of procedure setHandler:,return from a call to BlockInHeap.setHandler:,return from a call to BlockInHeap.assign_block_to_ivar,start of procedure handler,return from a call to BlockInHeap.handler,start of procedure block,return from a call to objc_blockBlockInHeap.assign_block_to_ivar_1,return from a call to block_in_heap_executed_after_bi_abduction_ok_no_retain_cycle,Taking true branch]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/field_superclass/SubtypingExample.m, Employee.initWithName:andAge:andEducation:, 6, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure initWithName:andAge:andEducation:,start of procedure initWithName:andAge:,return from a call to Person.initWithName:andAge:,Taking true branch]
codetoanalyze/objc/biabduction/field_superclass/SubtypingExample.m, subtyping_test, 0, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure subtyping_test(),start of procedure testFields(),start of procedure setEmployeeEducation:,return from a call to Employee.setEmployeeEducation:,start of procedure setAge:,return from a call to Person.setAge:,start of procedure setEmployeeEducation:,return from a call to Employee.setEmployeeEducation:,start of procedure getAge,return from a call to Person.getAge,return from a call to testFields]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/biabduction/initialization/struct_initlistexpr.c, field_set_correctly, 2, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure field_set_correctly()]
codetoanalyze/objc/biabduction/initialization/struct_initlistexpr.c, implicit_expr_set_correctly, 3, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure implicit_expr_set_correctly()]
codetoanalyze/objc/biabduction/initialization/struct_initlistexpr.c, point_coords_set_correctly, 2, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure point_coords_set_correctly()]
[closures preanalysis] [3/n] Adding models to dispatch functions and remove code for previous specialization and dispatch models Summary: This diff finishes the migration from the specialization of methods that take blocks as arguments. Here we delete all the old code and change the way we model dispatch functions so that the tests pass. - Remove the code for specializing the methods in biabduction. - Remove the call flags `cf_with_block_parameters` that was only used in this algorithm. - Removes models for dispatch functions. - Adds models for dispatch functions as program transformation only in biabduction. To be added in other checkers in the future. Reviewed By: ngorogiannis Differential Revision: D23345342 fbshipit-source-id: b5e8542ce
4 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlockAsParameter.m, FBSomeDataManager.fetchNewData, 2, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure fetchNewData,start of procedure initWithCompletionBlock:,return from a call to Fetcher.initWithCompletionBlock:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlockAsParameter.m, FBSomeDataManager.fetchNewData, 2, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure fetchNewData,start of procedure initWithCompletionBlock:,return from a call to Fetcher.initWithCompletionBlock:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlocks.m, RCBlock.retain_self_in_block, 1, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure retain_self_in_block,start of procedure setHandler:,return from a call to RCBlock.setHandler:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlocks.m, RCBlock.retain_self_in_block, 1, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure retain_self_in_block,start of procedure setHandler:,return from a call to RCBlock.setHandler:]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlocks.m, objc_blockretain_a_in_block_cycle_3, 1, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure block,start of procedure setChild:,return from a call to RCBlockAA.setChild:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlocks.m, objc_blockretain_a_in_block_cycle_3, 1, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure block,start of procedure setChild:,return from a call to RCBlockAA.setChild:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlocks.m, retain_a_in_block_cycle, 4, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure retain_a_in_block_cycle(),start of procedure setB:,return from a call to RCBlockAA.setB:,start of procedure setA:,return from a call to RCBlock.setA:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleBlocks.m, retain_a_in_block_cycle, 4, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure retain_a_in_block_cycle(),start of procedure setB:,return from a call to RCBlockAA.setB:,start of procedure setA:,return from a call to RCBlock.setA:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleDeduplication.m, CViewController.setCaptureInteractionController:, 4, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure setCaptureInteractionController:,Taking true branch,start of procedure setDelegate:,return from a call to CaptureController.setDelegate:,start of procedure setDelegate:,return from a call to CaptureController.setDelegate:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleDeduplication.m, CViewController.setCaptureInteractionController:, 4, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure setCaptureInteractionController:,Taking true branch,start of procedure setDelegate:,return from a call to CaptureController.setDelegate:,start of procedure setDelegate:,return from a call to CaptureController.setDelegate:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCyclePropertyInProtocol.m, Delegate.delegate, 0, Bad_footprint, no_bucket, ERROR, [start of procedure delegate]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCyclePropertyInProtocol.m, Delegate.setDelegate:, 0, Bad_footprint, no_bucket, ERROR, [start of procedure setDelegate:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCyclePropertyInProtocol.m, Delegate.setStrong_delegate:, 0, Bad_footprint, no_bucket, ERROR, [start of procedure setStrong_delegate:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCyclePropertyInProtocol.m, Delegate.strong_delegate, 0, Bad_footprint, no_bucket, ERROR, [start of procedure strong_delegate]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/retain_cycle.m, strongcycle, 6, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure strongcycle(),start of procedure setB:,return from a call to AA.setB:,start of procedure setA:,return from a call to BBStrong.setA:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/retain_cycle.m, strongcycle, 6, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure strongcycle(),start of procedure setB:,return from a call to AA.setB:,start of procedure setA:,return from a call to BBStrong.setA:]
record objc tests Summary: Some recent severity changes broke them. Reviewed By: ngorogiannis Differential Revision: D21931247 fbshipit-source-id: 6b681b32d
5 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/retain_cycle2.m, strongcycle2, 4, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure strongcycle2(),start of procedure init,return from a call to Parent.init,start of procedure init,return from a call to Child.init,start of procedure setChild:,return from a call to Parent.setChild:,start of procedure setParent:,return from a call to Child.setParent:]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/retain_cycle2.m, strongcycle2, 4, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure strongcycle2(),start of procedure init,return from a call to Parent.init,start of procedure init,return from a call to Child.init,start of procedure setChild:,return from a call to Parent.setChild:,start of procedure setParent:,return from a call to Child.setParent:]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/biabduction/npe/UpdateDict.m, add_nil_in_dict, 10, NULL_DEREFERENCE, B1, ERROR, [start of procedure add_nil_in_dict(),Skipping dictionaryWithObjectsAndKeys:: method has no implementation]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, add_nil_to_array, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure add_nil_to_array()]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, insert_nil_in_array, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure insert_nil_in_array()]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, nullable_NSDictionary_objectForKey, 4, NULL_DEREFERENCE, B5, ERROR, [start of procedure nullable_NSDictionary_objectForKey(),Taking true branch,Taking true branch]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, nullable_NSDictionary_objectForKeyedSubscript, 5, NULL_DEREFERENCE, B5, ERROR, [start of procedure nullable_NSDictionary_objectForKeyedSubscript(),Taking true branch,Taking true branch]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, nullable_NSMapTable_objectForKey, 4, NULL_DEREFERENCE, B5, ERROR, [start of procedure nullable_NSMapTable_objectForKey(),Taking true branch,Taking true branch]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, update_array_with_null, 5, NULL_DEREFERENCE, B1, ERROR, [start of procedure update_array_with_null()]
codetoanalyze/objc/biabduction/npe/UpdateDict.m, update_dict_with_key_null, 10, NULL_DEREFERENCE, B1, ERROR, [start of procedure update_dict_with_key_null(),Skipping dictionaryWithObjectsAndKeys:: method has no implementation]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/npe/nil_in_array_literal.m, Arr.nilInArrayWithObject, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInArrayWithObject]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralKey0, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralKey0]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralKey1, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralKey1]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralKey2, 5, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralKey2]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralKey3, 5, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralKey3]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralValue0, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralValue0]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralValue1, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralValue1]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralValue2, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralValue2]
codetoanalyze/objc/biabduction/npe/nil_in_dictionary_literal.m, ADict.nilInDictionaryLiteralValue3, 4, NULL_DEREFERENCE, B1, ERROR, [start of procedure nilInDictionaryLiteralValue3]
codetoanalyze/objc/biabduction/npe/npe_conditional.m, conditionalNPE, 3, NULL_DEREFERENCE, B2, ERROR, [start of procedure conditionalNPE(),start of procedure name,return from a call to ConditionalA.name,Condition is true]
codetoanalyze/objc/biabduction/npe/npe_self.m, CSelf.init, 2, NULL_DEREFERENCE, B2, ERROR, [start of procedure init]
codetoanalyze/objc/biabduction/npe/npe_self.m, CSelf.test, 3, NULL_DEREFERENCE, B5, ERROR, [start of procedure test,Taking false branch]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/biabduction/npe/nullable.m, derefNullableParamDirect, 0, NULL_DEREFERENCE, B1, ERROR, [start of procedure derefNullableParamDirect()]
codetoanalyze/objc/biabduction/npe/nullable.m, derefNullableParamIndirect, 2, NULL_DEREFERENCE, B1, ERROR, [start of procedure derefNullableParamIndirect()]
codetoanalyze/objc/biabduction/npe/nullable.m, parameter_nullable_bug, 5, NULL_DEREFERENCE, B1, ERROR, [start of procedure parameter_nullable_bug()]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/property/ExplicitIvarName.m, ExplicitIvarNameA.testDefaultName, 7, NULL_DEREFERENCE, B1, ERROR, [start of procedure testDefaultName,Skipping setY:: method has no implementation,Taking true branch]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
codetoanalyze/objc/biabduction/property/ExplicitIvarName.m, ExplicitIvarNameA.testExplicit, 6, NULL_DEREFERENCE, B1, ERROR, [start of procedure testExplicit,start of procedure x,return from a call to ExplicitIvarNameA.x,Taking true branch]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivideByZero1, 2, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure shouldThrowDivideByZero1(),start of procedure init,return from a call to Base.init,start of procedure returnsZero1:,Taking true branch,return from a call to Base.returnsZero1:]
codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivideByZero2, 2, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure shouldThrowDivideByZero2(),start of procedure init,return from a call to Base.init,start of procedure returnsZero2(),Taking false branch,return from a call to returnsZero2]
codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivideByZero3, 3, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure shouldThrowDivideByZero3(),start of procedure init,return from a call to Derived.init,Taking true branch]
record objc tests Summary: Some recent severity changes broke them. Reviewed By: ngorogiannis Differential Revision: D21931247 fbshipit-source-id: 6b681b32d
5 years ago
codetoanalyze/objc/biabduction/variadic_methods/premature_nil_termination.m, PrematureNilTermA.nilInArrayWithObjects, 5, PREMATURE_NIL_TERMINATION_ARGUMENT, B1, WARNING, [start of procedure nilInArrayWithObjects]
[pulse] Enable pulse memory leaks and disable biabduction one Summary: The new memory leaks analysis is now ready to be enabled by default and turned on in production. This also replaces the biabduction one which is now disabled. Reviewed By: jvillard Differential Revision: D21998666 fbshipit-source-id: 9cd95e894
5 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/NSData_models_tests.m, NSData_models_tests.macForIV:, 2, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure macForIV:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/NSString_models_tests.m, StringInitA.hexStringValue, 11, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure hexStringValue,Skipping CFStringCreateWithBytesNoCopy(): method has no implementation,Taking false branch]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleLength3.m, strongcycle, 6, BIABDUCTION_ANALYSIS_STOPS, no_bucket, WARNING, [start of procedure strongcycle(),start of procedure setB:,return from a call to AA.setB:,start of procedure setC:,return from a call to BB.setC:,start of procedure setA:,return from a call to CC.setA:]
codetoanalyze/objc/biabduction/memory_leaks_benchmark/RetainCycleLength3.m, strongcycle, 6, RETAIN_CYCLE, no_bucket, ERROR, [start of procedure strongcycle(),start of procedure setB:,return from a call to AA.setB:,start of procedure setC:,return from a call to BB.setC:,start of procedure setA:,return from a call to CC.setA:]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/npe/Fraction.m, test_virtual_call, 7, NULL_DEREFERENCE, B1, ERROR, [start of procedure test_virtual_call(),start of procedure setNumerator:,return from a call to Fraction.setNumerator:,start of procedure getNumerator,return from a call to Fraction.getNumerator,Taking true branch]
codetoanalyze/objc/biabduction/npe/Npe_with_equal_names.m, EqualNamesTest, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure EqualNamesTest(),start of procedure meth,return from a call to EqualNamesA.meth]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, initWithFormatBad, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure initWithFormatBad()]
codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, stringByAppendingStringBad, 2, NULL_DEREFERENCE, B1, ERROR, [start of procedure stringByAppendingStringBad()]
codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, stringWithStringBad, 2, NULL_DEREFERENCE, B1, ERROR, [start of procedure stringWithStringBad(),start of procedure nullableMethod(),return from a call to nullableMethod]
codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, stringWithUTF8StringBad, 1, NULL_DEREFERENCE, B5, ERROR, [start of procedure stringWithUTF8StringBad(),start of procedure nullableMethod(),return from a call to nullableMethod]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/npe/block.m, BlockA.doSomethingThenCallback:, 2, PARAMETER_NOT_NULL_CHECKED, B1, WARNING, [start of procedure doSomethingThenCallback:]
codetoanalyze/objc/biabduction/npe/block.m, BlockA.foo, 5, NULL_DEREFERENCE, B1, ERROR, [start of procedure foo]
codetoanalyze/objc/biabduction/npe/block.m, BlockA.foo3:, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure foo3:]
codetoanalyze/objc/biabduction/npe/block.m, BlockA.foo4:, 6, NULL_DEREFERENCE, B1, ERROR, [start of procedure foo4:]
codetoanalyze/objc/biabduction/npe/block.m, BlockA.foo7, 2, IVAR_NOT_NULL_CHECKED, B1, WARNING, [start of procedure foo7]
codetoanalyze/objc/biabduction/npe/dynamic_dispatch.m, DynamicDispatchMain.npe_bad, 2, NULL_DEREFERENCE, B5, ERROR, [start of procedure npe_bad,start of procedure get_ddclass_from:,start of procedure get_ddclass,return from a call to PInstance.get_ddclass,return from a call to DynamicDispatchMain.get_ddclass_from:]
codetoanalyze/objc/biabduction/npe/dynamic_dispatch.m, objc_blockDynamicDispatchMain.dispatch_async_block_npe_bad_1, 3, NULL_DEREFERENCE, B5, ERROR, [start of procedure block,start of procedure get_ddclass_from:,start of procedure get_ddclass,return from a call to PInstance.get_ddclass,return from a call to DynamicDispatchMain.get_ddclass_from:]
codetoanalyze/objc/biabduction/npe/ivar_blocks.m, MyClass.ivar_npe, 1, IVAR_NOT_NULL_CHECKED, B1, WARNING, [start of procedure ivar_npe]
Revert "[sqlite] enforce attribute.is_defined iff procdesc is not NULL" Summary: This reverts commit 983216cb697840fce59af80ffc143353b8e1473d. Reviewed By: jvillard Differential Revision: D23706950 fbshipit-source-id: 9b1cf9e64
4 years ago
codetoanalyze/objc/biabduction/npe/skip_method_with_nil_object.m, SkipMethodNilA.testBug:, 6, PARAMETER_NOT_NULL_CHECKED, B2, WARNING, [start of procedure testBug:,Message get_a with receiver nil returns nil.,Message skip_method with receiver nil returns nil.,Taking false branch]
[pulse] Enable pulse memory leaks and disable biabduction one Summary: The new memory leaks analysis is now ready to be enabled by default and turned on in production. This also replaces the biabduction one which is now disabled. Reviewed By: jvillard Differential Revision: D21998666 fbshipit-source-id: 9cd95e894
5 years ago
codetoanalyze/objc/biabduction/property/main.c, property_main, 3, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure property_main(),Skipping aProperty: method has no implementation]
[closures preanalysis] [3/n] Adding models to dispatch functions and remove code for previous specialization and dispatch models Summary: This diff finishes the migration from the specialization of methods that take blocks as arguments. Here we delete all the old code and change the way we model dispatch functions so that the tests pass. - Remove the code for specializing the methods in biabduction. - Remove the call flags `cf_with_block_parameters` that was only used in this algorithm. - Removes models for dispatch functions. - Adds models for dispatch functions as program transformation only in biabduction. To be added in other checkers in the future. Reviewed By: ngorogiannis Differential Revision: D23345342 fbshipit-source-id: b5e8542ce
4 years ago
codetoanalyze/objc/biabduction/resource_leaks/Dispatch_sources.m, ProcessContentsOfFile, 35, RESOURCE_LEAK, no_bucket, ERROR, [start of procedure ProcessContentsOfFile(),Taking false branch,Skipping dispatch_get_global_queue(): method has no implementation,Skipping dispatch_source_create(): method has no implementation,Taking false branch]
[pulse] Enable pulse memory leaks and disable biabduction one Summary: The new memory leaks analysis is now ready to be enabled by default and turned on in production. This also replaces the biabduction one which is now disabled. Reviewed By: jvillard Differential Revision: D21998666 fbshipit-source-id: 9cd95e894
5 years ago
codetoanalyze/objc/biabduction/resource_leaks/Dispatch_sources.m, objc_blockProcessContentsOfFile_2, 6, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure block,Skipping dispatch_source_get_data(): method has no implementation,Taking true branch,Skipping MyProcessFileData(): method has no implementation]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/biabduction/resource_leaks/ResourceLeakExample.m, NSFileHandle.fileHandleForLoggingAtPath:mode:, 9, RESOURCE_LEAK, no_bucket, ERROR, [start of procedure fileHandleForLoggingAtPath:mode:,Taking true branch,Skipping fileSystemRepresentation: method has no implementation,Taking false branch,Taking true branch,Skipping autorelease: no implementation found for method declared in Objective-C protocol]
[clang] Adding implicit implementation of dealloc methods to ObjC classes Summary: This models ARC implementation of dealloc, see https://clang.llvm.org/docs/AutomaticReferenceCounting.html#dealloc. Dealloc methods can be added to ObjC classes to free C memory for example, but the deallocation of the ObjC instance variables of the object is done automatically. So here we add this explicitly to Infer: 1. First, we add an empty dealloc method when it is not written explicitly. 2. For each dealloc method (including the implicitly added ones) we add calls to dealloc of the ObjC instance variables. Reviewed By: jvillard Differential Revision: D21883546 fbshipit-source-id: f5d4930f2
5 years ago
codetoanalyze/objc/shared/annotations/nonnull_annotations.m, NonnullAnnot.test1:, 2, PARAMETER_NOT_NULL_CHECKED, B2, WARNING, [start of procedure test1:,Message child with receiver nil returns nil.]
codetoanalyze/objc/shared/annotations/nonnull_annotations.m, NonnullAnnot.test3:, 1, PARAMETER_NOT_NULL_CHECKED, B1, WARNING, [start of procedure test3:]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/shared/annotations/nullable_annotations.m, User.otherUserName, 2, NULL_DEREFERENCE, B2, ERROR, [start of procedure otherUserName,Skipping otherUser: method has no implementation]
[biabd] rename test directories from {biabduction,errors,infer} to {biabduction} Summary: The directory names had some interesting variety due to historical reasons. - {c,cpp,objc,objcpp}/errors/ date from the time when infer was only biabduction - java/infer/ dates from the time when we had an "--analyzer" option and "infer" was one of them (sic), and eg another was "eradicate". - c/biabduction/ dates from the time when the biabduction analysis was being migrated to the "checkers" (AI) framework. For some reasons the tests there are not a subset of c/infer/ but seem to be entirely new tests. The convention now dictates that we should name all of these */biabduction/. This diff moves the existing tests from c/biabduction/ into c/biabduction/misc/. Reviewed By: mityal Differential Revision: D21300147 fbshipit-source-id: 516d1cb15
5 years ago
codetoanalyze/objc/shared/annotations/nullable_annotations.m, npe_property_nullable, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure npe_property_nullable(),Skipping child: method has no implementation]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/shared/annotations/nullable_annotations_fields.m, A.nullable_field, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure nullable_field,Skipping getA(): method has no implementation]
[closure] Substitute closure parameter when given via variable Summary: This diff substitutes closure parameter when it is given via variable. For example, ``` x = ^{ ... } foo(x) ``` this diff substitutes the closure variable `x`, ``` x = ^{ ... } foo(^{ ... }) ``` so that the specialization of `foo` can be done by `CCallSpecializaedWithClosures.process`. Reviewed By: jvillard Differential Revision: D23814595 fbshipit-source-id: a89f1530f
4 years ago
codetoanalyze/objc/shared/block/dispatch.m, DispatchA.dispatch_a_block_variable_from_macro_delivers_initialised_object, 3, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure dispatch_a_block_variable_from_macro_delivers_initialised_object,start of procedure dispatch_a_block_variable_from_macro,start of procedure block,start of procedure init,return from a call to DispatchA.init,return from a call to objc_blockDispatchA.dispatch_a_block_variable_from_macro_5,return from a call to DispatchA.dispatch_a_block_variable_from_macro]
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
codetoanalyze/objc/shared/npe/Available_expr.m, Available_expr.test_no_bug, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure test_no_bug,Taking true branch]