pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '2d49f4b7ad'
${ noResults }
infer_clone/infer/tests/cost.make

31 lines
911 B
Raw Normal View History Unescape

[cost] Add ability to test costs-report.json Summary: In order to test cost analysis results, currently we rely on having an arbitrary cost threshold (200) and report issues that exceed this cost. For instance, a cost of 201 is considered expensive and reported as `EXPENSIVE_EXECUTION_TIME` issue in cost tests. This means, if we change the cost analysis in a slight way that results in some constant cost increase under 200, we wouldn't able to detect it. I find this unsatisfactory and somewhat hacky. This diff adds the ability to write the result of `costs-report.json` into a separate `cost-issues.exp` and then compare the actual costs (not only than relying on this arbitrary threshold reporting mechanism). Reviewed By: skcho Differential Revision: D21816312 fbshipit-source-id: 93b531928
5 years ago
# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
[cost] Revise cost.make not to run infer parallel Summary: This diff avoids `infer report`s run parallel. If they do, there may be race for writing `infer-out/.infer_runstate.json`, which result in `make test` failure in the next time. Reviewed By: jvillard Differential Revision: D21999073 fbshipit-source-id: 64df79cb6
5 years ago
# We add issues.exp.test to recipe in order to avoid "infer report"s run parallel
cost-issues.exp.test$(TEST_SUFFIX): $(INFER_OUT)/report.json $(INFER_BIN) issues.exp.test$(TEST_SUFFIX)
[cost] Add ability to test costs-report.json Summary: In order to test cost analysis results, currently we rely on having an arbitrary cost threshold (200) and report issues that exceed this cost. For instance, a cost of 201 is considered expensive and reported as `EXPENSIVE_EXECUTION_TIME` issue in cost tests. This means, if we change the cost analysis in a slight way that results in some constant cost increase under 200, we wouldn't able to detect it. I find this unsatisfactory and somewhat hacky. This diff adds the ability to write the result of `costs-report.json` into a separate `cost-issues.exp` and then compare the actual costs (not only than relying on this arbitrary threshold reporting mechanism). Reviewed By: skcho Differential Revision: D21816312 fbshipit-source-id: 93b531928
5 years ago
$(QUIET)$(INFER_BIN) report -q --results-dir $(<D) \
$(INFERPRINT_COST_OPTIONS) $@
test: cost-test
[cost] Add .PHONY in cost.make Reviewed By: jberdine Differential Revision: D22002143 fbshipit-source-id: dd036d5d4
5 years ago
.PHONY: cost-test
[cost] Add ability to test costs-report.json Summary: In order to test cost analysis results, currently we rely on having an arbitrary cost threshold (200) and report issues that exceed this cost. For instance, a cost of 201 is considered expensive and reported as `EXPENSIVE_EXECUTION_TIME` issue in cost tests. This means, if we change the cost analysis in a slight way that results in some constant cost increase under 200, we wouldn't able to detect it. I find this unsatisfactory and somewhat hacky. This diff adds the ability to write the result of `costs-report.json` into a separate `cost-issues.exp` and then compare the actual costs (not only than relying on this arbitrary threshold reporting mechanism). Reviewed By: skcho Differential Revision: D21816312 fbshipit-source-id: 93b531928
5 years ago
cost-test: cost-issues.exp.test$(TEST_SUFFIX)
$(QUIET)cd $(TESTS_DIR) && \
$(call check_no_diff,$(TEST_REL_DIR)/cost-issues.exp,$(TEST_REL_DIR)/cost-issues.exp.test$(TEST_SUFFIX))
replace: cost-replace
[cost] Add .PHONY in cost.make Reviewed By: jberdine Differential Revision: D22002143 fbshipit-source-id: dd036d5d4
5 years ago
.PHONY: cost-replace
[cost] Add ability to test costs-report.json Summary: In order to test cost analysis results, currently we rely on having an arbitrary cost threshold (200) and report issues that exceed this cost. For instance, a cost of 201 is considered expensive and reported as `EXPENSIVE_EXECUTION_TIME` issue in cost tests. This means, if we change the cost analysis in a slight way that results in some constant cost increase under 200, we wouldn't able to detect it. I find this unsatisfactory and somewhat hacky. This diff adds the ability to write the result of `costs-report.json` into a separate `cost-issues.exp` and then compare the actual costs (not only than relying on this arbitrary threshold reporting mechanism). Reviewed By: skcho Differential Revision: D21816312 fbshipit-source-id: 93b531928
5 years ago
cost-replace: cost-issues.exp.test$(TEST_SUFFIX)
cp $< cost-issues.exp$(TEST_RESULT_SUFFIX)
clean: cost-clean
[cost] Add .PHONY in cost.make Reviewed By: jberdine Differential Revision: D22002143 fbshipit-source-id: dd036d5d4
5 years ago
.PHONY: cost-clean
[cost] Add ability to test costs-report.json Summary: In order to test cost analysis results, currently we rely on having an arbitrary cost threshold (200) and report issues that exceed this cost. For instance, a cost of 201 is considered expensive and reported as `EXPENSIVE_EXECUTION_TIME` issue in cost tests. This means, if we change the cost analysis in a slight way that results in some constant cost increase under 200, we wouldn't able to detect it. I find this unsatisfactory and somewhat hacky. This diff adds the ability to write the result of `costs-report.json` into a separate `cost-issues.exp` and then compare the actual costs (not only than relying on this arbitrary threshold reporting mechanism). Reviewed By: skcho Differential Revision: D21816312 fbshipit-source-id: 93b531928
5 years ago
cost-clean:
[cost] Add ability to test costs-report.json (part 2) Summary: D21816312 forgot to add the new cost testing mechanism to `fb-performance` and `performance-exlusive` directories. This diff fixes that. Reviewed By: skcho Differential Revision: D21837912 fbshipit-source-id: 407dafcd3
5 years ago
$(REMOVE) cost-issues.exp.test$(TEST_SUFFIX)