|
|
|
|
(*
|
|
|
|
|
* Copyright (c) 2013 - present Facebook, Inc.
|
|
|
|
|
* All rights reserved.
|
|
|
|
|
*
|
|
|
|
|
* This source code is licensed under the BSD style license found in the
|
|
|
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
|
*)
|
|
|
|
|
|
|
|
|
|
(** Define the signature of a method consisting of its name, its arguments, *)
|
|
|
|
|
(** return type, location and whether its an instance method. *)
|
|
|
|
|
|
|
|
|
|
type method_signature = {
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
mutable _name : Procname.t;
|
|
|
|
|
_args : (string * Clang_ast_t.type_ptr) list;
|
|
|
|
|
_ret_type : Clang_ast_t.type_ptr;
|
|
|
|
|
_attributes : Clang_ast_t.attribute list;
|
|
|
|
|
_loc : Clang_ast_t.source_range;
|
|
|
|
|
_is_instance : bool;
|
|
|
|
|
_is_generated : bool;
|
|
|
|
|
_language : CFrontend_config.lang;
|
|
|
|
|
_pointer_to_parent : Clang_ast_t.pointer option;
|
|
|
|
|
mutable _objc_accessor : ProcAttributes.objc_accessor_type option;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
let ms_get_name ms =
|
|
|
|
|
ms._name
|
|
|
|
|
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let ms_set_name ms name =
|
|
|
|
|
ms._name <- name
|
|
|
|
|
|
|
|
|
|
let ms_get_args ms =
|
|
|
|
|
ms._args
|
|
|
|
|
|
|
|
|
|
let ms_get_ret_type ms =
|
|
|
|
|
ms._ret_type
|
|
|
|
|
|
|
|
|
|
let ms_get_attributes ms =
|
|
|
|
|
ms._attributes
|
|
|
|
|
|
|
|
|
|
let ms_get_loc ms =
|
|
|
|
|
ms._loc
|
|
|
|
|
|
|
|
|
|
let ms_is_instance ms =
|
|
|
|
|
ms._is_instance
|
|
|
|
|
|
|
|
|
|
let ms_is_generated ms =
|
|
|
|
|
ms._is_generated
|
|
|
|
|
|
|
|
|
|
let ms_get_lang ms =
|
|
|
|
|
ms._language
|
|
|
|
|
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let ms_get_pointer_to_parent ms =
|
|
|
|
|
ms._pointer_to_parent
|
|
|
|
|
|
|
|
|
|
let ms_objc_accessor ms =
|
|
|
|
|
ms._objc_accessor
|
|
|
|
|
|
|
|
|
|
let ms_set_objc_accessor ms objc_accessor =
|
|
|
|
|
ms._objc_accessor <- objc_accessor
|
|
|
|
|
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let make_ms procname args ret_type attributes loc is_instance is_generated lang pointer_to_parent =
|
|
|
|
|
let meth_signature = {
|
|
|
|
|
_name = procname;
|
|
|
|
|
_args = args;
|
|
|
|
|
_ret_type = ret_type;
|
|
|
|
|
_attributes = attributes;
|
|
|
|
|
_loc = loc;
|
|
|
|
|
_is_instance = is_instance;
|
|
|
|
|
_is_generated = is_generated;
|
|
|
|
|
_language = lang;
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
_pointer_to_parent = pointer_to_parent;
|
|
|
|
|
_objc_accessor = None
|
|
|
|
|
} in
|
|
|
|
|
meth_signature
|
|
|
|
|
|
|
|
|
|
let replace_name_ms ms name =
|
|
|
|
|
{ ms with _name = name }
|
|
|
|
|
|
|
|
|
|
let ms_to_string ms =
|
|
|
|
|
let gen = if ms._is_generated then " (generated)" else "" in
|
[clang] [2 of 3] Dealing with custom ast expressions and flow of types in the frontend.
Summary:
This is the second of 3 stack diffs to deal with replacing the parser of types.
This diff is about general changes to the frontend to make it cope with the change. There
are two main challenges:
1. We create pieces of ast in ast_expressions, such as getters and setters. For that we create
custom types.
2. We store types in cMethod_signature for parameters and return type of functions. This was
stored as strings, but that means losing the pointer information which is vital to get the
sil types.
So this diff consists mostly of dealing with these challenges. It change the signature of
cMethod_signature and update modules accordingly.
To deal with the custom types, we build methods in ast_expressions for creating those types,
with a custom type pointer, like "internal_typeint". At the beginning of the translation we save
all these custom types in the map from type pointers to sil types that we build as we compute the
types, so that they are available later.
Another custom type that we build is a type of classes or pointer of classes based on the current
class. I found a simple way to deal with it, giving it a pointer "class_name", and then we know
how to translate those. Something I tried is to save the declaration of the current class and pass
that declaration around, but somehow that lead to pref regression, so I removed it in favor of this
more lightweight version.
9 years ago
|
|
|
"Method " ^ (Procname.to_string ms._name) ^ gen ^ " " ^
|
|
|
|
|
IList.to_string
|
|
|
|
|
(fun (s1, s2) -> s1 ^ ", " ^ (Clang_ast_j.string_of_type_ptr s2))
|
[clang] [2 of 3] Dealing with custom ast expressions and flow of types in the frontend.
Summary:
This is the second of 3 stack diffs to deal with replacing the parser of types.
This diff is about general changes to the frontend to make it cope with the change. There
are two main challenges:
1. We create pieces of ast in ast_expressions, such as getters and setters. For that we create
custom types.
2. We store types in cMethod_signature for parameters and return type of functions. This was
stored as strings, but that means losing the pointer information which is vital to get the
sil types.
So this diff consists mostly of dealing with these challenges. It change the signature of
cMethod_signature and update modules accordingly.
To deal with the custom types, we build methods in ast_expressions for creating those types,
with a custom type pointer, like "internal_typeint". At the beginning of the translation we save
all these custom types in the map from type pointers to sil types that we build as we compute the
types, so that they are available later.
Another custom type that we build is a type of classes or pointer of classes based on the current
class. I found a simple way to deal with it, giving it a pointer "class_name", and then we know
how to translate those. Something I tried is to save the declaration of the current class and pass
that declaration around, but somehow that lead to pref regression, so I removed it in favor of this
more lightweight version.
9 years ago
|
|
|
ms._args
|
|
|
|
|
^ "->" ^ (Clang_ast_j.string_of_type_ptr ms._ret_type) ^ " " ^
|
|
|
|
|
Clang_ast_j.string_of_source_range ms._loc
|
