pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '3d588b2751'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/shared/block/dispatch.m.dot

289 lines
25 KiB
Raw Normal View History Unescape

Add @generated comment to icfg.dot files Reviewed By: jvillard Differential Revision: D3358243 fbshipit-source-id: a47cc01
9 years ago
/* @generated */
[cfg] rename iCFG to cfg in dotty files Summary: Not sure what an "iCFG" is but the dotty is only about CFGs anyway. Diff obtained by mass-`sed`. Reviewed By: sblackshear Differential Revision: D6324280 fbshipit-source-id: b7603bb
7 years ago
digraph cfg {
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_1" [label="1: Start DispatchMain\nFormals: \nLocals: p:int* b:DispatchA* \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_1" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_12" ;
[SIL] change `variable_initialization()` builtin to a new auxiliary instruction Summary: Instead of emitting an ad-hoc builtin on variable declaration emit a new metadata instruction. This allows us to remove the code matching on that ad-hoc builtin that had to be inserted in several checkers. Inferbo & pulse used that information meaningfully and had to undergo some minor changes to cope with the new metada instruction. Reviewed By: ezgicicek Differential Revision: D14833100 fbshipit-source-id: 9b3009d22
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" [label="2: Exit DispatchMain \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_3" [label="3: + \n " ]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_3" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" [label="4: between_join_and_exit \n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" [label="5: BinaryOperatorStmt: EQ \n n$0=*&b:DispatchA* [line 85, column 7]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" [label="6: Prune (true branch, if) \n PRUNE((n$0 == null), true); [line 85, column 7]\n " shape="invhouse"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" [label="7: Prune (false branch, if) \n PRUNE(!(n$0 == null), false); [line 85, column 7]\n " shape="invhouse"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" [label="8: Return Stmt \n n$1=*&p:int* [line 86, column 13]\n n$2=*n$1:int [line 86, column 12]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" [label="9: Return Stmt \n *&return:int=n$2 [line 86, column 5]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" [label="10: Return Stmt \n *&return:int=0 [line 88, column 5]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" [label="11: DeclStmt \n VARIABLE_DECLARED(p:int*); [line 84, column 3]\n *&p:int*=null [line 84, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_12" [label="12: DeclStmt \n VARIABLE_DECLARED(b:DispatchA*); [line 83, column 3]\n n$4=_fun_DispatchA.sharedInstance() [line 83, column 18]\n *&b:DispatchA*=n$4 [line 83, column 3]\n " shape="box"]
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_12" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" ;
Update type of procdesc and closure expression to contain information about capture variable mode Summary: We update the type of captured variables to include information about capture mode (`ByReference` or `ByValue`) both for procdesc attributes and the closure expression. For lambda: closure expression now contains correct capture mode for capture variables. Procdesc still does not contain information about captured variables which we will address in the next diff. For objc blocks: at the moment all captured variables have mode `ByReference`. Added TODOs to fix this. Reviewed By: jvillard Differential Revision: D22572054 fbshipit-source-id: 4c88678ee
4 years ago
"objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_1" [label="1: Start objc_blockDispatchA.block_attribute_2\nFormals: a:DispatchA*\nLocals: \nCaptured: [by ref]a:DispatchA* \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_1" -> "objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_3" ;
"objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_2" [label="2: Exit objc_blockDispatchA.block_attribute_2 \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_3" [label="3: BinaryOperatorStmt: Assign \n n$8=*&a:DispatchA* [line 38, column 5]\n *n$8._x:int=10 [line 38, column 5]\n " shape="box"]
initial synchronization
10 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_3" -> "objc_blockDispatchA.block_attribute_2(class DispatchA).fbb5956dc6c8f95a8f2ae751ac2b44a1_2" ;
"objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_1" [label="1: Start objc_blockDispatchA.dispatch_a_block_variable_4\nFormals: \nLocals: \n " color=yellow style=filled]
initial synchronization
10 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_1" -> "objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_3" ;
"objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_2" [label="2: Exit objc_blockDispatchA.dispatch_a_block_variable_4 \n " color=yellow style=filled]
initial synchronization
10 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_3" [label="3: BinaryOperatorStmt: Assign \n n$20=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 55, column 25]\n n$21=_fun_NSObject.init(n$20:DispatchA*) virtual [line 55, column 25]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.dispatch_a_block_variable.static_storage__:DispatchA*=n$21 [line 55, column 5]\n " shape="box"]
Adding endtoend test that shows that dispatch once works well Reviewed By: ddino Differential Revision: D2570191 fb-gh-sync-id: 01be61c
9 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_3" -> "objc_blockDispatchA.dispatch_a_block_variable_4.85a73921543aa13f4bc6d889cc185a8d_2" ;
"objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_1" [label="1: Start objc_blockDispatchA.dispatch_a_block_variable_from_macro_5\nFormals: \nLocals: \n " color=yellow style=filled]
Adding endtoend test that shows that dispatch once works well Reviewed By: ddino Differential Revision: D2570191 fb-gh-sync-id: 01be61c
9 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_1" -> "objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_3" ;
"objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_2" [label="2: Exit objc_blockDispatchA.dispatch_a_block_variable_from_macro_5 \n " color=yellow style=filled]
initial synchronization
10 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_3" [label="3: BinaryOperatorStmt: Assign \n n$25=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 66, column 27]\n n$26=_fun_NSObject.init(n$25:DispatchA*) virtual [line 66, column 27]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.dispatch_a_block_variable_from_macro.static_storage__:DispatchA*=n$26 [line 66, column 7]\n " shape="box"]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_3" -> "objc_blockDispatchA.dispatch_a_block_variable_from_macro_5.8b47e325760aa028beb8a7010bc38e1c_2" ;
"objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_1" [label="1: Start objc_blockDispatchA.sharedInstance_1\nFormals: \nLocals: \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_1" -> "objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_3" ;
"objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_2" [label="2: Exit objc_blockDispatchA.sharedInstance_1 \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_3" [label="3: BinaryOperatorStmt: Assign \n n$2=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 29, column 23]\n n$3=_fun_DispatchA.init(n$2:DispatchA*) virtual [line 29, column 22]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.sharedInstance.sharedInstance:objc_object*=n$3 [line 29, column 5]\n " shape="box"]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_3" -> "objc_blockDispatchA.sharedInstance_1.1c7ccafb7c17643dbbe0027bd1749ee3_2" ;
"objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_1" [label="1: Start objc_blockDispatchA.trans_3\nFormals: \nLocals: \n " color=yellow style=filled]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_1" -> "objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_3" ;
"objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_2" [label="2: Exit objc_blockDispatchA.trans_3 \n " color=yellow style=filled]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_3" [label="3: BinaryOperatorStmt: Assign \n n$15=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 46, column 23]\n n$16=_fun_DispatchA.init(n$15:DispatchA*) virtual [line 46, column 22]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.trans.sharedInstance:objc_object*=n$16 [line 46, column 5]\n " shape="box"]
initial synchronization
10 years ago
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_3" -> "objc_blockDispatchA.trans_3.2993ae0bfb5e0ec6d91c5c53d1084592_2" ;
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_1" [label="1: Start DispatchA.block_attribute\nFormals: \nLocals: a:DispatchA*(__block) \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_1" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_6" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_2" [label="2: Exit DispatchA.block_attribute \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" [label="3: Return Stmt \n n$5=*&a:DispatchA* [line 40, column 10]\n n$6=*n$5._x:int [line 40, column 10]\n " shape="box"]
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" ;
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" [label="4: Return Stmt \n *&return:int=n$6 [line 40, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_2" ;
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" [label="5: Call _fun__dispatch_once \n n$7=*&a:DispatchA* [line 37, column 24]\n n$9=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.block_attribute.once:long*,(_fun_objc_blockDispatchA.block_attribute_2,([by ref]n$7 &a:DispatchA*)):_fn_(*)) [line 37, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" ;
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_6" [label="6: DeclStmt \n VARIABLE_DECLARED(a:DispatchA*); [line 36, column 3]\n n$10=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 36, column 26]\n n$11=_fun_NSObject.init(n$10:DispatchA*) virtual [line 36, column 26]\n *&a:DispatchA*=n$11 [line 36, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_6" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_1" [label="1: Start DispatchA.dispatch_a_block_variable\nFormals: \nLocals: initialization_block__:_fn_(*) \n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_1" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_6" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_2" [label="2: Exit DispatchA.dispatch_a_block_variable \n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" [label="3: Return Stmt \n n$17=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.dispatch_a_block_variable.static_storage__:DispatchA* [line 59, column 10]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" ;
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" [label="4: Return Stmt \n *&return:objc_object*=n$17 [line 59, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_2" ;
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" [label="5: Call _fun__dispatch_once \n n$18=*&initialization_block__:_fn_(*) [line 58, column 32]\n n$19=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.dispatch_a_block_variable.once_token__:long*,(_fun_objc_blockDispatchA.dispatch_a_block_variable_4):_fn_(*)) [line 58, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" ;
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_6" [label="6: DeclStmt \n VARIABLE_DECLARED(initialization_block__:_fn_(*)); [line 54, column 3]\n *&initialization_block__:_fn_(*)=(_fun_objc_blockDispatchA.dispatch_a_block_variable_4) [line 54, column 3]\n " shape="box"]
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_6" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_1" [label="1: Start DispatchA.dispatch_a_block_variable_from_macro\nFormals: \nLocals: initialization_block__:_fn_(*) \n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_1" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_2" [label="2: Exit DispatchA.dispatch_a_block_variable_from_macro \n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] get rid of FallbackNode Summary: Dummy names are bad for debugging. Reviewed By: da319 Differential Revision: D24991563 fbshipit-source-id: 799d2b071
4 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" [label="3: Compound statement \n n$22=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.dispatch_a_block_variable_from_macro.static_storage__:DispatchA* [line 70, column 5]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" ;
[closure] Substitute closure parameter when given via variable Summary: This diff substitutes closure parameter when it is given via variable. For example, ``` x = ^{ ... } foo(x) ``` this diff substitutes the closure variable `x`, ``` x = ^{ ... } foo(^{ ... }) ``` so that the specialization of `foo` can be done by `CCallSpecializaedWithClosures.process`. Reviewed By: jvillard Differential Revision: D23814595 fbshipit-source-id: a89f1530f
4 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" [label="4: Call _fun__dispatch_once \n n$23=*&initialization_block__:_fn_(*) [line 69, column 34]\n n$24=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.dispatch_a_block_variable_from_macro.once_token__:long*,(_fun_objc_blockDispatchA.dispatch_a_block_variable_from_macro_5):_fn_(*)) [line 69, column 5]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" [label="5: DeclStmt \n VARIABLE_DECLARED(initialization_block__:_fn_(*)); [line 65, column 5]\n *&initialization_block__:_fn_(*)=(_fun_objc_blockDispatchA.dispatch_a_block_variable_from_macro_5) [line 65, column 5]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" [label="6: Return Stmt \n *&return:objc_object*=n$22 [line 63, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_2" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_1" [label="1: Start DispatchA.dispatch_a_block_variable_from_macro_delivers_initialised_object\nFormals: \nLocals: a:DispatchA* \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_1" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_6" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_2" [label="2: Exit DispatchA.dispatch_a_block_variable_from_macro_delivers_initialised_object \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" [label="3: Return Stmt \n n$27=*&a:DispatchA* [line 77, column 15]\n n$28=*n$27._x:int [line 77, column 15]\n " shape="box"]
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" ;
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" [label="4: Return Stmt \n *&return:int=(1 / (n$28 - 5)) [line 77, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_2" ;
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" [label="5: BinaryOperatorStmt: Assign \n n$29=*&a:DispatchA* [line 76, column 3]\n *n$29._x:int=5 [line 76, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" ;
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_6" [label="6: DeclStmt \n VARIABLE_DECLARED(a:DispatchA*); [line 75, column 3]\n n$30=_fun_DispatchA.dispatch_a_block_variable_from_macro() [line 75, column 18]\n *&a:DispatchA*=n$30 [line 75, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_6" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_1" [label="1: Start DispatchA.sharedInstance\nFormals: \nLocals: \n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_1" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_5" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_2" [label="2: Exit DispatchA.sharedInstance \n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" [label="3: Return Stmt \n n$1=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.sharedInstance.sharedInstance:objc_object* [line 31, column 10]\n " shape="box"]
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" ;
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" [label="4: Return Stmt \n *&return:objc_object*=n$1 [line 31, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_2" ;
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_5" [label="5: Call _fun__dispatch_once \n n$4=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.sharedInstance.once:long*,(_fun_objc_blockDispatchA.sharedInstance_1):_fn_(*)) [line 28, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_5" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_1" [label="1: Start DispatchA.trans\nFormals: \nLocals: dummy_block:_fn_(*) \n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_1" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_6" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_2" [label="2: Exit DispatchA.trans \n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" [label="3: Return Stmt \n n$12=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA.trans.sharedInstance:objc_object* [line 49, column 10]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" ;
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" [label="4: Return Stmt \n *&return:objc_object*=n$12 [line 49, column 3]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_2" ;
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" [label="5: Call n$13 \n n$13=*&dummy_block:_fn_(*) [line 48, column 3]\n n$14=n$13() objc_block [line 48, column 3]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" ;
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_6" [label="6: DeclStmt \n VARIABLE_DECLARED(dummy_block:_fn_(*)); [line 45, column 3]\n *&dummy_block:_fn_(*)=(_fun_objc_blockDispatchA.trans_3) [line 45, column 3]\n " shape="box"]
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_6" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" ;
[clang] Adding implicit implementation of dealloc methods to ObjC classes Summary: This models ARC implementation of dealloc, see https://clang.llvm.org/docs/AutomaticReferenceCounting.html#dealloc. Dealloc methods can be added to ObjC classes to free C memory for example, but the deallocation of the ObjC instance variables of the object is done automatically. So here we add this explicitly to Infer: 1. First, we add an empty dealloc method when it is not written explicitly. 2. For each dealloc method (including the implicitly added ones) we add calls to dealloc of the ObjC instance variables. Reviewed By: jvillard Differential Revision: D21883546 fbshipit-source-id: f5d4930f2
5 years ago
"dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_1" [label="1: Start DispatchA.dealloc\nFormals: self:DispatchA*\nLocals: \n " color=yellow style=filled]
"dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_1" -> "dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_3" ;
"dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_2" [label="2: Exit DispatchA.dealloc \n " color=yellow style=filled]
"dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_3" [label="3: Call dealloc \n " shape="box"]
"dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_3" -> "dealloc#DispatchA#instance.efcbb5cd324f6ef16ae8c5197a17f974_2" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_1" [label="1: Start DispatchA.init\nFormals: self:DispatchA*\nLocals: \n " color=yellow style=filled]
[clang] Adding parameters as part of the procname for C++/ObjC methods and ObjC blocks Reviewed By: mbouaziz Differential Revision: D8237112 fbshipit-source-id: c0ec4b4
7 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_1" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_2" [label="2: Exit DispatchA.init \n " color=yellow style=filled]
[clang] Adding parameters as part of the procname for C++/ObjC methods and ObjC blocks Reviewed By: mbouaziz Differential Revision: D8237112 fbshipit-source-id: c0ec4b4
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" [label="3: Return Stmt \n n$0=*&self:DispatchA* [line 22, column 10]\n " shape="box"]
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_4" ;
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_4" [label="4: Return Stmt \n *&return:objc_object*=n$0 [line 22, column 3]\n " shape="box"]
[clang] Adding parameters as part of the procname for C++/ObjC methods and ObjC blocks Reviewed By: mbouaziz Differential Revision: D8237112 fbshipit-source-id: c0ec4b4
7 years ago
[clang] change the way we wire up return statements Summary: Split the translation of return more aggressively between: 1. the instruction that has to happen before the translation of the sub-expr 2. the sub-expr 3. the instruction that has to happen after the sub-expr This is needed for the next diff which creates potentially large CFGs in (2). Reviewed By: da319 Differential Revision: D24954071 fbshipit-source-id: a7e7e2527
4 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_4" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_2" ;
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
"setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_1" [label="1: Start DispatchA.setX:\nFormals: self:DispatchA* x:int\nLocals: \n " color=yellow style=filled]
"setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_1" -> "setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_3" ;
"setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_2" [label="2: Exit DispatchA.setX: \n " color=yellow style=filled]
"setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_3" [label="3: BinaryOperatorStmt: Node \n n$0=*&self:DispatchA* [line 12, column 26]\n n$1=*&x:int [line 12, column 26]\n *n$0._x:int=n$1 [line 12, column 26]\n " shape="box"]
"setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_3" -> "setX:#DispatchA#instance.b6cea284a46ba947192a21fbc276649b_2" ;
"x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_1" [label="1: Start DispatchA.x\nFormals: self:DispatchA*\nLocals: \n " color=yellow style=filled]
"x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_1" -> "x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_3" ;
"x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_2" [label="2: Exit DispatchA.x \n " color=yellow style=filled]
"x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_3" [label="3: BinaryOperatorStmt: Node \n n$2=*&self:DispatchA* [line 12, column 26]\n n$3=*n$2._x:int [line 12, column 26]\n *&return:int=n$3 [line 12, column 26]\n " shape="box"]
"x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_3" -> "x#DispatchA#instance.f9f4a74f4e170606d41e9af1e202a966_2" ;
initial synchronization
10 years ago
}