pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '3e94fc7e16'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/shared/block/dispatch.m.dot

228 lines
23 KiB
Raw Normal View History Unescape

Add @generated comment to icfg.dot files Reviewed By: jvillard Differential Revision: D3358243 fbshipit-source-id: a47cc01
9 years ago
/* @generated */
[cfg] rename iCFG to cfg in dotty files Summary: Not sure what an "iCFG" is but the dotty is only about CFGs anyway. Diff obtained by mass-`sed`. Reviewed By: sblackshear Differential Revision: D6324280 fbshipit-source-id: b7603bb
7 years ago
digraph cfg {
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_1" [label="1: Start DispatchMain\nFormals: \nLocals: p:int* b:DispatchA* \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_1" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" [label="2: Exit DispatchMain \n NULLIFY(&p); [line 89, column 1]\n NULLIFY(&b); [line 89, column 1]\n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_3" [label="3: + \n " ]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_3" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" [label="4: between_join_and_exit \n APPLY_ABSTRACTION; [line 85, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_4" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" [label="5: BinaryOperatorStmt: EQ \n n$0=*&b:DispatchA* [line 85, column 7]\n EXIT_SCOPE(b); [line 85, column 7]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" ;
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" [label="6: Prune (true branch, if) \n PRUNE((n$0 == null), true); [line 85, column 7]\n EXIT_SCOPE(n$0); [line 85, column 7]\n " shape="invhouse"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_6" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" [label="7: Prune (false branch, if) \n PRUNE(!(n$0 == null), false); [line 85, column 7]\n EXIT_SCOPE(n$0,p); [line 85, column 7]\n " shape="invhouse"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_7" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" [label="8: Return Stmt \n n$1=*&p:int* [line 86, column 13]\n n$2=*n$1:int [line 86, column 12]\n *&return:int=n$2 [line 86, column 5]\n EXIT_SCOPE(n$1,n$2,p); [line 86, column 5]\n APPLY_ABSTRACTION; [line 86, column 5]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_8" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" [label="9: Return Stmt \n *&return:int=0 [line 88, column 5]\n APPLY_ABSTRACTION; [line 88, column 5]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_9" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_2" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" [label="10: DeclStmt \n n$4=_fun___variable_initialization(&p:int*) assign_last [line 84, column 3]\n *&p:int*=null [line 84, column 3]\n EXIT_SCOPE(n$4); [line 84, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_5" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" [label="11: DeclStmt \n n$6=_fun___variable_initialization(&b:DispatchA*) assign_last [line 83, column 3]\n n$5=_fun_DispatchA_sharedInstance() [line 83, column 18]\n *&b:DispatchA*=n$5 [line 83, column 3]\n EXIT_SCOPE(n$5,n$6); [line 83, column 3]\n " shape="box"]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_11" -> "DispatchMain.f6461dbdaeaf9a114cbe40f5f72fbb3f_10" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_1" [label="1: Start objc_blockDispatchA_block_attribute_2\nFormals: a:DispatchA*\nLocals: \nCaptured: a:DispatchA* \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[clang] Add the types of captured variables to the procname of blocks Reviewed By: mbouaziz Differential Revision: D8735374 fbshipit-source-id: 5c7c0b2
6 years ago
"objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_1" -> "objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_3" ;
"objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_2" [label="2: Exit objc_blockDispatchA_block_attribute_2 \n " color=yellow style=filled]
Fix StmtExpr Summary: The extra dereference in stmtexpr was wrong. When a dereference is needed, we have a cast. This was causing one dereference too many, and creating wrong results. Reviewed By: akotulski Differential Revision: D3393294 fbshipit-source-id: 7a1ec8e
9 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_3" [label="3: BinaryOperatorStmt: Assign \n n$8=*&a:DispatchA* [line 38, column 5]\n *n$8._x:int=10 [line 38, column 5]\n NULLIFY(&a); [line 38, column 5]\n EXIT_SCOPE(n$8,a); [line 38, column 5]\n APPLY_ABSTRACTION; [line 38, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Add the types of captured variables to the procname of blocks Reviewed By: mbouaziz Differential Revision: D8735374 fbshipit-source-id: 5c7c0b2
6 years ago
"objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_3" -> "objc_blockDispatchA_block_attribute_2(class DispatchA).2825198b53dffef0e3209a90789e506f_2" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_1" [label="1: Start objc_blockDispatchA_dispatch_a_block_variable_4\nFormals: \nLocals: \n " color=yellow style=filled]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_1" -> "objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_3" ;
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_2" [label="2: Exit objc_blockDispatchA_dispatch_a_block_variable_4 \n " color=yellow style=filled]
initial synchronization
10 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_3" [label="3: BinaryOperatorStmt: Assign \n n$22=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 55, column 25]\n n$23=_fun_NSObject_init(n$22:DispatchA*) virtual [line 55, column 25]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable.static_storage__:objc_object*=n$23 [line 55, column 5]\n EXIT_SCOPE(n$22,n$23); [line 55, column 5]\n APPLY_ABSTRACTION; [line 55, column 5]\n " shape="box"]
Adding endtoend test that shows that dispatch once works well Reviewed By: ddino Differential Revision: D2570191 fb-gh-sync-id: 01be61c
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_3" -> "objc_blockDispatchA_dispatch_a_block_variable_4.2eedc45fca2c35e6e8c11937ba7a2df8_2" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_1" [label="1: Start objc_blockDispatchA_dispatch_a_block_variable_from_macro_5\nFormals: \nLocals: \n " color=yellow style=filled]
Adding endtoend test that shows that dispatch once works well Reviewed By: ddino Differential Revision: D2570191 fb-gh-sync-id: 01be61c
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_1" -> "objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_3" ;
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_2" [label="2: Exit objc_blockDispatchA_dispatch_a_block_variable_from_macro_5 \n " color=yellow style=filled]
initial synchronization
10 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_3" [label="3: BinaryOperatorStmt: Assign \n n$28=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 66, column 27]\n n$29=_fun_NSObject_init(n$28:DispatchA*) virtual [line 66, column 27]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_from_macro.static_storage__:objc_object*=n$29 [line 66, column 7]\n EXIT_SCOPE(n$28,n$29); [line 66, column 7]\n APPLY_ABSTRACTION; [line 66, column 7]\n " shape="box"]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_3" -> "objc_blockDispatchA_dispatch_a_block_variable_from_macro_5.e4f37df69df9d95138cb008e85eedab8_2" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_1" [label="1: Start objc_blockDispatchA_sharedInstance_1\nFormals: \nLocals: \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_1" -> "objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_3" ;
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_2" [label="2: Exit objc_blockDispatchA_sharedInstance_1 \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_3" [label="3: BinaryOperatorStmt: Assign \n n$2=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 29, column 23]\n n$3=_fun_NSBundleResourceRequest_init(n$2:DispatchA*) virtual [line 29, column 22]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_sharedInstance.sharedInstance:objc_object*=n$3 [line 29, column 5]\n EXIT_SCOPE(n$2,n$3); [line 29, column 5]\n APPLY_ABSTRACTION; [line 29, column 5]\n " shape="box"]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_3" -> "objc_blockDispatchA_sharedInstance_1.0b8803e75b6a82e1a4530bcb953490e2_2" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_1" [label="1: Start objc_blockDispatchA_trans_3\nFormals: \nLocals: \n " color=yellow style=filled]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_1" -> "objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_3" ;
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_2" [label="2: Exit objc_blockDispatchA_trans_3 \n " color=yellow style=filled]
[clang] Fix expression statement with conditional inside Summary: CFG nodes were not connected and some instructions ended up in wrong place. Fix those issues Reviewed By: dulmarod Differential Revision: D5406720 fbshipit-source-id: 2a70e1a
7 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_3" [label="3: BinaryOperatorStmt: Assign \n n$16=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 46, column 23]\n n$17=_fun_NSBundleResourceRequest_init(n$16:DispatchA*) virtual [line 46, column 22]\n *&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_trans.sharedInstance:objc_object*=n$17 [line 46, column 5]\n EXIT_SCOPE(n$16,n$17); [line 46, column 5]\n APPLY_ABSTRACTION; [line 46, column 5]\n " shape="box"]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_3" -> "objc_blockDispatchA_trans_3.80c09fe69dc0d5591de63a0c525de29b_2" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_1" [label="1: Start DispatchA_block_attribute\nFormals: \nLocals: a:DispatchA*(__block) \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_1" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_2" [label="2: Exit DispatchA_block_attribute \n NULLIFY(&a); [line 41, column 1]\n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" [label="3: Return Stmt \n n$5=*&a:DispatchA* [line 40, column 10]\n n$6=*n$5._x:int [line 40, column 10]\n *&return:int=n$6 [line 40, column 3]\n EXIT_SCOPE(n$5,n$6,a); [line 40, column 3]\n APPLY_ABSTRACTION; [line 40, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_2" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" [label="4: Call _fun__dispatch_once \n n$7=*&a:DispatchA* [line 37, column 24]\n n$9=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_block_attribute.once:long*,(_fun_objc_blockDispatchA_block_attribute_2,(n$7 &a:DispatchA*)):_fn_(*)) block_params [line 37, column 3]\n EXIT_SCOPE(n$7,n$9); [line 37, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_3" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" [label="5: DeclStmt \n n$12=_fun___variable_initialization(&a:DispatchA*) assign_last [line 36, column 3]\n n$10=_fun___objc_alloc_no_fail(sizeof(t=DispatchA):unsigned long) [line 36, column 26]\n n$11=_fun_NSObject_init(n$10:DispatchA*) virtual [line 36, column 26]\n *&a:DispatchA*=n$11 [line 36, column 3]\n EXIT_SCOPE(n$10,n$11,n$12); [line 36, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_5" -> "block_attribute#DispatchA#class.df997e345dbf19ec3438c667c942e14a_4" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_1" [label="1: Start DispatchA_dispatch_a_block_variable\nFormals: \nLocals: initialization_block__:_fn_(*) \n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_1" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_2" [label="2: Exit DispatchA_dispatch_a_block_variable \n NULLIFY(&initialization_block__); [line 60, column 1]\n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" [label="3: Return Stmt \n n$19=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable.static_storage__:objc_object* [line 59, column 10]\n *&return:objc_object*=n$19 [line 59, column 3]\n EXIT_SCOPE(n$19); [line 59, column 3]\n APPLY_ABSTRACTION; [line 59, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_2" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" [label="4: Call _fun__dispatch_once \n n$20=*&initialization_block__:_fn_(*) [line 58, column 32]\n n$21=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable.once_token__:long*,n$20:_fn_(*)) [line 58, column 3]\n EXIT_SCOPE(n$20,n$21,initialization_block__); [line 58, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_3" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" [label="5: DeclStmt \n n$24=_fun___variable_initialization(&initialization_block__:_fn_(*)) assign_last [line 54, column 3]\n *&initialization_block__:_fn_(*)=(_fun_objc_blockDispatchA_dispatch_a_block_variable_4) [line 54, column 3]\n EXIT_SCOPE(n$24); [line 54, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_5" -> "dispatch_a_block_variable#DispatchA#class.3cc12dd22127281b8293b7c046d21bb2_4" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_1" [label="1: Start DispatchA_dispatch_a_block_variable_from_macro\nFormals: \nLocals: initialization_block__:_fn_(*) \n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_1" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_2" [label="2: Exit DispatchA_dispatch_a_block_variable_from_macro \n NULLIFY(&initialization_block__); [line 72, column 1]\n " color=yellow style=filled]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[clang] leave markers of variable initialization for pulse Summary: When initialising a variable via semi-exotic means, the frontend loses the information that the variable was initialised. For instance, it translates: ``` struct Foo { int i; }; ... Foo s = {42}; ``` as: ``` s.i := 42 ``` This can be confusing for backends that need to know that `s` actually got initialised, eg pulse. The solution implemented here is to insert of dummy call to `__variable_initiazition`: ``` __variable_initialization(&s); s.i := 42; ``` Then checkers can recognise that this builtin function does what its name says. Reviewed By: mbouaziz Differential Revision: D12887122 fbshipit-source-id: 6e7214438
6 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" [label="3: Fallback node \n n$25=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_from_macro.static_storage__:objc_object* [line 70, column 5]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" [label="4: Call _fun__dispatch_once \n n$26=*&initialization_block__:_fn_(*) [line 69, column 34]\n n$27=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_dispatch_a_block_variable_from_macro.once_token__:long*,n$26:_fn_(*)) [line 69, column 5]\n EXIT_SCOPE(n$26,n$27,initialization_block__); [line 69, column 5]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_3" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" [label="5: DeclStmt \n n$30=_fun___variable_initialization(&initialization_block__:_fn_(*)) assign_last [line 65, column 5]\n *&initialization_block__:_fn_(*)=(_fun_objc_blockDispatchA_dispatch_a_block_variable_from_macro_5) [line 65, column 5]\n EXIT_SCOPE(n$30); [line 65, column 5]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_5" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_4" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" [label="6: Return Stmt \n *&return:objc_object*=n$25 [line 63, column 3]\n EXIT_SCOPE(n$25); [line 63, column 3]\n APPLY_ABSTRACTION; [line 63, column 3]\n " shape="box"]
[IR] combine is_objc_instance_method and is_cpp_instance_method fields in ProcAttributes into method_kind Summary: - Combine two fields from ProcAttributes.t into a single field `method_kind` with more information - New field details whether the procedure is an `OBJC_INSTANCE`, `CPP_INSTANCE`, `OBJ_CLASS`, `CPP_CLASS`, `BLOCK`, or `C_FUNCTION` - `is_objc_instance_method` and `is_cpp_instance_method` fields no longer necessary - Changed `is_instance` field in CMethod_signature to `method_kind` field of type ProcAttributes.method_kind Reviewed By: dulmarod Differential Revision: D6884402 fbshipit-source-id: 4b916c3
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_6" -> "dispatch_a_block_variable_from_macro#DispatchA#class.92567a38d5ab3cf637f72030b1097441_2" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_1" [label="1: Start DispatchA_dispatch_a_block_variable_from_macro_delivers_initialised_object\nFormals: \nLocals: a:DispatchA* \n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_1" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_2" [label="2: Exit DispatchA_dispatch_a_block_variable_from_macro_delivers_initialised_object \n NULLIFY(&a); [line 78, column 1]\n " color=yellow style=filled]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" [label="3: Return Stmt \n n$31=*&a:DispatchA* [line 77, column 15]\n n$32=*n$31._x:int [line 77, column 15]\n *&return:int=(1 / (n$32 - 5)) [line 77, column 3]\n EXIT_SCOPE(n$31,n$32,a); [line 77, column 3]\n APPLY_ABSTRACTION; [line 77, column 3]\n " shape="box"]
Fix dyspatch_async calls Reviewed By: akotulski Differential Revision: D3392473 fbshipit-source-id: 37b5b67
9 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_2" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" [label="4: BinaryOperatorStmt: Assign \n n$33=*&a:DispatchA* [line 76, column 3]\n *n$33._x:int=5 [line 76, column 3]\n EXIT_SCOPE(n$33); [line 76, column 3]\n " shape="box"]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_3" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" [label="5: DeclStmt \n n$35=_fun___variable_initialization(&a:DispatchA*) assign_last [line 75, column 3]\n n$34=_fun_DispatchA_dispatch_a_block_variable_from_macro() [line 75, column 18]\n *&a:DispatchA*=n$34 [line 75, column 3]\n EXIT_SCOPE(n$34,n$35); [line 75, column 3]\n " shape="box"]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_5" -> "dispatch_a_block_variable_from_macro_delivers_initialised_object#DispatchA#class.a58ef5afb5e1e9480b49788e2400c52c_4" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_1" [label="1: Start DispatchA_sharedInstance\nFormals: \nLocals: \n " color=yellow style=filled]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_1" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" ;
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_2" [label="2: Exit DispatchA_sharedInstance \n " color=yellow style=filled]
initial synchronization
10 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" [label="3: Return Stmt \n n$1=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_sharedInstance.sharedInstance:objc_object* [line 31, column 10]\n *&return:objc_object*=n$1 [line 31, column 3]\n EXIT_SCOPE(n$1); [line 31, column 3]\n APPLY_ABSTRACTION; [line 31, column 3]\n " shape="box"]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_2" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" [label="4: Call _fun__dispatch_once \n n$4=_fun__dispatch_once(&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_sharedInstance.once:long*,(_fun_objc_blockDispatchA_sharedInstance_1):_fn_(*)) block_params [line 28, column 3]\n EXIT_SCOPE(n$4); [line 28, column 3]\n " shape="box"]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_4" -> "sharedInstance#DispatchA#class.8992c6086d1ce5c225093940f62386ac_3" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_1" [label="1: Start DispatchA_trans\nFormals: \nLocals: dummy_block:_fn_(*) \n " color=yellow style=filled]
initial synchronization
10 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_1" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_2" [label="2: Exit DispatchA_trans \n NULLIFY(&dummy_block); [line 50, column 1]\n " color=yellow style=filled]
initial synchronization
10 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" [label="3: Return Stmt \n n$13=*&#GB<codetoanalyze/objc/shared/block/dispatch.m>$DispatchA_trans.sharedInstance:objc_object* [line 49, column 10]\n *&return:objc_object*=n$13 [line 49, column 3]\n EXIT_SCOPE(n$13); [line 49, column 3]\n APPLY_ABSTRACTION; [line 49, column 3]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_2" ;
[SIL][2/3] print all the CallFlags Summary: This seems generally useful. Force people to do it in the future even if they want to avoid having to update the frontend tests. Reviewed By: mbouaziz Differential Revision: D14324758 fbshipit-source-id: cdef3f72a
6 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" [label="4: Call n$14 \n n$14=*&dummy_block:_fn_(*) [line 48, column 3]\n n$15=n$14() objc_block [line 48, column 3]\n EXIT_SCOPE(n$14,n$15,dummy_block); [line 48, column 3]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_3" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" [label="5: DeclStmt \n n$18=_fun___variable_initialization(&dummy_block:_fn_(*)) assign_last [line 45, column 3]\n *&dummy_block:_fn_(*)=(_fun_objc_blockDispatchA_trans_3) [line 45, column 3]\n EXIT_SCOPE(n$18); [line 45, column 3]\n " shape="box"]
[IR] Adding support for variable attributes, adding __block for ObjC variables Reviewed By: sblackshear Differential Revision: D6424743 fbshipit-source-id: 409359a
7 years ago
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_5" -> "trans#DispatchA#class.23f9d908a87deca79c235bc76ca6e941_4" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_1" [label="1: Start DispatchA_init\nFormals: self:DispatchA*\nLocals: \n " color=yellow style=filled]
[clang] Adding parameters as part of the procname for C++/ObjC methods and ObjC blocks Reviewed By: mbouaziz Differential Revision: D8237112 fbshipit-source-id: c0ec4b4
7 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_1" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" ;
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_2" [label="2: Exit DispatchA_init \n " color=yellow style=filled]
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" [label="3: Return Stmt \n n$0=*&self:DispatchA* [line 22, column 10]\n *&return:objc_object*=n$0 [line 22, column 3]\n NULLIFY(&self); [line 22, column 3]\n EXIT_SCOPE(n$0,self); [line 22, column 3]\n APPLY_ABSTRACTION; [line 22, column 3]\n " shape="box"]
[clang] Adding parameters as part of the procname for C++/ObjC methods and ObjC blocks Reviewed By: mbouaziz Differential Revision: D8237112 fbshipit-source-id: c0ec4b4
7 years ago
"init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_3" -> "init#DispatchA#instance.ff6c7b9a5a49bb46493519a4290a6582_2" ;
initial synchronization
10 years ago
}