pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '3e94fc7e16'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/shared/property/PropertyAttributes.m.dot

78 lines
6.9 KiB
Raw Normal View History Unescape

Add @generated comment to icfg.dot files Reviewed By: jvillard Differential Revision: D3358243 fbshipit-source-id: a47cc01
9 years ago
/* @generated */
[cfg] rename iCFG to cfg in dotty files Summary: Not sure what an "iCFG" is but the dotty is only about CFGs anyway. Diff obtained by mass-`sed`. Reviewed By: sblackshear Differential Revision: D6324280 fbshipit-source-id: b7603bb
7 years ago
digraph cfg {
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_1" [label="1: Start test\nFormals: a2:PropertyA*\nLocals: a:PropertyA* \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_1" -> "test.098f6bcd4621d373cade4e832627b4f6_6" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_2" [label="2: Exit test \n NULLIFY(&a); [line 45, column 1]\n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_3" [label="3: Return Stmt \n *&return:int=0 [line 44, column 3]\n APPLY_ABSTRACTION; [line 44, column 3]\n " shape="box"]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_3" -> "test.098f6bcd4621d373cade4e832627b4f6_2" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_4" [label="4: Message Call: release \n n$0=*&a:PropertyA* [line 43, column 4]\n n$1=_fun_NSObject_release(n$0:PropertyA*) virtual [line 43, column 3]\n EXIT_SCOPE(n$0,n$1,a); [line 43, column 3]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_4" -> "test.098f6bcd4621d373cade4e832627b4f6_3" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_5" [label="5: Message Call: setLast_name: \n n$3=*&a:PropertyA* [line 42, column 3]\n n$2=*&a2:PropertyA* [line 42, column 17]\n n$4=_fun_PropertyA_setLast_name:(n$3:PropertyA*,n$2:PropertyA*) [line 42, column 5]\n NULLIFY(&a2); [line 42, column 5]\n EXIT_SCOPE(n$2,n$3,n$4,a2); [line 42, column 5]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_5" -> "test.098f6bcd4621d373cade4e832627b4f6_4" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_6" [label="6: DeclStmt \n n$7=_fun___variable_initialization(&a:PropertyA*) assign_last [line 41, column 3]\n n$5=_fun___objc_alloc_no_fail(sizeof(t=PropertyA):unsigned long) [line 41, column 19]\n n$6=_fun_PropertyA_init(n$5:PropertyA*) virtual [line 41, column 18]\n *&a:PropertyA*=n$6 [line 41, column 3]\n EXIT_SCOPE(n$5,n$6,n$7); [line 41, column 3]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_6" -> "test.098f6bcd4621d373cade4e832627b4f6_5" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_1" [label="1: Start PropertyA_copy\nFormals: self:PropertyA*\nLocals: other:PropertyA* \n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_1" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" ;
[cfg] print dotty *after* pre-analysis Summary: Useful to understand the changes in the pre-analysis, or to inspect the CFG that checkers actually get. This means that the pre-analysis always runs when we output the dotty, but I don't really see a reason why not. In fact, we could probably *always* store the CFGs as pre-analysed. Reviewed By: mbouaziz Differential Revision: D13102952 fbshipit-source-id: 89f3102ec
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_2" [label="2: Exit PropertyA_copy \n NULLIFY(&other); [line 36, column 1]\n " color=yellow style=filled]
initial synchronization
10 years ago
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_3" [label="3: Return Stmt \n n$1=*&other:PropertyA* [line 35, column 10]\n *&return:PropertyA*=n$1 [line 35, column 3]\n EXIT_SCOPE(n$1,other); [line 35, column 3]\n APPLY_ABSTRACTION; [line 35, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_3" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_2" ;
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" [label="4: + \n " ]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_3" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_5" [label="5: Prune (true branch, if) \n n$2=*&other:PropertyA* [line 30, column 7]\n PRUNE(n$2, true); [line 30, column 7]\n EXIT_SCOPE(n$2); [line 30, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_5" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_9" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_6" [label="6: Prune (false branch, if) \n n$2=*&other:PropertyA* [line 30, column 7]\n PRUNE(!n$2, false); [line 30, column 7]\n EXIT_SCOPE(n$2); [line 30, column 7]\n APPLY_ABSTRACTION; [line 30, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_6" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_7" [label="7: BinaryOperatorStmt: Assign \n n$3=*&other:PropertyA* [line 33, column 5]\n n$4=*&self:PropertyA* [line 33, column 21]\n n$5=*n$4._child:PropertyA* [line 33, column 21]\n *n$3._child:PropertyA*=n$5 [line 33, column 5]\n NULLIFY(&self); [line 33, column 5]\n EXIT_SCOPE(n$3,n$4,n$5,self); [line 33, column 5]\n APPLY_ABSTRACTION; [line 33, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_7" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_8" [label="8: BinaryOperatorStmt: Assign \n n$6=*&other:PropertyA* [line 32, column 5]\n n$7=*&self:PropertyA* [line 32, column 25]\n n$8=*n$7._last_name:PropertyA* [line 32, column 25]\n *n$6._last_name:PropertyA*=n$8 [line 32, column 5]\n EXIT_SCOPE(n$6,n$7,n$8); [line 32, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_8" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_7" ;
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_9" [label="9: BinaryOperatorStmt: Assign \n n$9=*&other:PropertyA* [line 31, column 5]\n n$10=*&self:PropertyA* [line 31, column 20]\n n$11=*n$10._name:PropertyA* [line 31, column 20]\n *n$9._name:PropertyA*=n$11 [line 31, column 5]\n EXIT_SCOPE(n$9,n$10,n$11); [line 31, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_9" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_8" ;
[SIL][preanalysis] add call flag for functions treating first formal as return Summary: This helps some checkers and the liveness preanalysis. Reviewed By: da319 Differential Revision: D13102954 fbshipit-source-id: b8d3c5fe2
6 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" [label="10: DeclStmt \n n$16=_fun___variable_initialization(&other:PropertyA*) assign_last [line 29, column 3]\n n$14=_fun___objc_alloc_no_fail(sizeof(t=PropertyA):unsigned long) [line 29, column 23]\n n$15=_fun_PropertyA_init(n$14:PropertyA*) virtual [line 29, column 22]\n *&other:PropertyA*=n$15 [line 29, column 3]\n EXIT_SCOPE(n$14,n$15,n$16); [line 29, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_5" ;
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_6" ;
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_1" [label="1: Start PropertyA_init\nFormals: self:PropertyA*\nLocals: \n " color=yellow style=filled]
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_1" -> "init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_3" ;
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_2" [label="2: Exit PropertyA_init \n " color=yellow style=filled]
[preanalysis] do not delay killing variables taken by reference Summary: Before, the liveness pre-analysis would place extra instructions in the CFG for either: 1. marking an `Ident.t` as dead, or 2. marking a `Pvar.t` as `= 0` But we have no way of marking pvars dead without setting them to 0. This is bad because setting pvars to 0 is not possible everywhere they are dead. Indeed, we only do it when we haven't seen their address being taken anyway. This prevents the following situation, recorded in our tests: ``` int address_taken() { int** x; int* y; int i = 7; y = &i; x = &y; // if we don't reason about taken addresses while adding nullify instructions, // we'll add // `nullify(y)` here and report a false NPE on the next line return **x; } ``` So we want to mark pvars as dead without nullifying them. This diff extends the `Remove_temps` SIL instruction to accept pvars as well, and so renames it to `ExitScope`. Reviewed By: da319 Differential Revision: D13102953 fbshipit-source-id: aa7f03a52
6 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_3" [label="3: Return Stmt \n n$0=*&self:PropertyA* [line 25, column 10]\n *&return:objc_object*=n$0 [line 25, column 3]\n NULLIFY(&self); [line 25, column 3]\n EXIT_SCOPE(n$0,self); [line 25, column 3]\n APPLY_ABSTRACTION; [line 25, column 3]\n " shape="box"]
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_3" -> "init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_2" ;
initial synchronization
10 years ago
}