pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '3eed17488a'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/autoreleasepool/cost-issues.exp

80 lines
12 KiB
Raw Normal View History Unescape

[cost] Add model of NSArray.index_of_object_passing_test Summary: This diff add a model of `NSArray.index_of_object_passing_test` in autoreleasepool size model. Worst case autorelease cost is "array size x cost of given test function (lambda)". Reviewed By: ezgicicek Differential Revision: D23785165 fbshipit-source-id: 95ec9700a
4 years ago
${XCODE_ISYSROOT}/System/Library/Frameworks/Foundation.framework/Headers/NSArray.h, NSArray.indexOfObjectPassingTest:[objc_blockArcBlock.callIndexOfObjectPassingTest_linear:_1], 0, OnUIThread:false, []
[closure] Substitute closure parameter when given via variable Summary: This diff substitutes closure parameter when it is given via variable. For example, ``` x = ^{ ... } foo(x) ``` this diff substitutes the closure variable `x`, ``` x = ^{ ... } foo(^{ ... }) ``` so that the specialization of `foo` can be done by `CCallSpecializaedWithClosures.process`. Reviewed By: jvillard Differential Revision: D23814595 fbshipit-source-id: a89f1530f
4 years ago
${XCODE_ISYSROOT}/System/Library/Frameworks/Foundation.framework/Headers/NSArray.h, NSArray.indexOfObjectPassingTest:[objc_blockArcBlock.callIndexOfObjectPassingTest_param_linear:_2], 0, OnUIThread:false, []
[preanalysis] Handle closure substitution in conditionals Summary: Specialized closure substitution was broken for conditionals: ``` void foo(dispatch_block_t block1){ if (x){ block1(); // not replaced with specialized implementation } } ``` The problem was that when substituting function calls, it only used memory state at the exit node, rather than at each program point. We could solve this by - reverting the domain change in D24418560 (https://github.com/facebook/infer/commit/c47911359ac9a207aa376f6641915fccca5b150e), i.e. collecting all possible mappings conservatively (e.g. switch the domain back to `Map`) - pass the `invariant_map` for substitutions at each program point. We go with the second option here. The closure substitution is still somewhat broken as exemplified by the following example: ``` void foo(dispatch_block_t block1){ dispatch_block_t local_block = block1; local_block(); // we don't substitute the call here } ``` Reviewed By: skcho Differential Revision: D24993962 fbshipit-source-id: ebadddb58
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.callBlock:, |block|, OnUIThread:false, []
[preanalysis] Handle assigning blocks to locals in closure substitution Summary: Existing closure substitution only supported direct block calls to formals. The following didn't work since the domain was only keeping track of loads/calls from formals, but didn't support stores. ``` void foo(dispatch_block_t block1){ dispatch_block_t local_block = block1; local_block(); // we don't substitute the call here } ``` This diff adds support for assigning a block to a local variable so that we can specialize the above example. We now have a pair domain - existing mapping from ids to block vars - a new mapping from mangled to block specializations the latter allows us to update the mapping in local block assignment (via store). Reviewed By: skcho Differential Revision: D25030234 fbshipit-source-id: 3f172341c
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.callBlock:[objc_blockArcBlock.call_CallBlock_linear:_4], 1, OnUIThread:false, [autorelease,Call to objc_blockArcBlock.call_CallBlock_linear:_4,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[cost] Add model of NSArray.index_of_object_passing_test Summary: This diff add a model of `NSArray.index_of_object_passing_test` in autoreleasepool size model. Worst case autorelease cost is "array size x cost of given test function (lambda)". Reviewed By: ezgicicek Differential Revision: D23785165 fbshipit-source-id: 95ec9700a
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.callIndexOfObjectPassingTest_linear:, x->elements.length.ub, OnUIThread:false, [{x->elements.length.ub},Modeled call to indexOfObjectPassingTest:,autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[closure] Substitute closure parameter when given via variable Summary: This diff substitutes closure parameter when it is given via variable. For example, ``` x = ^{ ... } foo(x) ``` this diff substitutes the closure variable `x`, ``` x = ^{ ... } foo(^{ ... }) ``` so that the specialization of `foo` can be done by `CCallSpecializaedWithClosures.process`. Reviewed By: jvillard Differential Revision: D23814595 fbshipit-source-id: a89f1530f
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.callIndexOfObjectPassingTest_param_linear:, x->elements.length.ub, OnUIThread:false, [{x->elements.length.ub},Modeled call to indexOfObjectPassingTest:,autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[preanalysis] Handle assigning blocks to locals in closure substitution Summary: Existing closure substitution only supported direct block calls to formals. The following didn't work since the domain was only keeping track of loads/calls from formals, but didn't support stores. ``` void foo(dispatch_block_t block1){ dispatch_block_t local_block = block1; local_block(); // we don't substitute the call here } ``` This diff adds support for assigning a block to a local variable so that we can specialize the above example. We now have a pair domain - existing mapping from ids to block vars - a new mapping from mangled to block specializations the latter allows us to update the mapping in local block assignment (via store). Reviewed By: skcho Differential Revision: D25030234 fbshipit-source-id: 3f172341c
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.call_CallBlock_linear:, k, OnUIThread:false, [{k},Loop,autorelease,Call to ArcBlock.callBlock:[objc_blockArcBlock.call_CallBlock_linear:_4],Call to objc_blockArcBlock.call_CallBlock_linear:_4,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[preanalysis] Handle closure substitution in conditionals Summary: Specialized closure substitution was broken for conditionals: ``` void foo(dispatch_block_t block1){ if (x){ block1(); // not replaced with specialized implementation } } ``` The problem was that when substituting function calls, it only used memory state at the exit node, rather than at each program point. We could solve this by - reverting the domain change in D24418560 (https://github.com/facebook/infer/commit/c47911359ac9a207aa376f6641915fccca5b150e), i.e. collecting all possible mappings conservatively (e.g. switch the domain back to `Map`) - pass the `invariant_map` for substitutions at each program point. We go with the second option here. The closure substitution is still somewhat broken as exemplified by the following example: ``` void foo(dispatch_block_t block1){ dispatch_block_t local_block = block1; local_block(); // we don't substitute the call here } ``` Reviewed By: skcho Differential Revision: D24993962 fbshipit-source-id: ebadddb58
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.call_ConditionalRunBlock_linear:, k, OnUIThread:false, [{k},Loop,autorelease,Call to ArcBlock.conditionalRunBlock:[objc_blockArcBlock.call_ConditionalRunBlock_linear:_3],Call to objc_blockArcBlock.call_ConditionalRunBlock_linear:_3,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.conditionalRunBlock:, |block|, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.conditionalRunBlock:[objc_blockArcBlock.call_ConditionalRunBlock_linear:_3], 1, OnUIThread:false, [autorelease,Call to objc_blockArcBlock.call_ConditionalRunBlock_linear:_3,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[cost] Add a FN test using block (autoreleasepool) Summary: This diff adds a FN test using block. Reviewed By: ezgicicek Differential Revision: D23708266 fbshipit-source-id: 35ade9507
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, ArcBlock.dealloc, 0, OnUIThread:false, []
[cost] Add model of NSArray.index_of_object_passing_test Summary: This diff add a model of `NSArray.index_of_object_passing_test` in autoreleasepool size model. Worst case autorelease cost is "array size x cost of given test function (lambda)". Reviewed By: ezgicicek Differential Revision: D23785165 fbshipit-source-id: 95ec9700a
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, objc_blockArcBlock.callIndexOfObjectPassingTest_linear:_1, 1, OnUIThread:false, [autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[closure] Substitute closure parameter when given via variable Summary: This diff substitutes closure parameter when it is given via variable. For example, ``` x = ^{ ... } foo(x) ``` this diff substitutes the closure variable `x`, ``` x = ^{ ... } foo(^{ ... }) ``` so that the specialization of `foo` can be done by `CCallSpecializaedWithClosures.process`. Reviewed By: jvillard Differential Revision: D23814595 fbshipit-source-id: a89f1530f
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, objc_blockArcBlock.callIndexOfObjectPassingTest_param_linear:_2, 1, OnUIThread:false, [autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[preanalysis] Handle closure substitution in conditionals Summary: Specialized closure substitution was broken for conditionals: ``` void foo(dispatch_block_t block1){ if (x){ block1(); // not replaced with specialized implementation } } ``` The problem was that when substituting function calls, it only used memory state at the exit node, rather than at each program point. We could solve this by - reverting the domain change in D24418560 (https://github.com/facebook/infer/commit/c47911359ac9a207aa376f6641915fccca5b150e), i.e. collecting all possible mappings conservatively (e.g. switch the domain back to `Map`) - pass the `invariant_map` for substitutions at each program point. We go with the second option here. The closure substitution is still somewhat broken as exemplified by the following example: ``` void foo(dispatch_block_t block1){ dispatch_block_t local_block = block1; local_block(); // we don't substitute the call here } ``` Reviewed By: skcho Differential Revision: D24993962 fbshipit-source-id: ebadddb58
4 years ago
codetoanalyze/objc/autoreleasepool/arc_block.m, objc_blockArcBlock.call_CallBlock_linear:_4, 1, OnUIThread:false, [autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
codetoanalyze/objc/autoreleasepool/arc_block.m, objc_blockArcBlock.call_ConditionalRunBlock_linear:_3, 1, OnUIThread:false, [autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[cost] Increase autoreleasepool size when non-ARC call ARC Summary: This diff increases autoreleasepool size when * caller is non-ARC-compiled * callee is ARC-compiled * return type is a pointer to objc object To distinguish non-ARC-/ARC-compiled: * extended `translation_unit_decl_info` to have a boolean field `is_objc_arc_on` * then copied it to `ProcAttributes.t` for each procedures. Reviewed By: ezgicicek Differential Revision: D23565003 fbshipit-source-id: dee22ea82
4 years ago
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.allocObject, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.copyObject:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.dealloc, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveMeInt, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveMeObject, 0, OnUIThread:false, []
[cost] Ignore tagged pointers in autoreleasepool size Summary: This diff ignores tagged pointers in the autoreleasepool size, since they are not added to the autorelease pool. https://opensource.apple.com/source/objc4/objc4-781/runtime/objc-internal.h.auto.html Reviewed By: ezgicicek Differential Revision: D23626339 fbshipit-source-id: ba9ef4106
4 years ago
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveTaggedPointerDate, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveTaggedPointerIndexPath, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveTaggedPointerIndexSet, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveTaggedPointerNumber, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.giveTaggedPointerString, 0, OnUIThread:false, []
[cost] Increase autoreleasepool size when non-ARC call ARC Summary: This diff increases autoreleasepool size when * caller is non-ARC-compiled * callee is ARC-compiled * return type is a pointer to objc object To distinguish non-ARC-/ARC-compiled: * extended `translation_unit_decl_info` to have a boolean field `is_objc_arc_on` * then copied it to `ProcAttributes.t` for each procedures. Reviewed By: ezgicicek Differential Revision: D23565003 fbshipit-source-id: dee22ea82
4 years ago
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.mutableCopyObject:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_callee.m, ArcCallee.newObject, 0, OnUIThread:false, []
[cost] Add tests run with ARC/non-ARC sources Summary: This diff adds some tests run with ARC/non-ARC compiled objective-c sources. Reviewed By: ezgicicek Differential Revision: D23542135 fbshipit-source-id: 8e089666b
4 years ago
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.callAllocObject_zero:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.callCopyObject_zero:x:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.callGiveMeObject_autoreleasepool_zero:, 0, OnUIThread:false, []
[cost] Add autorelease models: some methods of NSKeyedUnarchiver Summary: This diff regards some methods of NSKeyedUnarchiver as autorelease, because they may call autorelease. Reviewed By: ezgicicek Differential Revision: D23600232 fbshipit-source-id: a9fc1cc56
4 years ago
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.callGiveMeObject_linear:, n, OnUIThread:false, [{n},Loop,autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[cost] Add tests run with ARC/non-ARC sources Summary: This diff adds some tests run with ARC/non-ARC compiled objective-c sources. Reviewed By: ezgicicek Differential Revision: D23542135 fbshipit-source-id: 8e089666b
4 years ago
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.callMutableCopyObject_zero:x:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.callNewObject_zero:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_caller.m, ArcCaller.dealloc, 0, OnUIThread:false, []
[clang] deal with conditionally-destroyed temporaries Summary: This was left as a TODO before: where to place calls to destructors for C++ temporaries that are only conditionally creating when evaluating an expression. This can happen inside the branches of a conditional operation `b?e:f` or in potentially-short-circuited conditions on the righ-hand side of `&&` and `||` operators. Following the compilation scheme of clang (observed by looking at the generated LLVM bitcode), we instrument the program with "marker" variables, so that for instance `X x = true?X():y;` becomes (following the execution on the true branch): ``` marker1 = 0; // initialize all markers to 0 PRUNE(true) // entering true branch X::X(&temporary); // create temporary... marker1 = 1; // ...triggers setting its marker to 1 X::X(&x, &temporary); // finish expression if (marker1) { X::~X(&temporary); // conditionally destroy the temporary } ``` In this diff, you'll find code for: - associating markers to temporaries that need them - code to initialize markers to 0 before full-expressions - code to conditionally destroy temporaries based on the values of the markers once the full-expression has finished evaluating Reviewed By: da319 Differential Revision: D24954070 fbshipit-source-id: cf15df7f7
4 years ago
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, ArcEnumerator.callMyEnumerator_linear_FP:, (x->elements.length.ub + 1) × (x->elements.length.ub + 1) + (x->elements.length.ub + 1), OnUIThread:false, [{x->elements.length.ub + 1},Call to MyEnumerator.nextObject,Loop,{x->elements.length.ub + 1},Call to MyEnumerator.nextObject,Loop,{x->elements.length.ub + 1},Loop]
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, ArcEnumerator.callMyEnumerator_nextObject_linear:, (x->elements.length.ub + 1), OnUIThread:false, [{x->elements.length.ub + 1},Call to MyEnumerator.nextObject,Loop]
[cost] Add FN test: saving lambda in object field Summary: This diff adds a test, in which autoreleasing lambda is written in an object field, then called later. The test is not analyzed precisely because it cannot follow that a lambda value is written to a field of an object as of now. Reviewed By: ezgicicek Differential Revision: D23843089 fbshipit-source-id: 62ba153aa
4 years ago
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, ArcEnumerator.dealloc, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, ArcEnumerator.makeMyEnumerator_zero:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, MyEnumerator.dealloc, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, MyEnumerator.initWithArray:filter:, 0, OnUIThread:false, []
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, MyEnumerator.nextObject, (self->_enumerator.length + 1) × |self->_filter|, OnUIThread:false, [{self->_enumerator.length + 1},Loop]
[cost] Add FN test: saving lambda in object field Summary: This diff adds a test, in which autoreleasing lambda is written in an object field, then called later. The test is not analyzed precisely because it cannot follow that a lambda value is written to a field of an object as of now. Reviewed By: ezgicicek Differential Revision: D23843089 fbshipit-source-id: 62ba153aa
4 years ago
codetoanalyze/objc/autoreleasepool/arc_enumerator.m, objc_blockArcEnumerator.makeMyEnumerator_zero:_1, 1, OnUIThread:false, [autorelease,Call to NoArcCallee.giveMeObject,Modeled call to NSObject.autorelease]
[cost] Add autorelease models: some methods of NSKeyedUnarchiver Summary: This diff regards some methods of NSKeyedUnarchiver as autorelease, because they may call autorelease. Reviewed By: ezgicicek Differential Revision: D23600232 fbshipit-source-id: a9fc1cc56
4 years ago
codetoanalyze/objc/autoreleasepool/arc_keyed_unarchiver.m, ArcKeyedUnarchiver.callInitForReadingFromData_constant:data:, 1, OnUIThread:false, [autorelease,Modeled call to NSKeyedUnarchiver.initForReadingFromData:error:]
codetoanalyze/objc/autoreleasepool/arc_keyed_unarchiver.m, ArcKeyedUnarchiver.callInitForReadingWithData_constant:data:, 1, OnUIThread:false, [autorelease,Modeled call to NSKeyedUnarchiver.initForReadingWithData:]
codetoanalyze/objc/autoreleasepool/arc_keyed_unarchiver.m, ArcKeyedUnarchiver.callUnarchivedObjectOfClass_constant:data:, 1, OnUIThread:false, [autorelease,Modeled call to NSKeyedUnarchiver.unarchivedObjectOfClass:fromData:error:]
codetoanalyze/objc/autoreleasepool/arc_keyed_unarchiver.m, ArcKeyedUnarchiver.callUnarchivedObjectOfClasses_constant:set:data:, 1, OnUIThread:false, [autorelease,Modeled call to NSKeyedUnarchiver.unarchivedObjectOfClasses:fromData:error:]
codetoanalyze/objc/autoreleasepool/arc_keyed_unarchiver.m, ArcKeyedUnarchiver.dealloc, 0, OnUIThread:false, []
[cost] Fix cost-issues.exp in autoreleasepool Summary: * Updated cost-issues.exp * Added objc_autoreleasepool to Makefile Reviewed By: ezgicicek Differential Revision: D23599735 fbshipit-source-id: f29425efa
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.autorelease_unreachable_zero:, 0, OnUIThread:false, []
[cost] Autoreleasepool size analysis Summary: This diff adds a new experimental checker for detecting size of objects in autorelease pool in ObjC. The basic mechanism is almost the same with the previous cost calculation: * Autorelease pool size is increased at explicit `autorelease` call * Autorelease pool size is set as zero by the `autoreleasepool` block. While it only supports the explicit calls as of now, we will extend the checker to handle more cases in the following diffs. Reviewed By: ezgicicek Differential Revision: D23473145 fbshipit-source-id: 416488176
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.autoreleased_in_autoreleasepool_zero:, 0, OnUIThread:false, []
[cost] Add autorelease models: some methods of NSKeyedUnarchiver Summary: This diff regards some methods of NSKeyedUnarchiver as autorelease, because they may call autorelease. Reviewed By: ezgicicek Differential Revision: D23600232 fbshipit-source-id: a9fc1cc56
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.autoreleased_in_loop_linear:, n, OnUIThread:false, [{n},Loop,autorelease,Call to Basic.call_autorelease_constant,Modeled call to NSObject.autorelease]
[cost] Autoreleasepool size analysis Summary: This diff adds a new experimental checker for detecting size of objects in autorelease pool in ObjC. The basic mechanism is almost the same with the previous cost calculation: * Autorelease pool size is increased at explicit `autorelease` call * Autorelease pool size is set as zero by the `autoreleasepool` block. While it only supports the explicit calls as of now, we will extend the checker to handle more cases in the following diffs. Reviewed By: ezgicicek Differential Revision: D23473145 fbshipit-source-id: 416488176
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.autoreleased_in_loop_nested_zero:, 0, OnUIThread:false, []
[cost] Add autorelease models: some methods of NSKeyedUnarchiver Summary: This diff regards some methods of NSKeyedUnarchiver as autorelease, because they may call autorelease. Reviewed By: ezgicicek Differential Revision: D23600232 fbshipit-source-id: a9fc1cc56
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.autoreleased_in_loop_sequential_constant:, 1, OnUIThread:false, [autorelease,Call to Basic.call_autorelease_constant,Modeled call to NSObject.autorelease]
codetoanalyze/objc/autoreleasepool/basic.m, Basic.autoreleased_in_loop_sequential_linear:, n, OnUIThread:false, [{n},Loop,autorelease,Call to Basic.call_autorelease_constant,Modeled call to NSObject.autorelease]
codetoanalyze/objc/autoreleasepool/basic.m, Basic.call_autorelease_constant, 1, OnUIThread:false, [autorelease,Modeled call to NSObject.autorelease]
[cost] Add model of CFAutorelease Summary: ObjC objects can be added to autorelease pool by `CFAutorelease`. Reviewed By: ezgicicek Differential Revision: D23625632 fbshipit-source-id: 694e5bffb
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.call_cf_autorelease_constant:, 1, OnUIThread:false, [autorelease,Modeled call to CFAutorelease]
[cost] Autoreleasepool size analysis Summary: This diff adds a new experimental checker for detecting size of objects in autorelease pool in ObjC. The basic mechanism is almost the same with the previous cost calculation: * Autorelease pool size is increased at explicit `autorelease` call * Autorelease pool size is set as zero by the `autoreleasepool` block. While it only supports the explicit calls as of now, we will extend the checker to handle more cases in the following diffs. Reviewed By: ezgicicek Differential Revision: D23473145 fbshipit-source-id: 416488176
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.call_no_autorelease_zero, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/basic.m, Basic.dealloc, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/basic.m, Basic.loop_in_autoreleasepool_zero:, 0, OnUIThread:false, []
[cost] Add autorelease models: some methods of NSKeyedUnarchiver Summary: This diff regards some methods of NSKeyedUnarchiver as autorelease, because they may call autorelease. Reviewed By: ezgicicek Differential Revision: D23600232 fbshipit-source-id: a9fc1cc56
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.multiple_autorelease_constants:, 2 + n, OnUIThread:false, [{n},Loop,autorelease,Call to Basic.call_autorelease_constant,Modeled call to NSObject.autorelease]
[cost] Autoreleasepool size analysis Summary: This diff adds a new experimental checker for detecting size of objects in autorelease pool in ObjC. The basic mechanism is almost the same with the previous cost calculation: * Autorelease pool size is increased at explicit `autorelease` call * Autorelease pool size is set as zero by the `autoreleasepool` block. While it only supports the explicit calls as of now, we will extend the checker to handle more cases in the following diffs. Reviewed By: ezgicicek Differential Revision: D23473145 fbshipit-source-id: 416488176
4 years ago
codetoanalyze/objc/autoreleasepool/basic.m, Basic.no_autoreleased_in_loop_zero:, 0, OnUIThread:false, []
[cost] Add tests run with ARC/non-ARC sources Summary: This diff adds some tests run with ARC/non-ARC compiled objective-c sources. Reviewed By: ezgicicek Differential Revision: D23542135 fbshipit-source-id: 8e089666b
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_callee.m, NoArcCallee.allocObject, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_callee.m, NoArcCallee.copyObject:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_callee.m, NoArcCallee.dealloc, 0, OnUIThread:false, []
[cost] Add autorelease models: some methods of NSKeyedUnarchiver Summary: This diff regards some methods of NSKeyedUnarchiver as autorelease, because they may call autorelease. Reviewed By: ezgicicek Differential Revision: D23600232 fbshipit-source-id: a9fc1cc56
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_callee.m, NoArcCallee.giveMeObject, 1, OnUIThread:false, [autorelease,Modeled call to NSObject.autorelease]
[cost] Add tests run with ARC/non-ARC sources Summary: This diff adds some tests run with ARC/non-ARC compiled objective-c sources. Reviewed By: ezgicicek Differential Revision: D23542135 fbshipit-source-id: 8e089666b
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_callee.m, NoArcCallee.mutableCopyObject:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_callee.m, NoArcCallee.newObject, 0, OnUIThread:false, []
[cost] Use prefix convention not returning autoreleased object Summary: By naming convention, methods start with "alloc", "new", "copy", and "mutableCopy" return non-autoreleased object. Let's avoid raising issues in that case. Reviewed By: ezgicicek Differential Revision: D23565512 fbshipit-source-id: e7aa58ea9
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callAllocObject_zero:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callCopyObject_zero:x:, 0, OnUIThread:false, []
[cost] Increase autoreleasepool size when non-ARC call ARC Summary: This diff increases autoreleasepool size when * caller is non-ARC-compiled * callee is ARC-compiled * return type is a pointer to objc object To distinguish non-ARC-/ARC-compiled: * extended `translation_unit_decl_info` to have a boolean field `is_objc_arc_on` * then copied it to `ProcAttributes.t` for each procedures. Reviewed By: ezgicicek Differential Revision: D23565003 fbshipit-source-id: dee22ea82
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveMeInt_zero, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveMeObject_autoreleasepool_zero:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveMeObject_linear:, n, OnUIThread:false, [{n},Loop,autorelease,ARC function call to ArcCallee.giveMeObject from non-ARC caller]
[cost] Ignore tagged pointers in autoreleasepool size Summary: This diff ignores tagged pointers in the autoreleasepool size, since they are not added to the autorelease pool. https://opensource.apple.com/source/objc4/objc4-781/runtime/objc-internal.h.auto.html Reviewed By: ezgicicek Differential Revision: D23626339 fbshipit-source-id: ba9ef4106
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveTaggedPointerDate_zero, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveTaggedPointerIndexPath_zero, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveTaggedPointerIndexSet_zero, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveTaggedPointerNumber_zero, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callGiveTaggedPointerString_zero, 0, OnUIThread:false, []
[cost] Use prefix convention not returning autoreleased object Summary: By naming convention, methods start with "alloc", "new", "copy", and "mutableCopy" return non-autoreleased object. Let's avoid raising issues in that case. Reviewed By: ezgicicek Differential Revision: D23565512 fbshipit-source-id: e7aa58ea9
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callMutableCopyObject_zero:x:, 0, OnUIThread:false, []
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.callNewObject_zero:, 0, OnUIThread:false, []
[cost] Increase autoreleasepool size when non-ARC call ARC Summary: This diff increases autoreleasepool size when * caller is non-ARC-compiled * callee is ARC-compiled * return type is a pointer to objc object To distinguish non-ARC-/ARC-compiled: * extended `translation_unit_decl_info` to have a boolean field `is_objc_arc_on` * then copied it to `ProcAttributes.t` for each procedures. Reviewed By: ezgicicek Differential Revision: D23565003 fbshipit-source-id: dee22ea82
4 years ago
codetoanalyze/objc/autoreleasepool/no_arc_caller.m, NoArcCaller.dealloc, 0, OnUIThread:false, []