pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '43d6c17f29'
${ noResults }
infer_clone/infer/src/checkers/SiofTrace.mli

21 lines
655 B
Raw Normal View History Unescape

[siof] check origin of globals and complain if potential siof Summary: Checker for the Static Initialization Order Fiasco pattern: https://isocpp.org/wiki/faq/ctors#static-init-order 1. Collect all globals (transitively) accessed in any given procedure. 2. Once the interprocedural analysis has finished, look at globals accessed in initializers that do not belong to the current translation unit. Reviewed By: sblackshear Differential Revision: D3780266 fbshipit-source-id: 1d07161
8 years ago
(*
* Copyright (c) 2016 - present Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*)
Divide Utils into Utils, Pp, and IStd Summary: Utils contains definitions intended to be in the global namespace for all of the infer code-base, as well as pretty-printing functions, and assorted utility functions mostly for dealing with files and processes. This diff changes the module opened into the global namespace to IStd (Std conflict with extlib), and moves the pretty-printing definitions from Utils to Pp. Reviewed By: jvillard Differential Revision: D4232457 fbshipit-source-id: 1e070e0
8 years ago
open! IStd
[siof] convert domain to sink trace of pvar's Summary: The Quandary-style traces are too general for checkers like SIOF. This diff adds a "suffix abstraction" of the trace for analyses that just care about sinks. To show how to use it, we add it to SIOF. Note: this diff converts the domain, but isn't actually doing the fancier reporting yet. That will come in a future diff. Reviewed By: jvillard Differential Revision: D4124881 fbshipit-source-id: 5b9fd07
8 years ago
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
include SinkTrace.S with type Sink.Kind.t = Pvar.t
[siof] convert domain to sink trace of pvar's Summary: The Quandary-style traces are too general for checkers like SIOF. This diff adds a "suffix abstraction" of the trace for analyses that just care about sinks. To show how to use it, we add it to SIOF. Note: this diff converts the domain, but isn't actually doing the fancier reporting yet. That will come in a future diff. Reviewed By: jvillard Differential Revision: D4124881 fbshipit-source-id: 5b9fd07
8 years ago
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
module GlobalVar : PrettyPrintable.PrintableOrderedType with type t = Pvar.t
[siof] better error reports using `Errlog.loc_trace`s Summary: This adds generic support for reporting error traces as usual infer issues traces (instead of putting them in the textual description of the error) to Trace.ml and SinkTrace.ml. The siof checker is made to use these new traces, and gets an improved error message mentioning the name of the problematic global as well, which requires a slight API change in Pvar.re. The support in Trace.ml is incomplete: passthroughs are ignored. This missing feature will be needed by Quandary to migrate its error messages. Reviewed By: sblackshear Differential Revision: D4159542 fbshipit-source-id: 8c1101d
8 years ago
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
module GlobalVarSet : PrettyPrintable.PPSet with type elt = Pvar.t
val make_access : Pvar.t -> Location.t -> Sink.t
[siof] better error reports using `Errlog.loc_trace`s Summary: This adds generic support for reporting error traces as usual infer issues traces (instead of putting them in the textual description of the error) to Trace.ml and SinkTrace.ml. The siof checker is made to use these new traces, and gets an improved error message mentioning the name of the problematic global as well, which requires a slight API change in Pvar.re. The support in Trace.ml is incomplete: passthroughs are ignored. This missing feature will be needed by Quandary to migrate its error messages. Reviewed By: sblackshear Differential Revision: D4159542 fbshipit-source-id: 8c1101d
8 years ago
[siof] collate multiple reports at the same line into one Summary: Change the domain of SIOF to be based on sets of pvar * location instead of single pvars. This allows us to group several accesses together. However, we still get different trace elems for different instructions in a proc. We do two things to get around this limitation and get a trace where all accesses within the same proc are grouped together, instead of one trace for each access: 1. A post-processing phase at the end of the analysis of one proc collects all the globals directly accessed in the proc into a single trace elem. 2. When creating the error trace, unpack this set into several trace elements to see each access (at its correct location) separately in the trace. This is a bit hacky and another way would be to extend the API of traces to handle in-procedure accesses natively instead of shoe-horning them. However since SIOF is the only one to use this, it introduces less boilerplate to do it that way for now. Also, a few .mlis for good measure. Reviewed By: sblackshear Differential Revision: D4299070 fbshipit-source-id: 3bbb5c2
8 years ago
val trace_of_error : Location.t -> string -> sink_path -> Errlog.loc_trace_elem list