pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '53b2ec61de'
${ noResults }
infer_clone/infer/tests/codetoanalyze/java/nullsafe-annotation-graph/issues.exp

130 lines
5.2 KiB
Raw Normal View History Unescape

[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, Linters_dummy_method, 12, ERADICATE_ANNOTATION_GRAPH, no_bucket, INFO, [], AnnotationGraph, codetoanalyze.java.nullsafe_annotation_graph
AnnotationGraph:
Annotation point:
id: f0
kind: Field
field_name: fieldA
num_violations: 1
[nullsafe][annotation graph] Add test case for annotation graph Summary: We never tested params dependent on things (tested only things dependend on params). Reviewed By: artempyanykh Differential Revision: D24726858 fbshipit-source-id: a0861cfc3
4 years ago
dependent_point_ids: [f1, p8, p10]
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
Annotation point:
id: f1
kind: Field
field_name: fieldB
num_violations: 1
dependent_point_ids: []
Annotation point:
id: f2
kind: Field
field_name: fieldD
num_violations: 1
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
dependent_point_ids: [m4]
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
Annotation point:
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
id: m4
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
kind: Method
method_info:
method_name: methodA
params: java.lang.String, boolean
access_level: Private
num_violations: 0
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
dependent_point_ids: [m6]
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
Annotation point:
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
id: m6
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
kind: Method
method_info:
method_name: methodB
params:
access_level: Private
num_violations: 0
dependent_point_ids: []
Annotation point:
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
id: m7
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
kind: Method
method_info:
method_name: methodC
params:
access_level: Public
num_violations: 1
dependent_point_ids: []
[nullsafe][annotation graph] Add test case for annotation graph Summary: We never tested params dependent on things (tested only things dependend on params). Reviewed By: artempyanykh Differential Revision: D24726858 fbshipit-source-id: a0861cfc3
4 years ago
Annotation point:
id: p10
kind: Param
method_info:
method_name: methodF
params: java.lang.String, java.lang.String, java.lang.String
access_level: Private
param_num: 2
num_violations: 0
dependent_point_ids: []
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
Annotation point:
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
id: p3
kind: Param
method_info:
method_name: equals
params: java.lang.Object
access_level: Public
param_num: 0
num_violations: 1
dependent_point_ids: []
Annotation point:
id: p5
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
kind: Param
method_info:
method_name: methodA
params: java.lang.String, boolean
access_level: Private
param_num: 0
num_violations: 0
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
dependent_point_ids: [f0, m4]
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
[nullsafe][annotation graph] Add test case for annotation graph Summary: We never tested params dependent on things (tested only things dependend on params). Reviewed By: artempyanykh Differential Revision: D24726858 fbshipit-source-id: a0861cfc3
4 years ago
Annotation point:
id: p8
kind: Param
method_info:
method_name: methodF
params: java.lang.String, java.lang.String, java.lang.String
access_level: Private
param_num: 0
num_violations: 0
dependent_point_ids: []
Annotation point:
id: p9
kind: Param
method_info:
method_name: methodF
params: java.lang.String, java.lang.String, java.lang.String
access_level: Private
param_num: 1
num_violations: 0
dependent_point_ids: []
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
[nullsafe][annotation graph] Support `Object.equals()` Summary: There is a feature in Nullsafe that is interfering with "annotation graph" feature. Because of this we would not detect provisional violations for misuses of params of equals() (They will be recorded as user facing rather than provisional issues). This diff turns this feature off for annotation graph mode. Reviewed By: artempyanykh Differential Revision: D24726655 fbshipit-source-id: 4b7577667
4 years ago
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, Linters_dummy_method, 12, ERADICATE_META_CLASS_NEEDS_IMPROVEMENT, no_bucket, INFO, [], AnnotationGraph, codetoanalyze.java.nullsafe_annotation_graph, issues: 4, curr_mode: "Default"
[nullsafe][annotation graph] Add test case for annotation graph Summary: We never tested params dependent on things (tested only things dependend on params). Reviewed By: artempyanykh Differential Revision: D24726858 fbshipit-source-id: a0861cfc3
4 years ago
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, Linters_dummy_method, 87, ERADICATE_ANNOTATION_GRAPH, no_bucket, INFO, [], SomeExternalClass, codetoanalyze.java.nullsafe_annotation_graph
[nullsafe][annotation graph] Snapshot test for annotation graph Summary: This is a complex enough feature so iterating on it in a safe manner will be useful. Reviewed By: artempyanykh Differential Revision: D24725406 fbshipit-source-id: 81b247143
4 years ago
AnnotationGraph:
Annotation point:
id: p0
kind: Param
method_info:
method_name: doesNotAcceptNull
params: java.lang.String
access_level: Public
param_num: 0
num_violations: 0
dependent_point_ids: []
[nullsafe][annotation graph] Add test case for annotation graph Summary: We never tested params dependent on things (tested only things dependend on params). Reviewed By: artempyanykh Differential Revision: D24726858 fbshipit-source-id: a0861cfc3
4 years ago
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, Linters_dummy_method, 87, ERADICATE_META_CLASS_CAN_BE_NULLSAFE, no_bucket, ADVICE, [Congrats! `SomeExternalClass` is free of nullability issues. Mark it `@Nullsafe(Nullsafe.Mode.LOCAL)` to prevent regressions.], SomeExternalClass, codetoanalyze.java.nullsafe_annotation_graph, issues: 0, curr_mode: "Default", promote_mode: "Strict"
[nullsafe] Change "Field not initialized" error message Summary: `Initializer` annotation is an advanced feature that should be used sparingly. Let's remove it from the error message and hence discourage overuse Reviewed By: ngorogiannis Differential Revision: D27047431 fbshipit-source-id: 8eb7ba7ab
4 years ago
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.<init>(), 0, ERADICATE_FIELD_NOT_INITIALIZED, no_bucket, WARNING, [Field `fieldB` is declared non-nullable, so it should be initialized in the constructor], AnnotationGraph, codetoanalyze.java.nullsafe_annotation_graph, field:codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.fieldB
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.<init>(), 0, ERADICATE_FIELD_NOT_INITIALIZED, no_bucket, WARNING, [Field `fieldA` is declared non-nullable, so it should be initialized in the constructor], AnnotationGraph, codetoanalyze.java.nullsafe_annotation_graph, field:codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.fieldA
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.<init>(), 0, ERADICATE_FIELD_NOT_INITIALIZED, no_bucket, WARNING, [Field `fieldD` is declared non-nullable, so it should be initialized in the constructor], AnnotationGraph, codetoanalyze.java.nullsafe_annotation_graph, field:codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.fieldD
[nullsafe] Record correct param index in json Summary: In all other places, we index params from 0, but accidentally recorded the wrong number in json. It was because of the confusion between index and user-visible param position that we show for the user message. This diff fixes it: now we use 0-based indices internally (but of course still report 1-based ones in the error message). Reviewed By: artempyanykh Differential Revision: D24916878 fbshipit-source-id: 45532c5ff
4 years ago
codetoanalyze/java/nullsafe-annotation-graph/AnnotationGraph.java, codetoanalyze.java.nullsafe_annotation_graph.AnnotationGraph.equals(java.lang.Object):boolean, 0, ERADICATE_INCONSISTENT_SUBCLASS_PARAMETER_ANNOTATION, no_bucket, WARNING, [Parameter `obj` is missing `@Nullable` declaration: according to the Java Specification, for any object `x` call `x.equals(null)` should properly return false.], AnnotationGraph, codetoanalyze.java.nullsafe_annotation_graph, inconsistent_param_index:0