pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '5599f078ee'
${ noResults }
infer_clone/infer/models/Makefile

49 lines
1.1 KiB
Raw Normal View History Unescape

migrate infer/models/Makefile Summary: public Use autoconf's detection of xcode-select to decide whether to build the ObjC models or not. Reviewed By: jeremydubreil Differential Revision: D2703864 fb-gh-sync-id: e6dadca
9 years ago
# Copyright (c) 2015 - present Facebook, Inc.
# All rights reserved.
#
# This source code is licensed under the BSD style license found in the
# LICENSE file in the root directory of this source tree. An additional grant
# of patent rights can be found in the PATENTS file in the same directory.
ROOT_DIR = ../..
include $(ROOT_DIR)/Makefile.config
C_MODELS_DIR = c
CPP_MODELS_DIR = cpp
JAVA_MODELS_DIR = java
OBJC_MODELS_DIR = objc
CLANG_SUBDIRS = $(C_MODELS_DIR) $(CPP_MODELS_DIR)
move all config variables to Makefile.config.in Summary: Hardcoding `variable@` in Makefiles is Bad™ because it prevents the users from overwriting them easily with `make variable="my custom value"`. The right way to do it is thus: ``` variable = variable@ # then use $(variable) everywhere ``` This diff puts all the `variable = variable@` lines in Makefile.config.in, and changes every occurrence of a `variable@` to `$(variable)` everywhere else. I mostly automated generating this diff. Here are the steps I did: - find out which `variable@`s we use: find . -name 'Makefile*' -exec grep -e '@[^@ []\+@' -o -h \{\} \+ | sort | uniq > config_variables - write this `replace.sh` script to replace every `variable@` with `$(variable)`: ``` #!/bin/sh config_vars_file=$1 shift for line in $(cat $config_vars_file); do var=$(echo $line | tr -d @) sed -i -e "s/$line/\$($var)/g" $@ > /dev/null done ``` - run the script as such: find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \) -exec ./replace.sh config_variables \{\} \+ - put all the `VARIABLE = VARIABLE@` lines in Makefile.config.in - move all `Makefile.in` to `Makefile`, since they don't need to be generated by `./configure` anymore: ``` for i in $(find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \)); do \ rm $(dirname $i)/$(basename $i .in) && git mv $i $(dirname $i)/$(basename $i .in) ; \ done ``` - delete all Makefile except Makefile.config from configure.ac - manually inspect and remove remaining instances of `VAR = $(VAR)` in makefiles, looking at the output of `git grep '^\(\w\+\) = $(\1)'` Reviewed By: jberdine Differential Revision: D3358379 fbshipit-source-id: 5d37f02
9 years ago
ifneq (no, $(XCODE_SELECT))
migrate infer/models/Makefile Summary: public Use autoconf's detection of xcode-select to decide whether to build the ObjC models or not. Reviewed By: jeremydubreil Differential Revision: D2703864 fb-gh-sync-id: e6dadca
9 years ago
CLANG_SUBDIRS += $(OBJC_MODELS_DIR)
endif
build in one directory only Summary: Build everything at once all the time. This removes the need for multiple directories, which were a hassle to begin with. This removes the `java`, `clang`, and `llvm` targets in various Makefiles as well. Reviewed By: jberdine Differential Revision: D3317230 fbshipit-source-id: 8e86140
9 years ago
all:
move all config variables to Makefile.config.in Summary: Hardcoding `variable@` in Makefiles is Bad™ because it prevents the users from overwriting them easily with `make variable="my custom value"`. The right way to do it is thus: ``` variable = variable@ # then use $(variable) everywhere ``` This diff puts all the `variable = variable@` lines in Makefile.config.in, and changes every occurrence of a `variable@` to `$(variable)` everywhere else. I mostly automated generating this diff. Here are the steps I did: - find out which `variable@`s we use: find . -name 'Makefile*' -exec grep -e '@[^@ []\+@' -o -h \{\} \+ | sort | uniq > config_variables - write this `replace.sh` script to replace every `variable@` with `$(variable)`: ``` #!/bin/sh config_vars_file=$1 shift for line in $(cat $config_vars_file); do var=$(echo $line | tr -d @) sed -i -e "s/$line/\$($var)/g" $@ > /dev/null done ``` - run the script as such: find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \) -exec ./replace.sh config_variables \{\} \+ - put all the `VARIABLE = VARIABLE@` lines in Makefile.config.in - move all `Makefile.in` to `Makefile`, since they don't need to be generated by `./configure` anymore: ``` for i in $(find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \)); do \ rm $(dirname $i)/$(basename $i .in) && git mv $i $(dirname $i)/$(basename $i .in) ; \ done ``` - delete all Makefile except Makefile.config from configure.ac - manually inspect and remove remaining instances of `VAR = $(VAR)` in makefiles, looking at the output of `git grep '^\(\w\+\) = $(\1)'` Reviewed By: jberdine Differential Revision: D3358379 fbshipit-source-id: 5d37f02
9 years ago
ifeq ($(BUILD_C_ANALYZERS),yes)
build in one directory only Summary: Build everything at once all the time. This removes the need for multiple directories, which were a hassle to begin with. This removes the `java`, `clang`, and `llvm` targets in various Makefiles as well. Reviewed By: jberdine Differential Revision: D3317230 fbshipit-source-id: 8e86140
9 years ago
all: clang
endif
move all config variables to Makefile.config.in Summary: Hardcoding `variable@` in Makefiles is Bad™ because it prevents the users from overwriting them easily with `make variable="my custom value"`. The right way to do it is thus: ``` variable = variable@ # then use $(variable) everywhere ``` This diff puts all the `variable = variable@` lines in Makefile.config.in, and changes every occurrence of a `variable@` to `$(variable)` everywhere else. I mostly automated generating this diff. Here are the steps I did: - find out which `variable@`s we use: find . -name 'Makefile*' -exec grep -e '@[^@ []\+@' -o -h \{\} \+ | sort | uniq > config_variables - write this `replace.sh` script to replace every `variable@` with `$(variable)`: ``` #!/bin/sh config_vars_file=$1 shift for line in $(cat $config_vars_file); do var=$(echo $line | tr -d @) sed -i -e "s/$line/\$($var)/g" $@ > /dev/null done ``` - run the script as such: find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \) -exec ./replace.sh config_variables \{\} \+ - put all the `VARIABLE = VARIABLE@` lines in Makefile.config.in - move all `Makefile.in` to `Makefile`, since they don't need to be generated by `./configure` anymore: ``` for i in $(find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \)); do \ rm $(dirname $i)/$(basename $i .in) && git mv $i $(dirname $i)/$(basename $i .in) ; \ done ``` - delete all Makefile except Makefile.config from configure.ac - manually inspect and remove remaining instances of `VAR = $(VAR)` in makefiles, looking at the output of `git grep '^\(\w\+\) = $(\1)'` Reviewed By: jberdine Differential Revision: D3358379 fbshipit-source-id: 5d37f02
9 years ago
ifeq ($(BUILD_JAVA_ANALYZERS),yes)
build in one directory only Summary: Build everything at once all the time. This removes the need for multiple directories, which were a hassle to begin with. This removes the `java`, `clang`, and `llvm` targets in various Makefiles as well. Reviewed By: jberdine Differential Revision: D3317230 fbshipit-source-id: 8e86140
9 years ago
all: java
endif
[make] make infer/src/Makefile less phony Reviewed By: jberdine Differential Revision: D4319515 fbshipit-source-id: 607022c
8 years ago
.PHONY: java clang clean clean_specs $(CLANG_SUBDIRS)
migrate infer/models/Makefile Summary: public Use autoconf's detection of xcode-select to decide whether to build the ObjC models or not. Reviewed By: jeremydubreil Differential Revision: D2703864 fb-gh-sync-id: e6dadca
9 years ago
Remove specs before rebuilding models Summary: Specs files can become stale and cause crashes if the serialized format changes. It is unclear how to add the right dependencies to the existing targets, so this patch just removes them. Perhaps when the specs are built we should drop an empty file to time-stamp them, and add a target that depends on e.g. InferAnalyze and produces that file, and then add dependencies on it. Reviewed By: jvillard Differential Revision: D3358460 fbshipit-source-id: d8aee48
9 years ago
clean_specs:
$(REMOVE) $(SPECS_LIB_DIR)/*.specs
migrate infer/models/Makefile Summary: public Use autoconf's detection of xcode-select to decide whether to build the ObjC models or not. Reviewed By: jeremydubreil Differential Revision: D2703864 fb-gh-sync-id: e6dadca
9 years ago
Remove specs before rebuilding models Summary: Specs files can become stale and cause crashes if the serialized format changes. It is unclear how to add the right dependencies to the existing targets, so this patch just removes them. Perhaps when the specs are built we should drop an empty file to time-stamp them, and add a target that depends on e.g. InferAnalyze and produces that file, and then add dependencies on it. Reviewed By: jvillard Differential Revision: D3358460 fbshipit-source-id: d8aee48
9 years ago
$(CLANG_SUBDIRS):
[make] print @ commands when passed VERBOSE=1 Summary: It can be useful when debugging infer or the Makefiles themselves to see what `make` is doing. Instead of editing Makefiles to remove `@` now you can `make VERBOSE=1`. This is just `git ls-files | grep -e Makefile -e '.*\.make' | xargs sed -e 's/^\t@/\t$(QUIET)/' -i`, and adding the definition of `QUIET` to Makefile.config. Reviewed By: jeremydubreil Differential Revision: D4779115 fbshipit-source-id: e6e4642
8 years ago
$(QUIET)$(MAKE) -C $@ install
migrate infer/models/Makefile Summary: public Use autoconf's detection of xcode-select to decide whether to build the ObjC models or not. Reviewed By: jeremydubreil Differential Revision: D2703864 fb-gh-sync-id: e6dadca
9 years ago
[make] do not confuse the jobserver Summary: Turns out that swapping stdout and stderr using a temporary fd 3 was screwing up with make's jobserver, who also uses fd 3! Also, infer is partly to blame as it also calls `make`. Unsetting `MAKEFLAGS` in infer tells `make` that the way infer calls `make` is independent from parent `make` invocations. Also, simplify the rules for direct tests and build system tests. Reviewed By: jberdine Differential Revision: D4328979 fbshipit-source-id: 96818e8
8 years ago
clang: $(CLANG_SUBDIRS)
Remove specs before rebuilding models Summary: Specs files can become stale and cause crashes if the serialized format changes. It is unclear how to add the right dependencies to the existing targets, so this patch just removes them. Perhaps when the specs are built we should drop an empty file to time-stamp them, and add a target that depends on e.g. InferAnalyze and produces that file, and then add dependencies on it. Reviewed By: jvillard Differential Revision: D3358460 fbshipit-source-id: d8aee48
9 years ago
[make] make infer/src/Makefile less phony Reviewed By: jberdine Differential Revision: D4319515 fbshipit-source-id: 607022c
8 years ago
java:
[make] print @ commands when passed VERBOSE=1 Summary: It can be useful when debugging infer or the Makefiles themselves to see what `make` is doing. Instead of editing Makefiles to remove `@` now you can `make VERBOSE=1`. This is just `git ls-files | grep -e Makefile -e '.*\.make' | xargs sed -e 's/^\t@/\t$(QUIET)/' -i`, and adding the definition of `QUIET` to Makefile.config. Reviewed By: jeremydubreil Differential Revision: D4779115 fbshipit-source-id: e6e4642
8 years ago
$(QUIET)$(MAKE) -C $@ install
Remove specs before rebuilding models Summary: Specs files can become stale and cause crashes if the serialized format changes. It is unclear how to add the right dependencies to the existing targets, so this patch just removes them. Perhaps when the specs are built we should drop an empty file to time-stamp them, and add a target that depends on e.g. InferAnalyze and produces that file, and then add dependencies on it. Reviewed By: jvillard Differential Revision: D3358460 fbshipit-source-id: d8aee48
9 years ago
clean: clean_specs
[make] print @ commands when passed VERBOSE=1 Summary: It can be useful when debugging infer or the Makefiles themselves to see what `make` is doing. Instead of editing Makefiles to remove `@` now you can `make VERBOSE=1`. This is just `git ls-files | grep -e Makefile -e '.*\.make' | xargs sed -e 's/^\t@/\t$(QUIET)/' -i`, and adding the definition of `QUIET` to Makefile.config. Reviewed By: jeremydubreil Differential Revision: D4779115 fbshipit-source-id: e6e4642
8 years ago
$(QUIET)$(MAKE) -C $(JAVA_MODELS_DIR) clean
$(QUIET)$(MAKE) -C $(C_MODELS_DIR) clean
$(QUIET)$(MAKE) -C $(CPP_MODELS_DIR) clean
move all config variables to Makefile.config.in Summary: Hardcoding `variable@` in Makefiles is Bad™ because it prevents the users from overwriting them easily with `make variable="my custom value"`. The right way to do it is thus: ``` variable = variable@ # then use $(variable) everywhere ``` This diff puts all the `variable = variable@` lines in Makefile.config.in, and changes every occurrence of a `variable@` to `$(variable)` everywhere else. I mostly automated generating this diff. Here are the steps I did: - find out which `variable@`s we use: find . -name 'Makefile*' -exec grep -e '@[^@ []\+@' -o -h \{\} \+ | sort | uniq > config_variables - write this `replace.sh` script to replace every `variable@` with `$(variable)`: ``` #!/bin/sh config_vars_file=$1 shift for line in $(cat $config_vars_file); do var=$(echo $line | tr -d @) sed -i -e "s/$line/\$($var)/g" $@ > /dev/null done ``` - run the script as such: find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \) -exec ./replace.sh config_variables \{\} \+ - put all the `VARIABLE = VARIABLE@` lines in Makefile.config.in - move all `Makefile.in` to `Makefile`, since they don't need to be generated by `./configure` anymore: ``` for i in $(find . -name 'Makefile.*in' \( -not -wholename './Makefile.config.in' \)); do \ rm $(dirname $i)/$(basename $i .in) && git mv $i $(dirname $i)/$(basename $i .in) ; \ done ``` - delete all Makefile except Makefile.config from configure.ac - manually inspect and remove remaining instances of `VAR = $(VAR)` in makefiles, looking at the output of `git grep '^\(\w\+\) = $(\1)'` Reviewed By: jberdine Differential Revision: D3358379 fbshipit-source-id: 5d37f02
9 years ago
ifneq (no, $(XCODE_SELECT))
[make] print @ commands when passed VERBOSE=1 Summary: It can be useful when debugging infer or the Makefiles themselves to see what `make` is doing. Instead of editing Makefiles to remove `@` now you can `make VERBOSE=1`. This is just `git ls-files | grep -e Makefile -e '.*\.make' | xargs sed -e 's/^\t@/\t$(QUIET)/' -i`, and adding the definition of `QUIET` to Makefile.config. Reviewed By: jeremydubreil Differential Revision: D4779115 fbshipit-source-id: e6e4642
8 years ago
$(QUIET)$(MAKE) -C $(OBJC_MODELS_DIR) clean
migrate infer/models/Makefile Summary: public Use autoconf's detection of xcode-select to decide whether to build the ObjC models or not. Reviewed By: jeremydubreil Differential Revision: D2703864 fb-gh-sync-id: e6dadca
9 years ago
endif