pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '581487ec61'
${ noResults }
infer_clone/infer/tests/codetoanalyze/java/hoisting/issues.exp

77 lines
16 KiB
Raw Normal View History Unescape

[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/ByteBufferTest.java, ByteBufferTest$ByteBuffer.remaining():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int ByteBufferTest$ByteBuffer.remaining()]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.array_store_hoist(int,int[]):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 117 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.bar(int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int Hoist.bar(int)]
codetoanalyze/java/hoisting/Hoist.java, Hoist.clash_function_calls_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.clash_function_calls_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.clash_function_calls_hoist(int):void, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 26 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.dep_not_invariant_dont_hoist(int,int[]):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.dep_not_invariant_dont_hoist(int,int[])]
codetoanalyze/java/hoisting/Hoist.java, Hoist.dumb_foo():void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.dumb_foo()]
codetoanalyze/java/hoisting/Hoist.java, Hoist.foo(int,int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int Hoist.foo(int,int)]
codetoanalyze/java/hoisting/Hoist.java, Hoist.get_array_length_dont_hoist(int[]):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.get_array_length_dont_hoist(int[])]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.get_array_length_dont_hoist(int[]):void, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to __get_array_length at line 157 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.instanceof_dont_hoist(Hoist$EmptyFoo):boolean, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function boolean Hoist.instanceof_dont_hoist(Hoist$EmptyFoo)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.instanceof_dont_hoist(Hoist$EmptyFoo):boolean, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to __instanceof at line 171 is loop-invariant]
codetoanalyze/java/hoisting/Hoist.java, Hoist.legit_hoist(int,int[]):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 73 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.loop_guard_hoist(int,int[]):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.loop_guard_hoist(int,int[])]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.loop_guard_hoist(int,int[]):void, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 65 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.nested_loop_dont_hoist(int,int,int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.nested_loop_dont_hoist(int,int,int)]
codetoanalyze/java/hoisting/Hoist.java, Hoist.nested_loop_hoist(int,int,int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.nested_loop_hoist(int,int,int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.nested_loop_hoist(int,int,int):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 127 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.new_dont_hoist(java.util.ArrayList):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.new_dont_hoist(ArrayList)]
codetoanalyze/java/hoisting/Hoist.java, Hoist.not_guaranteed_to_execute_dont_hoist(int,int,int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.not_guaranteed_to_execute_dont_hoist(int,int,int)]
codetoanalyze/java/hoisting/Hoist.java, Hoist.reassigned_temp_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.reassigned_temp_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.reassigned_temp_hoist(int):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 45 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.two_function_call_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.two_function_call_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.two_function_call_hoist(int):void, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.bar(int) at line 35 is loop-invariant]
codetoanalyze/java/hoisting/Hoist.java, Hoist.two_function_call_hoist(int):void, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 35 is loop-invariant]
codetoanalyze/java/hoisting/Hoist.java, Hoist.used_in_loop_body_before_def_temp_hoist(int,int[]):void, 6, INVARIANT_CALL, no_bucket, ERROR, [The call to int Hoist.foo(int,int) at line 57 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.void_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.void_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.void_hoist(int):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to void Hoist.dumb_foo() at line 183 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/Hoist.java, Hoist.x_not_invariant_dont_hoist(int,int,int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void Hoist.x_not_invariant_dont_hoist(int,int,int)]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal$Foo.read_global():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistGlobal$Foo.read_global()]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal$Foo.return_zero():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistGlobal$Foo.return_zero()]
[cost][loop-invariance] Do not invalidate pure functions Reviewed By: skcho Differential Revision: D23051880 fbshipit-source-id: b0cee1366
4 years ago
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.global_modification_dont_hoist_FP(int):int, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistGlobal.read_global() at line 41 is loop-invariant]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.global_modification_hoist(java.util.ArrayList):int, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to int ArrayList.size() at line 51 is loop-invariant]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.global_modification_hoist(java.util.ArrayList):int, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistGlobal.return_one() at line 52 is loop-invariant]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.processModulesDirectory_dont_hoist_FP(java.util.Set,java.lang.String[]):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to boolean Set.contains(Object) at line 70 is loop-invariant]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.processModulesDirectory_hoist(java.util.Set,java.lang.String[]):void, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to boolean Set.contains(Object) at line 90 is loop-invariant]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.processModulesDirectory_param_dont_hoist_FP(java.util.Set,java.lang.String[],AppModuleFileInfo,AppModuleFileInfo):void, 8, INVARIANT_CALL, no_bucket, ERROR, [The call to boolean Set.contains(Object) at line 82 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.read_global():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistGlobal.read_global()]
codetoanalyze/java/hoisting/HoistGlobal.java, HoistGlobal.return_one():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistGlobal.return_one()]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.deep_modification_dont_hoist(int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect$Test.deep_modification_dont_hoist(int)]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.foo(int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect$Test.foo(int)]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.get_sum_test(HoistIndirect$Test,int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect$Test.get_sum_test(HoistIndirect$Test,int)]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.get_test(HoistIndirect$Test):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect$Test.get_test(HoistIndirect$Test)]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.indirect_modification_hoist(int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect$Test.indirect_modification_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.indirect_modification_hoist(int):int, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect$Test.foo(int) at line 72 is loop-invariant]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.indirect_modification_only_second_call_hoist(int,HoistIndirect$Test,HoistIndirect$Test):int, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect$Test.get_test(HoistIndirect$Test) at line 86 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect$Test.return_only(HoistIndirect$Test):HoistIndirect$Test, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function HoistIndirect$Test HoistIndirect$Test.return_only(HoistIndirect$Test)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.arg_modification_hoist(int,HoistIndirect$Test):int, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect.get() at line 133 is loop-invariant]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.direct_this_modification_dont_hoist_FP(int):int, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect.get() at line 115 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.double_me(int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect.double_me(int)]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.get():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect.get()]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.get_ith(int,int[]):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect.get_ith(int,int[])]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.independent_hoist(int,HoistIndirect$Test):int, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect$Test.foo(int) at line 160 is loop-invariant]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.irvar_independent_hoist(int[][],int,int[]):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect.double_me(int) at line 210 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.regionFirst(int[]):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect.regionFirst(int[])]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.return_zero():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistIndirect.return_zero()]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.this_modification_outside_hoist(int):int, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect.get() at line 125 is loop-invariant]
codetoanalyze/java/hoisting/HoistIndirect.java, HoistIndirect.unmodified_arg_hoist(int[][],int,int[]):void, 4, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistIndirect.regionFirst(int[]) at line 220 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistInvalidate.java, HoistInvalidate$Item.while_dont_hoist(HoistInvalidate$Item,HoistInvalidate$Item):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistInvalidate$Item.while_dont_hoist(HoistInvalidate$Item,HoistInvalidate$Item)]
codetoanalyze/java/hoisting/HoistInvalidate.java, HoistInvalidate.get_length(int[]):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistInvalidate.get_length(int[])]
codetoanalyze/java/hoisting/HoistInvalidate.java, HoistInvalidate.get_x(int[]):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistInvalidate.get_x(int[])]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistInvalidate.java, HoistInvalidate.loop_indirect_hoist(java.util.ArrayList,int,int[]):void, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistInvalidate.get_length(int[]) at line 52 is loop-invariant]
codetoanalyze/java/hoisting/HoistModeled.java, HoistModeled.call_contains_pure_hoist_FN(int,java.util.ArrayList):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to Integer Integer.valueOf(int) at line 50 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistModeled.java, HoistModeled.deserialize_hoist(com.fasterxml.jackson.databind.JsonDeserializer,com.fasterxml.jackson.core.JsonParser,com.fasterxml.jackson.databind.DeserializationContext):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.deserialize_hoist(JsonDeserializer,JsonParser,DeserializationContext)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistModeled.java, HoistModeled.deserialize_hoist(com.fasterxml.jackson.databind.JsonDeserializer,com.fasterxml.jackson.core.JsonParser,com.fasterxml.jackson.databind.DeserializationContext):void, 8, INVARIANT_CALL, no_bucket, ERROR, [The call to Object JsonDeserializer.deserialize(JsonParser,DeserializationContext) at line 33 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistModeled.java, HoistModeled.list_contains_hoist(java.util.List,java.lang.String):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistModeled.list_contains_hoist(List,String)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistModeled.java, HoistModeled.list_contains_hoist(java.util.List,java.lang.String):int, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to String String.substring(int,int) at line 18 is loop-invariant]
codetoanalyze/java/hoisting/HoistModeled.java, HoistModeled.list_contains_hoist(java.util.List,java.lang.String):int, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to boolean List.contains(Object) at line 18 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.avg(java.util.ArrayList):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistNoIndirectMod.avg(ArrayList)]
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.calcNext():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistNoIndirectMod.calcNext()]
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.calcSame():int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistNoIndirectMod.calcSame()]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.increment_dont_hoist_FP(int):int, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistNoIndirectMod.calcNext() at line 28 is loop-invariant]
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.modify_and_increment_dont_hoist_FP(int):int, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistNoIndirectMod.calcNext() at line 36 is loop-invariant]
[java] bug fix for type translation Summary: `JavaSplitName` is used to represent Java types (in `Procname` in particular). The type itself is a pair of string (an optional package qualifier) and a "type name" (the quotes are there because it may contain array qualifiers). For example `java.lang.Object[][]` should be represented as ``` {package=Some "java.lang"; typename="Object[][]"} ``` The constructor `make` was misused to construct instead types such as ``` {package=None; typename="java.lang.Object[][]"}` ``` This is evident when we print the return type of a `Procname` non-verbosely (the default), but we still see the package qualifier. Obviously this is not just a pretty-printing bug, the values were themselves wrong. The fix is to use the `of_string` constructor which will parse the package and separate it correctly. Another bug (in response to this one) had to be fixed in `Procname.is_vararg` to maintain behaviour in Nullsafe and Quandary. Reviewed By: mityal Differential Revision: D20394146 fbshipit-source-id: 4633902eb
5 years ago
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.no_mod_hoist(java.lang.Integer[],java.util.ArrayList):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistNoIndirectMod.no_mod_hoist(Integer[],ArrayList)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoisting/HoistNoIndirectMod.java, HoistNoIndirectMod.no_mod_hoist(java.lang.Integer[],java.util.ArrayList):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistNoIndirectMod.avg(ArrayList) at line 77 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoisting/HoistUnmodeled.java, HoistUnmodeled.harmless_pure():void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistUnmodeled.harmless_pure()]