|
|
|
(*
|
|
|
|
* Copyright (c) 2013 - present Facebook, Inc.
|
|
|
|
* All rights reserved.
|
|
|
|
*
|
|
|
|
* This source code is licensed under the BSD style license found in the
|
|
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
*)
|
|
|
|
|
|
|
|
open! IStd
|
|
|
|
|
|
|
|
(** Methods for creating a procdesc from a method or function declaration
|
|
|
|
and for resolving a method call and finding the right callee *)
|
|
|
|
|
|
|
|
module L = Logging
|
|
|
|
|
|
|
|
exception Invalid_declaration
|
|
|
|
|
|
|
|
(** When the methoc call is MCStatic, means that it is a class method. When it is MCVirtual, it
|
|
|
|
means that it is an instance method and that the method to be called will be determined at
|
|
|
|
runtime. If it is MCNoVirtual it means that it is an instance method but that the method to be
|
|
|
|
called will be determined at compile time *)
|
|
|
|
type method_call_type =
|
|
|
|
| MCVirtual
|
|
|
|
| MCNoVirtual
|
|
|
|
| MCStatic [@@deriving compare]
|
|
|
|
|
|
|
|
let equal_method_call_type = [%compare.equal : method_call_type]
|
|
|
|
|
|
|
|
type function_method_decl_info =
|
|
|
|
| Func_decl_info of Clang_ast_t.function_decl_info * Clang_ast_t.qual_type
|
|
|
|
| Cpp_Meth_decl_info of Clang_ast_t.function_decl_info * Clang_ast_t.cxx_method_decl_info * Clang_ast_t.pointer * Clang_ast_t.qual_type
|
|
|
|
| ObjC_Meth_decl_info of Clang_ast_t.obj_c_method_decl_info * Clang_ast_t.pointer
|
|
|
|
| Block_decl_info of Clang_ast_t.block_decl_info * Clang_ast_t.qual_type * CContext.t
|
|
|
|
|
|
|
|
let is_instance_method function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Func_decl_info _ | Block_decl_info _ -> false
|
|
|
|
| Cpp_Meth_decl_info (_, method_decl_info, _, _) ->
|
|
|
|
not method_decl_info.Clang_ast_t.xmdi_is_static
|
|
|
|
| ObjC_Meth_decl_info (method_decl_info, _) ->
|
|
|
|
method_decl_info.Clang_ast_t.omdi_is_instance_method
|
|
|
|
|
|
|
|
let get_original_return_type function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Func_decl_info (_, typ)
|
|
|
|
| Cpp_Meth_decl_info (_, _, _, typ)
|
|
|
|
| Block_decl_info (_, typ, _) -> CType.return_type_of_function_type typ
|
|
|
|
| ObjC_Meth_decl_info (method_decl_info, _) -> method_decl_info.Clang_ast_t.omdi_result_type
|
|
|
|
|
|
|
|
let get_class_param function_method_decl_info =
|
|
|
|
if (is_instance_method function_method_decl_info) then
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Cpp_Meth_decl_info (_, _, class_decl_ptr, _) ->
|
|
|
|
let class_type = CAst_utils.qual_type_of_decl_ptr class_decl_ptr in
|
|
|
|
[(Mangled.from_string CFrontend_config.this, class_type)]
|
|
|
|
| ObjC_Meth_decl_info (_, class_decl_ptr) ->
|
|
|
|
let class_type = CAst_utils.qual_type_of_decl_ptr class_decl_ptr in
|
|
|
|
[(Mangled.from_string CFrontend_config.self, class_type)]
|
|
|
|
| _ -> []
|
|
|
|
else []
|
|
|
|
|
|
|
|
|
|
|
|
let should_add_return_param return_type ~is_objc_method =
|
|
|
|
match return_type.Typ.desc with
|
|
|
|
| Tstruct _ -> not is_objc_method
|
|
|
|
| _ -> false
|
|
|
|
|
|
|
|
let is_objc_method function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| ObjC_Meth_decl_info _ -> true
|
|
|
|
| _ -> false
|
|
|
|
|
|
|
|
let get_return_param tenv function_method_decl_info =
|
|
|
|
let is_objc_method = is_objc_method function_method_decl_info in
|
|
|
|
let return_qual_type = get_original_return_type function_method_decl_info in
|
|
|
|
let return_typ = CType_decl.qual_type_to_sil_type tenv return_qual_type in
|
|
|
|
if should_add_return_param return_typ ~is_objc_method then
|
|
|
|
[(Mangled.from_string CFrontend_config.return_param,
|
|
|
|
Ast_expressions.create_pointer_qual_type return_qual_type)]
|
|
|
|
else
|
|
|
|
[]
|
|
|
|
|
|
|
|
let get_param_decls function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Func_decl_info (function_decl_info, _)
|
|
|
|
| Cpp_Meth_decl_info (function_decl_info, _, _, _) ->
|
|
|
|
function_decl_info.Clang_ast_t.fdi_parameters
|
|
|
|
| ObjC_Meth_decl_info (method_decl_info, _) -> method_decl_info.Clang_ast_t.omdi_parameters
|
|
|
|
| Block_decl_info (block_decl_info, _, _) -> block_decl_info.Clang_ast_t.bdi_parameters
|
|
|
|
|
|
|
|
let get_language trans_unit_ctx function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Func_decl_info (_, _) -> trans_unit_ctx.CFrontend_config.lang
|
|
|
|
| Cpp_Meth_decl_info _ -> CFrontend_config.CPP
|
|
|
|
| ObjC_Meth_decl_info _ -> CFrontend_config.ObjC
|
|
|
|
| Block_decl_info _ -> CFrontend_config.ObjC
|
|
|
|
|
|
|
|
let is_cpp_virtual function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Cpp_Meth_decl_info (_, mdi, _, _) -> mdi.Clang_ast_t.xmdi_is_virtual
|
|
|
|
| _ -> false
|
|
|
|
|
|
|
|
let is_cpp_nothrow function_method_decl_info =
|
|
|
|
match function_method_decl_info with
|
|
|
|
| Func_decl_info (fdi, _)
|
|
|
|
| Cpp_Meth_decl_info (fdi, _, _, _) ->
|
|
|
|
fdi.Clang_ast_t.fdi_is_no_throw
|
|
|
|
| _ -> false
|
|
|
|
|
|
|
|
(** Returns parameters of a function/method. They will have following order:
|
|
|
|
1. self/this parameter (optional, only for methods)
|
|
|
|
2. normal parameters
|
|
|
|
3. return parameter (optional) *)
|
|
|
|
let get_parameters trans_unit_ctx tenv function_method_decl_info =
|
|
|
|
let par_to_ms_par par =
|
|
|
|
match par with
|
|
|
|
| Clang_ast_t.ParmVarDecl (_, name_info, qt, var_decl_info) ->
|
|
|
|
let _, mangled = CGeneral_utils.get_var_name_mangled name_info var_decl_info in
|
|
|
|
let param_typ = CType_decl.qual_type_to_sil_type tenv qt in
|
|
|
|
let new_qt =
|
|
|
|
match param_typ.Typ.desc with
|
|
|
|
| Tstruct _ when CGeneral_utils.is_cpp_translation trans_unit_ctx ->
|
|
|
|
Ast_expressions.create_reference_qual_type qt
|
|
|
|
| _ -> qt in
|
|
|
|
(mangled, new_qt)
|
|
|
|
| _ -> assert false in
|
|
|
|
let pars = List.map ~f:par_to_ms_par (get_param_decls function_method_decl_info) in
|
|
|
|
get_class_param function_method_decl_info @ pars @ get_return_param tenv function_method_decl_info
|
|
|
|
|
|
|
|
(** get return type of the function and optionally type of function's return parameter *)
|
|
|
|
let get_return_val_and_param_types tenv function_method_decl_info =
|
|
|
|
let return_qual_type = get_original_return_type function_method_decl_info in
|
|
|
|
let return_typ = CType_decl.qual_type_to_sil_type tenv return_qual_type in
|
|
|
|
let is_objc_method = is_objc_method function_method_decl_info in
|
|
|
|
if should_add_return_param return_typ ~is_objc_method then
|
|
|
|
Ast_expressions.create_void_type, Some (CType.add_pointer_to_typ return_typ)
|
|
|
|
else return_qual_type, None
|
|
|
|
|
|
|
|
let build_method_signature trans_unit_ctx tenv decl_info procname function_method_decl_info
|
|
|
|
parent_pointer pointer_to_property_opt =
|
|
|
|
let source_range = decl_info.Clang_ast_t.di_source_range in
|
|
|
|
let tp, return_param_type_opt = get_return_val_and_param_types tenv function_method_decl_info in
|
|
|
|
let is_instance_method = is_instance_method function_method_decl_info in
|
|
|
|
let parameters = get_parameters trans_unit_ctx tenv function_method_decl_info in
|
|
|
|
let attributes = decl_info.Clang_ast_t.di_attributes in
|
|
|
|
let lang = get_language trans_unit_ctx function_method_decl_info in
|
|
|
|
let is_cpp_virtual = is_cpp_virtual function_method_decl_info in
|
|
|
|
let is_cpp_nothrow = is_cpp_nothrow function_method_decl_info in
|
|
|
|
CMethod_signature.make_ms
|
|
|
|
procname parameters tp attributes source_range is_instance_method ~is_cpp_virtual
|
|
|
|
~is_cpp_nothrow lang parent_pointer pointer_to_property_opt return_param_type_opt
|
|
|
|
|
|
|
|
let get_init_list_instrs method_decl_info =
|
|
|
|
let create_custom_instr construct_instr = `CXXConstructorInit construct_instr in
|
|
|
|
List.map ~f:create_custom_instr method_decl_info.Clang_ast_t.xmdi_cxx_ctor_initializers
|
|
|
|
|
|
|
|
let method_signature_of_decl trans_unit_ctx tenv meth_decl block_data_opt =
|
|
|
|
let open Clang_ast_t in
|
|
|
|
match meth_decl, block_data_opt with
|
|
|
|
| FunctionDecl (decl_info, _, qt, fdi), _ ->
|
|
|
|
let func_decl = Func_decl_info (fdi, qt) in
|
|
|
|
let procname = CProcname.from_decl trans_unit_ctx ~tenv meth_decl in
|
|
|
|
let ms = build_method_signature trans_unit_ctx tenv decl_info procname func_decl None None in
|
|
|
|
ms, fdi.Clang_ast_t.fdi_body, []
|
|
|
|
| CXXMethodDecl (decl_info, _, qt, fdi, mdi), _
|
|
|
|
| CXXConstructorDecl (decl_info, _, qt, fdi, mdi), _
|
|
|
|
| CXXConversionDecl (decl_info, _, qt, fdi, mdi), _
|
|
|
|
| CXXDestructorDecl (decl_info, _, qt, fdi, mdi), _ ->
|
|
|
|
let procname = CProcname.from_decl trans_unit_ctx ~tenv meth_decl in
|
|
|
|
let parent_ptr = Option.value_exn decl_info.di_parent_pointer in
|
|
|
|
let method_decl = Cpp_Meth_decl_info (fdi, mdi, parent_ptr, qt) in
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let parent_pointer = decl_info.Clang_ast_t.di_parent_pointer in
|
|
|
|
let ms = build_method_signature
|
|
|
|
trans_unit_ctx tenv decl_info procname method_decl parent_pointer None in
|
|
|
|
let init_list_instrs = get_init_list_instrs mdi in (* it will be empty for methods *)
|
|
|
|
ms, fdi.Clang_ast_t.fdi_body, init_list_instrs
|
|
|
|
| ObjCMethodDecl (decl_info, _, mdi), _ ->
|
|
|
|
let procname = CProcname.from_decl trans_unit_ctx ~tenv meth_decl in
|
|
|
|
let parent_ptr = Option.value_exn decl_info.di_parent_pointer in
|
|
|
|
let method_decl = ObjC_Meth_decl_info (mdi, parent_ptr) in
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let parent_pointer = decl_info.Clang_ast_t.di_parent_pointer in
|
|
|
|
let pointer_to_property_opt =
|
|
|
|
match mdi.Clang_ast_t.omdi_property_decl with
|
|
|
|
| Some decl_ref -> Some decl_ref.Clang_ast_t.dr_decl_pointer
|
|
|
|
| None -> None in
|
|
|
|
let ms = build_method_signature trans_unit_ctx tenv decl_info procname method_decl
|
|
|
|
parent_pointer pointer_to_property_opt in
|
|
|
|
ms, mdi.omdi_body, []
|
|
|
|
| BlockDecl (decl_info, bdi), Some (outer_context, tp, procname, _) ->
|
|
|
|
let func_decl = Block_decl_info (bdi, tp, outer_context) in
|
|
|
|
let ms = build_method_signature trans_unit_ctx tenv decl_info procname func_decl None None in
|
|
|
|
ms, bdi.bdi_body, []
|
|
|
|
| _ -> raise Invalid_declaration
|
|
|
|
|
|
|
|
let method_signature_of_pointer trans_unit_ctx tenv pointer =
|
|
|
|
try
|
|
|
|
match CAst_utils.get_decl pointer with
|
|
|
|
| Some meth_decl ->
|
|
|
|
let ms, _, _ = method_signature_of_decl trans_unit_ctx tenv meth_decl None in
|
|
|
|
Some ms
|
|
|
|
| None -> None
|
|
|
|
with Invalid_declaration -> None
|
|
|
|
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let get_method_name_from_clang tenv ms_opt =
|
|
|
|
match ms_opt with
|
|
|
|
| Some ms ->
|
|
|
|
(match CAst_utils.get_decl_opt (CMethod_signature.ms_get_pointer_to_parent ms) with
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
| Some decl ->
|
|
|
|
if ObjcProtocol_decl.is_protocol decl then None
|
|
|
|
else
|
|
|
|
(ignore (CType_decl.add_types_from_decl_to_tenv tenv decl);
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
match ObjcCategory_decl.get_base_class_name_from_category decl with
|
|
|
|
| Some class_typename ->
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
let procname = CMethod_signature.ms_get_name ms in
|
|
|
|
let new_procname = Typ.Procname.replace_class procname class_typename in
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
CMethod_signature.ms_set_name ms new_procname;
|
|
|
|
Some ms
|
|
|
|
| None -> Some ms)
|
|
|
|
| None -> Some ms)
|
|
|
|
| None -> None
|
|
|
|
|
|
|
|
let get_superclass_curr_class_objc context =
|
|
|
|
let open Clang_ast_t in
|
|
|
|
let super_of_decl_ref_opt decl_ref =
|
|
|
|
match decl_ref
|
|
|
|
|> Option.value_map ~f:(fun dr -> dr.dr_name) ~default:None
|
|
|
|
|> Option.map ~f:CAst_utils.get_qualified_name with
|
|
|
|
| Some name -> name
|
|
|
|
| None -> assert false
|
|
|
|
in
|
|
|
|
let retreive_super_name ptr = match CAst_utils.get_decl ptr with
|
|
|
|
| Some ObjCInterfaceDecl (_, _, _, _, otdi) -> super_of_decl_ref_opt otdi.otdi_super
|
|
|
|
| Some ObjCImplementationDecl (_, _, _, _, oi) -> (
|
|
|
|
match oi.Clang_ast_t.oidi_class_interface
|
|
|
|
|> Option.map ~f:(fun dr -> dr.dr_decl_pointer)
|
|
|
|
|> Option.value_map ~f:CAst_utils.get_decl ~default:None with
|
|
|
|
| Some ObjCInterfaceDecl (_, _, _, _, otdi) -> super_of_decl_ref_opt otdi.otdi_super
|
|
|
|
| _ -> assert false
|
|
|
|
)
|
|
|
|
| Some ObjCCategoryDecl (_, _, _, _, ocdi) ->
|
|
|
|
super_of_decl_ref_opt ocdi.odi_class_interface
|
|
|
|
| Some ObjCCategoryImplDecl (_, _, _, _, ocidi) ->
|
|
|
|
super_of_decl_ref_opt ocidi.ocidi_class_interface
|
|
|
|
| _ -> assert false in
|
|
|
|
match CContext.get_curr_class context with
|
|
|
|
| CContext.ContextClsDeclPtr ptr -> Typ.Name.Objc.from_qual_name (retreive_super_name ptr)
|
|
|
|
| CContext.ContextNoCls -> assert false
|
|
|
|
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
(* Gets the class name from a method signature found by clang, if search is successful *)
|
|
|
|
let get_class_name_method_call_from_clang trans_unit_ctx tenv obj_c_message_expr_info =
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
match obj_c_message_expr_info.Clang_ast_t.omei_decl_pointer with
|
|
|
|
| Some pointer ->
|
|
|
|
(match method_signature_of_pointer trans_unit_ctx tenv pointer with
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
| Some ms ->
|
|
|
|
begin
|
|
|
|
match CMethod_signature.ms_get_name ms with
|
|
|
|
| Typ.Procname.ObjC_Cpp objc_cpp ->
|
|
|
|
Some (Typ.Procname.objc_cpp_get_class_type_name objc_cpp)
|
|
|
|
| _ ->
|
|
|
|
None
|
|
|
|
end
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
| None -> None)
|
|
|
|
| None -> None
|
|
|
|
|
|
|
|
(* Get class name from a method call accorsing to the info given by the receiver kind *)
|
|
|
|
let get_class_name_method_call_from_receiver_kind context obj_c_message_expr_info act_params =
|
|
|
|
match obj_c_message_expr_info.Clang_ast_t.omei_receiver_kind with
|
|
|
|
| `Class qt ->
|
|
|
|
let sil_type = CType_decl.qual_type_to_sil_type context.CContext.tenv qt in
|
|
|
|
(CType.objc_classname_of_type sil_type)
|
|
|
|
| `Instance ->
|
|
|
|
(match act_params with
|
|
|
|
| (_, {Typ.desc=Tptr(t, _)}):: _
|
|
|
|
| (_, t):: _ -> CType.objc_classname_of_type t
|
|
|
|
| _ -> assert false)
|
|
|
|
| `SuperInstance ->get_superclass_curr_class_objc context
|
|
|
|
| `SuperClass -> get_superclass_curr_class_objc context
|
Using clang's method resolution if possible
Summary: public
Using clang's method resolution. This means that, in method calls, clang gives you a pointer to the declaration of the method.
In some cases though, clang doesn't find the right method. For example, when it finds a method in a category, we
need to make it into a method in the corresponding class, because that's how we treat categories in Infer. Moreover,
when it finds a method in a protocol, that is not useful for us, since the implementation will be in some class. Finally,
sometimes the call is on an object of type id, in which case clang doesn't know what is the correct declaration. In
those cases, we fall back to what we were doing before of approximating the method resolution. We also refactor
some of the code.
Reviewed By: akotulski
Differential Revision: D2679766
fb-gh-sync-id: b79bb85
9 years ago
|
|
|
|
|
|
|
let get_objc_method_data obj_c_message_expr_info =
|
|
|
|
let selector = obj_c_message_expr_info.Clang_ast_t.omei_selector in
|
|
|
|
let pointer = obj_c_message_expr_info.Clang_ast_t.omei_decl_pointer in
|
|
|
|
match obj_c_message_expr_info.Clang_ast_t.omei_receiver_kind with
|
|
|
|
| `Instance -> (selector, pointer, MCVirtual)
|
|
|
|
| `SuperInstance -> (selector, pointer, MCNoVirtual)
|
|
|
|
| `Class _
|
|
|
|
| `SuperClass -> (selector, pointer, MCStatic)
|
|
|
|
|
|
|
|
let get_formal_parameters tenv ms =
|
|
|
|
let rec defined_parameters pl =
|
|
|
|
match pl with
|
|
|
|
| [] -> []
|
|
|
|
| (mangled, qual_type):: pl' ->
|
|
|
|
let should_add_pointer name ms =
|
|
|
|
let is_objc_self =
|
|
|
|
String.equal name CFrontend_config.self &&
|
|
|
|
CFrontend_config.equal_clang_lang
|
|
|
|
(CMethod_signature.ms_get_lang ms) CFrontend_config.ObjC in
|
|
|
|
let is_cxx_this =
|
|
|
|
String.equal name CFrontend_config.this &&
|
|
|
|
CFrontend_config.equal_clang_lang
|
|
|
|
(CMethod_signature.ms_get_lang ms) CFrontend_config.CPP in
|
|
|
|
(is_objc_self && CMethod_signature.ms_is_instance ms) || is_cxx_this in
|
|
|
|
let qt = if should_add_pointer (Mangled.to_string mangled) ms then
|
|
|
|
(Ast_expressions.create_pointer_qual_type qual_type)
|
|
|
|
else qual_type in
|
|
|
|
let typ = CType_decl.qual_type_to_sil_type tenv qt in
|
|
|
|
(mangled, typ):: defined_parameters pl' in
|
|
|
|
defined_parameters (CMethod_signature.ms_get_args ms)
|
|
|
|
|
|
|
|
let get_return_type tenv ms =
|
[clang] [2 of 3] Dealing with custom ast expressions and flow of types in the frontend.
Summary:
This is the second of 3 stack diffs to deal with replacing the parser of types.
This diff is about general changes to the frontend to make it cope with the change. There
are two main challenges:
1. We create pieces of ast in ast_expressions, such as getters and setters. For that we create
custom types.
2. We store types in cMethod_signature for parameters and return type of functions. This was
stored as strings, but that means losing the pointer information which is vital to get the
sil types.
So this diff consists mostly of dealing with these challenges. It change the signature of
cMethod_signature and update modules accordingly.
To deal with the custom types, we build methods in ast_expressions for creating those types,
with a custom type pointer, like "internal_typeint". At the beginning of the translation we save
all these custom types in the map from type pointers to sil types that we build as we compute the
types, so that they are available later.
Another custom type that we build is a type of classes or pointer of classes based on the current
class. I found a simple way to deal with it, giving it a pointer "class_name", and then we know
how to translate those. Something I tried is to save the declaration of the current class and pass
that declaration around, but somehow that lead to pref regression, so I removed it in favor of this
more lightweight version.
9 years ago
|
|
|
let return_type = CMethod_signature.ms_get_ret_type ms in
|
|
|
|
CType_decl.qual_type_to_sil_type tenv return_type
|
|
|
|
|
|
|
|
let sil_func_attributes_of_attributes attrs =
|
|
|
|
let rec do_translation acc al = match al with
|
|
|
|
| [] -> List.rev acc
|
|
|
|
| Clang_ast_t.SentinelAttr attribute_info:: tl ->
|
|
|
|
let (sentinel, null_pos) = match attribute_info.Clang_ast_t.ai_parameters with
|
|
|
|
| a:: b::[] -> (int_of_string a, int_of_string b)
|
|
|
|
| _ -> assert false
|
|
|
|
in
|
|
|
|
do_translation (PredSymb.FA_sentinel(sentinel, null_pos):: acc) tl
|
|
|
|
| _:: tl -> do_translation acc tl in
|
|
|
|
do_translation [] attrs
|
|
|
|
|
|
|
|
let should_create_procdesc cfg procname defined set_objc_accessor_attr =
|
|
|
|
match Cfg.find_proc_desc_from_name cfg procname with
|
|
|
|
| Some previous_procdesc ->
|
|
|
|
let is_defined_previous = Procdesc.is_defined previous_procdesc in
|
|
|
|
if (defined || set_objc_accessor_attr) && (not is_defined_previous) then
|
|
|
|
(Cfg.remove_proc_desc cfg (Procdesc.get_proc_name previous_procdesc);
|
|
|
|
true)
|
|
|
|
else false
|
|
|
|
| None -> true
|
|
|
|
|
|
|
|
let sil_method_annotation_of_args args method_type : Annot.Method.t =
|
|
|
|
let args_types = List.map ~f:snd args in
|
|
|
|
let param_annots = List.map ~f:CAst_utils.sil_annot_of_type args_types in
|
|
|
|
let retval_annot = CAst_utils.sil_annot_of_type method_type in
|
|
|
|
retval_annot, param_annots
|
|
|
|
|
|
|
|
let is_pointer_to_const {Clang_ast_t.qt_type_ptr} =
|
|
|
|
match CAst_utils.get_type qt_type_ptr with
|
|
|
|
| Some PointerType (_, {Clang_ast_t.qt_is_const})
|
|
|
|
| Some ObjCObjectPointerType (_, {Clang_ast_t.qt_is_const})
|
|
|
|
| Some RValueReferenceType (_, {Clang_ast_t.qt_is_const})
|
|
|
|
| Some LValueReferenceType (_, {Clang_ast_t.qt_is_const}) ->
|
|
|
|
qt_is_const
|
|
|
|
| _ ->
|
|
|
|
false
|
|
|
|
|
|
|
|
(** Returns a list of the indices of expressions in [args] which point to const-typed values. Each
|
|
|
|
index is offset by [shift]. *)
|
|
|
|
let get_const_args_indices ~shift args =
|
|
|
|
let i = ref shift in
|
|
|
|
let rec aux result = function
|
|
|
|
| [] ->
|
|
|
|
List.rev result
|
|
|
|
| (_, qual_type)::tl ->
|
|
|
|
incr i;
|
|
|
|
if is_pointer_to_const qual_type then
|
|
|
|
aux (!i - 1::result) tl
|
|
|
|
else
|
|
|
|
aux result tl in
|
|
|
|
aux [] args
|
|
|
|
|
|
|
|
let get_objc_property_accessor ms =
|
|
|
|
let open Clang_ast_t in
|
|
|
|
match CAst_utils.get_decl_opt (CMethod_signature.ms_get_pointer_to_property_opt ms) with
|
|
|
|
| Some (ObjCPropertyDecl (_, _, obj_c_property_decl_info)) ->
|
|
|
|
let ivar_decl_ref = obj_c_property_decl_info.Clang_ast_t.opdi_ivar_decl in
|
|
|
|
(match CAst_utils.get_decl_opt_with_decl_ref ivar_decl_ref with
|
|
|
|
| Some ObjCIvarDecl (_, named_decl_info, _, _, _) ->
|
|
|
|
let field_name = CGeneral_utils.mk_class_field_name named_decl_info in
|
|
|
|
if CMethod_signature.ms_is_getter ms then
|
|
|
|
Some (ProcAttributes.Objc_getter field_name)
|
|
|
|
else if CMethod_signature.ms_is_setter ms then
|
|
|
|
Some (ProcAttributes.Objc_setter field_name)
|
|
|
|
else None
|
|
|
|
| _ -> None)
|
|
|
|
| _ -> None
|
|
|
|
|
|
|
|
(** Creates a procedure description. *)
|
|
|
|
let create_local_procdesc ?(set_objc_accessor_attr=false) trans_unit_ctx cfg tenv ms
|
|
|
|
fbody captured is_objc_inst_method =
|
|
|
|
let defined = not (Int.equal (List.length fbody) 0) in
|
|
|
|
let proc_name = CMethod_signature.ms_get_name ms in
|
|
|
|
let pname = Typ.Procname.to_string proc_name in
|
|
|
|
let attributes = sil_func_attributes_of_attributes (CMethod_signature.ms_get_attributes ms) in
|
|
|
|
let method_ret_type = CMethod_signature.ms_get_ret_type ms in
|
|
|
|
let method_annotation =
|
|
|
|
sil_method_annotation_of_args (CMethod_signature.ms_get_args ms) method_ret_type in
|
|
|
|
let is_cpp_inst_method =
|
|
|
|
CMethod_signature.ms_is_instance ms &&
|
|
|
|
CFrontend_config.equal_clang_lang (CMethod_signature.ms_get_lang ms) CFrontend_config.CPP in
|
|
|
|
let is_cpp_nothrow = CMethod_signature.ms_is_cpp_nothrow ms in
|
|
|
|
let create_new_procdesc () =
|
|
|
|
let formals = get_formal_parameters tenv ms in
|
|
|
|
let captured_mangled = List.map ~f:(fun (var, t) -> (Pvar.get_name var), t) captured in
|
|
|
|
(* Captured variables for blocks are treated as parameters *)
|
|
|
|
let formals = captured_mangled @ formals in
|
|
|
|
let const_formals = get_const_args_indices
|
|
|
|
~shift:(List.length captured_mangled)
|
|
|
|
(CMethod_signature.ms_get_args ms) in
|
|
|
|
let source_range = CMethod_signature.ms_get_loc ms in
|
|
|
|
L.(debug Capture Verbose) "@\nCreating a new procdesc for function: '%s'@\n@." pname;
|
|
|
|
L.(debug Capture Verbose) "@\nms = %s@\n@." (CMethod_signature.ms_to_string ms);
|
|
|
|
let loc_start = CLocation.get_sil_location_from_range trans_unit_ctx source_range true in
|
|
|
|
let loc_exit = CLocation.get_sil_location_from_range trans_unit_ctx source_range false in
|
|
|
|
let ret_type = get_return_type tenv ms in
|
|
|
|
let objc_property_accessor =
|
|
|
|
if set_objc_accessor_attr then get_objc_property_accessor ms
|
|
|
|
else None in
|
|
|
|
let procdesc =
|
|
|
|
let proc_attributes =
|
|
|
|
{ (ProcAttributes.default proc_name Config.Clang) with
|
|
|
|
ProcAttributes.captured = captured_mangled;
|
|
|
|
formals;
|
|
|
|
const_formals;
|
|
|
|
func_attributes = attributes;
|
|
|
|
is_defined = defined;
|
|
|
|
is_objc_instance_method = is_objc_inst_method;
|
|
|
|
is_cpp_instance_method = is_cpp_inst_method;
|
|
|
|
is_cpp_noexcept_method = is_cpp_nothrow;
|
|
|
|
is_model = Config.models_mode;
|
|
|
|
loc = loc_start;
|
|
|
|
objc_accessor = objc_property_accessor;
|
|
|
|
translation_unit = Some trans_unit_ctx.CFrontend_config.source_file;
|
|
|
|
method_annotation;
|
|
|
|
ret_type;
|
|
|
|
} in
|
|
|
|
Cfg.create_proc_desc cfg proc_attributes in
|
|
|
|
if defined then
|
|
|
|
(if !Config.arc_mode then
|
|
|
|
Procdesc.set_flag procdesc Mleak_buckets.objc_arc_flag "true";
|
|
|
|
let start_kind = Procdesc.Node.Start_node proc_name in
|
|
|
|
let start_node = Procdesc.create_node procdesc loc_start start_kind [] in
|
|
|
|
let exit_kind = Procdesc.Node.Exit_node proc_name in
|
|
|
|
let exit_node = Procdesc.create_node procdesc loc_exit exit_kind [] in
|
|
|
|
Procdesc.set_start_node procdesc start_node;
|
|
|
|
Procdesc.set_exit_node procdesc exit_node) in
|
|
|
|
if should_create_procdesc cfg proc_name defined set_objc_accessor_attr then
|
|
|
|
(create_new_procdesc (); true)
|
|
|
|
else false
|
|
|
|
|
|
|
|
(** Create a procdesc for objc methods whose signature cannot be found. *)
|
|
|
|
let create_external_procdesc cfg proc_name is_objc_inst_method type_opt =
|
|
|
|
match Cfg.find_proc_desc_from_name cfg proc_name with
|
|
|
|
| Some _ -> ()
|
|
|
|
| None ->
|
|
|
|
let ret_type, formals =
|
|
|
|
(match type_opt with
|
|
|
|
| Some (ret_type, arg_types) ->
|
|
|
|
ret_type, List.map ~f:(fun typ -> (Mangled.from_string "x", typ)) arg_types
|
|
|
|
| None -> Typ.mk Typ.Tvoid, []) in
|
|
|
|
let proc_attributes =
|
|
|
|
{ (ProcAttributes.default proc_name Config.Clang) with
|
|
|
|
ProcAttributes.formals;
|
|
|
|
is_objc_instance_method = is_objc_inst_method;
|
|
|
|
ret_type;
|
|
|
|
} in
|
|
|
|
ignore (Cfg.create_proc_desc cfg proc_attributes)
|
|
|
|
|
|
|
|
let create_procdesc_with_pointer context pointer class_name_opt name =
|
|
|
|
let open CContext in
|
|
|
|
match method_signature_of_pointer context.translation_unit_context context.tenv pointer with
|
|
|
|
| Some callee_ms ->
|
|
|
|
ignore (create_local_procdesc context.translation_unit_context context.cfg context.tenv
|
|
|
|
callee_ms [] [] false);
|
|
|
|
CMethod_signature.ms_get_name callee_ms
|
|
|
|
| None ->
|
|
|
|
let callee_name =
|
|
|
|
match class_name_opt with
|
|
|
|
| Some class_name ->
|
|
|
|
CProcname.NoAstDecl.cpp_method_of_string context.tenv class_name name
|
|
|
|
| None ->
|
|
|
|
CProcname.NoAstDecl.c_function_of_string
|
|
|
|
context.translation_unit_context context.tenv name in
|
|
|
|
create_external_procdesc context.cfg callee_name false None;
|
|
|
|
callee_name
|
|
|
|
|
|
|
|
let add_default_method_for_class trans_unit_ctx class_name decl_info =
|
|
|
|
let loc = CLocation.get_sil_location_from_range trans_unit_ctx
|
|
|
|
decl_info.Clang_ast_t.di_source_range true in
|
|
|
|
let proc_name = Typ.Procname.get_default_objc_class_method class_name in
|
|
|
|
let attrs = { (ProcAttributes.default proc_name Config.Clang) with loc; } in
|
|
|
|
AttributesTable.store_attributes attrs
|
|
|
|
|
|
|
|
let get_procname_from_cpp_lambda context dec =
|
|
|
|
match dec with
|
|
|
|
| Clang_ast_t.CXXRecordDecl (_, _, _, _, _, _, _, cxx_rdi) ->
|
|
|
|
(match cxx_rdi.xrdi_lambda_call_operator with
|
|
|
|
| Some dr ->
|
|
|
|
let name_info, decl_ptr, _ = CAst_utils.get_info_from_decl_ref dr in
|
|
|
|
create_procdesc_with_pointer context decl_ptr None name_info.ni_name
|
|
|
|
| _ -> assert false (* We should not get here *))
|
|
|
|
| _ -> assert false (* We should not get here *)
|
|
|
|
|
|
|
|
(*
|
|
|
|
let instance_to_method_call_type instance =
|
|
|
|
if instance then MCVirtual
|
|
|
|
else MCStatic
|
|
|
|
*)
|