pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '9111526a5e'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/shared/property/PropertyAttributes.m.dot

155 lines
12 KiB
Raw Normal View History Unescape

Add @generated comment to icfg.dot files Reviewed By: jvillard Differential Revision: D3358243 fbshipit-source-id: a47cc01
9 years ago
/* @generated */
[cfg] rename iCFG to cfg in dotty files Summary: Not sure what an "iCFG" is but the dotty is only about CFGs anyway. Diff obtained by mass-`sed`. Reviewed By: sblackshear Differential Revision: D6324280 fbshipit-source-id: b7603bb
7 years ago
digraph cfg {
Get rid of Declare_locals Reviewed By: jeremydubreil Differential Revision: D9234331 fbshipit-source-id: 70443eabe
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_1" [label="1: Start test\nFormals: a2:PropertyA*\nLocals: a:PropertyA* \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_1" -> "test.098f6bcd4621d373cade4e832627b4f6_6" ;
[SIL] change `variable_initialization()` builtin to a new auxiliary instruction Summary: Instead of emitting an ad-hoc builtin on variable declaration emit a new metadata instruction. This allows us to remove the code matching on that ad-hoc builtin that had to be inserted in several checkers. Inferbo & pulse used that information meaningfully and had to undergo some minor changes to cope with the new metada instruction. Reviewed By: ezgicicek Differential Revision: D14833100 fbshipit-source-id: 9b3009d22
6 years ago
"test.098f6bcd4621d373cade4e832627b4f6_2" [label="2: Exit test \n " color=yellow style=filled]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"test.098f6bcd4621d373cade4e832627b4f6_3" [label="3: Return Stmt \n *&return:int=0 [line 44, column 3]\n " shape="box"]
[tests] Prepare objective-c tests for conversion to the new direct testing format Summary: Rename symbols in test files so they are not duplicated and files can be analyzed together without affecting analysis results. Fix some compilation errors, where files could be analyzed but would fail direct compilation. Add Makefile mimicking the same analysis parameters used for the existing tests. Reviewed By: dulmarod Differential Revision: D3869993 fbshipit-source-id: 6db1baf
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_3" -> "test.098f6bcd4621d373cade4e832627b4f6_2" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"test.098f6bcd4621d373cade4e832627b4f6_4" [label="4: Message Call: release \n n$0=*&a:PropertyA* [line 43, column 4]\n n$1=_fun_NSObject.release(n$0:PropertyA*) virtual [line 43, column 3]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_4" -> "test.098f6bcd4621d373cade4e832627b4f6_3" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"test.098f6bcd4621d373cade4e832627b4f6_5" [label="5: Message Call: setLast_name: \n n$3=*&a:PropertyA* [line 42, column 3]\n n$2=*&a2:PropertyA* [line 42, column 17]\n n$4=_fun_PropertyA.setLast_name:(n$3:PropertyA*,n$2:PropertyA*) [line 42, column 5]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_5" -> "test.098f6bcd4621d373cade4e832627b4f6_4" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"test.098f6bcd4621d373cade4e832627b4f6_6" [label="6: DeclStmt \n VARIABLE_DECLARED(a:PropertyA*); [line 41, column 3]\n n$5=_fun___objc_alloc_no_fail(sizeof(t=PropertyA):unsigned long) [line 41, column 19]\n n$6=_fun_PropertyA.init(n$5:PropertyA*) virtual [line 41, column 18]\n *&a:PropertyA*=n$6 [line 41, column 3]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"test.098f6bcd4621d373cade4e832627b4f6_6" -> "test.098f6bcd4621d373cade4e832627b4f6_5" ;
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_1" [label="1: Start PropertyA.child\nFormals: self:PropertyA*\nLocals: \n " color=yellow style=filled]
"child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_1" -> "child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_3" ;
"child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_2" [label="2: Exit PropertyA.child \n " color=yellow style=filled]
[frontend] Track protocols in A<ObjCProtocol> Reviewed By: skcho Differential Revision: D24566435 fbshipit-source-id: 62d41c8c6
4 years ago
"child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_3" [label="3: BinaryOperatorStmt: Node \n n$13=*&self:PropertyA* [line 12, column 39]\n n$14=*n$13._child:PropertyA* [line 12, column 39]\n *&return:PropertyA*=n$14 [line 12, column 39]\n " shape="box"]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_3" -> "child#PropertyA#instance.6f8ba5a5a49be48cc5dabe234a5b1918_2" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_1" [label="1: Start PropertyA.copy\nFormals: self:PropertyA*\nLocals: other:PropertyA* \n " color=yellow style=filled]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_1" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_2" [label="2: Exit PropertyA.copy \n " color=yellow style=filled]
initial synchronization
10 years ago
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_3" [label="3: Return Stmt \n n$1=*&other:PropertyA* [line 35, column 10]\n *&return:PropertyA*=n$1 [line 35, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_3" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_2" ;
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" [label="4: + \n " ]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_3" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_5" [label="5: Prune (true branch, if) \n n$2=*&other:PropertyA* [line 30, column 7]\n PRUNE(n$2, true); [line 30, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_5" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_9" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_6" [label="6: Prune (false branch, if) \n n$2=*&other:PropertyA* [line 30, column 7]\n PRUNE(!n$2, false); [line 30, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_6" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_7" [label="7: BinaryOperatorStmt: Assign \n n$3=*&other:PropertyA* [line 33, column 5]\n n$4=*&self:PropertyA* [line 33, column 21]\n n$5=*n$4._child:PropertyA* [line 33, column 21]\n *n$3._child:PropertyA*=n$5 [line 33, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_7" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_4" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_8" [label="8: BinaryOperatorStmt: Assign \n n$6=*&other:PropertyA* [line 32, column 5]\n n$7=*&self:PropertyA* [line 32, column 25]\n n$8=*n$7._last_name:PropertyA* [line 32, column 25]\n *n$6._last_name:PropertyA*=n$8 [line 32, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_8" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_7" ;
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_9" [label="9: BinaryOperatorStmt: Assign \n n$9=*&other:PropertyA* [line 31, column 5]\n n$10=*&self:PropertyA* [line 31, column 20]\n n$11=*n$10._name:PropertyA* [line 31, column 20]\n *n$9._name:PropertyA*=n$11 [line 31, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_9" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_8" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" [label="10: DeclStmt \n VARIABLE_DECLARED(other:PropertyA*); [line 29, column 3]\n n$14=_fun___objc_alloc_no_fail(sizeof(t=PropertyA):unsigned long) [line 29, column 23]\n n$15=_fun_PropertyA.init(n$14:PropertyA*) virtual [line 29, column 22]\n *&other:PropertyA*=n$15 [line 29, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_5" ;
"copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_10" -> "copy#PropertyA#instance.d5955e11cf35af4b4d602b2971590d5f_6" ;
[clang] Adding implicit implementation of dealloc methods to ObjC classes Summary: This models ARC implementation of dealloc, see https://clang.llvm.org/docs/AutomaticReferenceCounting.html#dealloc. Dealloc methods can be added to ObjC classes to free C memory for example, but the deallocation of the ObjC instance variables of the object is done automatically. So here we add this explicitly to Infer: 1. First, we add an empty dealloc method when it is not written explicitly. 2. For each dealloc method (including the implicitly added ones) we add calls to dealloc of the ObjC instance variables. Reviewed By: jvillard Differential Revision: D21883546 fbshipit-source-id: f5d4930f2
5 years ago
"dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_1" [label="1: Start PropertyA.dealloc\nFormals: self:PropertyA*\nLocals: \n " color=yellow style=filled]
"dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_1" -> "dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_3" ;
"dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_2" [label="2: Exit PropertyA.dealloc \n " color=yellow style=filled]
"dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_3" [label="3: Call dealloc \n n$0=*&self:PropertyA* [line 38, column 1]\n n$1=*n$0._last_name:PropertyA* [line 38, column 1]\n n$2=_fun_PropertyA.dealloc(n$1:PropertyA*) [line 38, column 1]\n n$3=*&self:PropertyA* [line 38, column 1]\n n$4=*n$3._name:PropertyA* [line 38, column 1]\n n$5=_fun_PropertyA.dealloc(n$4:PropertyA*) [line 38, column 1]\n n$6=*&self:PropertyA* [line 38, column 1]\n n$7=*n$6._child:PropertyA* [line 38, column 1]\n n$8=_fun_PropertyA.dealloc(n$7:PropertyA*) [line 38, column 1]\n " shape="box"]
"dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_3" -> "dealloc#PropertyA#instance.6f8be74d1c8a16eeeed561e5def4ae54_2" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_1" [label="1: Start PropertyA.init\nFormals: self:PropertyA*\nLocals: \n " color=yellow style=filled]
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_1" -> "init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_3" ;
[IR] Fix the function hashable_name for ObjC methods Summary: This function had been computing the name for ObjC methods wrong, with only the class name. This was causing wrong error messages in Pulse. The main issue was that `Procname.to_simplified_string` was writing `Classname::methodname` for ObjC methods, which is not the convention. This confused the `hashable_name` funtion. So changing the method name to `Classname.methodname` which is more standard, and this also fixes `hashable_name`. Reviewed By: ngorogiannis, jvillard Differential Revision: D21570880 fbshipit-source-id: 13ed62cf8
5 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_2" [label="2: Exit PropertyA.init \n " color=yellow style=filled]
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
[cfg] run pre-analysis lazily in ondemand Summary: This also prints the CFGs *after* pre-analysis for individual procedures in infer-out/captured/<filename>/<proc>.dot. One can also look up the CFGs before pre-analysis in infer-out/captured/proc_cfgs_frontend.dot. Context: I want to add a pre-analysis that needs to look at proc attributes inter-procedurally. For this to make sense it has to happen *after* all of capture, and before analysis. Thus, this diff brings back the lazy running of the pre-analysis like in D15803492, except that we still make sure to run the pre-analyses systematically regardless of the checkers being run by running the pre-analysis from ondemand.ml. Also we don't need to re-introduce the "did_preanalysis" proc attribute for the same reason that the pre-analysis is now run once and for all by ondemand.ml (instead of each individual checker back in the days). This has the benefit of running the pre-analysis only when needed, and the drawback that several concurrent processes analysing the same proc descs will duplicate work. Since pre-analyses are supposed to be very fast I assume that neither is a big deal. If they become more expensive then the benefit gets bigger and the drawback is just the same as with regular analyses. Reviewed By: skcho Differential Revision: D18573920 fbshipit-source-id: de350eaef
5 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_3" [label="3: Return Stmt \n n$0=*&self:PropertyA* [line 25, column 10]\n *&return:objc_object*=n$0 [line 25, column 3]\n " shape="box"]
[debug] print procedures in alphabetical order in cfgs Summary: When looking at large CFGs, at least in `xdot`, it's often difficult to find the procedure you're looking for. Sorting the proc names puts them in alphabetical order, which makes searching one procedure easier. Reviewed By: mbouaziz Differential Revision: D7758521 fbshipit-source-id: 8e9997f
7 years ago
"init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_3" -> "init#PropertyA#instance.a50cf011b0759e26f65bb059fbc6d60c_2" ;
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_1" [label="1: Start PropertyA.last_name\nFormals: self:PropertyA*\nLocals: \n " color=yellow style=filled]
"last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_1" -> "last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_3" ;
"last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_2" [label="2: Exit PropertyA.last_name \n " color=yellow style=filled]
[frontend] Track protocols in A<ObjCProtocol> Reviewed By: skcho Differential Revision: D24566435 fbshipit-source-id: 62d41c8c6
4 years ago
"last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_3" [label="3: BinaryOperatorStmt: Node \n n$19=*&self:PropertyA* [line 16, column 52]\n n$20=*n$19._last_name:PropertyA* [line 16, column 52]\n *&return:PropertyA*=n$20 [line 16, column 52]\n " shape="box"]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_3" -> "last_name#PropertyA#instance.1ce5ad70e2d4c718c3a98ccc959a3bc9_2" ;
"name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_1" [label="1: Start PropertyA.name\nFormals: self:PropertyA*\nLocals: \n " color=yellow style=filled]
"name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_1" -> "name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_3" ;
"name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_2" [label="2: Exit PropertyA.name \n " color=yellow style=filled]
[frontend] Track protocols in A<ObjCProtocol> Reviewed By: skcho Differential Revision: D24566435 fbshipit-source-id: 62d41c8c6
4 years ago
"name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_3" [label="3: BinaryOperatorStmt: Node \n n$11=*&self:PropertyA* [line 14, column 41]\n n$12=*n$11._name:PropertyA* [line 14, column 41]\n *&return:PropertyA*=n$12 [line 14, column 41]\n " shape="box"]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_3" -> "name#PropertyA#instance.c1cdbf324fa14cda26c4633e95fc7667_2" ;
"setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_1" [label="1: Start PropertyA.setChild:\nFormals: self:PropertyA* child:PropertyA*\nLocals: \n " color=yellow style=filled]
"setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_1" -> "setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_3" ;
"setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_2" [label="2: Exit PropertyA.setChild: \n " color=yellow style=filled]
[frontend] Track protocols in A<ObjCProtocol> Reviewed By: skcho Differential Revision: D24566435 fbshipit-source-id: 62d41c8c6
4 years ago
"setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_3" [label="3: BinaryOperatorStmt: Node \n n$17=*&self:PropertyA* [line 12, column 39]\n n$18=*&child:PropertyA* [line 12, column 39]\n *n$17._child:PropertyA*=n$18 [line 12, column 39]\n " shape="box"]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_3" -> "setChild:#PropertyA(class PropertyA)#instance.2830b91fc93649a2fb3b313489bf5461_2" ;
"setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_1" [label="1: Start PropertyA.setLast_name:\nFormals: self:PropertyA* last_name:PropertyA*\nLocals: \n " color=yellow style=filled]
"setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_1" -> "setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_3" ;
"setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_2" [label="2: Exit PropertyA.setLast_name: \n " color=yellow style=filled]
[frontend] Track protocols in A<ObjCProtocol> Reviewed By: skcho Differential Revision: D24566435 fbshipit-source-id: 62d41c8c6
4 years ago
"setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_3" [label="3: BinaryOperatorStmt: Node \n n$15=*&self:PropertyA* [line 16, column 52]\n n$16=*&last_name:PropertyA* [line 16, column 52]\n *n$15._last_name:PropertyA*=n$16 [line 16, column 52]\n " shape="box"]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_3" -> "setLast_name:#PropertyA(class PropertyA)#instance.47d6f73ea37f95beeca8ce7a0352c15f_2" ;
"setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_1" [label="1: Start PropertyA.setName:\nFormals: self:PropertyA* name:PropertyA*\nLocals: \n " color=yellow style=filled]
"setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_1" -> "setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_3" ;
"setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_2" [label="2: Exit PropertyA.setName: \n " color=yellow style=filled]
[frontend] Track protocols in A<ObjCProtocol> Reviewed By: skcho Differential Revision: D24566435 fbshipit-source-id: 62d41c8c6
4 years ago
"setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_3" [label="3: BinaryOperatorStmt: Node \n n$9=*&self:PropertyA* [line 14, column 41]\n n$10=*&name:PropertyA* [line 14, column 41]\n *n$9._name:PropertyA*=n$10 [line 14, column 41]\n " shape="box"]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
5 years ago
"setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_3" -> "setName:#PropertyA(class PropertyA)#instance.530a6c9eaa83786feeaf3a50fc2cd0e6_2" ;
initial synchronization
10 years ago
}