infer_clone/infer/src/pulse/PulseBasicInterface.ml

(*
 * Copyright (c) Facebook, Inc. and its affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 *)
open! IStd

(** Basic Pulse modules that are safe to use in any module *)

module AbstractValue = PulseAbstractValue
module Attribute = PulseAttribute
module Attributes = PulseAttribute.Attributes
module CallEvent = PulseCallEvent
module CItv = PulseCItv
module Diagnostic = PulseDiagnostic
module Invalidation = PulseInvalidation
module SkippedCalls = PulseSkippedCalls
module Trace = PulseTrace
module ValueHistory = PulseValueHistory
[pulse][1/9] create PulseBasicInterface, with CallEvent Summary: Problem: PulseDomain.ml is pretty big, and contains lots of small modules. The Infer build being a bit monolithic at the moment, it is hard to split all these small modules off without creating some confusion about which abstraction barries lay where. For instance, it's fine to use `PulseDomain.ValueHistory` anywhere, but using `PulseDomain` itself is sometimes bad when one should use `PulseAbductiveDomain` instead. Proposal: a poorman's library mechanism based on module aliasing. This stack of diffs creates new Pulse* modules for all these small, safe to use modules, together with `PulseBasicInterface.ml`, which aliases these modules to remove the `Pulse` prefix. At the end of the stack, it will contain: ``` module AbstractValue = PulseAbstractValue module Attribute = PulseAttribute module Attributes = PulseAttribute.Attributes module CallEvent = PulseCallEvent module Diagnostic = PulseDiagnostic module Invalidation = PulseInvalidation module Trace = PulseTrace module ValueHistory = PulseValueHistory ``` This "interface" module can be opened in other pulse modules freely. Reviewed By: ezgicicek Differential Revision: D17955104 fbshipit-source-id: 13d3aa2b5 5 years ago			`(*`
			`* Copyright (c) Facebook, Inc. and its affiliates.`
			`*`
			`* This source code is licensed under the MIT license found in the`
			`* LICENSE file in the root directory of this source tree.`
			`*)`
			`open! IStd`

			`(** Basic Pulse modules that are safe to use in any module *)`

[pulse][6/9] add PulseAbstractValue to PulseBasicInterface Summary: See explanations in D17955104. This renames `AbstractAddress` to `AbstractValue` since they are not necessarily addresses. Reviewed By: ezgicicek Differential Revision: D17955290 fbshipit-source-id: 8bb4c61f2 5 years ago			`module AbstractValue = PulseAbstractValue`
[pulse][5/9] add PulseAttribute{,s} to PulseBasicInterface Summary: See explanations in D17955104. I put Attributes inside PulseAttribute instead of creating a new file to avoid exposing more internals about ranks. Reviewed By: ezgicicek Differential Revision: D17955284 fbshipit-source-id: a8719a58f 5 years ago			`module Attribute = PulseAttribute`
			`module Attributes = PulseAttribute.Attributes`
[pulse][1/9] create PulseBasicInterface, with CallEvent Summary: Problem: PulseDomain.ml is pretty big, and contains lots of small modules. The Infer build being a bit monolithic at the moment, it is hard to split all these small modules off without creating some confusion about which abstraction barries lay where. For instance, it's fine to use `PulseDomain.ValueHistory` anywhere, but using `PulseDomain` itself is sometimes bad when one should use `PulseAbductiveDomain` instead. Proposal: a poorman's library mechanism based on module aliasing. This stack of diffs creates new Pulse* modules for all these small, safe to use modules, together with `PulseBasicInterface.ml`, which aliases these modules to remove the `Pulse` prefix. At the end of the stack, it will contain: ``` module AbstractValue = PulseAbstractValue module Attribute = PulseAttribute module Attributes = PulseAttribute.Attributes module CallEvent = PulseCallEvent module Diagnostic = PulseDiagnostic module Invalidation = PulseInvalidation module Trace = PulseTrace module ValueHistory = PulseValueHistory ``` This "interface" module can be opened in other pulse modules freely. Reviewed By: ezgicicek Differential Revision: D17955104 fbshipit-source-id: 13d3aa2b5 5 years ago			`module CallEvent = PulseCallEvent`
[pulse] rename "PulseArithmetic" to "PulseCItv" Summary: In preparation for PulseArithmetic to be something else. Reviewed By: ezgicicek Differential Revision: D20393928 fbshipit-source-id: d93131e12 5 years ago			`module CItv = PulseCItv`
[pulse][9/9] add PulseDiagnostic to PulseBasicInterface Summary: See explanations in D17955104 Reviewed By: ezgicicek Differential Revision: D17955288 fbshipit-source-id: ac5932cd2 5 years ago			`module Diagnostic = PulseDiagnostic`
[pulse][2/9] add PulseInvalidation to PulseBasicInterface Summary: See explanations in D17955104 Reviewed By: ezgicicek Differential Revision: D17955286 fbshipit-source-id: 831491e47 5 years ago			`module Invalidation = PulseInvalidation`
[pulse] move SkippedCalls to its own file Summary: Seems logical. Reviewed By: ezgicicek Differential Revision: D21022922 fbshipit-source-id: 1b8546332 5 years ago			`module SkippedCalls = PulseSkippedCalls`
[pulse][4/9] add PulseTrace to PulseBasicInterface Summary: See explanations in D17955104 Reviewed By: ezgicicek Differential Revision: D17955282 fbshipit-source-id: a9d75e8a1 5 years ago			`module Trace = PulseTrace`
[pulse][3/9] add PulseValueHistory to PulseBasicInterface Summary: See explanations in D17955104 Reviewed By: ezgicicek Differential Revision: D17955285 fbshipit-source-id: 4e93a86df 5 years ago			`module ValueHistory = PulseValueHistory`