pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'a6da208e9d'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/self-in-block/issues.exp

10 lines
2.1 KiB
Raw Normal View History Unescape

[SelfInBlock] Check for when weakSelf is used in a no escaping block Summary: This adds a check for when developers use weakSelf (and maybe strongSelf) in a block, when there is no need for it, because it won't cause a retain cycle. In general there is an annotation in Objective-C for methods that take blocks, NS_NOESCAPE, that means that the passed block won't leave the scope, i.e. is "no escaping". So we report when weakSelf is used and the block has the annotation. Reviewed By: ngorogiannis Differential Revision: D19662468 fbshipit-source-id: f5ac695aa
5 years ago
codetoanalyze/objc/self-in-block/NoescapeBlock.m, objc_blockA::weak_in_noescape_block_bad:_1, 1, WEAK_SELF_IN_NO_ESCAPE_BLOCK, no_bucket, ERROR, [Using &weakSelf]
[self in block] Add a check for strongSelf not checked for null Summary: The variable strongSelf, because it is equal to a weak captured pointer, needs to be checked for null before being used, otherwise it could be null by the time the block is executed. Added this check to the SelfInBlock checker, and removed it from biabduction. We want to migrate all the objc checks from biabduction, so it will be easier to change and faster and more reliable. Moreover, this check is more general, it will flag any use of unchecked strongSelf, not just a dereference. Reviewed By: skcho Differential Revision: D18403849 fbshipit-source-id: a9cf5d80b
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::mixSelfWeakSelf_bad_1, 5, MIXED_SELF_WEAKSELF, no_bucket, ERROR, [Using &weakSelf,Using &self,Using &self]
[self in block] Adding traces to the Strong_self_not_checked check Summary: Adding a trace that includes when strongSelf was assigned to, and when it's used without a check. Reviewed By: skcho Differential Revision: D18506113 fbshipit-source-id: 778c4b086
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::strongSelfCheck3_bad_7, 2, STRONG_SELF_NOT_CHECKED, no_bucket, ERROR, [&strongSelf assigned here,Using &strongSelf not checked for null]
[SelfInBlock] Reporting strongSelf Not Checked only in field access Summary: After receiving feedback about this, I'm changing the reporting of strongSelf Not Checked to only in cases where it can cause a crash. Here I'm adding reporting for field access, and removing general reporting. In a next diff, I'll also add reporting for passing strongSelf to methods in not explicitly nullable positions. Reviewed By: skcho Differential Revision: D19329842 fbshipit-source-id: 35beb2aa3
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::strongSelfCheckOnce_bad_5, 6, STRONG_SELF_NOT_CHECKED, no_bucket, ERROR, [&strongSelf assigned here,Using &strongSelf not checked for null,Using &strongSelf not checked for null]
[SelfInBlock] Report strongSelf Not Checked when strongSelf passed to a function as argument Summary: Adding reporting to strongSelf Not Checked when strongSelf is passed to a method in a not explicitly nullable position. Reviewed By: ezgicicek Differential Revision: D19330872 fbshipit-source-id: 95871a70a
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::strongSelfCheckOnce_bad_5, 8, STRONG_SELF_NOT_CHECKED, no_bucket, ERROR, [&strongSelf assigned here,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null]
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::strongSelfCheckOnce_bad_5, 10, STRONG_SELF_NOT_CHECKED, no_bucket, ERROR, [&strongSelf assigned here,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null,Using &strongSelf not checked for null]
[selfInBlock] Add a new check when strongSelf is captured in a (sub)block. Summary: Adding a new check as part of the SelfInBlock checker, for cases when a strong pointer to self, that is not self, is captured in the block. This will cover the following wrong scenarios: 1. strongSelf is a local variable in a block as it should be, and then it's used in a sub-block, in which case it's a captured variable. 2. weakSelf is defined without the weak attribute by mistake. Reviewed By: ngorogiannis Differential Revision: D19538036 fbshipit-source-id: 151871745
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::strongSelfNoCheckNotWeakSelf_good_2, 1, CAPTURED_STRONG_SELF, no_bucket, ERROR, [Using captured &weakSelf]
[selfInBlock] Remove false positive from mix self weakSelf Summary: The translation of closures includes a load instruction for the captured variable, then we add that corresponding id to the closure. This doesn't correspond to an actual "use" of the captured variable in the source program though, and causes false positives. Here we remove the ids from the domain when that id is being added to a closure. Reviewed By: ngorogiannis Differential Revision: D19557352 fbshipit-source-id: 52b426011
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockSelfInBlockTest::weakSelfMultiple_bad_11, 1, MULTIPLE_WEAKSELF, no_bucket, ERROR, [Using &weakSelf,Using &weakSelf]
[selfInBlock] Add a new check when strongSelf is captured in a (sub)block. Summary: Adding a new check as part of the SelfInBlock checker, for cases when a strong pointer to self, that is not self, is captured in the block. This will cover the following wrong scenarios: 1. strongSelf is a local variable in a block as it should be, and then it's used in a sub-block, in which case it's a captured variable. 2. weakSelf is defined without the weak attribute by mistake. Reviewed By: ngorogiannis Differential Revision: D19538036 fbshipit-source-id: 151871745
5 years ago
codetoanalyze/objc/self-in-block/StrongSelf.m, objc_blockobjc_blockSelfInBlockTest::capturedStrongSelf_bad_12_13, 1, CAPTURED_STRONG_SELF, no_bucket, ERROR, [Using captured &strongSelf]