pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'b4f23ab599'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/performance/cost-issues.exp

173 lines
24 KiB
Raw Normal View History Unescape

[frontend] Add translation of arrayWithObjects:count: Summary: This diff adds translation of `arrayWithObjects:count:`. In the previous implementation it was translated as if it was `arrayWithObjects:`, but their function parameters are different. In this diff, it translates an array literal `NSArray* a = @ [ 2, 3 ];` to ``` n$1=NSNumber.numberWithInt:(2:int) n$2=NSNumber.numberWithInt:(3:int) temp[0]:objc_object*=n$1 temp[1]:objc_object*=n$2 n$3=NSArray.arrayWithObjects:count:(temp:objc_object* const [2*8],2:int) a:NSArray*=n$3 ``` where `temp` is an additional local variable declared as array. See, https://developer.apple.com/documentation/foundation/nsarray/1460145-arraywithobjects https://developer.apple.com/documentation/foundation/nsarray/1460096-arraywithobjects?language=objc Reviewed By: jvillard Differential Revision: D22631305 fbshipit-source-id: 5be0a55d4
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_access_constant, 50, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_access_linear, 3 + 7 ⋅ array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] add objc test for NSArray and NSMutableArray Summary: Add objc test for ```NSArray``` and ```NSMutableArray```. ```NSMutableArray``` is a subclass of ```NSArray```. For documentation of ```NSArray```, https://developer.apple.com/documentation/foundation/nsarray?language=objc For documentation of ```NSMutableArray```, https://developer.apple.com/documentation/foundation/nsmutablearray?language=objc The underlying mechanism for ```NSMutableArray``` is quite complicated. It changes the underlying data structure during runtime, so it is possible to have say O(log n) complexity for accessing element in array. (See here https://opensource.apple.com/source/CF/CF-855.11/CFArray.h) However, this is unlikely to happen if the engineer does not abuse the usage of the class ```NSMutableArray``` according to at least two ios engineers. So here the complexity is set to match the normal expectation of the complexity. Reviewed By: ezgicicek Differential Revision: D22041277 fbshipit-source-id: c27f43167
5 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_add_object_constant, 8, OnUIThread:false, []
codetoanalyze/objc/performance/NSArray.m, nsarray_add_objects_from_array_linear_FN, 8, OnUIThread:false, []
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_array_with_objects_constant, 27, OnUIThread:false, []
[cost] add objc test for NSArray and NSMutableArray Summary: Add objc test for ```NSArray``` and ```NSMutableArray```. ```NSMutableArray``` is a subclass of ```NSArray```. For documentation of ```NSArray```, https://developer.apple.com/documentation/foundation/nsarray?language=objc For documentation of ```NSMutableArray```, https://developer.apple.com/documentation/foundation/nsmutablearray?language=objc The underlying mechanism for ```NSMutableArray``` is quite complicated. It changes the underlying data structure during runtime, so it is possible to have say O(log n) complexity for accessing element in array. (See here https://opensource.apple.com/source/CF/CF-855.11/CFArray.h) However, this is unlikely to happen if the engineer does not abuse the usage of the class ```NSMutableArray``` according to at least two ios engineers. So here the complexity is set to match the normal expectation of the complexity. Reviewed By: ezgicicek Differential Revision: D22041277 fbshipit-source-id: c27f43167
5 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_binary_search_log_FN, 10, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_contains_object_linear, 3 + array->elements.length.ub, OnUIThread:false, [{array->elements.length.ub},Modeled call to NSArray.containsObject:]
codetoanalyze/objc/performance/NSArray.m, nsarray_count_bounded_linear, 3 + 3 ⋅ array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] add inferbo model for NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22390462 fbshipit-source-id: bd9157874
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_empty_array_constant, 8, OnUIThread:false, []
[cost] add NSArray iterator Summary: As title. This diff is co-authored by SungKeun Cho and me. facebook This diff is co-authored by skcho and me. Original comments from skcho "For the record: 1. Rory and I tried to write models for ObjC iterator. 2. We could not use Java's iterator semantics: In Java's, `hasNext` returns the size of collection, rather than a boolean, and which is used as a control variable. On the other hand, in ObjC, it calls only `nextObject`, not calling `hasNext`, and the return value of which is being checked as `null`. 3. We added an artificial field `objc_iterator_offset` to keep the index of the iterator, and the models added in this diff are handling that integer value. A problem is that `array.objc_iterator_offset` is not included in the control variables, since the condition of the loop is `nextObject() != null` that does not include the iterator offset. We need to make `array.objc_iterator_offset` as a control variable, by changing the part collecting control variables. " Reviewed By: ezgicicek, skcho Differential Revision: D22944278 fbshipit-source-id: 7e71b79c1
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_enumerator_linear_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_find_linear, 4 + 9 ⋅ array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] add objc test for NSArray and NSMutableArray Summary: Add objc test for ```NSArray``` and ```NSMutableArray```. ```NSMutableArray``` is a subclass of ```NSArray```. For documentation of ```NSArray```, https://developer.apple.com/documentation/foundation/nsarray?language=objc For documentation of ```NSMutableArray```, https://developer.apple.com/documentation/foundation/nsmutablearray?language=objc The underlying mechanism for ```NSMutableArray``` is quite complicated. It changes the underlying data structure during runtime, so it is possible to have say O(log n) complexity for accessing element in array. (See here https://opensource.apple.com/source/CF/CF-855.11/CFArray.h) However, this is unlikely to happen if the engineer does not abuse the usage of the class ```NSMutableArray``` according to at least two ios engineers. So here the complexity is set to match the normal expectation of the complexity. Reviewed By: ezgicicek Differential Revision: D22041277 fbshipit-source-id: c27f43167
5 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_first_object_constant, 4, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_get_first_constant, 27, OnUIThread:false, []
[cost] add inferbo model for NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22390462 fbshipit-source-id: bd9157874
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_init_constant, 9, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_init_with_array_constant, 14, OnUIThread:false, []
codetoanalyze/objc/performance/NSArray.m, nsarray_init_with_array_copy_linear, 7 + 3 ⋅ array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
codetoanalyze/objc/performance/NSArray.m, nsarray_init_with_array_linear, 6 + 3 ⋅ array->elements.length.ub + array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Modeled call to NSArray.initWithArray:,{array->elements.length.ub},Loop]
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_init_with_objects_constant, 39, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_is_equal_to_array_linear, 4 + array1->elements.length.ub, OnUIThread:false, [{array1->elements.length.ub},Modeled call to NSArray.isEqualToArray:]
[cost] add NSArray iterator Summary: As title. This diff is co-authored by SungKeun Cho and me. facebook This diff is co-authored by skcho and me. Original comments from skcho "For the record: 1. Rory and I tried to write models for ObjC iterator. 2. We could not use Java's iterator semantics: In Java's, `hasNext` returns the size of collection, rather than a boolean, and which is used as a control variable. On the other hand, in ObjC, it calls only `nextObject`, not calling `hasNext`, and the return value of which is being checked as `null`. 3. We added an artificial field `objc_iterator_offset` to keep the index of the iterator, and the models added in this diff are handling that integer value. A problem is that `array.objc_iterator_offset` is not included in the control variables, since the condition of the loop is `nextObject() != null` that does not include the iterator offset. We need to make `array.objc_iterator_offset` as a control variable, by changing the part collecting control variables. " Reviewed By: ezgicicek, skcho Differential Revision: D22944278 fbshipit-source-id: 7e71b79c1
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_iterate_linear, 6 + 4 ⋅ array->elements.length.ub + 4 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] add objc test for NSArray and NSMutableArray Summary: Add objc test for ```NSArray``` and ```NSMutableArray```. ```NSMutableArray``` is a subclass of ```NSArray```. For documentation of ```NSArray```, https://developer.apple.com/documentation/foundation/nsarray?language=objc For documentation of ```NSMutableArray```, https://developer.apple.com/documentation/foundation/nsmutablearray?language=objc The underlying mechanism for ```NSMutableArray``` is quite complicated. It changes the underlying data structure during runtime, so it is possible to have say O(log n) complexity for accessing element in array. (See here https://opensource.apple.com/source/CF/CF-855.11/CFArray.h) However, this is unlikely to happen if the engineer does not abuse the usage of the class ```NSMutableArray``` according to at least two ios engineers. So here the complexity is set to match the normal expectation of the complexity. Reviewed By: ezgicicek Differential Revision: D22041277 fbshipit-source-id: c27f43167
5 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_last_object_constant, 4, OnUIThread:false, []
[cost] add NSArray iterator Summary: As title. This diff is co-authored by SungKeun Cho and me. facebook This diff is co-authored by skcho and me. Original comments from skcho "For the record: 1. Rory and I tried to write models for ObjC iterator. 2. We could not use Java's iterator semantics: In Java's, `hasNext` returns the size of collection, rather than a boolean, and which is used as a control variable. On the other hand, in ObjC, it calls only `nextObject`, not calling `hasNext`, and the return value of which is being checked as `null`. 3. We added an artificial field `objc_iterator_offset` to keep the index of the iterator, and the models added in this diff are handling that integer value. A problem is that `array.objc_iterator_offset` is not included in the control variables, since the condition of the loop is `nextObject() != null` that does not include the iterator offset. We need to make `array.objc_iterator_offset` as a control variable, by changing the part collecting control variables. " Reviewed By: ezgicicek, skcho Differential Revision: D22944278 fbshipit-source-id: 7e71b79c1
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_next_object_constant_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
codetoanalyze/objc/performance/NSArray.m, nsarray_next_object_linear, 5 + array->elements.length.ub + 4 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] Add NSArray.arrayWithObjects: and array access function Summary: As title Reviewed By: skcho Differential Revision: D22502619 fbshipit-source-id: 3af885170
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_object_at_indexed_constant, 34, OnUIThread:false, []
[frontend] Add translation of arrayWithObjects:count: Summary: This diff adds translation of `arrayWithObjects:count:`. In the previous implementation it was translated as if it was `arrayWithObjects:`, but their function parameters are different. In this diff, it translates an array literal `NSArray* a = @ [ 2, 3 ];` to ``` n$1=NSNumber.numberWithInt:(2:int) n$2=NSNumber.numberWithInt:(3:int) temp[0]:objc_object*=n$1 temp[1]:objc_object*=n$2 n$3=NSArray.arrayWithObjects:count:(temp:objc_object* const [2*8],2:int) a:NSArray*=n$3 ``` where `temp` is an additional local variable declared as array. See, https://developer.apple.com/documentation/foundation/nsarray/1460145-arraywithobjects https://developer.apple.com/documentation/foundation/nsarray/1460096-arraywithobjects?language=objc Reviewed By: jvillard Differential Revision: D22631305 fbshipit-source-id: 5be0a55d4
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_sort_using_descriptors_constant, 34, OnUIThread:false, []
codetoanalyze/objc/performance/NSArray.m, nsarray_sort_using_descriptors_nlogn_FN, 10, OnUIThread:false, []
[cost] add objc test for NSArray and NSMutableArray Summary: Add objc test for ```NSArray``` and ```NSMutableArray```. ```NSMutableArray``` is a subclass of ```NSArray```. For documentation of ```NSArray```, https://developer.apple.com/documentation/foundation/nsarray?language=objc For documentation of ```NSMutableArray```, https://developer.apple.com/documentation/foundation/nsmutablearray?language=objc The underlying mechanism for ```NSMutableArray``` is quite complicated. It changes the underlying data structure during runtime, so it is possible to have say O(log n) complexity for accessing element in array. (See here https://opensource.apple.com/source/CF/CF-855.11/CFArray.h) However, this is unlikely to happen if the engineer does not abuse the usage of the class ```NSMutableArray``` according to at least two ios engineers. So here the complexity is set to match the normal expectation of the complexity. Reviewed By: ezgicicek Differential Revision: D22041277 fbshipit-source-id: c27f43167
5 years ago
codetoanalyze/objc/performance/NSArray.m, objc_blocknsarray_binary_search_log_FN_1, 5, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_all_keys_linear1, 3 + 3 ⋅ dict->elements.length.ub + 4 ⋅ (dict->elements.length.ub + 1), OnUIThread:false, [{dict->elements.length.ub + 1},Loop,{dict->elements.length.ub},Loop]
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_all_keys_linear2, 6 + 3 ⋅ dict->elements.length.ub + 3 ⋅ (dict->elements.length.ub + 1), OnUIThread:false, [{dict->elements.length.ub + 1},Loop,{dict->elements.length.ub},Loop]
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_all_values_linear, 3 + 3 ⋅ dict->elements.length.ub + 4 ⋅ (dict->elements.length.ub + 1), OnUIThread:false, [{dict->elements.length.ub + 1},Loop,{dict->elements.length.ub},Loop]
[cost] add inferbo model for most common function of NSDictionary Summary: As title Reviewed By: skcho Differential Revision: D22572603 fbshipit-source-id: d9871cc3f
4 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_dictionary_with_objects_linear, 14 + 15 ⋅ n_entries + 3 ⋅ n_entries + 2 ⋅ (1+max(0, n_entries)) + 4 ⋅ (1+max(0, n_entries)), OnUIThread:false, [{1+max(0, n_entries)},Loop,{1+max(0, n_entries)},Loop,{n_entries},Loop,{n_entries},Loop]
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_enumerate_constant, 52, OnUIThread:false, []
[cost] add objc test for NSDictionary and NSMutableDictionary Summary: Add test for ```NSDictionary``` and ```NSMutableDictionary```. ```NSMutableDictionary``` is a subclass of ```NSDictionary```. [Doc] ```NSDictionary``` https://developer.apple.com/documentation/foundation/nsdictionary?language=objc ```NSMutableDictionary``` https://developer.apple.com/documentation/foundation/nsmutabledictionary?language=objc Reviewed By: skcho Differential Revision: D22041942 fbshipit-source-id: d1a1aa781
5 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_enumerator_linear_FN, 10, OnUIThread:false, []
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_fast_enumerate_linear_FN, 10, OnUIThread:false, []
[cost] add test for unmodeled inferbo functions that acts as control variable Summary: Create test for the most common unmodeled function in inferbo that acts as control variable. Reviewed By: skcho Differential Revision: D22331168 fbshipit-source-id: 1913682db
4 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_find_key_linear_FN, 19, OnUIThread:false, []
[cost] add objc test for NSDictionary and NSMutableDictionary Summary: Add test for ```NSDictionary``` and ```NSMutableDictionary```. ```NSMutableDictionary``` is a subclass of ```NSDictionary```. [Doc] ```NSDictionary``` https://developer.apple.com/documentation/foundation/nsdictionary?language=objc ```NSMutableDictionary``` https://developer.apple.com/documentation/foundation/nsmutabledictionary?language=objc Reviewed By: skcho Differential Revision: D22041942 fbshipit-source-id: d1a1aa781
5 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_init_dictionary_constant, 3, OnUIThread:false, []
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_init_literal_constant, 41, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_init_with_dictionary_linear_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
codetoanalyze/objc/performance/NSInteger.m, nsinteger_value_linear, 3 + 3 ⋅ integer + 2 ⋅ (1+max(0, integer)), OnUIThread:false, [{1+max(0, integer)},Loop,{integer},Loop]
[cost] add inferbo model for NSNumber Summary: As title Reviewed By: ezgicicek Differential Revision: D22411709 fbshipit-source-id: 994946a85
4 years ago
codetoanalyze/objc/performance/NSInteger.m, nsnumber_number_with_int_integer_value_constant, 34, OnUIThread:false, []
[cost] add NSMutableArray's add and remove function model Summary: As title Reviewed By: ezgicicek Differential Revision: D22975158 fbshipit-source-id: de4217a32
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_add_all_constant, 23, OnUIThread:false, []
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_add_in_loop_constant_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_add_in_loop_linear_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_add_in_loop_quadratic, 6 + 5 ⋅ n + 8 ⋅ n × m + 2 ⋅ n × (m + 1) + 2 ⋅ (n + 1), OnUIThread:false, [{n + 1},Loop,{m + 1},Loop,{m},Loop,{n},Loop]
[cost] add NSMutableArray's add and remove function model Summary: As title Reviewed By: ezgicicek Differential Revision: D22975158 fbshipit-source-id: de4217a32
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_add_then_loop_constant, 108, OnUIThread:false, []
[cost] add objc test for NSArray and NSMutableArray Summary: Add objc test for ```NSArray``` and ```NSMutableArray```. ```NSMutableArray``` is a subclass of ```NSArray```. For documentation of ```NSArray```, https://developer.apple.com/documentation/foundation/nsarray?language=objc For documentation of ```NSMutableArray```, https://developer.apple.com/documentation/foundation/nsmutablearray?language=objc The underlying mechanism for ```NSMutableArray``` is quite complicated. It changes the underlying data structure during runtime, so it is possible to have say O(log n) complexity for accessing element in array. (See here https://opensource.apple.com/source/CF/CF-855.11/CFArray.h) However, this is unlikely to happen if the engineer does not abuse the usage of the class ```NSMutableArray``` according to at least two ios engineers. So here the complexity is set to match the normal expectation of the complexity. Reviewed By: ezgicicek Differential Revision: D22041277 fbshipit-source-id: c27f43167
5 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_empty_ok_costant, 7, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_init_with_capacity_constant_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] add NSMutableArray's add and remove function model Summary: As title Reviewed By: ezgicicek Differential Revision: D22975158 fbshipit-source-id: de4217a32
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_remove_all_linear, 4 + 3 ⋅ array->elements.length.ub + array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Modeled call to NSArray.removeAllObjects,{array->elements.length.ub},Loop]
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_remove_constant, 17, OnUIThread:false, []
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_remove_in_loop_constant_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_set_in_loop_constant, 51, OnUIThread:false, []
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_set_linear, 3 + 11 ⋅ array->elements.length.ub + 3 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] add objc test for NSDictionary and NSMutableDictionary Summary: Add test for ```NSDictionary``` and ```NSMutableDictionary```. ```NSMutableDictionary``` is a subclass of ```NSDictionary```. [Doc] ```NSDictionary``` https://developer.apple.com/documentation/foundation/nsdictionary?language=objc ```NSMutableDictionary``` https://developer.apple.com/documentation/foundation/nsmutabledictionary?language=objc Reviewed By: skcho Differential Revision: D22041942 fbshipit-source-id: d1a1aa781
5 years ago
codetoanalyze/objc/performance/NSMutableDictionary.m, nsmutabledictionary_set_element_in_loop_linear_FN, 14, OnUIThread:false, []
[inferbo][cost] Check supertype in ObjC models Summary: We check for supertypes in Java. Why not ObjC? Would be good to get dulmarod's input here. Reviewed By: roro47 Differential Revision: D22817126 fbshipit-source-id: 52c1c3f3c
4 years ago
codetoanalyze/objc/performance/NSMutableString.m, nsmstring_append_string_constant, 14 + 3 ⋅ (str.length.ub + 5) + 3 ⋅ (str.length.ub + 6), OnUIThread:false, [{str.length.ub + 6},Loop,{str.length.ub + 5},Loop]
codetoanalyze/objc/performance/NSMutableString.m, nsmstring_append_string_linear, 5 + str2.length.ub + 3 ⋅ (str2.length.ub + str1.length.ub) + 3 ⋅ (str2.length.ub + str1.length.ub + 1), OnUIThread:false, [{str2.length.ub + str1.length.ub + 1},Loop,{str2.length.ub + str1.length.ub},Loop,{str2.length.ub},Modeled call to NSMutableString.appendString:]
[cost] add more inferbo and cost analysis models for NSString Summary: As title Reviewed By: skcho Differential Revision: D22663505 fbshipit-source-id: 61ee2d346
4 years ago
codetoanalyze/objc/performance/NSString.m, call_component_separated_by_char_constant, 46, OnUIThread:false, []
[cost] add inferbo model for init function of NSString and NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22844475 fbshipit-source-id: 0eb757bb0
4 years ago
codetoanalyze/objc/performance/NSString.m, call_init_with_string_constant, 15, OnUIThread:false, []
[cost] add more inferbo and cost analysis models for NSString Summary: As title Reviewed By: skcho Differential Revision: D22663505 fbshipit-source-id: 61ee2d346
4 years ago
codetoanalyze/objc/performance/NSString.m, component_seperated_by_char_linear, 6 + m.length.ub + 3 ⋅ (-1+max(2, m.length.ub)) + 3 ⋅ (max(2, m.length.ub)), OnUIThread:false, [{max(2, m.length.ub)},Loop,{-1+max(2, m.length.ub)},Loop,{m.length.ub},Modeled call to NSString.componentsSeparatedByString:]
codetoanalyze/objc/performance/NSString.m, component_seperated_by_string_linear, 6 + sep.length.ub × m.length.ub + 3 ⋅ (-1+max(2, m.length.ub)) + 3 ⋅ (max(2, m.length.ub)), OnUIThread:false, [{max(2, m.length.ub)},Loop,{-1+max(2, m.length.ub)},Loop,{m.length.ub},Modeled call to NSString.componentsSeparatedByString:,{sep.length.ub},Modeled call to NSString.componentsSeparatedByString:]
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSString.m, has_prefix_constant, 13, OnUIThread:false, []
[cost] add alloc for NSObject and NSString.init as an example function using alloc Summary: Implement `alloc` and implement initialisation method that uses the return value of `alloc`, i.e. `NSString.init`. Reviewed By: ezgicicek Differential Revision: D22840080 fbshipit-source-id: 47a7523e3
4 years ago
codetoanalyze/objc/performance/NSString.m, init_string_constant, 9, OnUIThread:false, []
[cost] add inferbo model for init function of NSString and NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22844475 fbshipit-source-id: 0eb757bb0
4 years ago
codetoanalyze/objc/performance/NSString.m, init_with_bytes_linear, 9 + 3 ⋅ length + 3 ⋅ (length + 1), OnUIThread:false, [{length + 1},Loop,{length},Loop]
codetoanalyze/objc/performance/NSString.m, init_with_string_constant, 39, OnUIThread:false, []
codetoanalyze/objc/performance/NSString.m, init_with_string_linear, 7 + 3 ⋅ s.length.ub + 3 ⋅ (s.length.ub + 1), OnUIThread:false, [{s.length.ub + 1},Loop,{s.length.ub},Loop]
[cost] add more inferbo and cost analysis models for NSString Summary: As title Reviewed By: skcho Differential Revision: D22663505 fbshipit-source-id: 61ee2d346
4 years ago
codetoanalyze/objc/performance/NSString.m, rangeof_character_from_set_linear, 5 + m.length.ub, OnUIThread:false, [{m.length.ub},Modeled call to NSString.rangeOfString:]
codetoanalyze/objc/performance/NSString.m, rangeof_string_quadratic, 5 + n.length.ub × m.length.ub, OnUIThread:false, [{m.length.ub},Modeled call to NSString.rangeOfString:,{n.length.ub},Modeled call to NSString.rangeOfString:]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/NSString.m, replace_linear_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSString.m, string_by_appending_path_component_linear, 4 + path.length.ub + file.length.ub, OnUIThread:false, [{file.length.ub},Modeled call to NSString.stringByAppendingPathComponent:,{path.length.ub},Modeled call to NSString.stringByAppendingPathComponent:]
[cost] add more inferbo and cost analysis models for NSString Summary: As title Reviewed By: skcho Differential Revision: D22663505 fbshipit-source-id: 61ee2d346
4 years ago
codetoanalyze/objc/performance/NSString.m, string_by_appending_same_string_linear, 11 + s.length.ub + 3 ⋅ (s.length.ub + 2) + 3 ⋅ (s.length.ub + 3), OnUIThread:false, [{s.length.ub + 3},Loop,{s.length.ub + 2},Loop,{s.length.ub},Modeled call to NSString.stringByAppendingString:]
codetoanalyze/objc/performance/NSString.m, string_by_appending_string_linear, 8 + m.length.ub + 3 ⋅ (m.length.ub + s.length.ub) + s.length.ub + 3 ⋅ (m.length.ub + s.length.ub + 1), OnUIThread:false, [{m.length.ub + s.length.ub + 1},Loop,{s.length.ub},Modeled call to NSString.stringByAppendingString:,{m.length.ub + s.length.ub},Loop,{m.length.ub},Modeled call to NSString.stringByAppendingString:]
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSString.m, string_has_prefix_linear, 4 + str.length.ub, OnUIThread:false, [{str.length.ub},Modeled call to NSString.hasPrefix:]
codetoanalyze/objc/performance/NSString.m, string_is_equal_to_string_linear, 4 + str1.length.ub, OnUIThread:false, [{str1.length.ub},Modeled call to NSString.isEqualToString:]
[cost] add model for NSString.string_with_utf8_string_linear and NSString.length Summary: As title Model `NSString` as `JavaString`. Since `NSArray` does not contain information about its type of element, we do not use associate string with collection as in Java and C++. In Java, String model is implemented using java collection, and for C++, string model is implemented using vector. So instead, we use existing `JavaString` model. Reviewed By: skcho Differential Revision: D22431949 fbshipit-source-id: 7cdde1ad7
4 years ago
codetoanalyze/objc/performance/NSString.m, string_length_linear, 3 + 3 ⋅ s.length.ub + 4 ⋅ (s.length.ub + 1), OnUIThread:false, [{s.length.ub + 1},Loop,{s.length.ub},Loop]
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/NSString.m, string_with_utf8_string_linear, 7 + 3 ⋅ p->strlen.ub + p->strlen.ub + 4 ⋅ (p->strlen.ub + 1), OnUIThread:false, [{p->strlen.ub + 1},Loop,{p->strlen.ub},Modeled call to NSString.stringWithUTF8String:,{p->strlen.ub},Loop]
[cost] add more inferbo and cost analysis models for NSString Summary: As title Reviewed By: skcho Differential Revision: D22663505 fbshipit-source-id: 61ee2d346
4 years ago
codetoanalyze/objc/performance/NSString.m, substring_no_end_linear, 10 + 6 ⋅ (-x + s.length.ub), OnUIThread:false, [{-x + s.length.ub},Loop]
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
codetoanalyze/objc/performance/araii.m, Araii.buffer, 4, OnUIThread:false, []
[cost] Record cost traces in cost-report.json Summary: We do not use an arbitrary threshold to test cost results anymore but instead rely on `cost-issues` which do not have any trace attached. This diff adds traces to `costs-report.json` so that we can test cost issues with traces. Reviewed By: skcho Differential Revision: D21858846 fbshipit-source-id: e73321a92
5 years ago
codetoanalyze/objc/performance/araii.m, Araii.dealloc, 4, OnUIThread:false, []
codetoanalyze/objc/performance/araii.m, Araii.initWithBuffer, 15, OnUIThread:false, []
[clang] Add implicit implementations for ObjC getters and setters as a preanalysis Summary: Move the implementation of implicit getters and setters from the biabduction to the clang frontend so these methods are accessible to all the checkers. *Background*: In Objective-C when properties are created in the interface of a class, the compiler creates automatically the instance variable for it and also the getter and setter in the implementation of the class. In the frontend we collect the information about which method is the implicit getter and setter of which instance variable (we get the method declaration but not the implementation), and here we add the implicit implementation. Reviewed By: skcho Differential Revision: D22187238 fbshipit-source-id: 76e0508ed
4 years ago
codetoanalyze/objc/performance/araii.m, Araii.setBuffer:, 4, OnUIThread:false, []
[cost] Record cost traces in cost-report.json Summary: We do not use an arbitrary threshold to test cost results anymore but instead rely on `cost-issues` which do not have any trace attached. This diff adds traces to `costs-report.json` so that we can test cost issues with traces. Reviewed By: skcho Differential Revision: D21858846 fbshipit-source-id: e73321a92
5 years ago
codetoanalyze/objc/performance/araii.m, memory_leak_raii_main, 18, OnUIThread:false, []
[cost] add NSArray iterator Summary: As title. This diff is co-authored by SungKeun Cho and me. facebook This diff is co-authored by skcho and me. Original comments from skcho "For the record: 1. Rory and I tried to write models for ObjC iterator. 2. We could not use Java's iterator semantics: In Java's, `hasNext` returns the size of collection, rather than a boolean, and which is used as a control variable. On the other hand, in ObjC, it calls only `nextObject`, not calling `hasNext`, and the return value of which is being checked as `null`. 3. We added an artificial field `objc_iterator_offset` to keep the index of the iterator, and the models added in this diff are handling that integer value. A problem is that `array.objc_iterator_offset` is not included in the control variables, since the condition of the loop is `nextObject() != null` that does not include the iterator offset. We need to make `array.objc_iterator_offset` as a control variable, by changing the part collecting control variables. " Reviewed By: ezgicicek, skcho Differential Revision: D22944278 fbshipit-source-id: 7e71b79c1
4 years ago
codetoanalyze/objc/performance/block.m, block_multiply_array_linear, 13 + 5 ⋅ array->elements.length.ub + 4 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Call to objc_blockblock_multiply_array_linear_1,Loop,{array->elements.length.ub},Call to objc_blockblock_multiply_array_linear_1,Loop]
codetoanalyze/objc/performance/block.m, objc_blockblock_multiply_array_linear_1, 8 + 5 ⋅ array->elements.length.ub + 4 ⋅ (array->elements.length.ub + 1), OnUIThread:false, [{array->elements.length.ub + 1},Loop,{array->elements.length.ub},Loop]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/break.m, break_constant_FP, 8 + 5 ⋅ p + 2 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Call to break_loop,Loop,{p},Call to break_loop,Loop]
codetoanalyze/objc/performance/break.m, break_loop, 5 + 5 ⋅ p + 2 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Loop,{p},Loop]
codetoanalyze/objc/performance/break.m, break_loop_with_t, 7 + 5 ⋅ p + 2 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Loop,{p},Loop]
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/cf.m, array_count_linear, 6 + 3 ⋅ arr->elements.length.ub + 2 ⋅ (arr->elements.length.ub + 1), OnUIThread:false, [{arr->elements.length.ub + 1},Loop,{arr->elements.length.ub},Loop]
codetoanalyze/objc/performance/cf.m, cf_array_create_copy_linear, 8 + 3 ⋅ arrayValues.elements.length + 2 ⋅ (arrayValues.elements.length + 1), OnUIThread:false, [{arrayValues.elements.length + 1},Loop,{arrayValues.elements.length},Loop]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cf.m, cf_array_create_linear, 11 + 3 ⋅ x + 2 ⋅ (1+max(0, x)), OnUIThread:false, [{1+max(0, x)},Loop,{x},Loop]
[cost] write ObjC's NSCollection model separately and refactor Summary: When implementing iterator, we find out that because some semantics of inferbo is Java-specific, we cannot simply use Java's `Collection` model for `NSCollection`. So this diff writing `NSCollection` model separately. This diff also extracts the common parts of `NSCollection` and `Collection` into `AbstractCollection` to combine the duplicate the parts. Reviewed By: ezgicicek Differential Revision: D22975159 fbshipit-source-id: daed3f99f
4 years ago
codetoanalyze/objc/performance/cf.m, dict_count_linear, 6 + 3 ⋅ dict->elements.length.ub + 2 ⋅ (dict->elements.length.ub + 1), OnUIThread:false, [{dict->elements.length.ub + 1},Loop,{dict->elements.length.ub},Loop]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/compound_loop_guard.m, compound_while, 7 + 3 ⋅ m + 4 ⋅ (1+max(0, m)), OnUIThread:false, [{1+max(0, m)},Loop,{m},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/compound_loop_guard.m, nested_while_and_or_constant, 20, OnUIThread:false, []
codetoanalyze/objc/performance/compound_loop_guard.m, simplified_simulated_while_with_and_constant, 605, OnUIThread:false, []
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_nested_loop_with_and_constant, 3529, OnUIThread:false, []
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_while_shortcut_constant, 9, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_while_with_and_linear, 6 + 3 ⋅ p + 4 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Loop,{p},Loop]
codetoanalyze/objc/performance/compound_loop_guard.m, while_and_or, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] Record cost traces in cost-report.json Summary: We do not use an arbitrary threshold to test cost results anymore but instead rely on `cost-issues` which do not have any trace attached. This diff adds traces to `costs-report.json` so that we can test cost issues with traces. Reviewed By: skcho Differential Revision: D21858846 fbshipit-source-id: e73321a92
5 years ago
codetoanalyze/objc/performance/control.m, __infer_globals_initializer_gvar, 2, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/control.m, wrong_cvar_FP, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test.m, always, 9, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cost_test.m, call_infinite, ⊤, OnUIThread:false, [Call to infinite,Unbounded loop,Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test.m, call_while_upto20_10_constant, 56, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test.m, call_while_upto20_minus100_constant, 606, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cost_test.m, call_while_upto20_unsigned, 6 + 4 ⋅ (-x + 20) + (21-min(20, x)), OnUIThread:false, [{21-min(20, x)},Call to while_upto20,Loop,{-x + 20},Call to while_upto20,Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test.m, cond_constant, 14, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test.m, div_const, 3, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test.m, foo_constant, 6, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cost_test.m, infinite, ⊤, OnUIThread:false, [Unbounded loop,Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test.m, infinite_FN, 19, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test.m, iter_div_const_constant, 109, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test.m, loop0_constant, 1005, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test.m, loop3_constant, 97, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cost_test.m, loop_character_symbols_linear, 5 + 4 ⋅ (122-min(97, c)), OnUIThread:false, [{122-min(97, c)},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test.m, unit_cost_function, 1, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cost_test.m, while_upto20, 4 + 4 ⋅ (-m + 20) + (21-min(20, m)), OnUIThread:false, [{21-min(20, m)},Loop,{-m + 20},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test_deps.m, if_bad_constant, 75, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, if_bad_loop_constant, 203, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, loop_despite_inferbo_constant, 1208, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, nested_loop_constant, 2547, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, real_while_constant, 218, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, simulated_nested_loop_cond_in_goto_constant, 3534, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, simulated_nested_loop_constant, 2529, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, simulated_nested_loop_more_expensive_constant, 2534, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, simulated_while_constant, 218, OnUIThread:false, []
codetoanalyze/objc/performance/cost_test_deps.m, two_loops, 549, OnUIThread:false, []
codetoanalyze/objc/performance/exit.m, call_exit_unreachable, ⊥, OnUIThread:false, [Unreachable node]
codetoanalyze/objc/performance/exit.m, call_unreachable_constant, 2, OnUIThread:false, []
codetoanalyze/objc/performance/exit.m, compute_exit_unreachable, ⊥, OnUIThread:false, [Unreachable node]
codetoanalyze/objc/performance/exit.m, exit_unreachable, ⊥, OnUIThread:false, [Unreachable node]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/exit.m, inline_exit_unreachable_FP, 3 ⋅ p + 2 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Loop,{p},Loop]
codetoanalyze/objc/performance/exit.m, linear, 3 + 3 ⋅ p + 2 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Loop,{p},Loop]
[cost] add objc test for customized_class and blocks Summary: Add objc test for customized class and blocks. Mostly sanity test. Reviewed By: ezgicicek Differential Revision: D22043918 fbshipit-source-id: 917deeea7
4 years ago
codetoanalyze/objc/performance/field_access.m, Person.add_income_constant:, 12, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Person.bank_account, 4, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Person.dealloc, 4, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Person.init_with_name_constant:, 22, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Person.name, 4, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Person.setBank_account:, 4, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Person.setName:, 4, OnUIThread:false, []
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/field_access.m, Person.species_name_constant, 7, OnUIThread:false, []
[cost] add objc test for customized_class and blocks Summary: Add objc test for customized class and blocks. Mostly sanity test. Reviewed By: ezgicicek Differential Revision: D22043918 fbshipit-source-id: 917deeea7
4 years ago
codetoanalyze/objc/performance/field_access.m, Test1.dealloc, 1, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Test1.setX:, 4, OnUIThread:false, []
codetoanalyze/objc/performance/field_access.m, Test1.x, 4, OnUIThread:false, []
[cost] add cost model for most common NSString functions Summary: Add cost model for most common `NSString` functions in cost analysis Reviewed By: skcho Differential Revision: D22433005 fbshipit-source-id: 2f57bbda9
4 years ago
codetoanalyze/objc/performance/field_access.m, create_common_person_constant, 57, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/field_access.m, iterate_upto_field_size_linear, 3 + 3 ⋅ test->_x.ub + 6 ⋅ (1+max(0, test->_x.ub)), OnUIThread:false, [{1+max(0, test->_x.ub)},Loop,{test->_x.ub},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/instantiate.m, do_2_times_constant, 20, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/instantiate.m, do_half_m2_times_quadratic, 3 + 5 ⋅ (m - 1) × m + 7 ⋅ m + 2 ⋅ m × (max(1, m)) + 2 ⋅ (1+max(0, m)), OnUIThread:false, [{1+max(0, m)},Loop,{max(1, m)},Call to do_n_times,Loop,{m},Loop,{m},Loop,{m - 1},Call to do_n_times,Loop]
codetoanalyze/objc/performance/instantiate.m, do_m2_times_quadratic, 3 + 7 ⋅ m + 5 ⋅ m × m + 2 ⋅ m × (1+max(0, m)) + 2 ⋅ (1+max(0, m)), OnUIThread:false, [{1+max(0, m)},Loop,{1+max(0, m)},Call to do_n_times,Loop,{m},Call to do_n_times,Loop,{m},Loop]
codetoanalyze/objc/performance/instantiate.m, do_n_times, 3 + 5 ⋅ n + 2 ⋅ (1+max(0, n)), OnUIThread:false, [{1+max(0, n)},Loop,{n},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/instantiate.m, no_op, 2, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/invariant.m, do_n_m_times_nested, 7 + 5 ⋅ n + 3 ⋅ n × m + 2 ⋅ n × (1+max(0, m)) + 2 ⋅ (1+max(0, n)), OnUIThread:false, [{1+max(0, n)},Loop,{1+max(0, m)},Loop,{m},Loop,{n},Loop]
codetoanalyze/objc/performance/invariant.m, two_loops_nested_invariant, 6 + 23 ⋅ p + 2 ⋅ (1+max(0, p)), OnUIThread:false, [{1+max(0, p)},Loop,{p},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/invariant.m, while_infinite_FN, 2, OnUIThread:false, []
codetoanalyze/objc/performance/invariant.m, while_unique_def_FN, 15, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/jump_inside_loop.m, jump_inside_loop_constant_linear, 9 + (k - 1) + 4 ⋅ (max(1, k)), OnUIThread:false, [{max(1, k)},Loop,{k - 1},Loop]
codetoanalyze/objc/performance/jump_inside_loop.m, loop_always_linear, 7 + k + 2 ⋅ (max(1, k)) + 2 ⋅ (1+max(1, k)), OnUIThread:false, [{1+max(1, k)},Loop,{max(1, k)},Loop,{k},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/loops.m, __infer_globals_initializer_array1, 4, OnUIThread:false, []
codetoanalyze/objc/performance/loops.m, __infer_globals_initializer_array2, 2, OnUIThread:false, []
codetoanalyze/objc/performance/loops.m, do_while_independent_of_p, 228, OnUIThread:false, []
codetoanalyze/objc/performance/loops.m, if_in_loop, 324, OnUIThread:false, []
codetoanalyze/objc/performance/loops.m, if_out_loop, 515, OnUIThread:false, []
codetoanalyze/objc/performance/loops.m, larger_state_FN, 1005, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/loops.m, loop_use_global_vars, 4 + 4 ⋅ x + 2 ⋅ (1+max(0, x)), OnUIThread:false, [{1+max(0, x)},Loop,{x},Loop]
codetoanalyze/objc/performance/loops.m, ptr_cmp, 5 + 5 ⋅ size + 2 ⋅ (2+max(-1, size)), OnUIThread:false, [{2+max(-1, size)},Loop,{size},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/purity.m, loop, 7007, OnUIThread:false, []
codetoanalyze/objc/performance/switch_continue.m, test_switch_FN, 601, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/switch_continue.m, unroll_loop, 16 + (n - 1) + 11 ⋅ (max(1, n)), OnUIThread:false, [{max(1, n)},Loop,{n - 1},Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/two_loops_symbolic.m, nop, 2, OnUIThread:false, []
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/two_loops_symbolic.m, two_loops_symb_diff, 8 + 5 ⋅ k + 5 ⋅ m + 2 ⋅ (1+max(0, k)) + 2 ⋅ (1+max(0, m)), OnUIThread:false, [{1+max(0, m)},Loop,{1+max(0, k)},Loop,{m},Loop,{k},Loop]
[cost] Fix unreachable node Top poisoning Summary: If a node is unreachable and the cost of the node is Top, we were giving Top cost :( Let's fix it. Reviewed By: skcho Differential Revision: D22548269 fbshipit-source-id: d79743669
4 years ago
codetoanalyze/objc/performance/unreachable.m, always_ret_false, 2, OnUIThread:false, []
codetoanalyze/objc/performance/unreachable.m, linear_loop, 3 + 3 ⋅ x + 2 ⋅ (1+max(0, x)), OnUIThread:false, [{1+max(0, x)},Loop,{x},Loop]
codetoanalyze/objc/performance/unreachable.m, unreachable_branch_constant, 4, OnUIThread:false, []
codetoanalyze/objc/performance/unreachable.m, unreachable_branch_constant2, 4, OnUIThread:false, []
codetoanalyze/objc/performance/unreachable.m, unreachable_branch_linear_loop, 8 + 3 ⋅ x + 2 ⋅ (1+max(0, x)), OnUIThread:false, [{1+max(0, x)},Call to linear_loop,Loop,{x},Call to linear_loop,Loop]