You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

233 lines
7.9 KiB

(*
* Copyright (c) 2016 - present Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*)
open! IStd
module F = Format
module L = Logging
module SourceKind = struct
type t =
| Endpoint of (Mangled.t * Typ.desc) (** source originating from formal of an endpoint *)
| EnvironmentVariable (** source that was read from an environment variable *)
| File (** source that was read from a file *)
| Other (** for testing or uncategorized sources *)
| Unknown
[@@deriving compare]
let unknown = Unknown
let of_string = function
| "Endpoint" -> Endpoint (Mangled.from_string "NONE", Typ.Tvoid)
| "EnvironmentVariable" -> EnvironmentVariable
| "File" -> File
| _ -> Other
let external_sources =
List.map
~f:(fun { QuandaryConfig.Source.procedure; kind; index; } ->
QualifiedCppName.Match.of_fuzzy_qual_names [procedure], kind, index)
(QuandaryConfig.Source.of_json Config.quandary_sources)
let endpoints = String.Set.of_list (QuandaryConfig.Endpoint.of_json Config.quandary_endpoints)
(* return Some(source kind) if [procedure_name] is in the list of externally specified sources *)
let get_external_source qualified_pname =
let return = None in
List.find_map
~f:(fun (qualifiers, kind, index) ->
if QualifiedCppName.Match.match_qualifiers qualifiers qualified_pname
then
let source_index =
try Some (int_of_string index)
with Failure _ -> return in
Some (of_string kind, source_index)
else None)
external_sources
let get pname _ =
let return = None in
match pname with
| Typ.Procname.ObjC_Cpp cpp_name ->
let qualified_pname = Typ.Procname.get_qualifiers pname in
begin
match
(QualifiedCppName.to_list
(Typ.Name.unqualified_name (Typ.Procname.objc_cpp_get_class_type_name cpp_name))),
Typ.Procname.get_method pname with
| ["std"; ("basic_istream" | "basic_iostream")],
("getline" | "read" | "readsome" | "operator>>") ->
Some (File, Some 1)
| _ ->
get_external_source qualified_pname
end
| Typ.Procname.C _ ->
begin
match Typ.Procname.to_string pname with
| "getenv" ->
Some (EnvironmentVariable, return)
| _ ->
get_external_source (Typ.Procname.get_qualifiers pname)
end
| Typ.Procname.Block _ ->
None
| pname when BuiltinDecl.is_declared pname ->
None
| pname ->
failwithf "Non-C++ procname %a in C++ analysis@." Typ.Procname.pp pname
let get_tainted_formals pdesc _ =
match Procdesc.get_proc_name pdesc with
| (Typ.Procname.ObjC_Cpp objc) as pname ->
let qualified_pname =
F.sprintf "%s::%s"
(Typ.Procname.objc_cpp_get_class_name objc)
(Typ.Procname.get_method pname) in
if String.Set.mem endpoints qualified_pname
then
List.map
~f:(fun (name, typ) -> name, typ, Some (Endpoint (name, typ.Typ.desc)))
(Procdesc.get_formals pdesc)
else
Source.all_formals_untainted pdesc
| _ ->
Source.all_formals_untainted pdesc
let pp fmt kind =
F.fprintf fmt "%s"
(match kind with
| Endpoint (formal_name, _) -> F.sprintf "Endpoint[%s]" (Mangled.to_string formal_name)
| EnvironmentVariable -> "EnvironmentVariable"
| File -> "File"
| Other -> "Other"
| Unknown -> "Unknown")
end
module CppSource = Source.Make(SourceKind)
module SinkKind = struct
type t =
| Allocation (** memory allocation *)
| ShellExec (** shell exec function *)
| SQL (** SQL query *)
| Other (** for testing or uncategorized sinks *)
[@@deriving compare]
let of_string = function
| "Allocation" -> Allocation
| "ShellExec" -> ShellExec
| "SQL" -> SQL
| _ -> Other
let external_sinks =
List.map
~f:(fun { QuandaryConfig.Sink.procedure; kind; index; } ->
QualifiedCppName.Match.of_fuzzy_qual_names [procedure], kind, index)
(QuandaryConfig.Sink.of_json Config.quandary_sinks)
(* taint the nth parameter (0-indexed) *)
let taint_nth n kind =
Some (kind, IntSet.singleton n)
let taint_all actuals kind =
Some (kind, IntSet.of_list (List.mapi ~f:(fun actual_num _ -> actual_num) actuals))
(* return Some(sink kind) if [procedure_name] is in the list of externally specified sinks *)
let get_external_sink pname actuals =
let qualified_pname = Typ.Procname.get_qualifiers pname in
List.find_map
~f:(fun (qualifiers, kind, index) ->
if QualifiedCppName.Match.match_qualifiers qualifiers qualified_pname
then
let kind = of_string kind in
try
let n = int_of_string index in
taint_nth n kind
with Failure _ ->
(* couldn't parse the index, just taint everything *)
taint_all actuals kind
else
None)
external_sinks
let get pname actuals _ =
match pname with
| Typ.Procname.ObjC_Cpp _ ->
get_external_sink pname actuals
| Typ.Procname.C _ ->
begin
match Typ.Procname.to_string pname with
| "execl" | "execlp" | "execle" | "execv" | "execve" | "execvp" | "system" ->
taint_all actuals ShellExec
| "brk" | "calloc" | "malloc" | "realloc" | "sbrk" ->
taint_all actuals Allocation
| _ ->
get_external_sink pname actuals
end
| Typ.Procname.Block _ ->
None
| pname when BuiltinDecl.is_declared pname ->
None
| pname ->
failwithf "Non-C++ procname %a in C++ analysis@." Typ.Procname.pp pname
let pp fmt kind =
F.fprintf fmt
(match kind with
| Allocation -> "Allocation"
| ShellExec -> "ShellExec"
| SQL -> "SQL"
| Other -> "Other")
end
module CppSink = Sink.Make(SinkKind)
include
Trace.Make(struct
module Source = CppSource
module Sink = CppSink
let should_report source sink =
(* using this to match custom string wrappers such as folly::StringPiece *)
let is_stringy typ =
let lowercase_typ = String.lowercase (Typ.to_string (Typ.mk typ)) in
String.is_substring ~substring:"string" lowercase_typ ||
String.is_substring ~substring:"char*" lowercase_typ in
match Source.kind source, Sink.kind sink with
| Endpoint (_, typ), (ShellExec | SQL) ->
(* untrusted string data flowing to shell exec/SQL *)
is_stringy typ
| (EnvironmentVariable | File), (ShellExec | SQL) ->
(* untrusted environment var or file data flowing to shell exec *)
true
| (Endpoint _ | EnvironmentVariable | File), Allocation ->
(* untrusted data flowing to memory allocation *)
true
| _, (Allocation | Other | ShellExec | SQL) when Source.is_footprint source ->
(* is this var a command line flag created by the popular gflags library? *)
let is_gflag pvar =
String.is_substring ~substring:"FLAGS_" (Pvar.get_simplified_name pvar) in
begin
match Option.map ~f:AccessPath.extract (Source.get_footprint_access_path source) with
| Some ((Var.ProgramVar pvar, _), _) when Pvar.is_global pvar && is_gflag pvar ->
(* gflags globals come from the environment; treat them as sources *)
true
| _ ->
false
end
| Other, _ ->
(* Other matches everything *)
true
| _, Other ->
true
| Unknown, (Allocation | ShellExec | SQL) ->
false
end)