pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'c9f3e20fc4'
${ noResults }
infer_clone/infer/tests/codetoanalyze/java/litho/issues.exp

40 lines
10 KiB
Raw Normal View History Unescape

[required-props] Add call chain to trace Summary: Improve the trace by incorporating the callees and their locations in the call chain (i.e. chain of methods starting from `build()` call) - extend the domain to contain the callee location - replace the test results with the new traces This makes our job much easier to debug FPs in a big codebase. Reviewed By: skcho Differential Revision: D17788996 fbshipit-source-id: 31938b5fe
5 years ago
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.FP_setRequiredOnBothBranchesOk(boolean):com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop1 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop2(Object),calls MyComponent$Builder MyComponent$Builder.prop3(Object),calls MyComponent MyComponent$Builder.build()]
[required-props] Add more tests showing the ineffectiveness of callee heuristic Summary: As a heuristic, litho library calls on non-litho callers are not tracked. This is very imprecise and results in FPs and FNs as exemplified by newly added tests. Instead, we should check to see if the summary contains a `build()` method as will be done in the next diff. This diff adds these tests and refactors the test code. Reviewed By: skcho Differential Revision: D17809536 fbshipit-source-id: 6dff1868c
5 years ago
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildPropLithoOK_FP():com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop1 is required for component com.facebook.litho.MyLithoComponent, but is not set before the call to build(),calls MyLithoComponent MyLithoComponent$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildPropLithoOK_FP():com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop2 is required for component com.facebook.litho.MyLithoComponent, but is not set before the call to build(),calls MyLithoComponent MyLithoComponent$Builder.build()]
[required-props] Add call chain to trace Summary: Improve the trace by incorporating the callees and their locations in the call chain (i.e. chain of methods starting from `build()` call) - extend the domain to contain the callee location - replace the test results with the new traces This makes our job much easier to debug FPs in a big codebase. Reviewed By: skcho Differential Revision: D17788996 fbshipit-source-id: 31938b5fe
5 years ago
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildPropResMissingBad():void, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop is required for component codetoanalyze.java.litho.ResPropComponent, but is not set before the call to build(),calls ResPropComponent ResPropComponent$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildPropVarArgMissingBad():void, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [Either @Prop props or @Prop(varArg = prop) is required for component codetoanalyze.java.litho.VarArgPropComponent, but is not set before the call to build(),calls VarArgPropComponent VarArgPropComponent$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildWithColumnChildBad():void, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop3 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop1(Object),calls Component Component$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildWithout1Bad():com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop1 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop2(Object),calls MyComponent$Builder MyComponent$Builder.prop3(Object),calls MyComponent MyComponent$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.buildWithout3Bad():com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop3 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop1(Object),calls MyComponent$Builder MyComponent$Builder.prop2(Object),calls MyComponent MyComponent$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.callBuildSuffixWithoutRequiredBad():com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop1 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop2(Object),calls MyComponent$Builder MyComponent$Builder.prop3(Object),calls MyComponent MyComponent$Builder.build()]
[required-props] Add more tests showing the ineffectiveness of callee heuristic Summary: As a heuristic, litho library calls on non-litho callers are not tracked. This is very imprecise and results in FPs and FNs as exemplified by newly added tests. Instead, we should check to see if the summary contains a `build()` method as will be done in the next diff. This diff adds these tests and refactors the test code. Reviewed By: skcho Differential Revision: D17809536 fbshipit-source-id: 6dff1868c
5 years ago
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.generalTypeForgot3Bad():java.lang.Object, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop3 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop1(Object),calls Component MyComponent$Builder.build()]
[required-props] Add call chain to trace Summary: Improve the trace by incorporating the callees and their locations in the call chain (i.e. chain of methods starting from `build()` call) - extend the domain to contain the callee location - replace the test results with the new traces This makes our job much easier to debug FPs in a big codebase. Reviewed By: skcho Differential Revision: D17788996 fbshipit-source-id: 31938b5fe
5 years ago
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.setProp3InCalleeButForgetProp1Bad():com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop1 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop3(Object),calls MyComponent$Builder MyComponent$Builder.prop2(Object),calls MyComponent MyComponent$Builder.build()]
codetoanalyze/java/litho/RequiredProps.java, codetoanalyze.java.litho.RequiredProps.setRequiredOnOneBranchBad(boolean):com.facebook.litho.Component, 0, MISSING_REQUIRED_PROP, no_bucket, ERROR, [@Prop prop1 is required for component codetoanalyze.java.litho.MyComponent, but is not set before the call to build(),calls MyComponent$Builder MyComponent$Builder.prop2(Object),calls MyComponent$Builder MyComponent$Builder.prop3(Object),calls MyComponent MyComponent$Builder.build()]
[litho] Hookup litho tests to main test suite Reviewed By: jvillard Differential Revision: D17093299 fbshipit-source-id: c6533723f
5 years ago
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout():void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout():void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors().get(...).toString()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout():void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors().get(...)]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout():void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors().size()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC().getD()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,boolean):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC().getD()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,boolean):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,boolean):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,char):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC().getD()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,char):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,char):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,double):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getA()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,float):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getA()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getC()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getC().getD()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC().getD()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC().getD()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.A,int,int):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [a.getB().getC()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.GraphQLStory):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.GraphQLStory):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors().get(...).toString()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.GraphQLStory):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors().size()]
codetoanalyze/java/litho/ShouldUpdate.java, com.facebook.graphql.model.LithoTest.onCreateLayout(com.facebook.graphql.model.GraphQLStory):void, 0, GRAPHQL_FIELD_ACCESS, no_bucket, ERROR, [story.getActors().get(...)]