pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'd3eb554e8c'
${ noResults }
infer_clone/infer/tests/codetoanalyze/java/performance/issues.exp

87 lines
20 KiB
Raw Normal View History Unescape

[cost] Brush up tests (1) Summary: Fix misleading test names. Correct FP/ok/bad markers. To be continued... Reviewed By: skcho Differential Revision: D21905556 fbshipit-source-id: 161801f9c
5 years ago
codetoanalyze/java/performance/Array.java, codetoanalyze.java.performance.Array.array_access_overrun_constant():void, 4, BUFFER_OVERRUN_L2, no_bucket, ERROR, [<Offset trace>,Assignment,<Length trace>,Array declaration,Array access: Offset: [2, 8] Size: 8]
[inferbo] Weak update on array contents Summary: The `represents_multiple_values` flag was adopted to decide whether updating abstract value strongly or weakly. However, the flag was included in the `Val` domain, which is strange, because it is a property of abstract locations, rather than abstract values. This makes the behavior of memory update function depend on the abstract value to update, making its code complicated. This diff detach the `represents_multiple_values` flag from the `Value` domain, thus the memory update does not depend on the abstract value. Since this is a refactoring, I believe the diff should not make many semantic changes. Reviewed By: ezgicicek Differential Revision: D16441734 fbshipit-source-id: 4c10779d7
5 years ago
codetoanalyze/java/performance/Array.java, codetoanalyze.java.performance.Array.call_gen_and_iter_types_linear_FP(int,int):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 88]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Array.java, codetoanalyze.java.performance.Array.call_gen_and_iter_types_linear_FP(int,int):void, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_add3_overrun_bad():void, 5, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Through,Through,Array access: Offset added: 4 Size: 3]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_addAll_bad():void, 10, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Through,Through,Array access: Offset added: 5 Size: 4]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_empty_overrun_bad():void, 2, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset added: 1 Size: 0]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_empty_underrun_bad():void, 2, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset added: -1 Size: 0]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_get_overrun_bad():void, 3, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Array access: Offset: 2 Size: 1]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_get_underrun_bad():void, 2, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset: 0 Size: 0]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_remove_bad():void, 5, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Through,Through,Array access: Offset: 1 Size: 1]
[inferbo] Distinguish array declaration and size-setting in trace Summary: This diff distinguishes array declaration and size-setting in trace. For example, when there is an assume statement on an array size, the array size can be pruned to another value. In which case, we want to see "Set array size" in the trace, instead of "Array declaration". Reviewed By: jvillard Differential Revision: D20914930 fbshipit-source-id: 0253fb69e
5 years ago
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_remove_in_loop_Good():void, 6, BUFFER_OVERRUN_L5, no_bucket, ERROR, [<Offset trace>,Assignment,<Length trace>,Set array size,Array access: Offset: [0, 9] Size: [0, 10]]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_remove_overrun_bad():void, 3, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Array access: Offset: 1 Size: 1]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_set_overrun_bad():void, 3, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Array access: Offset: 1 Size: 1]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.arraylist_set_underrun_bad():void, 2, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Array access: Offset: 0 Size: 0]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.empty_list_constant(int):void, 3, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/ArrayListTest.java, ArrayListTest.substitute_array_block_linear(java.util.ArrayList,java.util.ArrayList):void, 8, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [Parameter `b.elements[*]`,Call,Parameter `a.elements[*]`,Through,Through,Call,<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32 by call to `void ArrayListTest.iterate_over_arraylist(ArrayList)` ]
[cost] Refactor cost issue types and enable detecting allocation complexity increase on cold start Summary: - Add allocation costs to `costs-report.json` and enable diffing over allocation costs. - Also, let's be more consistent and modular in naming our cost issues. - introduce a generic issue type `X_TIME_COMPLEXITY_INCREASE` where `X` can be one of the cost kinds. If the function is on the cold start, issue can have the `COLD_START` suffix. Similarly for infinite/zero/expensive calls. - Change `PERFORMANCE_VARIATION` -> `EXECUTION_TIME_COMPLEXITY_INCREASE` - Add new issue type for `ALLOCATION_COMPLEXITY_INCREASE_COLD_START` which will be enabled by default - Refactor cost issues to be more modular and succinct. This also makes addition of a new cost kind very easy by adding the kind into the `enabled_cost_kinds` list in `CostKind.ml` Reviewed By: mbouaziz Differential Revision: D15822681 fbshipit-source-id: cf89ece59
6 years ago
codetoanalyze/java/performance/CantHandle.java, CantHandle.square_root_FP(int):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 17]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/CantHandle.java, CantHandle.square_root_FP(int):void, 2, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] × [0, +oo]):signed32]
codetoanalyze/java/performance/CantHandle.java, CantHandle.square_root_FP(int):void, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Refactor cost issue types and enable detecting allocation complexity increase on cold start Summary: - Add allocation costs to `costs-report.json` and enable diffing over allocation costs. - Also, let's be more consistent and modular in naming our cost issues. - introduce a generic issue type `X_TIME_COMPLEXITY_INCREASE` where `X` can be one of the cost kinds. If the function is on the cold start, issue can have the `COLD_START` suffix. Similarly for infinite/zero/expensive calls. - Change `PERFORMANCE_VARIATION` -> `EXECUTION_TIME_COMPLEXITY_INCREASE` - Add new issue type for `ALLOCATION_COMPLEXITY_INCREASE_COLD_START` which will be enabled by default - Refactor cost issues to be more modular and succinct. This also makes addition of a new cost kind very easy by adding the kind into the `enabled_cost_kinds` list in `CostKind.ml` Reviewed By: mbouaziz Differential Revision: D15822681 fbshipit-source-id: cf89ece59
6 years ago
codetoanalyze/java/performance/CantHandle.java, CantHandle.square_root_variant_FP(int):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 25]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/CantHandle.java, CantHandle.square_root_variant_FP(int):void, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Parameter `x`,Binary operation: ([0, +oo] + 1):signed32]
[cost] Add a test (recursive dependency in class initializers) Reviewed By: jvillard Differential Revision: D20389989 fbshipit-source-id: a89d7c478
5 years ago
codetoanalyze/java/performance/CollectionTest.java, CollectionTest$MyEnumType$1.<init>(), 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Update test results Summary: The `iterate_over_mycollection_quad_FN` was not actually FN because infer analyzes its complexity as degree 2 correctly. So, this diff removed `_FN` from there. Reviewed By: ezgicicek Differential Revision: D20467398 fbshipit-source-id: b10340612
5 years ago
codetoanalyze/java/performance/CollectionTest.java, CollectionTest$MyEnumType.<clinit>():void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to CollectionTest$MyEnumType$1.<init>(),Unbounded loop,Loop at line 88]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/CollectionsTest.java, CollectionsTest.emptyList_constant():void, 1, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/CollectionsTest.java, CollectionsTest.emptySet_zero():void, 2, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/CollectionsTest.java, CollectionsTest.globalEmptyList_constant():void, 1, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.compound_while(int):int, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[inferbo] Add traces to Conditions always true/false and Unreachable code Reviewed By: ezgicicek Differential Revision: D13082665 fbshipit-source-id: bb0e4cbf3
6 years ago
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.nested_while_and_or(int):int, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.nested_while_and_or(int):int, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.nested_while_and_or(int):int, 4, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.nested_while_and_or(int):int, 4, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] Refactor cost issue types and enable detecting allocation complexity increase on cold start Summary: - Add allocation costs to `costs-report.json` and enable diffing over allocation costs. - Also, let's be more consistent and modular in naming our cost issues. - introduce a generic issue type `X_TIME_COMPLEXITY_INCREASE` where `X` can be one of the cost kinds. If the function is on the cold start, issue can have the `COLD_START` suffix. Similarly for infinite/zero/expensive calls. - Change `PERFORMANCE_VARIATION` -> `EXECUTION_TIME_COMPLEXITY_INCREASE` - Add new issue type for `ALLOCATION_COMPLEXITY_INCREASE_COLD_START` which will be enabled by default - Refactor cost issues to be more modular and succinct. This also makes addition of a new cost kind very easy by adding the kind into the `enabled_cost_kinds` list in `CostKind.ml` Reviewed By: mbouaziz Differential Revision: D15822681 fbshipit-source-id: cf89ece59
6 years ago
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.while_and_or(int):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 24]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.while_and_or(int):void, 2, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/Compound_loop.java, codetoanalyze.java.performance.Compound_loop.while_and_or(int):void, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/Cost_test.java, codetoanalyze.java.performance.Cost_test.call_mult_symbold_quadratic(int):void, 2, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [Parameter `n`,Call,<LHS trace>,Parameter `x`,Binary operation: ([0, +oo] + 1):signed32 by call to `void Cost_test.mult_symbols_quadratic(int,int)` ]
codetoanalyze/java/performance/Cost_test_deps.java, codetoanalyze.java.performance.Cost_test_deps.if_bad_loop():int, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/Cost_test_deps.java, codetoanalyze.java.performance.Cost_test_deps.loop_no_dep1(int):int, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/Cost_test_deps.java, codetoanalyze.java.performance.Cost_test_deps.loop_no_dep2(int):int, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/Cost_test_deps.java, codetoanalyze.java.performance.Cost_test_deps.real_while():int, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [0, 29]):signed32]
codetoanalyze/java/performance/Cost_test_deps.java, codetoanalyze.java.performance.Cost_test_deps.two_loops():int, 5, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([3, +oo] + 1):signed32]
[cost] Refactor cost issue types and enable detecting allocation complexity increase on cold start Summary: - Add allocation costs to `costs-report.json` and enable diffing over allocation costs. - Also, let's be more consistent and modular in naming our cost issues. - introduce a generic issue type `X_TIME_COMPLEXITY_INCREASE` where `X` can be one of the cost kinds. If the function is on the cold start, issue can have the `COLD_START` suffix. Similarly for infinite/zero/expensive calls. - Change `PERFORMANCE_VARIATION` -> `EXECUTION_TIME_COMPLEXITY_INCREASE` - Add new issue type for `ALLOCATION_COMPLEXITY_INCREASE_COLD_START` which will be enabled by default - Refactor cost issues to be more modular and succinct. This also makes addition of a new cost kind very easy by adding the kind into the `enabled_cost_kinds` list in `CostKind.ml` Reviewed By: mbouaziz Differential Revision: D15822681 fbshipit-source-id: cf89ece59
6 years ago
codetoanalyze/java/performance/EvilCfg.java, EvilCfg.foo(int,int,boolean):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 15]
[cost] Find method of interface or abstract class Summary: To find a method in non-abstract sub-classes, this diff applies the same heuristics of inferbo. * If the class is an interface: Find its unique sub-class and apply the heuristics recursively. * If the class is an abstract class: Find/use its own summary if possible. If not found, find one (arbitrary but deterministic) summary from its sub-classes. * Otherwise: Find its own summary. Reviewed By: ezgicicek Differential Revision: D20647101 fbshipit-source-id: 2f8f3ff81
5 years ago
codetoanalyze/java/performance/InheritanceTest.java, InheritanceTest$UniqueImpl4.top_cost(InheritanceTest$MyInterface3):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 58]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/InheritanceTest.java, InheritanceTest$UniqueImpl4.top_cost(InheritanceTest$MyInterface3):void, 1, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Keep excluding unqualified variables by ItvUpdatedBy Summary: This diff avoids unqualified variables by `ItvUpdatedBy` are qualified later. For example, ``` z = x & y; z = z + 1; ``` While `z` should not be selected as a control variable, it wasn't, because it was qualified by the addition. This pattern introduces FPs in many cases. Reviewed By: ngorogiannis Differential Revision: D18505894 fbshipit-source-id: 13aec3008
5 years ago
codetoanalyze/java/performance/IntTest.java, IntTest.control_var_band_add_constant(int,int):void, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Parameter `x`,Binary operation: ([-oo, +oo] + 1):signed32]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/IntTest.java, IntTest.control_var_band_add_constant(int,int):void, 6, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Parameter `x`,Binary operation: ([-oo, +oo] + 1):signed32]
[inferbo] Add models for Java's Integer Summary: Add models for Java's Integer class. Reviewed By: skcho Differential Revision: D16668118 fbshipit-source-id: 05b3c8736
5 years ago
codetoanalyze/java/performance/IntTest.java, IntTest.static_Integer_top():void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 15]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/IntTest.java, IntTest.static_Integer_top():void, 1, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Refactor cost issue types and enable detecting allocation complexity increase on cold start Summary: - Add allocation costs to `costs-report.json` and enable diffing over allocation costs. - Also, let's be more consistent and modular in naming our cost issues. - introduce a generic issue type `X_TIME_COMPLEXITY_INCREASE` where `X` can be one of the cost kinds. If the function is on the cold start, issue can have the `COLD_START` suffix. Similarly for infinite/zero/expensive calls. - Change `PERFORMANCE_VARIATION` -> `EXECUTION_TIME_COMPLEXITY_INCREASE` - Add new issue type for `ALLOCATION_COMPLEXITY_INCREASE_COLD_START` which will be enabled by default - Refactor cost issues to be more modular and succinct. This also makes addition of a new cost kind very easy by adding the kind into the `enabled_cost_kinds` list in `CostKind.ml` Reviewed By: mbouaziz Differential Revision: D15822681 fbshipit-source-id: cf89ece59
6 years ago
codetoanalyze/java/performance/Invariant.java, Invariant.formal_not_invariant_FP(int,int):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 31]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Invariant.java, Invariant.formal_not_invariant_FP(int,int):void, 2, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Parameter `x`,<RHS trace>,Parameter `x`,Binary operation: (size + [min(0, x), max(0, x)]):signed32]
codetoanalyze/java/performance/Invariant.java, Invariant.formal_not_invariant_FP(int,int):void, 6, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Parameter `x`,Binary operation: ([0, +oo] + 1):signed32]
[cost] Non-symbolic value for unknown external function call Summary: This diff returns non-symbolic value (top) for unknown external function calls because the symbolic values sometimes make it hard to understand costs. Reviewed By: ezgicicek Differential Revision: D18685715 fbshipit-source-id: 1b39c718b
5 years ago
codetoanalyze/java/performance/JsonArray.java, libraries.marauder.analytics.utils.json.JsonArray.addStringEntry(java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addEntry(java.lang.String,boolean):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonMap.addKeyToMap(String),Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addEntry(java.lang.String,double):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonMap.addKeyToMap(String),Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addEntry(java.lang.String,java.lang.Object):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonMap.addKeyToMap(String),Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addEntry(java.lang.String,java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addEntry(java.lang.String,libraries.marauder.analytics.utils.json.JsonType):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonMap.addKeyToMap(String),Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addEntry(java.lang.String,long):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonMap.addKeyToMap(String),Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonMap.java, libraries.marauder.analytics.utils.json.JsonMap.addKeyToMap(java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonString.java, libraries.marauder.analytics.utils.json.JsonString.<init>(java.lang.String), 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to StringBuilder JsonUtils.serialize(String),Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonUtils.java, libraries.marauder.analytics.utils.json.JsonUtils.escape(java.lang.StringBuilder,java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 13]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/JsonUtils.java, libraries.marauder.analytics.utils.json.JsonUtils.escape(java.lang.StringBuilder,java.lang.String):void, 1, BUFFER_OVERRUN_U5, no_bucket, ERROR, [<Offset trace>,Assignment,<Length trace>,Unknown value from: char[] String.toCharArray(),Array access: Offset: [-oo, +oo] (⇐ [-oo, +oo] + [0, +oo]) Size: [0, +oo]]
codetoanalyze/java/performance/JsonUtils.java, libraries.marauder.analytics.utils.json.JsonUtils.escape(java.lang.StringBuilder,java.lang.String):void, 1, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Non-symbolic value for unknown external function call Summary: This diff returns non-symbolic value (top) for unknown external function calls because the symbolic values sometimes make it hard to understand costs. Reviewed By: ezgicicek Differential Revision: D18685715 fbshipit-source-id: 1b39c718b
5 years ago
codetoanalyze/java/performance/JsonUtils.java, libraries.marauder.analytics.utils.json.JsonUtils.serialize(java.lang.String):java.lang.StringBuilder, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonUtils.serialize(StringBuilder,String),Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
codetoanalyze/java/performance/JsonUtils.java, libraries.marauder.analytics.utils.json.JsonUtils.serialize(java.lang.StringBuilder,java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void JsonUtils.escape(StringBuilder,String),Unbounded loop,Loop at line 13]
[cost] Set the minimum basic cost of node Summary: The zero cost of node does not make sense especially when the abstract memory is non-bottom. This resulted in unreasonable zero cost results sometimes, e.g. when the checker could not find appropriate control varaibles having interval values of iteration. This diff fixes this, so sets the minimum basic cost as 1, if the abstract memory at the node is non-bottom. Reviewed By: ezgicicek Differential Revision: D18199291 fbshipit-source-id: b215d10e5
5 years ago
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.length_of_linked_list_linear_FP(codetoanalyze.java.performance.Loops$MyLinkedList):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded value x,call to void Loops.linear(int),Loop at line 86]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.length_of_linked_list_linear_FP(codetoanalyze.java.performance.Loops$MyLinkedList):void, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.modeled_range_linear(java.nio.channels.FileChannel,java.nio.ByteBuffer):void, 9, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 8):signed32]
[cost] Add modeled range Summary: `ModeledRange` represents how many times the interval value can be updated by modeled functions. This domain is to support the case where there are mismatches between value of a control variable and actual number of loop iterations. For example, ``` while((c = file_channel.read(buf)) != -1) { ... } ``` the loop will iterates as the file size, but the control variable `c` does not have that value. In these cases, it assigns a symbolic value of the file size to the modeled range of `c`, then which is used when calculating the overall cost. Reviewed By: jvillard Differential Revision: D17476621 fbshipit-source-id: 9a81376e8
5 years ago
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.nested_do_while_FP(int):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 34]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.nested_do_while_FP(int):void, 8, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Add modeled range Summary: `ModeledRange` represents how many times the interval value can be updated by modeled functions. This domain is to support the case where there are mismatches between value of a control variable and actual number of loop iterations. For example, ``` while((c = file_channel.read(buf)) != -1) { ... } ``` the loop will iterates as the file size, but the control variable `c` does not have that value. In these cases, it assigns a symbolic value of the file size to the modeled range of `c`, then which is used when calculating the overall cost. Reviewed By: jvillard Differential Revision: D17476621 fbshipit-source-id: 9a81376e8
5 years ago
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.unboundedSymbol():void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded value x,call to void Loops.linear(int),Loop at line 86]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.unboundedSymbol():void, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([-oo, +oo] × [-oo, +oo]):signed32]
codetoanalyze/java/performance/Loops.java, codetoanalyze.java.performance.Loops.unboundedSymbol():void, 5, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [Assignment,Call,<LHS trace>,Parameter `x`,Binary operation: ([0, +oo] + 1):signed32 by call to `void Loops.linear(int)` ]
[inferbo] Add model of Class.getCanonicalName Summary: Similarly to Enum.name, we model Class.getCanonicalName as returning an arbitrary non-empty string. Reviewed By: ngorogiannis Differential Revision: D21207120 fbshipit-source-id: 1e2dbd1fd
5 years ago
codetoanalyze/java/performance/StringTest.java, StringTest.class_get_canonical_name_constant(java.lang.Integer):void, 1, BUFFER_OVERRUN_U5, no_bucket, ERROR, [<Length trace>,Unknown value from: Class Object.getClass(),Assignment,Array access: Offset: [-oo, +oo] Size: [0, +oo]]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/Switch.java, codetoanalyze.java.performance.Switch.test_switch():int, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/java/performance/Switch.java, codetoanalyze.java.performance.Switch.vanilla_switch(int):void, 2, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] Non-symbolic value for unknown external function call Summary: This diff returns non-symbolic value (top) for unknown external function calls because the symbolic values sometimes make it hard to understand costs. Reviewed By: ezgicicek Differential Revision: D18685715 fbshipit-source-id: 1b39c718b
5 years ago
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.call_concrete_func_linear_FP(UnknownCallsTest$AbstractC):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 94]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.call_concrete_func_linear_FP(UnknownCallsTest$AbstractC):void, 2, BUFFER_OVERRUN_U5, no_bucket, ERROR, [<Length trace>,Unknown value from: int[] UnknownCallsTest$AbstractC.abstract_func(),Assignment,Array access: Offset: [-oo, +oo] Size: [0, +oo]]
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.call_concrete_func_linear_FP(UnknownCallsTest$AbstractC):void, 2, INTEGER_OVERFLOW_U5, no_bucket, ERROR, [<LHS trace>,Unknown value from: int[] UnknownCallsTest$AbstractC.abstract_func(),Binary operation: ([0, +oo] + 1):signed32]
[cost] Non-symbolic value for unknown external function call Summary: This diff returns non-symbolic value (top) for unknown external function calls because the symbolic values sometimes make it hard to understand costs. Reviewed By: ezgicicek Differential Revision: D18685715 fbshipit-source-id: 1b39c718b
5 years ago
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.call_loop_over_charArray_FP(java.lang.StringBuilder,java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to void UnknownCallsTest.loop_over_charArray_FP(StringBuilder,String),Unbounded loop,Loop at line 51]
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.loop_over_charArray_FP(java.lang.StringBuilder,java.lang.String):void, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop at line 51]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.loop_over_charArray_FP(java.lang.StringBuilder,java.lang.String):void, 1, BUFFER_OVERRUN_U5, no_bucket, ERROR, [<Offset trace>,Assignment,<Length trace>,Unknown value from: char[] String.toCharArray(),Array access: Offset: [-oo, +oo] (⇐ [-oo, +oo] + [0, +oo]) Size: [0, +oo]]
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.loop_over_charArray_FP(java.lang.StringBuilder,java.lang.String):void, 1, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.may_throw_exception():int, 2, UNREACHABLE_CODE, no_bucket, ERROR, [Here]
codetoanalyze/java/performance/UnknownCallsTest.java, UnknownCallsTest.throw_exception():int, 1, UNREACHABLE_CODE, no_bucket, ERROR, [Here]
[cost] Rename ZERO_* to *_UNREACHABLE_AT_EXIT Summary: This diff renames `ZERO_XXX` issues to more appropriately named and descriptive `XXX_UNREACHABLE_AT_EXIT` and replaces bottom with unreachable in cost kinds and issues. Reviewed By: skcho Differential Revision: D20140301 fbshipit-source-id: eb6076b30
5 years ago
codetoanalyze/java/performance/UnreachableAtExitTest.java, UnreachableAtExitTest.infeasible_path_unreachable():void, 0, EXECUTION_TIME_UNREACHABLE_AT_EXIT, no_bucket, ERROR, [Unreachable node]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/performance/UnreachableAtExitTest.java, UnreachableAtExitTest.infeasible_path_unreachable():void, 1, UNREACHABLE_CODE, no_bucket, ERROR, [Here]