pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'df154b4135'
${ noResults }
infer_clone/infer/tests/codetoanalyze/cpp/shared/attributes/deprecated_hack.cpp.dot

359 lines
38 KiB
Raw Normal View History Unescape

Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
/* @generated */
digraph iCFG {
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_1" [label="1: Start derefFirstArg_null_deref\nFormals: \nLocals: a:int \n DECLARE_LOCALS(&return,&a); [line 37]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_1" -> "derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_4" ;
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_2" [label="2: Exit derefFirstArg_null_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_3" [label="3: Return Stmt \n n$0=*null:int [line 39]\n *&return:int=n$0 [line 39]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_3" -> "derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_2" ;
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_4" [label="4: DeclStmt \n *&a:int=0 [line 38]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_4" -> "derefFirstArg_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z24derefFirstArg_null_derefv}.927581a38e7f35f59353c6a172d4704c_3" ;
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_1" [label="1: Start derefFirstArg_ok_deref\nFormals: \nLocals: a:int \n DECLARE_LOCALS(&return,&a); [line 42]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_1" -> "derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_4" ;
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_2" [label="2: Exit derefFirstArg_ok_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_3" [label="3: Return Stmt \n n$0=*&a:int [line 44]\n *&return:int=n$0 [line 44]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_3" -> "derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_2" ;
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_4" [label="4: DeclStmt \n *&a:int=0 [line 43]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_4" -> "derefFirstArg_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22derefFirstArg_ok_derefv}.81162ff63fe403ed6f07c90fd7747246_3" ;
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_1" [label="1: Start derefFirstArg2_null_deref\nFormals: \nLocals: a:int \n DECLARE_LOCALS(&return,&a); [line 47]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_1" -> "derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_4" ;
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_2" [label="2: Exit derefFirstArg2_null_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_3" [label="3: Return Stmt \n n$0=*null:int [line 49]\n *&return:int=n$0 [line 49]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_3" -> "derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_2" ;
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_4" [label="4: DeclStmt \n *&a:int=0 [line 48]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_4" -> "derefFirstArg2_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg2_null_derefv}.87e84a45939c306e33dfa703cc7fd30b_3" ;
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_1" [label="1: Start derefFirstArg2_ok_deref\nFormals: \nLocals: a:int \n DECLARE_LOCALS(&return,&a); [line 52]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_1" -> "derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_4" ;
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_2" [label="2: Exit derefFirstArg2_ok_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_3" [label="3: Return Stmt \n n$0=*&a:int [line 54]\n *&return:int=n$0 [line 54]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_3" -> "derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_2" ;
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_4" [label="4: DeclStmt \n *&a:int=0 [line 53]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_4" -> "derefFirstArg2_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg2_ok_derefv}.c5c7a2c8b8d8c952220574562b32d658_3" ;
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_1" [label="1: Start derefFirstArg3_ok_deref\nFormals: \nLocals: a:int \n DECLARE_LOCALS(&return,&a); [line 57]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_1" -> "derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_4" ;
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_2" [label="2: Exit derefFirstArg3_ok_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_3" [label="3: Return Stmt \n n$0=_fun_derefFirstArg3(null:int*,&a:int*) [line 59]\n *&return:int=n$0 [line 59]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_3" -> "derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_2" ;
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_4" [label="4: DeclStmt \n *&a:int=0 [line 58]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_4" -> "derefFirstArg3_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z23derefFirstArg3_ok_derefv}.a0391ff9bad133bfe5a5eca765002a53_3" ;
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_1" [label="1: Start derefFirstArg3_null_deref\nFormals: \nLocals: a:int \n DECLARE_LOCALS(&return,&a); [line 62]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_1" -> "derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_4" ;
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_2" [label="2: Exit derefFirstArg3_null_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_3" [label="3: Return Stmt \n n$0=_fun_derefFirstArg3(&a:int*,null:int*) [line 64]\n *&return:int=n$0 [line 64]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_3" -> "derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_2" ;
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_4" [label="4: DeclStmt \n *&a:int=0 [line 63]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_4" -> "derefFirstArg3_null_deref{d41d8cd98f00b204e9800998ecf8427e_Z25derefFirstArg3_null_derefv}.e1b26ac6d9c6e1ff0010ecdefd5b0904_3" ;
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_1" [label="1: Start getPtr_null_deref1\nFormals: \nLocals: t:int* \n DECLARE_LOCALS(&return,&t); [line 89]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_1" -> "getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_5" ;
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_2" [label="2: Exit getPtr_null_deref1 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_3" [label="3: Return Stmt \n _=*&t:int* [line 92]\n n$1=*&t:int* [line 92]\n n$2=*n$1:int [line 92]\n *&return:int=n$2 [line 92]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_3" -> "getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_2" ;
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 91]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,null:int*) [line 91]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_4" -> "getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_3" ;
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 90]\n n$4=*&t:int* [line 90]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_5" -> "getPtr_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref1v}.ca0bcbfa30cc9f3486057a2fbf4c0a43_4" ;
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_1" [label="1: Start getPtr_null_deref2\nFormals: \nLocals: t:int* \n DECLARE_LOCALS(&return,&t); [line 95]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_1" -> "getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_5" ;
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_2" [label="2: Exit getPtr_null_deref2 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_3" [label="3: Return Stmt \n _=*&t:int* [line 98]\n n$1=*&t:int* [line 98]\n n$2=*n$1:int [line 98]\n *&return:int=n$2 [line 98]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_3" -> "getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_2" ;
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 97]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,null:int*) [line 97]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_4" -> "getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_3" ;
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 96]\n n$4=*&t:int* [line 96]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_5" -> "getPtr_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getPtr_null_deref2v}.c0658f9bf55154f40aa7887ee5e9c67d_4" ;
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_1" [label="1: Start getPtr_ok_deref\nFormals: \nLocals: t:int* a:int \n DECLARE_LOCALS(&return,&t,&a); [line 101]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_1" -> "getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_6" ;
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_2" [label="2: Exit getPtr_ok_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_3" [label="3: Return Stmt \n _=*&t:int* [line 105]\n n$1=*&t:int* [line 105]\n n$2=*n$1:int [line 105]\n *&return:int=n$2 [line 105]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_3" -> "getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_2" ;
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 104]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,&a:int*) [line 104]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_4" -> "getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_3" ;
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 103]\n n$4=*&t:int* [line 103]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_5" -> "getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_4" ;
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_6" [label="6: DeclStmt \n *&a:int=0 [line 102]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_6" -> "getPtr_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getPtr_ok_derefv}.e6a87ae178aca92d95d36c354a58684b_5" ;
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_1" [label="1: Start operator_star_null_deref1\nFormals: \nLocals: t:int* \n DECLARE_LOCALS(&return,&t); [line 108]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_1" -> "operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_5" ;
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_2" [label="2: Exit operator_star_null_deref1 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_3" [label="3: Return Stmt \n n$0=*&t:int* [line 111]\n n$1=*n$0:int [line 111]\n *&return:int=n$1 [line 111]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_3" -> "operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_2" ;
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 110]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,null:int*) [line 110]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_4" -> "operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_3" ;
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 109]\n n$3=*&t:int* [line 109]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_5" -> "operator_star_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref1v}.768771cba782263aea8d94a1dbaadafa_4" ;
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_1" [label="1: Start operator_star_null_deref2\nFormals: \nLocals: t:int* \n DECLARE_LOCALS(&return,&t); [line 114]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_1" -> "operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_5" ;
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_2" [label="2: Exit operator_star_null_deref2 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_3" [label="3: Return Stmt \n _=*&t:int* [line 117]\n n$1=*&t:int* [line 117]\n n$2=*n$1:int [line 117]\n *&return:int=n$2 [line 117]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_3" -> "operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_2" ;
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 116]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,null:int*) [line 116]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_4" -> "operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_3" ;
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 115]\n n$4=*&t:int* [line 115]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_5" -> "operator_star_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z25operator_star_null_deref2v}.5dff5fc29e89a752d52014e07a143b0d_4" ;
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_1" [label="1: Start operator_star_ok_deref\nFormals: \nLocals: t:int* a:int \n DECLARE_LOCALS(&return,&t,&a); [line 120]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_1" -> "operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_5" ;
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_2" [label="2: Exit operator_star_ok_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_3" [label="3: Return Stmt \n _=*&t:int* [line 124]\n n$1=*&t:int* [line 124]\n n$2=*n$1:int [line 124]\n *&return:int=n$2 [line 124]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_3" -> "operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_2" ;
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 123]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,&a:int*) [line 123]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_4" -> "operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_3" ;
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 122]\n n$4=*&t:int* [line 122]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_5" -> "operator_star_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z22operator_star_ok_derefv}.fddf0680fb971d2f1a70bb3c9074d811_4" ;
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_1" [label="1: Start getRef_null_deref1\nFormals: \nLocals: t:int* \n DECLARE_LOCALS(&return,&t); [line 127]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_1" -> "getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_5" ;
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_2" [label="2: Exit getRef_null_deref1 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_3" [label="3: Return Stmt \n _=*&t:int* [line 130]\n n$1=*&t:int* [line 130]\n n$2=*n$1:int [line 130]\n *&return:int=n$2 [line 130]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_3" -> "getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_2" ;
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 129]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,null:int*) [line 129]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_4" -> "getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_3" ;
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 128]\n n$4=*&t:int* [line 128]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_5" -> "getRef_null_deref1{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref1v}.122119e932803230e14664a05f8e9bc1_4" ;
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_1" [label="1: Start getRef_null_deref2\nFormals: \nLocals: t:int* \n DECLARE_LOCALS(&return,&t); [line 133]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_1" -> "getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_5" ;
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_2" [label="2: Exit getRef_null_deref2 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_3" [label="3: Return Stmt \n _=*&t:int* [line 136]\n n$1=*&t:int* [line 136]\n n$2=*n$1:int [line 136]\n *&return:int=n$2 [line 136]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_3" -> "getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_2" ;
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 135]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,null:int*) [line 135]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_4" -> "getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_3" ;
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 134]\n n$4=*&t:int* [line 134]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_5" -> "getRef_null_deref2{d41d8cd98f00b204e9800998ecf8427e_Z18getRef_null_deref2v}.9ffcde6f39df65a7c54071cb9a9ddd2d_4" ;
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_1" [label="1: Start getRef_ok_deref\nFormals: \nLocals: t:int* a:int \n DECLARE_LOCALS(&return,&t,&a); [line 139]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_1" -> "getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_6" ;
[debug][dotty] Fix issue in dotty output where overloaded functions were conflated Reviewed By: jvillard Differential Revision: D4117078 fbshipit-source-id: fdd8e93
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_2" [label="2: Exit getRef_ok_deref \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
[C++ translation] Use correct type when generating dereference Summary: This modifies `CTrans_utils.dereference_value_from_result` function. Reasons: 1. Type in Sil.Load tuple is supposed to be the type of Ident.t field (result), not Exp.t (source) 2. Inside `dereference_value_from_result` we used wrong type when `~strip_pointer:true` - it used original type instead of the resulting one 3. Fixing (2), uncovered similar issue in `CTrans_utils.cast_operation` - it should have used resulting type, not original one Changed tests are expected: 1. `deprecated_hack.cpp` test was how I discovered this issue (it was very wrong) 2. the other test also had issues, now it's correct Sadly, there was no logic I followed when writing this change - I stuffed changes in a way that fits, but it may be breaking something somewhere else. Reviewed By: jberdine Differential Revision: D4481895 fbshipit-source-id: b139c59
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_3" [label="3: Return Stmt \n _=*&t:int* [line 143]\n n$1=*&t:int* [line 143]\n n$2=*n$1:int [line 143]\n *&return:int=n$2 [line 143]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_3" -> "getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_2" ;
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_4" [label="4: Call _fun_TranslateAsPtr<int>_setPtr \n _=*&t:int* [line 142]\n _fun_TranslateAsPtr<int>_setPtr(&t:int*&,&a:int*) [line 142]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_4" -> "getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_3" ;
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_5" [label="5: DeclStmt \n _fun_TranslateAsPtr<int>_TranslateAsPtr(&t:int**,null:int*) [line 141]\n n$4=*&t:int* [line 141]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_5" -> "getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_4" ;
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_6" [label="6: DeclStmt \n *&a:int=0 [line 140]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_6" -> "getRef_ok_deref{d41d8cd98f00b204e9800998ecf8427e_Z15getRef_ok_derefv}.a4f3a4a756890f6bb1065e1d22e6485f_5" ;
"derefFirstArg{d41d8cd98f00b204e9800998ecf8427e_Z13derefFirstArgPiS_}.b2938b7664e69c1046eb0d5c68f18fd4_1" [label="1: Start derefFirstArg\nFormals: a:int* b:int*\nLocals: \n DECLARE_LOCALS(&return); [line 19]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg{d41d8cd98f00b204e9800998ecf8427e_Z13derefFirstArgPiS_}.b2938b7664e69c1046eb0d5c68f18fd4_1" -> "derefFirstArg{d41d8cd98f00b204e9800998ecf8427e_Z13derefFirstArgPiS_}.b2938b7664e69c1046eb0d5c68f18fd4_2" ;
"derefFirstArg{d41d8cd98f00b204e9800998ecf8427e_Z13derefFirstArgPiS_}.b2938b7664e69c1046eb0d5c68f18fd4_2" [label="2: Exit derefFirstArg \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_1" [label="1: Start derefFirstArg2\nFormals: a:int* b:int*\nLocals: \n DECLARE_LOCALS(&return); [line 22]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_1" -> "derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_3" ;
"derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_2" [label="2: Exit derefFirstArg2 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_3" [label="3: Return Stmt \n n$0=*&b:int* [line 26]\n n$1=*n$0:int [line 26]\n *&return:int=n$1 [line 26]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_3" -> "derefFirstArg2{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg2PiS_}.d4966e65f3ff2cb5da0b76036244bf9c_2" ;
"derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_1" [label="1: Start derefFirstArg3\nFormals: a:int* b:int*\nLocals: \n DECLARE_LOCALS(&return); [line 31]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_1" -> "derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_3" ;
"derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_2" [label="2: Exit derefFirstArg3 \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_3" [label="3: Return Stmt \n n$0=*&b:int* [line 33]\n n$1=*n$0:int [line 33]\n *&return:int=n$1 [line 33]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_3" -> "derefFirstArg3{d41d8cd98f00b204e9800998ecf8427e_Z14derefFirstArg3PiS_}.c22270a8b45f207485450ebff7826470_2" ;
"TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEv).e9818cf7d486bf17e4505936e74fd8cf_1" [label="1: Start TranslateAsPtr<int>_getPtr\nFormals: this:int**\nLocals: \n DECLARE_LOCALS(&return); [line 78]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEv).e9818cf7d486bf17e4505936e74fd8cf_1" -> "TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEv).e9818cf7d486bf17e4505936e74fd8cf_2" ;
"TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEv).e9818cf7d486bf17e4505936e74fd8cf_2" [label="2: Exit TranslateAsPtr<int>_getPtr \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_operator*(_ZN14TranslateAsPtrIiEdeEv).6e33a6aa14a0cca60ad03c9c8323478d_1" [label="1: Start TranslateAsPtr<int>_operator*\nFormals: this:int**\nLocals: \n DECLARE_LOCALS(&return); [line 81]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_operator*(_ZN14TranslateAsPtrIiEdeEv).6e33a6aa14a0cca60ad03c9c8323478d_1" -> "TranslateAsPtr<int>_operator*(_ZN14TranslateAsPtrIiEdeEv).6e33a6aa14a0cca60ad03c9c8323478d_2" ;
"TranslateAsPtr<int>_operator*(_ZN14TranslateAsPtrIiEdeEv).6e33a6aa14a0cca60ad03c9c8323478d_2" [label="2: Exit TranslateAsPtr<int>_operator* \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEv).73b28e0b78502fc4a5ab3085d7c47bc7_1" [label="1: Start TranslateAsPtr<int>_getRef\nFormals: this:int**\nLocals: \n DECLARE_LOCALS(&return); [line 82]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEv).73b28e0b78502fc4a5ab3085d7c47bc7_1" -> "TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEv).73b28e0b78502fc4a5ab3085d7c47bc7_2" ;
"TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEv).73b28e0b78502fc4a5ab3085d7c47bc7_2" [label="2: Exit TranslateAsPtr<int>_getRef \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEii).b601a0b5470955664a78e673fb9687c0_1" [label="1: Start TranslateAsPtr<int>_getPtr\nFormals: this:int** a:int b:int\nLocals: \n DECLARE_LOCALS(&return); [line 79]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEii).b601a0b5470955664a78e673fb9687c0_1" -> "TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEii).b601a0b5470955664a78e673fb9687c0_2" ;
"TranslateAsPtr<int>_getPtr(_ZN14TranslateAsPtrIiE6getPtrEii).b601a0b5470955664a78e673fb9687c0_2" [label="2: Exit TranslateAsPtr<int>_getPtr \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEii).b3ec3ec67e954fbf2f0bf9bd5bd7a502_1" [label="1: Start TranslateAsPtr<int>_getRef\nFormals: this:int** a:int b:int\nLocals: \n DECLARE_LOCALS(&return); [line 83]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEii).b3ec3ec67e954fbf2f0bf9bd5bd7a502_1" -> "TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEii).b3ec3ec67e954fbf2f0bf9bd5bd7a502_2" ;
"TranslateAsPtr<int>_getRef(_ZN14TranslateAsPtrIiE6getRefEii).b3ec3ec67e954fbf2f0bf9bd5bd7a502_2" [label="2: Exit TranslateAsPtr<int>_getRef \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_1" [label="1: Start TranslateAsPtr<int>_TranslateAsPtr\nFormals: this:int** t:int*\nLocals: \n DECLARE_LOCALS(&return); [line 76]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_1" -> "TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_3" ;
"TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_2" [label="2: Exit TranslateAsPtr<int>_TranslateAsPtr \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_3" [label="3: Call _fun_TranslateAsPtr<int>_setPtr \n n$0=*&this:int** [line 76]\n _=*n$0:int* [line 76]\n n$2=*&t:int* [line 76]\n _fun_TranslateAsPtr<int>_setPtr(n$0:int**,n$2:int*) [line 76]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_3" -> "TranslateAsPtr<int>_TranslateAsPtr{_ZN14TranslateAsPtrIiEC1EPi}.5f550e6a31f09c70f2bf53349616a244_2" ;
"TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_1" [label="1: Start TranslateAsPtr<int>_setPtr\nFormals: this:int** v:int*\nLocals: \n DECLARE_LOCALS(&return); [line 86]\n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_1" -> "TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_3" ;
"TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_2" [label="2: Exit TranslateAsPtr<int>_setPtr \n " color=yellow style=filled]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_3" [label="3: BinaryOperatorStmt: Assign \n n$0=*&this:int** [line 86]\n n$1=*&v:int* [line 86]\n *n$0:void*=n$1 [line 86]\n " shape="box"]
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_3" -> "TranslateAsPtr<int>_setPtr(_ZN14TranslateAsPtrIiE6setPtrEPi).a5d7880acc84c7e32bc96cbed0a1e739_2" ;
Skip Sil.Call instruction for some shared_ptr method calls Summary: 1. Add capability to clang frontend to replace some function calls with another SIL code based on `__deprecated__` attribute. 2. Given this capability, use those attributes for shared_ptr getters to generate `Sil.Load` instruction instead of method call 3. Add test that mimics shared_ptr model, but it doesn't have that much scary C++ templated code Reviewed By: jvillard, jberdine Differential Revision: D3729176 fbshipit-source-id: 2a330d5
8 years ago
}