pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'e05fd1be67'
${ noResults }
infer_clone/infer/tests/codetoanalyze/java/hoistingExpensive/issues.exp

28 lines
6.8 KiB
Raw Normal View History Unescape

[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.cheap_dont_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistExpensive.cheap_dont_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.cheap_dont_hoist(int):void, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistExpensive.incr(int) at line 20 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.cheap_iterator_dont_hoist(java.util.ArrayList):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistExpensive.cheap_iterator_dont_hoist(ArrayList)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.cheap_iterator_dont_hoist(java.util.ArrayList):void, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to int HoistExpensive.incr(int) at line 42 is loop-invariant]
[purity] More models for Java Map Reviewed By: mbouaziz Differential Revision: D15659378 fbshipit-source-id: 2fa613281
6 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.getLeakSummary():java.lang.String, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function String HoistExpensive.getLeakSummary()]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.incr(int):int, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function int HoistExpensive.incr(int)]
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.instantiated_cheap_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistExpensive.instantiated_cheap_hoist(int)]
[cost] Re-locate where to print issue with heuristics Summary: Currenlty the cost issue is printed at the first node of a function, which is usually the first statment of the function. This may give a wrong impression that the cost of the statement is changed. This diff re-locate where to print issues with heuristics. Going backward from the first node lines, it looks up a line satisfying, 1. A line should start with <fname> or should include " <fname>". 2. The <fname> found in 1 should be followed by a space, '<', '(', or end of line. Reviewed By: jvillard Differential Revision: D20766876 fbshipit-source-id: b4fee3180
5 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.instantiated_cheap_hoist(int):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to void HoistExpensive.cheap_dont_hoist(int) at line 34 is loop-invariant]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.symbolic_expensive_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistExpensive.symbolic_expensive_hoist(int)]
[cost] Procedures with empty body gets 0 cost Reviewed By: jvillard Differential Revision: D25494222 fbshipit-source-id: 947993978
4 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.symbolic_expensive_hoist(int):void, 2, EXPENSIVE_LOOP_INVARIANT_CALL, no_bucket, ERROR, [The call to void HoistExpensive.cheap_dont_hoist(int) at line 27 is loop-invariant,with estimated cost 5 + 10 ⋅ size, degree = 1,{size},Call to void HoistExpensive.cheap_dont_hoist(int),Loop]
[purity] Always show PURE_FUNCTION issues Reviewed By: mbouaziz Differential Revision: D13973375 fbshipit-source-id: f23dab260
6 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.symbolic_expensive_iterator_hoist(int,java.util.ArrayList):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistExpensive.symbolic_expensive_iterator_hoist(int,ArrayList)]
[cost] Procedures with empty body gets 0 cost Reviewed By: jvillard Differential Revision: D25494222 fbshipit-source-id: 947993978
4 years ago
codetoanalyze/java/hoistingExpensive/HoistExpensive.java, HoistExpensive.symbolic_expensive_iterator_hoist(int,java.util.ArrayList):void, 2, EXPENSIVE_LOOP_INVARIANT_CALL, no_bucket, ERROR, [The call to void HoistExpensive.cheap_iterator_dont_hoist(ArrayList) at line 49 is loop-invariant,with estimated cost 6 + 13 ⋅ list.length + 3 ⋅ (list.length + 1), degree = 1,{list.length + 1},Call to void HoistExpensive.cheap_iterator_dont_hoist(ArrayList),Loop,{list.length},Call to void HoistExpensive.cheap_iterator_dont_hoist(ArrayList),Loop]
[cost] Remove expensive modeling for Provider.get Summary: We are getting lots of FPs due to modeling `Provider.get` as expensive. This is coming from Dependency Injection and Infer cannot statically determine the type of the provider and determine whether that provider is expensive (requires a global analysis and instrumentation). Instead, we are downgrading this method to the default constant cost. Reviewed By: skcho Differential Revision: D26223978 fbshipit-source-id: 79f81c997
4 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.call_expensive_dont_hoist(java.lang.String,java.util.ArrayList):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.call_expensive_dont_hoist(String,ArrayList)]
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.call_expensive_dont_hoist(java.lang.String,java.util.ArrayList):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to void HoistModeled.expensive_get_dont_hoist(int) at line 63 is loop-invariant]
[cost] Add cost models for loop invariant functions Reviewed By: jvillard Differential Revision: D14832961 fbshipit-source-id: 0d1b3353d
6 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.constant_contains_dont_hoist(java.lang.Integer):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.constant_contains_dont_hoist(Integer)]
[cost] Remove expensive modeling for Provider.get Summary: We are getting lots of FPs due to modeling `Provider.get` as expensive. This is coming from Dependency Injection and Infer cannot statically determine the type of the provider and determine whether that provider is expensive (requires a global analysis and instrumentation). Instead, we are downgrading this method to the default constant cost. Reviewed By: skcho Differential Revision: D26223978 fbshipit-source-id: 79f81c997
4 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.constant_contains_dont_hoist(java.lang.Integer):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to boolean ArrayList.contains(Object) at line 37 is loop-invariant]
[cost] Add cost models for loop invariant functions Reviewed By: jvillard Differential Revision: D14832961 fbshipit-source-id: 0d1b3353d
6 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.constant_substring_dont_hoist(java.lang.String):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.constant_substring_dont_hoist(String)]
[cost] Remove expensive modeling for Provider.get Summary: We are getting lots of FPs due to modeling `Provider.get` as expensive. This is coming from Dependency Injection and Infer cannot statically determine the type of the provider and determine whether that provider is expensive (requires a global analysis and instrumentation). Instead, we are downgrading this method to the default constant cost. Reviewed By: skcho Differential Revision: D26223978 fbshipit-source-id: 79f81c997
4 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.constant_substring_dont_hoist(java.lang.String):void, 3, INVARIANT_CALL, no_bucket, ERROR, [The call to String String.substring(int,int) at line 44 is loop-invariant]
[cost] Revise substring's cost model Summary: Prevent returning a negative cost bound when calling `substring(begin_index, end_index)` when either is possible - `begin_index < 0` - `begin_index > end_index` Instead, return unit cost since such cases either throw `IndexOutOfBoundsException ` at runtime or correspond to having two symbolic bounds that cannot be semantically compared. Reviewed By: dulmarod Differential Revision: D19619410 fbshipit-source-id: cf5e8cb7b
5 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.constant_substring_dont_hoist(java.lang.String,int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.constant_substring_dont_hoist(String,int)]
[cost] Remove expensive modeling for Provider.get Summary: We are getting lots of FPs due to modeling `Provider.get` as expensive. This is coming from Dependency Injection and Infer cannot statically determine the type of the provider and determine whether that provider is expensive (requires a global analysis and instrumentation). Instead, we are downgrading this method to the default constant cost. Reviewed By: skcho Differential Revision: D26223978 fbshipit-source-id: 79f81c997
4 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.constant_substring_dont_hoist(java.lang.String,int):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to String String.substring(int,int) at line 72 is loop-invariant]
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.expensive_get_dont_hoist(int):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.expensive_get_dont_hoist(int)]
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.expensive_get_dont_hoist(int):void, 2, INVARIANT_CALL, no_bucket, ERROR, [The call to Object Provider.get() at line 16 is loop-invariant]
[cost] Add cost models for loop invariant functions Reviewed By: jvillard Differential Revision: D14832961 fbshipit-source-id: 0d1b3353d
6 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.linear_contains_hoist(java.util.ArrayList,java.lang.Integer):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.linear_contains_hoist(ArrayList,Integer)]
[cost] Remove expensive modeling for Provider.get Summary: We are getting lots of FPs due to modeling `Provider.get` as expensive. This is coming from Dependency Injection and Infer cannot statically determine the type of the provider and determine whether that provider is expensive (requires a global analysis and instrumentation). Instead, we are downgrading this method to the default constant cost. Reviewed By: skcho Differential Revision: D26223978 fbshipit-source-id: 79f81c997
4 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.linear_contains_hoist(java.util.ArrayList,java.lang.Integer):void, 3, EXPENSIVE_LOOP_INVARIANT_CALL, no_bucket, ERROR, [The call to boolean ArrayList.contains(Object) at line 26 is loop-invariant,with estimated cost list.length, degree = 1,{list.length},Modeled call to List.contains]
[cost] Revise substring's cost model Summary: Prevent returning a negative cost bound when calling `substring(begin_index, end_index)` when either is possible - `begin_index < 0` - `begin_index > end_index` Instead, return unit cost since such cases either throw `IndexOutOfBoundsException ` at runtime or correspond to having two symbolic bounds that cannot be semantically compared. Reviewed By: dulmarod Differential Revision: D19619410 fbshipit-source-id: cf5e8cb7b
5 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.linear_substring_hoist_FN(java.lang.String,java.util.ArrayList,java.lang.Integer):void, 0, PURE_FUNCTION, no_bucket, ERROR, [Side-effect free function void HoistModeled.linear_substring_hoist_FN(String,ArrayList,Integer)]
[cost] Remove expensive modeling for Provider.get Summary: We are getting lots of FPs due to modeling `Provider.get` as expensive. This is coming from Dependency Injection and Infer cannot statically determine the type of the provider and determine whether that provider is expensive (requires a global analysis and instrumentation). Instead, we are downgrading this method to the default constant cost. Reviewed By: skcho Differential Revision: D26223978 fbshipit-source-id: 79f81c997
4 years ago
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.linear_substring_hoist_FN(java.lang.String,java.util.ArrayList,java.lang.Integer):void, 5, INVARIANT_CALL, no_bucket, ERROR, [The call to String String.substring(int,int) at line 53 is loop-invariant]
codetoanalyze/java/hoistingExpensive/HoistModeled.java, HoistModeled.linear_substring_hoist_FN(java.lang.String,java.util.ArrayList,java.lang.Integer):void, 9, INVARIANT_CALL, no_bucket, ERROR, [The call to String String.substring(int) at line 57 is loop-invariant]