pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'e15251579d'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/performance/issues.exp

55 lines
8.7 KiB
Raw Normal View History Unescape

[cost] add inferbo model for NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22390462 fbshipit-source-id: bd9157874
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_empty_array_constant, 3, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_enumerator_linear, 7, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [1, array->elements.length.ub + 1]):signed64]
[cost] add inferbo model for NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22390462 fbshipit-source-id: bd9157874
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_init_constant, 3, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/performance/NSArray.m, nsarray_iterate_linear, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [1, array->elements.length.ub + 1]):signed64]
codetoanalyze/objc/performance/NSDictionary.m, nsdictionary_enumerate_constant, 6, BUFFER_OVERRUN_L2, no_bucket, ERROR, [<Offset trace>,Assignment,<Length trace>,Array declaration,Array access: Offset: [1, 3] Size: 2]
[cost] Add model: NSFileManager.contentsOfDirectoryAtURL Summary: This diff adds a model for NSFileManager.contentsOfDirectoryAtURL as returning a constant-length collection. The analyzer cannot know files in a directory. We have some options to handle such unknown data. 1. Use `Unknown` value, ie `top` 2. Use a symbolic value 3. Use a constant value We had been used the first option. An upside of this is that the analyzer can remain as sound. However, a downside of this is the top value can be propagated to other procedures, making their costs top, thus we may miss some cost changes of them. The second option is to introduce a symbolic value, ie. that for the number of files. A problem is that the symbolic value will never be concretized. As a result, the symbol can be propagated to other procedures, increasing the coefficient of the complexity or making top costs. Note that handling multiple symbols is somewhat limited in Inferbo's interval domain. The last option is to introduce a constant value. I think this is the best approach we can take among above. Even though we may have FNs when there are a lot of files in a directory, we cannot reason or expect about that at the analysis time anyway. Reviewed By: ezgicicek Differential Revision: D24418099 fbshipit-source-id: bf8cf3538
4 years ago
codetoanalyze/objc/performance/NSFileManager.m, contents_of_directory_at_url_constant, 7, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
[inferbo] Generalize init's model to NSObject Reviewed By: roro47 Differential Revision: D23348725 fbshipit-source-id: 666472181
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsarray_new_constant, 2, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
[cost] make the size of collection more accurate when modifying in loop Summary: Two issues are fixed 1. For this diff, when the condition `curr_langauge_is Java` is removed in some part of the analysis, some c bufferoverrun tests are broken. This is fixed in this diff by inspecting if we are dealing with a `Size` alias referring to an `objc_internal_collection_array`. 2. Previously, when we are modifying mutable array in a loop, e.g. adding element to the array or removing element from the array, we are unable to give an estimable size of the array after exiting the loop. This is now fixed, and the corresponding FPs are resolved. Reviewed By: skcho Differential Revision: D23342350 fbshipit-source-id: 200f5261c
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_remove_constant, 6, BUFFER_OVERRUN_L1, no_bucket, ERROR, [<Length trace>,Array declaration,Through,Through,Through,Through,Array access: Offset: 0 Size: 0]
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_remove_in_loop_constant, 6, BUFFER_OVERRUN_L3, no_bucket, ERROR, [<Offset trace>,Set array size,<Length trace>,Assignment,Set array size,Array access: Offset: [0, 9] Size: [1, 10]]
[cost] add inferbo model for NSArray Summary: As title Reviewed By: ezgicicek Differential Revision: D22390462 fbshipit-source-id: bd9157874
4 years ago
codetoanalyze/objc/performance/NSMutableArray.m, nsmarray_set_linear, 2, INTEGER_OVERFLOW_U5, no_bucket, ERROR, [<LHS trace>,Unknown value from: NSNumber.intValue,Binary operation: ([-oo, +oo] + 1):signed32]
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/performance/NSSet.m, nsset_enumerator_linear, 7, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [1, set->elements.length.ub + 1]):signed64]
[inferbo] Model NSSet/NSOrderedSet as collections Reviewed By: skcho Differential Revision: D24138823 fbshipit-source-id: 7e8eddf34
4 years ago
codetoanalyze/objc/performance/NSSet.m, nsset_init_constant, 3, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/performance/NSSet.m, nsset_iterate_linear, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [1, set->elements.length.ub + 1]):signed64]
[cost] add alloc for NSObject and NSString.init as an example function using alloc Summary: Implement `alloc` and implement initialisation method that uses the return value of `alloc`, i.e. `NSString.init`. Reviewed By: ezgicicek Differential Revision: D22840080 fbshipit-source-id: 47a7523e3
4 years ago
codetoanalyze/objc/performance/NSString.m, init_string_constant, 2, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/NSString.m, replace_linear_FP, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop]
[cost] add model for NSString.string_with_utf8_string_linear and NSString.length Summary: As title Model `NSString` as `JavaString`. Since `NSArray` does not contain information about its type of element, we do not use associate string with collection as in Java and C++. In Java, String model is implemented using java collection, and for C++, string model is implemented using vector. So instead, we use existing `JavaString` model. Reviewed By: skcho Differential Revision: D22431949 fbshipit-source-id: 7cdde1ad7
4 years ago
codetoanalyze/objc/performance/NSString.m, replace_linear_FP, 2, INTEGER_OVERFLOW_U5, no_bucket, ERROR, [<LHS trace>,Unknown value from: NSString.stringByReplacingOccurrencesOfString:withString:,Binary operation: ([0, +oo] + 1):signed32]
[cost] Enable passing enumerator as paramter in ObjC Summary: This diff revises memory model of enumerator in ObjC to enable passing it as a parameter. The cost checker was not able to analyze a function precisely when it gets an enumerator as a parameter because the offset of an enumerator was available only when the analyzer knew the correct relation between the enumerator and an array. This diff simplifies the enumerator to have a similar value with `array->elements`, so its offset can be taken without the relation between enumerator and array to get them. Reviewed By: ezgicicek Differential Revision: D24446574 fbshipit-source-id: 27cdc051e
4 years ago
codetoanalyze/objc/performance/block.m, objc_blockblock_multiply_array_linear_1, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [1, array->elements.length.ub + 1]):signed64]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/compound_loop_guard.m, compound_while, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, nested_while_and_or_constant, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, nested_while_and_or_constant, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, nested_while_and_or_constant, 4, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, nested_while_and_or_constant, 4, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, simplified_simulated_while_with_and_constant, 5, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_nested_loop_with_and_constant, 7, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_nested_loop_with_and_constant, 8, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_while_shortcut_constant, 5, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, simulated_while_with_and_linear, 4, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/compound_loop_guard.m, while_and_or, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/compound_loop_guard.m, while_and_or, 2, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/compound_loop_guard.m, while_and_or, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/control.m, wrong_cvar_FP, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop]
[inferbo] Do not prune values with bottom Summary: This diff avoids pruning values with bottom, which incorrectly introduced unreachable nodes. Reviewed By: ezgicicek Differential Revision: D20029764 fbshipit-source-id: 16ca2f196
5 years ago
codetoanalyze/objc/performance/control.m, wrong_cvar_FP, 2, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] Do not print loop line number in trace message Summary: This diff prevents printing line numbers of loop in the trace description, which helps to keep the same descriptions even when the line number of a function is changed in tests. Reviewed By: ezgicicek Differential Revision: D22375584 fbshipit-source-id: 676d1a7cc
4 years ago
codetoanalyze/objc/performance/cost_test.m, call_infinite, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Call to infinite,Unbounded loop,Loop]
codetoanalyze/objc/performance/cost_test.m, infinite, 0, INFINITE_EXECUTION_TIME, no_bucket, ERROR, [Unbounded loop,Loop]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/cost_test.m, infinite, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([-oo, +oo] + [0, +oo]):signed32]
codetoanalyze/objc/performance/cost_test.m, infinite_FN, 3, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,<RHS trace>,Assignment,Binary operation: ([-oo, +oo] + [0, +oo]):signed32]
codetoanalyze/objc/performance/cost_test_deps.m, if_bad_loop_constant, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/objc/performance/cost_test_deps.m, real_while_constant, 4, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [0, 29]):signed32]
codetoanalyze/objc/performance/cost_test_deps.m, simulated_nested_loop_constant, 7, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/objc/performance/cost_test_deps.m, simulated_while_constant, 10, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Assignment,<RHS trace>,Assignment,Binary operation: ([0, +oo] + [0, 29]):signed32]
codetoanalyze/objc/performance/cost_test_deps.m, two_loops, 5, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([3, +oo] + 1):signed32]
codetoanalyze/objc/performance/exit.m, call_exit_unreachable, 0, EXECUTION_TIME_UNREACHABLE_AT_EXIT, no_bucket, ERROR, [Unreachable node]
codetoanalyze/objc/performance/exit.m, compute_exit_unreachable, 0, EXECUTION_TIME_UNREACHABLE_AT_EXIT, no_bucket, ERROR, [Unreachable node]
codetoanalyze/objc/performance/exit.m, exit_unreachable, 0, EXECUTION_TIME_UNREACHABLE_AT_EXIT, no_bucket, ERROR, [Unreachable node]
[inferbo] Generalize init's model to NSObject Reviewed By: roro47 Differential Revision: D23348725 fbshipit-source-id: 666472181
4 years ago
codetoanalyze/objc/performance/field_access.m, create_common_person_constant, 2, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [Call,Parameter `self->_bank_account`,Call,<LHS trace>,Parameter `self->_bank_account`,Call,Parameter `self->_bank_account`,Assignment,<RHS trace>,Parameter `income`,Binary operation: ([0, +oo] + 100):unsigned64 by call to `Person.add_income_constant:` ]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/invariant.m, while_infinite_FN, 2, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/loops.m, if_in_loop, 5, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
[inferbo] Handle when const global assigned to local variable Summary: Before this diff: ``` // Summary of const global // { global -> v } n$0 =* global // n$0 -> {global} x *= n$0 // x -> {global} ``` However, this is incorrect because we expect `x` have `v` instead of the abstract location of `global`. To fix the issue, this diff lookups the initializer summary when `global` is evaluated as RHS of load statement. After this diff: ``` // Summary of const global // { global -> v } n$0 =* global // n$0 -> v x *= n$0 // x -> v ``` Reviewed By: ezgicicek Differential Revision: D26369645 fbshipit-source-id: 98b1ed085
4 years ago
codetoanalyze/objc/performance/loops.m, loop_use_global_vars, 1, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] import c performance test to objc Summary: Basically copying test file from c/performance to objc/performance. Reviewed By: skcho Differential Revision: D21972945 fbshipit-source-id: 6e4412598
5 years ago
codetoanalyze/objc/performance/switch_continue.m, test_switch_FN, 3, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/switch_continue.m, unroll_loop, 6, INTEGER_OVERFLOW_L5, no_bucket, ERROR, [<LHS trace>,Assignment,Binary operation: ([0, +oo] + 1):signed32]
codetoanalyze/objc/performance/switch_continue.m, unroll_loop, 9, CONDITION_ALWAYS_TRUE, no_bucket, WARNING, [Here]
[cost] Fix unreachable node Top poisoning Summary: If a node is unreachable and the cost of the node is Top, we were giving Top cost :( Let's fix it. Reviewed By: skcho Differential Revision: D22548269 fbshipit-source-id: d79743669
4 years ago
codetoanalyze/objc/performance/unreachable.m, unreachable_branch_constant, 1, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/unreachable.m, unreachable_branch_constant2, 1, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]
codetoanalyze/objc/performance/unreachable.m, unreachable_branch_linear_loop, 1, CONDITION_ALWAYS_FALSE, no_bucket, WARNING, [Here]