pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ebcfae388a'
${ noResults }
infer_clone/infer/tests/codetoanalyze/cpp/frontend/reference/unbox.cpp.dot

90 lines
3.4 KiB
Raw Normal View History Unescape

Fix handling of C++ references Summary: @​public This diff changes following things: 1. expression_info.type_ptr has type than decl_ref_info.type_ptr for reference types. Use type from decl_ref_info as a source of truth 2. reference types need to have one extra dereference that is not in AST. Add handling for this. 3. [small refactor] create function that creates temporary variable from res_trans expression and returns new res_trans. Some caveats: 1. types are not quite right yet (see .dot files). 2. decl_ref_info might not be set for DeclRefExpr, make frontend crash in that case to catch when this happens This is high risk change since it changes behavior of every translation on very widely used expr. Reviewed By: @dulmarod Differential Revision: D2540632 fb-gh-sync-id: aa28936
9 years ago
digraph iCFG {
23 [label="23: DeclStmt \n *&a:int =3 [line 28]\n " shape="box"]
23 -> 22 ;
22 [label="22: DeclStmt \n *&p:int *=&a [line 29]\n " shape="box"]
22 -> 21 ;
21 [label="21: Call _fun_fun_p \n n$5=*&p:int * [line 31]\n n$6=_fun_fun_p(n$5:int *) [line 31]\n REMOVE_TEMPS(n$5,n$6); [line 31]\n " shape="box"]
21 -> 20 ;
20 [label="20: Call _fun_fun_v \n n$2=*&p:int * [line 32]\n n$3=*n$2:int [line 32]\n n$4=_fun_fun_v(n$3:int ) [line 32]\n REMOVE_TEMPS(n$2,n$3,n$4); [line 32]\n " shape="box"]
20 -> 19 ;
Fix type information about reference types in CFGs Summary: public Two cases were not handled properly so far: 1. Declaration of a reference variable missed reference bit in type 2. Parameters to a function expecting T& had type T. The way to distinguish reference types from value types is to look whether parameter is type 'T rvalue' or type 'T lvalue' (xvalue probably as well) Unfortunately, we can't just say 'T lvalue' = 'T&' because it would break a lot of things in our frontend. However, we know that when parameter to a function call has type 'T lvalue', it has to be 'T&' type. Same applies when init_expression type is lvalue. So, the solution is to add wrapper function that looks at results of `instruction` function and expected expression type. Then if it's lvalue, wrap the type in reference. Do this wrapping magic only when we know that lvalue mean reference type. The rest of the changes is to make frontend tests pass - since we use different fields in the AST, some of them were incorrectly set before and no one noticed. Reviewed By: cristianoc Differential Revision: D2549991 fb-gh-sync-id: 067f5d5
9 years ago
19 [label="19: Call _fun_fun_r \n n$0=*&p:int * [line 33]\n n$1=_fun_fun_r(n$0:int &) [line 33]\n REMOVE_TEMPS(n$0,n$1); [line 33]\n NULLIFY(&p,false); [line 33]\n NULLIFY(&a,false); [line 33]\n APPLY_ABSTRACTION; [line 33]\n " shape="box"]
Fix handling of C++ references Summary: @​public This diff changes following things: 1. expression_info.type_ptr has type than decl_ref_info.type_ptr for reference types. Use type from decl_ref_info as a source of truth 2. reference types need to have one extra dereference that is not in AST. Add handling for this. 3. [small refactor] create function that creates temporary variable from res_trans expression and returns new res_trans. Some caveats: 1. types are not quite right yet (see .dot files). 2. decl_ref_info might not be set for DeclRefExpr, make frontend crash in that case to catch when this happens This is high risk change since it changes behavior of every translation on very widely used expr. Reviewed By: @dulmarod Differential Revision: D2540632 fb-gh-sync-id: aa28936
9 years ago
19 -> 18 ;
18 [label="18: Exit unbox_ptr \n " color=yellow style=filled]
17 [label="17: Start unbox_ptr\nFormals: \nLocals: p:int * a:int \n DECLARE_LOCALS(&return,&p,&a); [line 27]\n NULLIFY(&p,false); [line 27]\n " color=yellow style=filled]
17 -> 23 ;
16 [label="16: DeclStmt \n *&a:int =3 [line 18]\n " shape="box"]
16 -> 15 ;
Fix type information about reference types in CFGs Summary: public Two cases were not handled properly so far: 1. Declaration of a reference variable missed reference bit in type 2. Parameters to a function expecting T& had type T. The way to distinguish reference types from value types is to look whether parameter is type 'T rvalue' or type 'T lvalue' (xvalue probably as well) Unfortunately, we can't just say 'T lvalue' = 'T&' because it would break a lot of things in our frontend. However, we know that when parameter to a function call has type 'T lvalue', it has to be 'T&' type. Same applies when init_expression type is lvalue. So, the solution is to add wrapper function that looks at results of `instruction` function and expected expression type. Then if it's lvalue, wrap the type in reference. Do this wrapping magic only when we know that lvalue mean reference type. The rest of the changes is to make frontend tests pass - since we use different fields in the AST, some of them were incorrectly set before and no one noticed. Reviewed By: cristianoc Differential Revision: D2549991 fb-gh-sync-id: 067f5d5
9 years ago
15 [label="15: DeclStmt \n *&r:int &=&a [line 19]\n " shape="box"]
Fix handling of C++ references Summary: @​public This diff changes following things: 1. expression_info.type_ptr has type than decl_ref_info.type_ptr for reference types. Use type from decl_ref_info as a source of truth 2. reference types need to have one extra dereference that is not in AST. Add handling for this. 3. [small refactor] create function that creates temporary variable from res_trans expression and returns new res_trans. Some caveats: 1. types are not quite right yet (see .dot files). 2. decl_ref_info might not be set for DeclRefExpr, make frontend crash in that case to catch when this happens This is high risk change since it changes behavior of every translation on very widely used expr. Reviewed By: @dulmarod Differential Revision: D2540632 fb-gh-sync-id: aa28936
9 years ago
15 -> 14 ;
14 [label="14: Call _fun_fun_p \n n$5=*&r:int & [line 21]\n n$6=_fun_fun_p(n$5:int *) [line 21]\n REMOVE_TEMPS(n$5,n$6); [line 21]\n " shape="box"]
14 -> 13 ;
13 [label="13: Call _fun_fun_v \n n$2=*&r:int & [line 22]\n n$3=*n$2:int [line 22]\n n$4=_fun_fun_v(n$3:int ) [line 22]\n REMOVE_TEMPS(n$2,n$3,n$4); [line 22]\n " shape="box"]
13 -> 12 ;
Fix type information about reference types in CFGs Summary: public Two cases were not handled properly so far: 1. Declaration of a reference variable missed reference bit in type 2. Parameters to a function expecting T& had type T. The way to distinguish reference types from value types is to look whether parameter is type 'T rvalue' or type 'T lvalue' (xvalue probably as well) Unfortunately, we can't just say 'T lvalue' = 'T&' because it would break a lot of things in our frontend. However, we know that when parameter to a function call has type 'T lvalue', it has to be 'T&' type. Same applies when init_expression type is lvalue. So, the solution is to add wrapper function that looks at results of `instruction` function and expected expression type. Then if it's lvalue, wrap the type in reference. Do this wrapping magic only when we know that lvalue mean reference type. The rest of the changes is to make frontend tests pass - since we use different fields in the AST, some of them were incorrectly set before and no one noticed. Reviewed By: cristianoc Differential Revision: D2549991 fb-gh-sync-id: 067f5d5
9 years ago
12 [label="12: Call _fun_fun_r \n n$0=*&r:int & [line 23]\n n$1=_fun_fun_r(n$0:int &) [line 23]\n REMOVE_TEMPS(n$0,n$1); [line 23]\n NULLIFY(&r,false); [line 23]\n NULLIFY(&a,false); [line 23]\n APPLY_ABSTRACTION; [line 23]\n " shape="box"]
Fix handling of C++ references Summary: @​public This diff changes following things: 1. expression_info.type_ptr has type than decl_ref_info.type_ptr for reference types. Use type from decl_ref_info as a source of truth 2. reference types need to have one extra dereference that is not in AST. Add handling for this. 3. [small refactor] create function that creates temporary variable from res_trans expression and returns new res_trans. Some caveats: 1. types are not quite right yet (see .dot files). 2. decl_ref_info might not be set for DeclRefExpr, make frontend crash in that case to catch when this happens This is high risk change since it changes behavior of every translation on very widely used expr. Reviewed By: @dulmarod Differential Revision: D2540632 fb-gh-sync-id: aa28936
9 years ago
12 -> 11 ;
11 [label="11: Exit unbox_ref \n " color=yellow style=filled]
10 [label="10: Start unbox_ref\nFormals: \nLocals: r:int & a:int \n DECLARE_LOCALS(&return,&r,&a); [line 17]\n NULLIFY(&r,false); [line 17]\n " color=yellow style=filled]
10 -> 16 ;
9 [label="9: Return Stmt \n n$0=*&p:int & [line 12]\n n$1=*n$0:int [line 12]\n *&return:int =n$1 [line 12]\n REMOVE_TEMPS(n$0,n$1); [line 12]\n NULLIFY(&p,false); [line 12]\n APPLY_ABSTRACTION; [line 12]\n " shape="box"]
9 -> 8 ;
8 [label="8: Exit fun_r \n " color=yellow style=filled]
7 [label="7: Start fun_r\nFormals: p:int &\nLocals: \n DECLARE_LOCALS(&return); [line 12]\n " color=yellow style=filled]
7 -> 9 ;
6 [label="6: Return Stmt \n n$0=*&p:int [line 11]\n *&return:int =n$0 [line 11]\n REMOVE_TEMPS(n$0); [line 11]\n NULLIFY(&p,false); [line 11]\n APPLY_ABSTRACTION; [line 11]\n " shape="box"]
6 -> 5 ;
5 [label="5: Exit fun_v \n " color=yellow style=filled]
4 [label="4: Start fun_v\nFormals: p:int \nLocals: \n DECLARE_LOCALS(&return); [line 11]\n " color=yellow style=filled]
4 -> 6 ;
3 [label="3: Return Stmt \n n$0=*&p:int * [line 10]\n n$1=*n$0:int [line 10]\n *&return:int =n$1 [line 10]\n REMOVE_TEMPS(n$0,n$1); [line 10]\n NULLIFY(&p,false); [line 10]\n APPLY_ABSTRACTION; [line 10]\n " shape="box"]
3 -> 2 ;
2 [label="2: Exit fun_p \n " color=yellow style=filled]
1 [label="1: Start fun_p\nFormals: p:int *\nLocals: \n DECLARE_LOCALS(&return); [line 10]\n " color=yellow style=filled]
1 -> 3 ;
}