pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ef556e048e'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/shared/block/block_release.m.dot

80 lines
7.9 KiB
Raw Normal View History Unescape

Add @generated comment to icfg.dot files Reviewed By: jvillard Differential Revision: D3358243 fbshipit-source-id: a47cc01
9 years ago
/* @generated */
initial synchronization
10 years ago
digraph iCFG {
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_1" [label="1: Start My_manager_blockReleaseTODO\nFormals: self:My_manager*\nLocals: newImage:CGImage* context:CGContext* z:int b:_fn_(*) \n DECLARE_LOCALS(&return,&newImage,&context,&z,&b); [line 20, column 1]\n " color=yellow style=filled]
Fix control-flow graph shape when conditional is last instruction. Summary:public When a conditional is the last instruction, there will be a join node leading directly to the exit node. Some instructions, such as nullification of dead variables, and abstraction, are added to the control flow graph automatically. But, join nodes cannot contain instructions. So when a procedure ends with a conditional, there might be no place to store these instructions. This diff adds one extra node between the join and the exit node in that situation. Reviewed By: jvillard Differential Revision: D3179056 fb-gh-sync-id: 2b9cd7e fbshipit-source-id: 2b9cd7e
9 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_1" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_12" ;
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_2" [label="2: Exit My_manager_blockReleaseTODO \n " color=yellow style=filled]
initial synchronization
10 years ago
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_3" [label="3: Return Stmt \n n$0=*&z:int [line 32, column 10]\n *&return:int=n$0 [line 32, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_3" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_2" ;
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_4" [label="4: + \n " ]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_4" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_3" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_5" [label="5: Prune (true branch) \n n$1=*&context:CGContext* [line 30, column 7]\n PRUNE(n$1, true); [line 30, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_5" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_7" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_6" [label="6: Prune (false branch) \n n$1=*&context:CGContext* [line 30, column 7]\n PRUNE(!n$1, false); [line 30, column 7]\n " shape="invhouse"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_6" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_4" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_7" [label="7: Call _fun_CGContextRelease \n n$2=*&context:CGContext* [line 31, column 22]\n _fun_CGContextRelease(n$2:CGContext*) [line 31, column 5]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_7" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_4" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_8" [label="8: Call n$3 \n n$3=*&b:_fn_(*) [line 29, column 3]\n n$4=*&z:int [line 29, column 5]\n n$3(n$4:int) [line 29, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_8" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_5" ;
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_8" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_6" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_9" [label="9: BinaryOperatorStmt: Assign \n DECLARE_LOCALS(&__objc_anonymous_block_My_manager_blockReleaseTODO______1); [line 25, column 7]\n n$8=_fun___objc_alloc_no_fail(sizeof(t=__objc_anonymous_block_My_manager_blockReleaseTODO______1):unsigned long) [line 25, column 7]\n *&__objc_anonymous_block_My_manager_blockReleaseTODO______1:__objc_anonymous_block_My_manager_blockReleaseTODO______1=n$8 [line 25, column 7]\n n$9=*&newImage:CGImage* [line 25, column 7]\n *n$8.newImage:CGImage*=n$9 [line 25, column 7]\n n$5=*&newImage:CGImage* [line 25, column 7]\n *&b:_fn_(*)=(_fun___objc_anonymous_block_My_manager_blockReleaseTODO______1,n$5) [line 25, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_9" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_8" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_10" [label="10: DeclStmt \n n$10=*&context:CGContext* [line 24, column 52]\n n$11=_fun_CGBitmapContextCreateImage(n$10:CGContext*) [line 24, column 25]\n *&newImage:CGImage*=n$11 [line 24, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_10" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_9" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_11" [label="11: DeclStmt \n n$12=_fun_CGBitmapContextCreate(null:void*,0:unsigned long,0:unsigned long,8:unsigned long,0:unsigned long,null:CGColorSpace*,0:unsigned int) [line 23, column 26]\n *&context:CGContext*=n$12 [line 23, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_11" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_10" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_12" [label="12: DeclStmt \n *&z:int=3 [line 22, column 3]\n " shape="box"]
initial synchronization
10 years ago
[clang] Change procname file naming scheme Summary: Procnames files are now reversed qualifier lists with `#` as separator (instead of `::` which needs to be escaped in bash). Because of the mechanism that is used to obtain qualifiers, it also affects naming for ObjC classes. Examples: ``` std::unique_ptr<int>::get -> get#unique_ptr<int>#std#__MANGLED,...__ // C++ method folly::split -> split#folly#__MANGLED,..._ // function within namespace NSNumber numberWithBool: -> numberWithBool:#NSNumber#class // ObjC method ``` Reviewed By: jvillard Differential Revision: D4689701 fbshipit-source-id: c3acfc6
8 years ago
"blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_12" -> "blockReleaseTODO#My_manager#instance.8c1d633cf596e86a307167d9425628a8_11" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_1" [label="1: Start __objc_anonymous_block_My_manager_blockReleaseTODO______1\nFormals: newImage:CGImage* a:int\nLocals: \nCaptured: newImage:CGImage* \n DECLARE_LOCALS(&return); [line 25, column 7]\n " color=yellow style=filled]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_1" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_5" ;
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_1" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_6" ;
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_2" [label="2: Exit __objc_anonymous_block_My_manager_blockReleaseTODO______1 \n " color=yellow style=filled]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_3" [label="3: + \n " ]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_3" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_4" ;
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_4" [label="4: between_join_and_exit \n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_4" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_2" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_5" [label="5: Prune (true branch) \n n$6=*&newImage:CGImage* [line 26, column 9]\n PRUNE(n$6, true); [line 26, column 9]\n " shape="invhouse"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_5" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_7" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_6" [label="6: Prune (false branch) \n n$6=*&newImage:CGImage* [line 26, column 9]\n PRUNE(!n$6, false); [line 26, column 9]\n " shape="invhouse"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_6" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_3" ;
[siof] one access per sink, better report deduplication Summary: The previous domain for SIOF was duplicating some work with the generic Trace domain, and basically was a bit confused and confusing. A sink was a set of global accesses, and a state contains a set of sinks. Then the checker has to needlessly jump through hoops to normalize this set of sets of accesses into a set of accesses. The new domain has one sink = one access, as suggested by sblackshear. This simplifies a few things, and makes the dedup logic much easier: just grab the first report of the list of reports for a function. We only report on the fake procedures generated to initialise a global, and the filtering means that we keep only one report per global. Reviewed By: sblackshear Differential Revision: D5932138 fbshipit-source-id: acb7285
7 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_7" [label="7: Call _fun_CGImageRelease \n n$7=*&newImage:CGImage* [line 27, column 22]\n _fun_CGImageRelease(n$7:CGImage*) [line 27, column 7]\n " shape="box"]
initial synchronization
10 years ago
Sort nodes when printing cfg to dot file Summary: Currently cfg nodes are written into dot files in whatever order they appear in a hash table. This seems unnecessarily sensitive, so this diff sorts the nodes. Reviewed By: dulmarod Differential Revision: D4232377 fbshipit-source-id: a907cc6
8 years ago
"__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_7" -> "__objc_anonymous_block_My_manager_blockReleaseTODO______1.727fb709fde4c2da5c24b6a887eca95a_3" ;
initial synchronization
10 years ago
}