pghs975uc
/
infer_clone
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'f5e7a6e6d7'
${ noResults }
infer_clone/infer/tests/codetoanalyze/objc/errors/issues.exp

98 lines
18 KiB
Raw Normal View History Unescape

[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/field_superclass/field.c, field_superclass_main, 3, RETAIN_CYCLE, [start of procedure field_superclass_main()]
codetoanalyze/objc/errors/global_const/global_const.m, SimpleRoot_doSomethingBadWithDict:andString:, 3, NULL_DEREFERENCE, [start of procedure doSomethingBadWithDict:andString:,Message stringByAppendingString: with receiver nil returns nil.]
[clang] Don't inline global var initializers Reviewed By: jberdine Differential Revision: D4786653 fbshipit-source-id: 22fd2b3
8 years ago
codetoanalyze/objc/errors/global_const/global_const.m, SimpleRoot_doSomethingOkWithDict:andString:, 3, NULL_DEREFERENCE, [start of procedure doSomethingOkWithDict:andString:,Message stringByAppendingString: with receiver nil returns nil.]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/initialization/compound_literal.c, init_with_compound_literal, 2, DIVIDE_BY_ZERO, [start of procedure init_with_compound_literal()]
codetoanalyze/objc/errors/memory_leaks_benchmark/CADisplayLinkRetainCycle.m, testCycle, 3, RETAIN_CYCLE, [start of procedure testCycle(),start of procedure init,return from a call to CADisplay_init]
codetoanalyze/objc/errors/npe/null_returned_by_method.m, NullReturnedByMethodA_test1, 1, NULL_DEREFERENCE, [start of procedure test1,start of procedure test,return from a call to NullReturnedByMethodA_test]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/errors/procdescs/main.c, ProcdescMain, 3, MEMORY_LEAK, [start of procedure ProcdescMain(),Skipping plusX:andY:: function or method not found]
codetoanalyze/objc/errors/procdescs/main.c, call_nslog, 3, MEMORY_LEAK, [start of procedure call_nslog(),Skipping NSLog(): function or method not found]
codetoanalyze/objc/errors/property/main.c, property_main, 3, MEMORY_LEAK, [start of procedure property_main(),Skipping aProperty: function or method not found]
Use natural order on hpred, optionally ignoring instrumentation Reviewed By: jeremydubreil Differential Revision: D4243981 fbshipit-source-id: 825b910
8 years ago
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_FBAudioInputCallbackChain:, 2, NULL_DEREFERENCE, [start of procedure FBAudioInputCallbackChain:,Message recordState with receiver nil returns nil.]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_FBAudioInputCallbackChain:, 2, PARAMETER_NOT_NULL_CHECKED, [start of procedure FBAudioInputCallbackChain:,Message recorder with receiver nil returns nil. Message recordState with receiver nil returns nil.]
Use natural order on hpred, optionally ignoring instrumentation Reviewed By: jeremydubreil Differential Revision: D4243981 fbshipit-source-id: 825b910
8 years ago
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_FBAudioInputCallbackField, 2, NULL_DEREFERENCE, [start of procedure FBAudioInputCallbackField,Message recordState with receiver nil returns nil.]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_FBAudioInputCallbackSimple:, 2, PARAMETER_NOT_NULL_CHECKED, [start of procedure FBAudioInputCallbackSimple:,Message recordState with receiver nil returns nil.]
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_FBAudioInputCallbackSimpleAliasing:, 3, PARAMETER_NOT_NULL_CHECKED, [start of procedure FBAudioInputCallbackSimpleAliasing:,Message recordState with receiver nil returns nil.]
[ios] Enable npes for self in initializers Reviewed By: ddino Differential Revision: D4543364 fbshipit-source-id: 0c662c5
8 years ago
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_init, 2, NULL_DEREFERENCE, [start of procedure init]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/warnings/ParameterNotNullableExample.m, FBAudioRecorder_test, 3, NULL_DEREFERENCE, [start of procedure test,Message recordState with receiver nil returns nil.]
[objc] Better names for the block translation and using temp variables Reviewed By: sblackshear Differential Revision: D6125704 fbshipit-source-id: 7b6aefc
7 years ago
codetoanalyze/objc/shared/block/BlockVar.m, BlockVar_blockPostBad, 5, NULL_DEREFERENCE, [start of procedure blockPostBad,start of procedure block,return from a call to objc_blockBlockVar_blockPostBad_2]
[DB] Use realpath when calling source_file_from_abs_path Summary: Dealing with symbolic links in project root is tricky. To avoid it, always normalize all paths to sources with `realpath`. Changes to tests are expected - infer started to resolve symbolic links which screws up with our testing mechanism. Reviewed By: jberdine Differential Revision: D4237587 fbshipit-source-id: fe1cb01
8 years ago
codetoanalyze/objc/shared/block/BlockVar.m, BlockVar_capturedNullDeref, 5, NULL_DEREFERENCE, [start of procedure capturedNullDeref,start of procedure block]
[objc] Better names for the block translation and using temp variables Reviewed By: sblackshear Differential Revision: D6125704 fbshipit-source-id: 7b6aefc
7 years ago
codetoanalyze/objc/shared/block/BlockVar.m, BlockVar_navigateToURLInBackground, 8, NULL_DEREFERENCE, [start of procedure navigateToURLInBackground,start of procedure block,start of procedure test,return from a call to BlockVar_test,return from a call to objc_blockBlockVar_navigateToURLInBackground_1,Condition is true]
codetoanalyze/objc/shared/block/block.m, main1, 31, DIVIDE_BY_ZERO, [start of procedure main1(),start of procedure block,start of procedure block,return from a call to objc_blockobjc_blockmain1_2_3,return from a call to objc_blockmain1_2,start of procedure block,return from a call to objc_blockmain1_1]
codetoanalyze/objc/shared/block/block_no_args.m, My_manager_m, 10, NULL_DEREFERENCE, [start of procedure m,start of procedure block,return from a call to objc_blockMy_manager_m_1,Condition is true]
[DB] Use realpath when calling source_file_from_abs_path Summary: Dealing with symbolic links in project root is tricky. To avoid it, always normalize all paths to sources with `realpath`. Changes to tests are expected - infer started to resolve symbolic links which screws up with our testing mechanism. Reviewed By: jberdine Differential Revision: D4237587 fbshipit-source-id: fe1cb01
8 years ago
codetoanalyze/objc/shared/block/block_release.m, My_manager_blockReleaseTODO, 5, MEMORY_LEAK, [start of procedure blockReleaseTODO]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/shared/category_procdesc/main.c, CategoryProcdescMain, 3, MEMORY_LEAK, [start of procedure CategoryProcdescMain(),Skipping performDaysWork: function or method not found]
[infer][biabduction] no longer drop the atoms that are referring to footprint variables Summary: Atoms of the form `identifier = footprint var` naturally occurs with the angelic analysis mode. So it is not clear to me why we should drop those. Reviewed By: sblackshear Differential Revision: D5654754 fbshipit-source-id: 9dd2eb5
7 years ago
codetoanalyze/objc/shared/field_superclass/SuperExample.m, ASuper_init, 2, NULL_DEREFERENCE, [start of procedure init,start of procedure init,return from a call to BSuper_init]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/field_superclass/SubtypingExample.m, Employee_initWithName:andAge:andEducation:, 3, NULL_TEST_AFTER_DEREFERENCE, [start of procedure initWithName:andAge:andEducation:,start of procedure initWithName:andAge:,return from a call to Person_initWithName:andAge:,Condition is false]
codetoanalyze/objc/errors/field_superclass/SubtypingExample.m, Employee_initWithName:andAge:andEducation:, 6, DIVIDE_BY_ZERO, [start of procedure initWithName:andAge:andEducation:,start of procedure initWithName:andAge:,return from a call to Person_initWithName:andAge:,Condition is true]
codetoanalyze/objc/errors/field_superclass/SubtypingExample.m, subtyping_test, 0, DIVIDE_BY_ZERO, [start of procedure subtyping_test(),start of procedure testFields(),start of procedure setEmployeeEducation:,return from a call to Employee_setEmployeeEducation:,start of procedure setAge:,return from a call to Person_setAge:,start of procedure setEmployeeEducation:,return from a call to Employee_setEmployeeEducation:,start of procedure getAge,return from a call to Person_getAge,return from a call to testFields]
codetoanalyze/objc/errors/initialization/struct_initlistexpr.c, field_set_correctly, 2, DIVIDE_BY_ZERO, [start of procedure field_set_correctly()]
codetoanalyze/objc/errors/initialization/struct_initlistexpr.c, implicit_expr_set_correctly, 3, DIVIDE_BY_ZERO, [start of procedure implicit_expr_set_correctly()]
codetoanalyze/objc/errors/initialization/struct_initlistexpr.c, point_coords_set_correctly, 2, DIVIDE_BY_ZERO, [start of procedure point_coords_set_correctly()]
codetoanalyze/objc/errors/memory_leaks_benchmark/retain_cycle.m, strongcycle, 6, RETAIN_CYCLE, [start of procedure strongcycle()]
codetoanalyze/objc/errors/memory_leaks_benchmark/retain_cycle2.m, strongcycle2, 4, RETAIN_CYCLE, [start of procedure strongcycle2(),start of procedure init,return from a call to Parent_init,start of procedure init,return from a call to Child_init,start of procedure setChild:,return from a call to Parent_setChild:,start of procedure setParent:,return from a call to Child_setParent:]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/errors/npe/UpdateDict.m, add_nil_in_dict, 10, NULL_DEREFERENCE, [start of procedure add_nil_in_dict(),Skipping dictionaryWithObjectsAndKeys:: function or method not found]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/npe/UpdateDict.m, add_nil_to_array, 4, NULL_DEREFERENCE, [start of procedure add_nil_to_array()]
codetoanalyze/objc/errors/npe/UpdateDict.m, insert_nil_in_array, 4, NULL_DEREFERENCE, [start of procedure insert_nil_in_array()]
Force emitting prune node for C++ comparison expressions Summary: This diff tries to achieve the followings: if we have the following C++ codes: ``` bool foo(int x, int y) { return &x == &y; } ``` We want the C++ frontend to emit Sil as if the input is written as ``` bool foo(int x, int y) { if (&x == &y) return 1; else return 0; } ``` This matches the behavior of our Java frontend. The reason why we prefer an explicit branch is that it will force the backend to eagerly produce two different specs for `foo`. Without the explicit branch, for the above example the backend would produce one spec with `return = (&x == &y)` as the post condition, which is not ideal because (1) we don't want local variables to escape to the function summary, and (2) with the knowledge that no two local variables may alias each other, the backend could actually determines that `&x == &y` is always false, emitting a more precise postcondition `return = 0`. This is not possible if we do not eagerly resolve the comparison expression. Reviewed By: akotulski Differential Revision: D5260745 fbshipit-source-id: 6bbbf99
8 years ago
codetoanalyze/objc/errors/npe/UpdateDict.m, nullable_NSDictionary_objectForKey, 4, NULL_DEREFERENCE, [start of procedure nullable_NSDictionary_objectForKey(),Condition is true,Condition is true,Condition is true]
codetoanalyze/objc/errors/npe/UpdateDict.m, nullable_NSDictionary_objectForKeyedSubscript, 5, NULL_DEREFERENCE, [start of procedure nullable_NSDictionary_objectForKeyedSubscript(),Condition is true,Condition is true,Condition is true]
codetoanalyze/objc/errors/npe/UpdateDict.m, nullable_NSMapTable_objectForKey, 4, NULL_DEREFERENCE, [start of procedure nullable_NSMapTable_objectForKey(),Condition is true,Condition is true,Condition is true]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/npe/UpdateDict.m, update_array_with_null, 5, NULL_DEREFERENCE, [start of procedure update_array_with_null()]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/errors/npe/UpdateDict.m, update_dict_with_key_null, 10, NULL_DEREFERENCE, [start of procedure update_dict_with_key_null(),Skipping dictionaryWithObjectsAndKeys:: function or method not found]
[objc] Better names for the block translation and using temp variables Reviewed By: sblackshear Differential Revision: D6125704 fbshipit-source-id: 7b6aefc
7 years ago
codetoanalyze/objc/errors/npe/WeakCapturedVarsNPE.m, objc_blockWeakCapturedA_strongSelfNoCheck_2, 2, NULL_DEREFERENCE, [start of procedure block]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/npe/nil_in_array_literal.m, Arr_nilInArrayLiteral0, 4, NULL_DEREFERENCE, [start of procedure nilInArrayLiteral0]
codetoanalyze/objc/errors/npe/nil_in_array_literal.m, Arr_nilInArrayLiteral1, 4, NULL_DEREFERENCE, [start of procedure nilInArrayLiteral1]
codetoanalyze/objc/errors/npe/nil_in_array_literal.m, Arr_nilInArrayLiteral2, 4, NULL_DEREFERENCE, [start of procedure nilInArrayLiteral2]
codetoanalyze/objc/errors/npe/nil_in_array_literal.m, Arr_nilInArrayLiteral3, 4, NULL_DEREFERENCE, [start of procedure nilInArrayLiteral3]
codetoanalyze/objc/errors/npe/nil_in_array_literal.m, Arr_nilInArrayWithObject, 4, NULL_DEREFERENCE, [start of procedure nilInArrayWithObject]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralKey0, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralKey0]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralKey1, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralKey1]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralKey2, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralKey2]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralKey3, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralKey3]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralValue0, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralValue0]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralValue1, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralValue1]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralValue2, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralValue2]
codetoanalyze/objc/errors/npe/nil_in_dictionary_literal.m, ADict_nilInDictionaryLiteralValue3, 4, NULL_DEREFERENCE, [start of procedure nilInDictionaryLiteralValue3]
codetoanalyze/objc/errors/npe/npe_conditional.m, conditionalNPE, 3, NULL_DEREFERENCE, [start of procedure conditionalNPE(),start of procedure name,return from a call to ConditionalA_name,Condition is true]
[ios] Enable npes for self in initializers Reviewed By: ddino Differential Revision: D4543364 fbshipit-source-id: 0c662c5
8 years ago
codetoanalyze/objc/errors/npe/npe_self.m, CSelf_init, 2, NULL_DEREFERENCE, [start of procedure init]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/npe/npe_self.m, CSelf_test, 3, NULL_DEREFERENCE, [start of procedure test,Condition is false]
codetoanalyze/objc/errors/npe/nullable.m, derefNullableParamDirect, 0, NULL_DEREFERENCE, [start of procedure derefNullableParamDirect()]
codetoanalyze/objc/errors/npe/nullable.m, derefNullableParamIndirect, 2, NULL_DEREFERENCE, [start of procedure derefNullableParamIndirect()]
codetoanalyze/objc/errors/npe/nullable.m, parameter_nullable_bug, 5, NULL_DEREFERENCE, [start of procedure parameter_nullable_bug()]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/errors/property/ExplicitIvarName.m, ExplicitIvarNameA_testDefaultName, 7, NULL_DEREFERENCE, [start of procedure testDefaultName,Skipping setY:: function or method not found,Condition is true]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/property/ExplicitIvarName.m, ExplicitIvarNameA_testExplicit, 6, NULL_DEREFERENCE, [start of procedure testExplicit,Condition is true]
codetoanalyze/objc/errors/subtyping/KindOfClassExample.m, shouldThrowDivideByZero1, 2, DIVIDE_BY_ZERO, [start of procedure shouldThrowDivideByZero1(),start of procedure init,return from a call to Base_init,start of procedure returnsZero1:,Condition is true,return from a call to Base_returnsZero1:]
codetoanalyze/objc/errors/subtyping/KindOfClassExample.m, shouldThrowDivideByZero2, 2, DIVIDE_BY_ZERO, [start of procedure shouldThrowDivideByZero2(),start of procedure init,return from a call to Base_init,start of procedure returnsZero2(),Condition is false,return from a call to returnsZero2]
codetoanalyze/objc/errors/subtyping/KindOfClassExample.m, shouldThrowDivideByZero3, 3, DIVIDE_BY_ZERO, [start of procedure shouldThrowDivideByZero3(),start of procedure init,return from a call to Derived_init,Condition is true]
codetoanalyze/objc/errors/variadic_methods/premature_nil_termination.m, PrematureNilTermA_nilInArrayWithObjects, 5, PREMATURE_NIL_TERMINATION_ARGUMENT, [start of procedure nilInArrayWithObjects]
[memory leaks] Adding model for CVPixelBufferRelease Reviewed By: da319 Differential Revision: D6458051 fbshipit-source-id: a61ffb9
7 years ago
codetoanalyze/objc/errors/memory_leaks_benchmark/CoreVideoExample.m, CoreVideoExample_cvpixelbuffer_not_released_leak, 1, MEMORY_LEAK, [start of procedure cvpixelbuffer_not_released_leak]
[ios] Model NSData initWithBytesNoCopy:data length:dataLength Reviewed By: akotulski Differential Revision: D4666223 fbshipit-source-id: 2c88ce8
8 years ago
codetoanalyze/objc/errors/memory_leaks_benchmark/NSData_models_tests.m, NSData_models_tests_macForIV:, 2, MEMORY_LEAK, [start of procedure macForIV:]
[objc] Refactor modeling of CoreFoundation and CoreGraphics libraries Summary: The diff is very big but it's mostly removing code. It was inspired by the fact that we were getting Dead Store FPs because we were modeling some functions from CoreFoundation and CoreGraphics directly as alloc in the frontend, which caused the parameters of the function to be seen as dead. See the new test. To deal with this, if we are going to skip the function, we model it as malloc instead. Given how many models we had for those "model as malloc" functions, I removed them to rely solely on the new mechanism. The modeling of malloc and release was still based on the old retain count implementation, even though all we do here is a malloc/free kind of analysis. I also changed that to be actually malloc/free which removed many Assert false in the tests. CFRelease is not exactly free though, and it's possible to use the variable afterwards. So used a custom free builtin that only cares about removing the Memory attribute and focuses on minimizing Memory Leaks FPs. Otherwise we were translating CFBridgingRelease as a special cast, and this wasn't working. To simplify this as well, I removed all the code for the special cast, and just modeled CFBridgingRelease and CFAutorelease also as free_cf, to avoid Memory Leak false positives. I also treated the cast __bridge_transfer as a free_cf model. This means we stopped trying to report Memory Leaks on those objects. The modeling of CoreGraph release functions was done in the frontend, but seemed simpler to also simplify that code and model all the relevant functions. Reviewed By: sblackshear Differential Revision: D6397150 fbshipit-source-id: b1dc636
7 years ago
codetoanalyze/objc/errors/memory_leaks_benchmark/NSString_models_tests.m, StringInitA_hexStringValue, 11, MEMORY_LEAK, [start of procedure hexStringValue,Skipping CFStringCreateWithBytesNoCopy(): function or method not found,Condition is false]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/npe/Fraction.m, test_virtual_call, 7, NULL_DEREFERENCE, [start of procedure test_virtual_call(),start of procedure setNumerator:,return from a call to Fraction_setNumerator:,start of procedure getNumerator,return from a call to Fraction_getNumerator,Condition is true]
codetoanalyze/objc/errors/npe/Npe_with_equal_names.m, EqualNamesTest, 3, NULL_DEREFERENCE, [start of procedure EqualNamesTest(),start of procedure meth,return from a call to EqualNamesA_meth]
codetoanalyze/objc/errors/npe/block.m, BlockA_doSomethingThenCallback:, 2, PARAMETER_NOT_NULL_CHECKED, [start of procedure doSomethingThenCallback:]
codetoanalyze/objc/errors/npe/block.m, BlockA_foo, 5, NULL_DEREFERENCE, [start of procedure foo]
codetoanalyze/objc/errors/npe/block.m, BlockA_foo3:, 3, NULL_DEREFERENCE, [start of procedure foo3:]
codetoanalyze/objc/errors/npe/block.m, BlockA_foo4:, 6, NULL_DEREFERENCE, [start of procedure foo4:]
codetoanalyze/objc/errors/npe/block.m, BlockA_foo7, 2, IVAR_NOT_NULL_CHECKED, [start of procedure foo7]
[clang] Add a preanalysis to compute nullability annotations Reviewed By: sblackshear Differential Revision: D4884502 fbshipit-source-id: e0b12a5
8 years ago
codetoanalyze/objc/errors/npe/ivar_blocks.m, MyClass_ivar_npe, 1, IVAR_NOT_NULL_CHECKED, [start of procedure ivar_npe]
[tests] Make project root infer/test/ for clang tests Summary: Run all clang tests with project-root at `infer/tests`. I need it because we'll start resolving symbolic links soon and some tests would lead outside of project root which means we'd start seeing absolute paths in recorded tests. Diff that does same thing for java tests: D4233236 Reviewed By: jberdine Differential Revision: D4233194 fbshipit-source-id: c261a2b
8 years ago
codetoanalyze/objc/errors/npe/skip_method_with_nil_object.m, SkipMethodNilA_testBug:, 6, PARAMETER_NOT_NULL_CHECKED, [start of procedure testBug:,Message get_a with receiver nil returns nil.,Message skip_method with receiver nil returns nil.,Condition is false]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/errors/property/main.c, property_main, 3, MEMORY_LEAK, [start of procedure property_main(),Skipping aProperty: function or method not found]
[objc] Model dispatch functions Reviewed By: ddino, jvillard Differential Revision: D6359807 fbshipit-source-id: b1a04de
7 years ago
codetoanalyze/objc/errors/resource_leaks/Dispatch_sources.m, ProcessContentsOfFile, 35, RESOURCE_LEAK, [start of procedure ProcessContentsOfFile(),Condition is false,Skipping dispatch_get_global_queue(): function or method not found,Skipping dispatch_source_create(): function or method not found,Condition is false]
[objc] Better names for the block translation and using temp variables Reviewed By: sblackshear Differential Revision: D6125704 fbshipit-source-id: 7b6aefc
7 years ago
codetoanalyze/objc/errors/resource_leaks/Dispatch_sources.m, objc_blockProcessContentsOfFile_2, 6, MEMORY_LEAK, [start of procedure block,Skipping dispatch_source_get_data(): function or method not found,Condition is true,Skipping MyProcessFileData(): function or method not found]
[cleanup] Remove the retain count implementation from ObjC that is unused. Reviewed By: jvillard Differential Revision: D6123668 fbshipit-source-id: 2836696
7 years ago
codetoanalyze/objc/errors/resource_leaks/ResourceLeakExample.m, NSFileHandle_fileHandleForLoggingAtPath:mode:, 9, RESOURCE_LEAK, [start of procedure fileHandleForLoggingAtPath:mode:,Condition is true,Skipping fileSystemRepresentation: function or method not found,Condition is false,Condition is true,Skipping autorelease: function or method not found]
[ios] Translate nonnull annotations and take them into account in parameter not null checked issues. Reviewed By: sblackshear Differential Revision: D4706345 fbshipit-source-id: c7e0065
8 years ago
codetoanalyze/objc/shared/annotations/nonnull_annotations.m, A_test1:, 2, PARAMETER_NOT_NULL_CHECKED, [start of procedure test1:,Message child with receiver nil returns nil.]
codetoanalyze/objc/shared/annotations/nonnull_annotations.m, A_test3:, 1, PARAMETER_NOT_NULL_CHECKED, [start of procedure test3:]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/shared/annotations/nullable_annotations.m, User_otherUserName, 2, NULL_DEREFERENCE, [start of procedure otherUserName,Skipping otherUser: function or method not found]
codetoanalyze/objc/shared/annotations/nullable_annotations.m, npe_property_nullable, 3, NULL_DEREFERENCE, [start of procedure npe_property_nullable(),Skipping child: function or method not found]
codetoanalyze/objc/shared/annotations/nullable_annotations_fields.m, A_nullable_field, 3, NULL_DEREFERENCE, [start of procedure nullable_field,Skipping getA(): function or method not found]
[objc] Model dispatch functions Reviewed By: ddino, jvillard Differential Revision: D6359807 fbshipit-source-id: b1a04de
7 years ago
codetoanalyze/objc/shared/block/dispatch.m, DispatchA_dispatch_a_block_variable_from_macro_delivers_initialised_object, 3, DIVIDE_BY_ZERO, [start of procedure dispatch_a_block_variable_from_macro_delivers_initialised_object,start of procedure dispatch_a_block_variable_from_macro,Skipping _dispatch_once(): function or method not found,return from a call to DispatchA_dispatch_a_block_variable_from_macro]
[DB] Use realpath when calling source_file_from_abs_path Summary: Dealing with symbolic links in project root is tricky. To avoid it, always normalize all paths to sources with `realpath`. Changes to tests are expected - infer started to resolve symbolic links which screws up with our testing mechanism. Reviewed By: jberdine Differential Revision: D4237587 fbshipit-source-id: fe1cb01
8 years ago
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_blockCapturedVarLeak, 3, MEMORY_LEAK, [start of procedure blockCapturedVarLeak]
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_blockFreeNoLeakTODO, 3, MEMORY_LEAK, [start of procedure blockFreeNoLeakTODO]
Adding changes to objc issues to fix tests. Summary: The title. Reviewed By: jvillard Differential Revision: D5735303 fbshipit-source-id: ac0ff92
7 years ago
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_createCloseCrossGlyph:, 2, MEMORY_LEAK, [start of procedure createCloseCrossGlyph:,Skipping CGRectGetHeight(): function or method not found]
[DB] Use realpath when calling source_file_from_abs_path Summary: Dealing with symbolic links in project root is tricky. To avoid it, always normalize all paths to sources with `realpath`. Changes to tests are expected - infer started to resolve symbolic links which screws up with our testing mechanism. Reviewed By: jberdine Differential Revision: D4237587 fbshipit-source-id: fe1cb01
8 years ago
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_measureFrameSizeForText, 1, MEMORY_LEAK, [start of procedure measureFrameSizeForText]
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_regularLeak, 3, MEMORY_LEAK, [start of procedure regularLeak]
[objc] Refactor modeling of CoreFoundation and CoreGraphics libraries Summary: The diff is very big but it's mostly removing code. It was inspired by the fact that we were getting Dead Store FPs because we were modeling some functions from CoreFoundation and CoreGraphics directly as alloc in the frontend, which caused the parameters of the function to be seen as dead. See the new test. To deal with this, if we are going to skip the function, we model it as malloc instead. Given how many models we had for those "model as malloc" functions, I removed them to rely solely on the new mechanism. The modeling of malloc and release was still based on the old retain count implementation, even though all we do here is a malloc/free kind of analysis. I also changed that to be actually malloc/free which removed many Assert false in the tests. CFRelease is not exactly free though, and it's possible to use the variable afterwards. So used a custom free builtin that only cares about removing the Memory attribute and focuses on minimizing Memory Leaks FPs. Otherwise we were translating CFBridgingRelease as a special cast, and this wasn't working. To simplify this as well, I removed all the code for the special cast, and just modeled CFBridgingRelease and CFAutorelease also as free_cf, to avoid Memory Leak false positives. I also treated the cast __bridge_transfer as a free_cf model. This means we stopped trying to report Memory Leaks on those objects. The modeling of CoreGraph release functions was done in the frontend, but seemed simpler to also simplify that code and model all the relevant functions. Reviewed By: sblackshear Differential Revision: D6397150 fbshipit-source-id: b1dc636
7 years ago
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_test, 3, MEMORY_LEAK, [start of procedure test,Skipping bounds: function or method not found,Skipping setShadowPath:: function or method not found]
[DB] Use realpath when calling source_file_from_abs_path Summary: Dealing with symbolic links in project root is tricky. To avoid it, always normalize all paths to sources with `realpath`. Changes to tests are expected - infer started to resolve symbolic links which screws up with our testing mechanism. Reviewed By: jberdine Differential Revision: D4237587 fbshipit-source-id: fe1cb01
8 years ago
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_test1:, 1, MEMORY_LEAK, [start of procedure test1:]
codetoanalyze/objc/shared/memory_leaks_benchmark/MemoryLeakExample.m, MemoryLeakExample_test2:, 1, MEMORY_LEAK, [start of procedure test2:]
[objc] Translate ObjCAvailabilityExpr Reviewed By: sblackshear Differential Revision: D5940985 fbshipit-source-id: 1e22357
7 years ago
codetoanalyze/objc/shared/npe/Available_expr.m, Available_expr_test_no_bug, 3, NULL_DEREFERENCE, [start of procedure test_no_bug,Condition is true]