From 07175f163cdd01650860efa6c343704c006d1e9c Mon Sep 17 00:00:00 2001
From: Nikos Gorogiannis <nikosg@fb.com>
Date: Thu, 23 Apr 2020 08:21:42 -0700
Subject: [PATCH] [racerd] make unknown-returns-owned true by default

Summary: This option makes RacerD angelic wrt the ownership of returned objects from procedures without summary. This will now be made the default and the option deprecated up the diff stack.

Reviewed By: dulmarod

Differential Revision: D21174676

fbshipit-source-id: 9c48d3d7d
---
 infer/man/man1/infer-analyze.txt | 6 +++---
 infer/man/man1/infer-full.txt    | 6 +++---
 infer/man/man1/infer.txt         | 6 +++---
 infer/src/base/Config.ml         | 2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/infer/man/man1/infer-analyze.txt b/infer/man/man1/infer-analyze.txt
index a13b06471..9ec8fa6fd 100644
--- a/infer/man/man1/infer-analyze.txt
+++ b/infer/man/man1/infer-analyze.txt
@@ -430,10 +430,10 @@ RACERD CHECKER OPTIONS
            Activates: Check @GuardedBy annotations with RacerD (Conversely:
            --no-racerd-guardedby)
 
-       --racerd-unknown-returns-owned
-           Activates: Assume that all methods without a CFG (including
+       --no-racerd-unknown-returns-owned
+           Deactivates: Assume that all methods without a CFG (including
            abstract methods) return owned objects (Conversely:
-           --no-racerd-unknown-returns-owned)
+           --racerd-unknown-returns-owned)
 
        --threadsafe-aliases json
            Specify custom annotations that should be considered aliases of
diff --git a/infer/man/man1/infer-full.txt b/infer/man/man1/infer-full.txt
index 61d6f833b..231202a34 100644
--- a/infer/man/man1/infer-full.txt
+++ b/infer/man/man1/infer-full.txt
@@ -910,10 +910,10 @@ OPTIONS
            Activates: Enable --racerd and disable all other checkers
            (Conversely: --no-racerd-only)           See also infer-analyze(1).
 
-       --racerd-unknown-returns-owned
-           Activates: Assume that all methods without a CFG (including
+       --no-racerd-unknown-returns-owned
+           Deactivates: Assume that all methods without a CFG (including
            abstract methods) return owned objects (Conversely:
-           --no-racerd-unknown-returns-owned)           See also infer-analyze(1).
+           --racerd-unknown-returns-owned)           See also infer-analyze(1).
 
        --reactive,-r
            Activates: Reactive mode: the analysis starts from the files
diff --git a/infer/man/man1/infer.txt b/infer/man/man1/infer.txt
index 9aeb0dbea..94545a5d1 100644
--- a/infer/man/man1/infer.txt
+++ b/infer/man/man1/infer.txt
@@ -910,10 +910,10 @@ OPTIONS
            Activates: Enable --racerd and disable all other checkers
            (Conversely: --no-racerd-only)           See also infer-analyze(1).
 
-       --racerd-unknown-returns-owned
-           Activates: Assume that all methods without a CFG (including
+       --no-racerd-unknown-returns-owned
+           Deactivates: Assume that all methods without a CFG (including
            abstract methods) return owned objects (Conversely:
-           --no-racerd-unknown-returns-owned)           See also infer-analyze(1).
+           --racerd-unknown-returns-owned)           See also infer-analyze(1).
 
        --reactive,-r
            Activates: Reactive mode: the analysis starts from the files
diff --git a/infer/src/base/Config.ml b/infer/src/base/Config.ml
index f7165fee5..8c63925e5 100644
--- a/infer/src/base/Config.ml
+++ b/infer/src/base/Config.ml
@@ -1830,7 +1830,7 @@ and racerd_guardedby =
 
 
 and racerd_unknown_returns_owned =
-  CLOpt.mk_bool ~long:"racerd-unknown-returns-owned" ~default:false
+  CLOpt.mk_bool ~long:"racerd-unknown-returns-owned" ~default:true
     ~in_help:InferCommand.[(Analyze, manual_racerd)]
     "Assume that all methods without a CFG (including abstract methods) return owned objects"