From 087ff08b82d61b1dffd1f685a555f49f36e8517c Mon Sep 17 00:00:00 2001
From: Sam Blackshear <shb@fb.com>
Date: Tue, 28 Nov 2017 14:53:54 -0800
Subject: [PATCH] [quandary] eliminate spammy soft error for bad return summary

Reviewed By: jeremydubreil

Differential Revision: D6427143

fbshipit-source-id: 55aedb3
---
 infer/src/quandary/TaintAnalysis.ml               | 4 +---
 infer/tests/codetoanalyze/cpp/quandary/basics.cpp | 4 ++++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/infer/src/quandary/TaintAnalysis.ml b/infer/src/quandary/TaintAnalysis.ml
index 64da44f24..822183542 100644
--- a/infer/src/quandary/TaintAnalysis.ml
+++ b/infer/src/quandary/TaintAnalysis.ml
@@ -317,9 +317,7 @@ module Make (TaintSpecification : TaintSpec.S) = struct
           | Some base_var ->
               Some (AccessPath.Abs.with_base base_var ret_ap)
           | None ->
-              L.internal_error
-                "Have summary for retval %a of callee %a, but no ret id to bind it to@\n"
-                AccessPath.Abs.pp ret_ap Typ.Procname.pp (CallSite.pname callee_site) ;
+              (* TODO (T23832636): fail hard here *)
               None
         in
         let project ~formal_ap ~actual_ap =
diff --git a/infer/tests/codetoanalyze/cpp/quandary/basics.cpp b/infer/tests/codetoanalyze/cpp/quandary/basics.cpp
index 5e91b61d3..ed2550bc5 100644
--- a/infer/tests/codetoanalyze/cpp/quandary/basics.cpp
+++ b/infer/tests/codetoanalyze/cpp/quandary/basics.cpp
@@ -195,4 +195,8 @@ void loop_ok() {
   }
 }
 
+void ret_void_ok() { return; }
+
+void ret_void_transitive_ok() { return ret_void_ok(); }
+
 }