From 0944763dc1cbc1661de7606d7d265e72b73e05ee Mon Sep 17 00:00:00 2001 From: Jules Villard Date: Thu, 9 Aug 2018 07:55:15 -0700 Subject: [PATCH] [make] do not take `--flags` into account when looking for `-s` Summary: In some `make` versions, when not passing any single-letter options explicitly from the command line it could be that the first word of `MAKEFLAGS` is some `--long-option` instead, and this trips the detections of `-s`. If the first word starts with `-` it will now be ignored. Reviewed By: ddino Differential Revision: D9239290 fbshipit-source-id: c1120e055 --- Makefile.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.config b/Makefile.config index 01466a6c4..bf34da3e5 100644 --- a/Makefile.config +++ b/Makefile.config @@ -111,7 +111,7 @@ define copy_or_same_file endef INTERACTIVE = $(shell [ -t 0 ] && echo 1) -SILENT = $(findstring s,$(firstword $(MAKEFLAGS))) +SILENT = $(findstring s,$(filter-out -%,$(firstword $(MAKEFLAGS)))) ifeq (1,$(INTERACTIVE)) TERM_ERROR = $(shell printf '\e[31;1m')