Summary: From the user perspective, the current behavior is confusing. The users intutitively expect the inner class to inherit Nullsafe mode from the outer one. Having a class that is Nullsafe but the inner is not is hence dangerous and misleading. For the sake of completeness and to support gradual strictification, we allow the nested class to improse additional strictness. Particularly, the inner class can be Nullsafe but the outer can be not. A follow up to this diff will include warnings telling about redundant and wrong usages of nested annotations. Reviewed By: artempyanykh Differential Revision: D21228055 fbshipit-source-id: 75755ad1dmaster
Mitya Lyubarskiy
5 years ago
committed by
Facebook GitHub Bot
parent
fccf66968f
commit
0b6c5172a8
@ -0,0 +1,112 @@
|
||||
/*
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package codetoanalyze.java.nullsafe_default;
|
||||
|
||||
import com.facebook.infer.annotation.Nullsafe;
|
||||
|
||||
/** Test to ensure we correctly evaluate mode for nested classes */
|
||||
@Nullsafe(Nullsafe.Mode.LOCAL)
|
||||
class NullsafeLocal {
|
||||
|
||||
public String shouldBeNullsafeModeError() {
|
||||
return null;
|
||||
}
|
||||
|
||||
// Mode should be inherited from the parent class
|
||||
class Nested {
|
||||
public String shouldBeNullsafeModeError() {
|
||||
return null;
|
||||
}
|
||||
|
||||
// Mode propagation should be transitive
|
||||
class DeeplyNested {
|
||||
public String shouldBeNullsafeModeError() {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
// This is Local, but not Strict mode
|
||||
public String returningDefaultNotNullIsOK() {
|
||||
return Default.getString();
|
||||
}
|
||||
}
|
||||
|
||||
// It is OK to make nested classes more strict
|
||||
@Nullsafe(Nullsafe.Mode.STRICT)
|
||||
class NestedStrict {
|
||||
public String returningDefaultNotNullIsError() {
|
||||
return Default.getString();
|
||||
}
|
||||
}
|
||||
|
||||
// No need to repeat the mode - it is redundant
|
||||
@Nullsafe(Nullsafe.Mode.LOCAL)
|
||||
class NestedExplicitLocal {
|
||||
public String shouldBeNullsafeModeError() {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@Nullsafe(Nullsafe.Mode.STRICT)
|
||||
class NullsafeStrict {
|
||||
public String returningDefaultNotNullIsError() {
|
||||
return Default.getString();
|
||||
}
|
||||
|
||||
// STRICT mode is propagated to the nested class
|
||||
class Nested {
|
||||
public String returningDefaultNotNullIsError() {
|
||||
return Default.getString();
|
||||
}
|
||||
|
||||
// Impossible to downgrade the level of nested class, even if the nested mode
|
||||
// is implicit
|
||||
@Nullsafe(Nullsafe.Mode.LOCAL)
|
||||
class DeeplyNestedLocalIsStillStrict {
|
||||
public String returningDefaultNotNullIsError() {
|
||||
return Default.getString();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Impossible to downgrade the level of nested class
|
||||
@Nullsafe(Nullsafe.Mode.LOCAL)
|
||||
class NestedLocalIsStillStrict {
|
||||
public String returningDefaultNotNullIsError() {
|
||||
return Default.getString();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
class Default {
|
||||
public static String getString() {
|
||||
return "";
|
||||
}
|
||||
|
||||
// OK for nested to be @Nullsafe but the outer is not
|
||||
@Nullsafe(Nullsafe.Mode.LOCAL)
|
||||
class NestedLocal {
|
||||
public String shouldBeNullsafeModeError() {
|
||||
return null;
|
||||
}
|
||||
|
||||
// This is Local, but not Strict mode
|
||||
public String returningDefaultNotNullIsOK() {
|
||||
return Default.getString();
|
||||
}
|
||||
|
||||
// And we can increase strictness even more
|
||||
@Nullsafe(Nullsafe.Mode.STRICT)
|
||||
class DeeplyNestedStrict {
|
||||
public String returningDefaultNotNullIsError() {
|
||||
return Default.getString();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Reference in new issue