From 0db83eb5dd5ebe097edb435cfc21050d43081462 Mon Sep 17 00:00:00 2001 From: Dulma Rodriguez Date: Tue, 10 Nov 2015 07:02:58 -0800 Subject: [PATCH] Adding the no progress bar option to the tests Summary: public Buck prints all the output at once and it doesn't look good. So we should not print the progress bar in the tests. Reviewed By: jvillard Differential Revision: D2631722 fb-gh-sync-id: 5460a70 --- infer/tests/codetoanalyze/c/errors/BUCK | 1 + infer/tests/codetoanalyze/java/checkers/BUCK | 1 + infer/tests/codetoanalyze/java/eradicate/BUCK | 1 + .../codetoanalyze/java/incremental/changed_only_future/BUCK | 1 + .../tests/codetoanalyze/java/incremental/changed_only_mode/BUCK | 1 + infer/tests/codetoanalyze/java/incremental/child_changed/BUCK | 1 + infer/tests/codetoanalyze/java/incremental/file_unchanged/BUCK | 1 + infer/tests/codetoanalyze/java/incremental/parent_changed/BUCK | 1 + infer/tests/codetoanalyze/java/infer/BUCK | 1 + infer/tests/codetoanalyze/java/tracing/BUCK | 1 + infer/tests/utils/InferRunner.java | 2 ++ 11 files changed, 12 insertions(+) diff --git a/infer/tests/codetoanalyze/c/errors/BUCK b/infer/tests/codetoanalyze/c/errors/BUCK index 3362eb5df..a542108dc 100644 --- a/infer/tests/codetoanalyze/c/errors/BUCK +++ b/infer/tests/codetoanalyze/c/errors/BUCK @@ -7,6 +7,7 @@ clean_cmd = ' '.join(['rm', '-rf', out]) env_cmd = ' '.join(['export', 'INFER_REPORT_ASSERTION_FAILURE=1']) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '--no-filtering', '-o', 'out', '--testing_mode', diff --git a/infer/tests/codetoanalyze/java/checkers/BUCK b/infer/tests/codetoanalyze/java/checkers/BUCK index 5dc49c1d3..ffe3077e5 100644 --- a/infer/tests/codetoanalyze/java/checkers/BUCK +++ b/infer/tests/codetoanalyze/java/checkers/BUCK @@ -20,6 +20,7 @@ classpath = ':'.join([('$(classpath ' + path + ')') for path in dependencies]) env_cmd = ' '.join(['export', 'INFER_REPORT_EXPENSIVE_CALLS=1']) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '--absolute-paths', '-o', out, '-a', 'checkers', diff --git a/infer/tests/codetoanalyze/java/eradicate/BUCK b/infer/tests/codetoanalyze/java/eradicate/BUCK index 7867c2fd8..463cd31e2 100644 --- a/infer/tests/codetoanalyze/java/eradicate/BUCK +++ b/infer/tests/codetoanalyze/java/eradicate/BUCK @@ -24,6 +24,7 @@ classpath = ':'.join([('$(classpath ' + path + ')') for path in dependencies]) env_cmd = ' '.join(['export', 'ERADICATE_RETURN_OVER_ANNOTATED=1']) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '--absolute-paths', '-o', out, '-a', 'eradicate', diff --git a/infer/tests/codetoanalyze/java/incremental/changed_only_future/BUCK b/infer/tests/codetoanalyze/java/incremental/changed_only_future/BUCK index b28914a4d..c1cacc73f 100644 --- a/infer/tests/codetoanalyze/java/incremental/changed_only_future/BUCK +++ b/infer/tests/codetoanalyze/java/incremental/changed_only_future/BUCK @@ -14,6 +14,7 @@ stripped_suffix_files = map(lambda f: f.replace('.v1', ''), v1_files) to_compile = ' '.join(stripped_suffix_files) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '-i', '--changed-only', '--absolute-paths', diff --git a/infer/tests/codetoanalyze/java/incremental/changed_only_mode/BUCK b/infer/tests/codetoanalyze/java/incremental/changed_only_mode/BUCK index 354fd7237..bdbd1b4ac 100644 --- a/infer/tests/codetoanalyze/java/incremental/changed_only_mode/BUCK +++ b/infer/tests/codetoanalyze/java/incremental/changed_only_mode/BUCK @@ -21,6 +21,7 @@ stripped_suffix_files = map(lambda f: f.replace('.v1', ''), v1_files) to_compile = ' '.join(set(normal_files + stripped_suffix_files)) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '-i', '--changed-only', '--absolute-paths', diff --git a/infer/tests/codetoanalyze/java/incremental/child_changed/BUCK b/infer/tests/codetoanalyze/java/incremental/child_changed/BUCK index 08bbd3985..5eddac1c9 100644 --- a/infer/tests/codetoanalyze/java/incremental/child_changed/BUCK +++ b/infer/tests/codetoanalyze/java/incremental/child_changed/BUCK @@ -21,6 +21,7 @@ stripped_suffix_files = map(lambda f: f.replace('.v1', ''), v1_files) to_compile = ' '.join(normal_files + stripped_suffix_files) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '-i', '--absolute-paths', '-o', out, diff --git a/infer/tests/codetoanalyze/java/incremental/file_unchanged/BUCK b/infer/tests/codetoanalyze/java/incremental/file_unchanged/BUCK index 6f759af7f..c7dfb567e 100644 --- a/infer/tests/codetoanalyze/java/incremental/file_unchanged/BUCK +++ b/infer/tests/codetoanalyze/java/incremental/file_unchanged/BUCK @@ -12,6 +12,7 @@ out = 'out' clean_cmd = ' '.join(['rm', '-rf', out]) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '-i', '--absolute-paths', '-o', out, diff --git a/infer/tests/codetoanalyze/java/incremental/parent_changed/BUCK b/infer/tests/codetoanalyze/java/incremental/parent_changed/BUCK index 781b49c20..16e1b7294 100644 --- a/infer/tests/codetoanalyze/java/incremental/parent_changed/BUCK +++ b/infer/tests/codetoanalyze/java/incremental/parent_changed/BUCK @@ -21,6 +21,7 @@ stripped_suffix_files = map(lambda f: f.replace('.v1', ''), v1_files) to_compile = ' '.join(normal_files + stripped_suffix_files) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '-i', '--absolute-paths', '-o', out, diff --git a/infer/tests/codetoanalyze/java/infer/BUCK b/infer/tests/codetoanalyze/java/infer/BUCK index 51fd4e7f2..b8920e7dc 100644 --- a/infer/tests/codetoanalyze/java/infer/BUCK +++ b/infer/tests/codetoanalyze/java/infer/BUCK @@ -23,6 +23,7 @@ def analysis_cmd(analyzer): classpath = ':'.join([('$(classpath ' + path + ')') for path in dependencies]) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '--absolute-paths', '--no-filtering', '-o', out, diff --git a/infer/tests/codetoanalyze/java/tracing/BUCK b/infer/tests/codetoanalyze/java/tracing/BUCK index 0c05a7755..45ee94071 100644 --- a/infer/tests/codetoanalyze/java/tracing/BUCK +++ b/infer/tests/codetoanalyze/java/tracing/BUCK @@ -18,6 +18,7 @@ clean_cmd = ' '.join(['rm', '-rf', out]) classpath = ':'.join([('$(classpath ' + path + ')') for path in dependencies]) infer_cmd = ' '.join([ 'infer', + '--no-progress-bar', '--absolute-paths', '-o', out, '-a', 'tracing', diff --git a/infer/tests/utils/InferRunner.java b/infer/tests/utils/InferRunner.java index 575edf019..21f98f186 100644 --- a/infer/tests/utils/InferRunner.java +++ b/infer/tests/utils/InferRunner.java @@ -105,6 +105,7 @@ public class InferRunner { return new ImmutableList.Builder() .add("infer") + .add("--no-progress-bar") .add("--no-filtering") .addAll(args) .add("-o") @@ -261,6 +262,7 @@ public class InferRunner { .add(ml_buckets == null ? "all" : ml_buckets); ImmutableList inferCmd = new ImmutableList.Builder() .add("infer") + .add("--no-progress-bar") .add("--no-filtering") .add("--out") .add(resultsDirName)