From 1db403c51d6480773ecc8cb21dbd34e5c4e14183 Mon Sep 17 00:00:00 2001 From: Jeremy Dubreil Date: Wed, 3 Jan 2018 14:02:14 -0800 Subject: [PATCH] [infer][scheduler] no need to filter the defined procedures when running the checkers Summary: Filtering the defined procedure at this level is not necessary. This check already happens when running the analysis in Ondemand. This could also cause flakiness if the "definedness" here does not agree with the check done in Ondemand. The fact that the analysis of a procedure is triggered from the top-level iteration or on-demand when analyzing another procedure is not deterministic. Reviewed By: sblackshear Differential Revision: D6575057 fbshipit-source-id: ff0bc2d --- infer/src/backend/callbacks.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/infer/src/backend/callbacks.ml b/infer/src/backend/callbacks.ml index ea0a4da0e..faa4a6d44 100644 --- a/infer/src/backend/callbacks.ml +++ b/infer/src/backend/callbacks.ml @@ -55,7 +55,7 @@ let iterate_procedure_callbacks get_proc_desc exe_env summary proc_desc = let get_procs_in_file proc_name = match Exe_env.get_cfg exe_env proc_name with | Some cfg -> - List.map ~f:Procdesc.get_proc_name (Cfg.get_defined_procs cfg) + List.map ~f:Procdesc.get_proc_name (Cfg.get_all_procs cfg) | None -> [] in