From 2152af123d7b09aada391dc788645b33b1c879a1 Mon Sep 17 00:00:00 2001 From: Sungkeun Cho Date: Thu, 16 Apr 2020 08:55:28 -0700 Subject: [PATCH] [inferbo] Remove dead check in appending field to location Summary: In `PowLoc`, we focus on making every constructors of `PowLoc.t` return nomalized value. Thus, it is unnecessary to nomalize any `PowLoc.t` inputs. Reviewed By: ezgicicek Differential Revision: D21064893 fbshipit-source-id: d00a7f06b --- infer/src/bufferoverrun/absLoc.ml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/infer/src/bufferoverrun/absLoc.ml b/infer/src/bufferoverrun/absLoc.ml index de4686674..a5bda02ca 100644 --- a/infer/src/bufferoverrun/absLoc.ml +++ b/infer/src/bufferoverrun/absLoc.ml @@ -535,23 +535,23 @@ module PowLoc = struct let append_field ploc ~fn = - match normalize ploc with + match ploc with | Bottom -> (* Return the unknown location to avoid unintended unreachable nodes *) Unknown | Unknown -> - ploc + Unknown | Known ploc -> Known (LocSet.fold (fun l -> LocSet.add (Loc.append_field l ~fn)) ploc LocSet.empty) let append_star_field ploc ~fn = - match normalize ploc with + match ploc with | Bottom -> (* Return the unknown location to avoid unintended unreachable nodes *) Unknown | Unknown -> - ploc + Unknown | Known ploc -> Known (LocSet.fold (fun l -> LocSet.add (Loc.append_star_field l ~fn)) ploc LocSet.empty)