[deadcode] Fix deadcode

Summary:
`make deadcode` is failing on master but our CI jobs didn't catch it :(
Let's fix existing deadcode for now.

Reviewed By: martintrojer

Differential Revision: D20510062

fbshipit-source-id: 4a5e5f849

infer/src/nullsafe/AggregatedSummaries.ml

@@ -14,8 +14,6 @@ module ClassInfo = struct
 
   let make_empty () = {summaries= []; nested_anonymous_classes= JavaClassName.Map.empty}
 
-  let get_class_summaries {summaries} = summaries
-
   (** Add top level (not anonymous) summary belonging to this class *)
   let add_class_summary summary t = {t with summaries= summary :: t.summaries}
 

infer/src/nullsafe/AggregatedSummaries.mli

@@ -14,9 +14,6 @@ open! IStd
 module ClassInfo : sig
   type t
 
-  val get_class_summaries : t -> Summary.t list
-  (** Summaries for all procedures in this class (not counting anonymous nested classes) *)
-
   val get_all_summaries : t -> Summary.t list
   (** List of all summaries, user-level and anonymous, combined together *)
 end

infer/src/pulse/PulseAbductiveDomain.ml

@@ -89,12 +89,6 @@ type t =
   ; pre: PreDomain.t  (** inferred pre at the current program point *)
   ; skipped_calls: SkippedCalls.t  (** set of skipped calls *) }
 
-let get_pre {pre} = (pre :> BaseDomain.t)
-
-let get_post {post} = (post :> BaseDomain.t)
-
-let get_skipped_calls {skipped_calls} = skipped_calls
-
 let pp f {post; pre; skipped_calls} =
   F.fprintf f "@[<v>%a@;PRE=[%a]@;skipped_calls=%a@]" Domain.pp post PreDomain.pp pre
     SkippedCalls.pp skipped_calls

infer/src/pulse/PulseAbductiveDomain.mli

@@ -109,12 +109,6 @@ val discard_unreachable : t -> t
 
 val add_skipped_calls : Procname.t -> PulseTrace.t -> t -> t
 
-val get_pre : t -> BaseDomain.t
-
-val get_post : t -> BaseDomain.t
-
-val get_skipped_calls : t -> SkippedCalls.t
-
 module PrePost : sig
   type domain_t = t
 

infer/src/unit/JavaClassNameTests.ml

@@ -8,7 +8,6 @@
 open! IStd
 open OUnit2
 open JavaClassName
-module F = Format
 
 let assert_equal_to classname ~expected_package ~expected_classname =
   assert_equal ~printer:JavaClassName.to_string classname