From 25c9d8ae49bf9fe311f2a97b4ab5276cb59f5126 Mon Sep 17 00:00:00 2001 From: Josh Berdine Date: Thu, 10 Nov 2016 13:59:22 -0800 Subject: [PATCH] [logging] Delay re-creation of log dir until log files created Summary: In some error conditions, it could happen that the log file directory was created early in execution, and then deleted, causing the creation of log files to then fail. Reviewed By: sblackshear Differential Revision: D4157986 fbshipit-source-id: 1548b08 --- infer/src/base/Logging.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/infer/src/base/Logging.ml b/infer/src/base/Logging.ml index 007a2aee9..a95f12a73 100644 --- a/infer/src/base/Logging.ml +++ b/infer/src/base/Logging.ml @@ -50,9 +50,9 @@ let set_log_file_identifier (current_exe : CLOpt.exe) string_opt = let exe_log_dir = let log_dir = Config.results_dir // Config.log_dir_name in log_dir // (log_dir_of_current_exe current_exe) in - create_path exe_log_dir; let fmt_chan_file name suffix = lazy ( try + create_path exe_log_dir ; let file = (* the command-line option takes precedence if specified *) if name <> "" then name