[CK][Linter Rule] Add CKRenderLayout component to Component Kit Conventional Superclass

Reviewed By: kfirapps, ddino Differential Revision: D13590155 fbshipit-source-id: 1a9f4ba15
6 years ago · 28c3ed50de
parent 322066d248
commit 28c3ed50de
4 changed files with 11 additions and 0 deletions
--- a/infer/src/clang/ComponentKit.ml
+++ b/infer/src/clang/ComponentKit.ml
@ -227,6 +227,7 @@ let component_with_unconventional_superclass_advice context an =
                     ; ckcomponentcontroller_cl
                     ; "CKCompositeComponent"
                     ; "CKRenderComponent"
+                     ; "CKRenderLayoutComponent"
                     ; "CKRenderWithChildrenComponent"
                     ; "CKStatefulViewComponent"
                     ; "CKStatefulViewComponentController"
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/FakeComponentKitHeader.h
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/FakeComponentKitHeader.h
@ -66,3 +66,7 @@ class CKComponentScope {
 // Mimic importing CKRenderWithChildrenComponent
@interface CKRenderWithChildrenComponent : CKComponent
@end
+
+// Mimic importing CKRenderLayoutComponent
+@interface CKRenderLayoutComponent : CKComponent
+@end
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.h
@ -26,3 +26,6 @@

@interface RenderWithChildrenFooComponent : CKRenderWithChildrenComponent // good
@end
+
+@interface RenderLayoutFooComponent : CKRenderLayoutComponent // good
+@end
--- a/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
+++ b/infer/tests/codetoanalyze/objcpp/linters/componentkit/UnconventionalSuperclassTest.mm
@ -23,3 +23,6 @@

@implementation RenderWithChildrenFooComponent
@end
+
+@implementation RenderLayoutFooComponent
+@end