Warn of label omitted in function application

Summary: public

Reviewed By: jvillard

Differential Revision: D2938346

fb-gh-sync-id: 50d5c73
shipit-source-id: 50d5c73

infer/src/Makefile.in

@@ -82,6 +82,7 @@ OCAMLBUILD_OPTIONS = \
                      -cflags -strict-formats \
                      -cflags -strict-sequence \
                      -cflags -w,@5 \
+                     -cflags -w,@6 \
                      -cflags -w,@8 \
                      -cflags -w,@10 \
                      -cflags -w,@11 \

infer/src/clang/cMethod_trans.ml

@@ -75,7 +75,7 @@ let get_return_param tenv function_method_decl_info =
   let is_objc_method = is_objc_method function_method_decl_info in
   let return_type_ptr = get_original_return_type function_method_decl_info in
   let return_typ = CTypes_decl.type_ptr_to_sil_type tenv return_type_ptr in
-  if should_add_return_param return_typ is_objc_method then
+  if should_add_return_param return_typ ~is_objc_method then
     [(CFrontend_config.return_param, Ast_expressions.create_pointer_type return_type_ptr)]
   else
     []
@@ -114,7 +114,7 @@ let get_return_type tenv function_method_decl_info =
   let return_type_ptr = get_original_return_type function_method_decl_info in
   let return_typ = CTypes_decl.type_ptr_to_sil_type tenv return_type_ptr in
   let is_objc_method = is_objc_method function_method_decl_info in
-  if should_add_return_param return_typ is_objc_method then
+  if should_add_return_param return_typ ~is_objc_method then
     Ast_expressions.create_void_type, Some (Sil.Tptr (return_typ, Sil.Pk_pointer))
   else return_type_ptr, None
 

infer/src/clang/cTrans.ml

@@ -259,7 +259,7 @@ struct
       else [Ident.create_fresh Ident.knormal] in
     let ret_id', params, initd_exps, ret_exps =
       (* Assumption: should_add_return_param will return true only for struct types *)
-      if CMethod_trans.should_add_return_param return_type is_objc_method then
+      if CMethod_trans.should_add_return_param return_type ~is_objc_method then
         let param_type = Sil.Tptr (return_type, Sil.Pk_pointer) in
         let var_exp = match trans_state.var_exp_typ with
           | Some (exp, _) -> exp